72231 2011-11-13 17:04:42 -0800 Add export macros to JSCore heap classes 2011-12-10 15:09:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 27551 67852 1 kevino kevino ggaren hausmann rakuco oldest_to_newest 501566 0 kevino 2011-11-13 17:04:42 -0800 Add export macros to JSCore heap classes 501567 1 114869 kevino 2011-11-13 17:06:24 -0800 Created attachment 114869 Patch 502125 2 ggaren 2011-11-14 11:26:27 -0800 I still don't like this idiom. I don't see the upside to it, and I don't know how to avoid breaking it in future. 503742 3 hausmann 2011-11-16 03:21:18 -0800 (In reply to comment #2) > I still don't like this idiom. I don't see the upside to it, and I don't know how to avoid breaking it in future. What are the options? I see: 1) The project will only support building JSC as shared lib if you use port & platform specific export files. 2) We add the export macro to _classes_, resulting in slightly more exported symbols that aaabsolutely necessary. (easier to maintain) 3) We add the export macro to classes and individual functions (like in attachment 114869). (harder to maintain, but closer to option 1) I would prefer option number 2, but the decision lies probably in the hands of the JSC folks :) 503865 4 kevino 2011-11-16 07:48:26 -0800 (In reply to comment #3) > (In reply to comment #2) > > I still don't like this idiom. I don't see the upside to it, and I don't know how to avoid breaking it in future. > > What are the options? > > I see: > > 1) The project will only support building JSC as shared lib if you use port & platform specific export files. > 2) We add the export macro to _classes_, resulting in slightly more exported symbols that aaabsolutely necessary. (easier to maintain) > 3) We add the export macro to classes and individual functions (like in attachment 114869 [details]). (harder to maintain, but closer to option 1) > > I would prefer option number 2, but the decision lies probably in the hands of the JSC folks :) I'd obviously prefer number 2 as well, and IMHO it's much less maintenance work, but the JSC folks did not want people to think they can, or be able to, use the exported classes as public API, so I have been told that if we're to do it it has to be per-symbol (as the current approach is). In a few cases, though, we actually do have to export the whole class when WebCore, etc. needs access to things like the viable that are only exported when you export the class, so you may see that from time to time. I only do that when it's necessary to get it linking, though. 504552 5 kevino 2011-11-16 22:02:36 -0800 (In reply to comment #2) > I still don't like this idiom. I don't see the upside to it, and I don't know how to avoid breaking it in future. I'm not sure I understand. If all the ports building JSCore shared use this approach, which is the necessary end result of this process, I don't see how it can break for any port because for any common symbol change, you'll need to add the export macro to get it linking, and once you do that, all ports get updated at the same time. For port-specific stuff, the port that needs it adds it, and the rest of the ports ignore it, so again no breakage AFAICT. In contrast, right now, it's easy to add an export symbol to only one port and break the others, and any new port that wants to build JSCore shared must craft their own export symbol files and commit to maintaining them. To be honest, I don't see what the upside to doing it that way is, and it was my understanding that it was decided to do things this way before multiple ports were in the tree. 518827 6 kevino 2011-12-10 15:09:35 -0800 This bug is superseded by work to automate the adding of header macros. 114869 2011-11-13 17:06:24 -0800 2011-12-10 15:08:23 -0800 Patch bug-72231-20111113170623.patch text/plain 6657 kevino SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAwMDk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDExLTExLTEzICBLZXZpbiBPbGxpdmllciAgPGtldmlub0B0aGVvbGxpdmllcnMuY29tPgor CisgICAgICAgIEFkZCBleHBvcnQgbWFjcm9zIHRvIEpTQ29yZSBoZWFwIGNsYXNzZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyMjMxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBoZWFwL0FsbG9jYXRp b25TcGFjZS5oOgorICAgICAgICAqIGhlYXAvSGFuZGxlSGVhcC5oOgorICAgICAgICAqIGhlYXAv SGVhcC5oOgorICAgICAgICAqIGhlYXAvTWFjaGluZVN0YWNrTWFya2VyLmg6CisgICAgICAgICog aGVhcC9NYXJrU3RhY2suaDoKKwogMjAxMS0xMS0xMyAgWXVxaWFuZyBYaWFuICA8eXVxaWFuZy54 aWFuQGludGVsLmNvbT4KIAogICAgICAgICBGaXggc2lsZW50IHNwaWxsaW5nL2ZpbGxpbmcgR1BS cyBpbiBERkcgMzJfNjQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0FsbG9jYXRp b25TcGFjZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0FsbG9j YXRpb25TcGFjZS5oCShyZXZpc2lvbiAxMDAwOTMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9BbGxvY2F0aW9uU3BhY2UuaAkod29ya2luZyBjb3B5KQpAQCAtNzIsNyArNzIsNyBAQCBw cml2YXRlOgogICAgIAogICAgIHZvaWQqIGFsbG9jYXRlKE1hcmtlZFNwYWNlOjpTaXplQ2xhc3Mm KTsKICAgICB2b2lkKiB0cnlBbGxvY2F0ZShNYXJrZWRTcGFjZTo6U2l6ZUNsYXNzJik7Ci0gICAg dm9pZCogYWxsb2NhdGVTbG93Q2FzZShNYXJrZWRTcGFjZTo6U2l6ZUNsYXNzJik7CisgICAgSlNf RVhQT1JUX1BSSVZBVEUgdm9pZCogYWxsb2NhdGVTbG93Q2FzZShNYXJrZWRTcGFjZTo6U2l6ZUNs YXNzJik7CiAgICAgTWFya2VkQmxvY2sqIGFsbG9jYXRlQmxvY2soc2l6ZV90IGNlbGxTaXplLCBB bGxvY2F0aW9uRWZmb3J0KTsKICAgICAKICAgICBIZWFwKiBtX2hlYXA7CkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaGVhcC9IYW5kbGVIZWFwLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvSGFuZGxlSGVhcC5oCShyZXZpc2lvbiAxMDAwOTMpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IYW5kbGVIZWFwLmgJKHdvcmtpbmcgY29weSkKQEAgLTQw LDcgKzQwLDcgQEAgY2xhc3MgSlNHbG9iYWxEYXRhOwogY2xhc3MgSlNWYWx1ZTsKIGNsYXNzIFNs b3RWaXNpdG9yOwogCi1jbGFzcyBXZWFrSGFuZGxlT3duZXIgeworY2xhc3MgSlNfRVhQT1JUX1BS SVZBVEUgV2Vha0hhbmRsZU93bmVyIHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5XZWFrSGFuZGxl T3duZXIoKTsKICAgICB2aXJ0dWFsIGJvb2wgaXNSZWFjaGFibGVGcm9tT3BhcXVlUm9vdHMoSGFu ZGxlPFVua25vd24+LCB2b2lkKiBjb250ZXh0LCBTbG90VmlzaXRvciYpOwpAQCAtNjUsNyArNjUs NyBAQCBwdWJsaWM6CiAgICAgdm9pZCB2aXNpdFdlYWtIYW5kbGVzKEhlYXBSb290VmlzaXRvciYp OwogICAgIHZvaWQgZmluYWxpemVXZWFrSGFuZGxlcygpOwogCi0gICAgdm9pZCB3cml0ZUJhcnJp ZXIoSGFuZGxlU2xvdCwgY29uc3QgSlNWYWx1ZSYpOworICAgIEpTX0VYUE9SVF9QUklWQVRFIHZv aWQgd3JpdGVCYXJyaWVyKEhhbmRsZVNsb3QsIGNvbnN0IEpTVmFsdWUmKTsKIAogI2lmICFBU1NF UlRfRElTQUJMRUQKICAgICBib29sIGhhc1dlYWtPd25lcihIYW5kbGVTbG90LCBXZWFrSGFuZGxl T3duZXIqKTsKQEAgLTExMSw3ICsxMTEsNyBAQCBwcml2YXRlOgogICAgIHN0YXRpYyBIYW5kbGVT bG90IHRvSGFuZGxlKE5vZGUqKTsKICAgICBzdGF0aWMgTm9kZSogdG9Ob2RlKEhhbmRsZVNsb3Qp OwogCi0gICAgdm9pZCBncm93KCk7CisgICAgSlNfRVhQT1JUX1BSSVZBVEUgdm9pZCBncm93KCk7 CiAgICAgCiAjaWYgRU5BQkxFKEdDX1ZBTElEQVRJT04pIHx8ICFBU1NFUlRfRElTQUJMRUQKICAg ICBib29sIGlzVmFsaWRXZWFrTm9kZShOb2RlKik7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvaGVhcC9IZWFwLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv SGVhcC5oCShyZXZpc2lvbiAxMDAwOTMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9I ZWFwLmgJKHdvcmtpbmcgY29weSkKQEAgLTcxLDE5ICs3MSwxOCBAQCBuYW1lc3BhY2UgSlNDIHsK ICAgICAgICAgc3RhdGljIGJvb2wgdGVzdEFuZFNldE1hcmtlZChjb25zdCB2b2lkKik7CiAgICAg ICAgIHN0YXRpYyB2b2lkIHNldE1hcmtlZChjb25zdCB2b2lkKik7CiAKLSAgICAgICAgc3RhdGlj IHZvaWQgd3JpdGVCYXJyaWVyKGNvbnN0IEpTQ2VsbCosIEpTVmFsdWUpOworICAgICAgICBKU19F WFBPUlRfUFJJVkFURSBzdGF0aWMgdm9pZCB3cml0ZUJhcnJpZXIoY29uc3QgSlNDZWxsKiwgSlNW YWx1ZSk7CiAgICAgICAgIHN0YXRpYyB2b2lkIHdyaXRlQmFycmllcihjb25zdCBKU0NlbGwqLCBK U0NlbGwqKTsKLSAgICAgICAgc3RhdGljIHVpbnQ4X3QqIGFkZHJlc3NPZkNhcmRGb3IoSlNDZWxs Kik7CiAKICAgICAgICAgSGVhcChKU0dsb2JhbERhdGEqLCBIZWFwU2l6ZSk7CiAgICAgICAgIH5I ZWFwKCk7Ci0gICAgICAgIHZvaWQgZGVzdHJveSgpOyAvLyBKU0dsb2JhbERhdGEgbXVzdCBjYWxs IGRlc3Ryb3koKSBiZWZvcmUgfkhlYXAoKS4KKyAgICAgICAgSlNfRVhQT1JUX1BSSVZBVEUgdm9p ZCBkZXN0cm95KCk7IC8vIEpTR2xvYmFsRGF0YSBtdXN0IGNhbGwgZGVzdHJveSgpIGJlZm9yZSB+ SGVhcCgpLgogCiAgICAgICAgIEpTR2xvYmFsRGF0YSogZ2xvYmFsRGF0YSgpIGNvbnN0IHsgcmV0 dXJuIG1fZ2xvYmFsRGF0YTsgfQogICAgICAgICBBbGxvY2F0aW9uU3BhY2UmIG9iamVjdFNwYWNl KCkgeyByZXR1cm4gbV9vYmplY3RTcGFjZTsgfQogICAgICAgICBNYWNoaW5lVGhyZWFkcyYgbWFj aGluZVRocmVhZHMoKSB7IHJldHVybiBtX21hY2hpbmVUaHJlYWRzOyB9CiAKLSAgICAgICAgR0NB Y3Rpdml0eUNhbGxiYWNrKiBhY3Rpdml0eUNhbGxiYWNrKCk7CisgICAgICAgIEpTX0VYUE9SVF9Q UklWQVRFIEdDQWN0aXZpdHlDYWxsYmFjayogYWN0aXZpdHlDYWxsYmFjaygpOwogICAgICAgICB2 b2lkIHNldEFjdGl2aXR5Q2FsbGJhY2soUGFzc093blB0cjxHQ0FjdGl2aXR5Q2FsbGJhY2s+KTsK IAogICAgICAgICAvLyB0cnVlIGlmIGFuIGFsbG9jYXRpb24gb3IgY29sbGVjdGlvbiBpcyBpbiBw cm9ncmVzcwpAQCAtOTMsMjAgKzkyLDIwIEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICB2b2lk KiBhbGxvY2F0ZShzaXplX3QpOwogCiAgICAgICAgIHR5cGVkZWYgdm9pZCAoKkZpbmFsaXplciko SlNDZWxsKik7Ci0gICAgICAgIHZvaWQgYWRkRmluYWxpemVyKEpTQ2VsbCosIEZpbmFsaXplcik7 CisgICAgICAgIEpTX0VYUE9SVF9QUklWQVRFIHZvaWQgYWRkRmluYWxpemVyKEpTQ2VsbCosIEZp bmFsaXplcik7CiAKICAgICAgICAgdm9pZCBub3RpZnlJc1NhZmVUb0NvbGxlY3QoKSB7IG1faXNT YWZlVG9Db2xsZWN0ID0gdHJ1ZTsgfQotICAgICAgICB2b2lkIGNvbGxlY3RBbGxHYXJiYWdlKCk7 CisgICAgICAgIEpTX0VYUE9SVF9QUklWQVRFIHZvaWQgY29sbGVjdEFsbEdhcmJhZ2UoKTsKIAog ICAgICAgICB2b2lkIHJlcG9ydEV4dHJhTWVtb3J5Q29zdChzaXplX3QgY29zdCk7CiAKLSAgICAg ICAgdm9pZCBwcm90ZWN0KEpTVmFsdWUpOwotICAgICAgICBib29sIHVucHJvdGVjdChKU1ZhbHVl KTsgLy8gVHJ1ZSB3aGVuIHRoZSBwcm90ZWN0IGNvdW50IGRyb3BzIHRvIDAuCisgICAgICAgIEpT X0VYUE9SVF9QUklWQVRFIHZvaWQgcHJvdGVjdChKU1ZhbHVlKTsKKyAgICAgICAgSlNfRVhQT1JU X1BSSVZBVEUgYm9vbCB1bnByb3RlY3QoSlNWYWx1ZSk7IC8vIFRydWUgd2hlbiB0aGUgcHJvdGVj dCBjb3VudCBkcm9wcyB0byAwLgogICAgICAgICAKICAgICAgICAgdm9pZCBhZGRKZXR0aXNvbmVk Q29kZUJsb2NrKFBhc3NPd25QdHI8Q29kZUJsb2NrPik7CiAKLSAgICAgICAgc2l6ZV90IHNpemUo KTsKLSAgICAgICAgc2l6ZV90IGNhcGFjaXR5KCk7CisgICAgICAgIEpTX0VYUE9SVF9QUklWQVRF IHNpemVfdCBzaXplKCk7CisgICAgICAgIEpTX0VYUE9SVF9QUklWQVRFIHNpemVfdCBjYXBhY2l0 eSgpOwogICAgICAgICBzaXplX3Qgb2JqZWN0Q291bnQoKTsKICAgICAgICAgc2l6ZV90IGdsb2Jh bE9iamVjdENvdW50KCk7CiAgICAgICAgIHNpemVfdCBwcm90ZWN0ZWRPYmplY3RDb3VudCgpOwpA QCAtMTM5LDggKzEzOCw4IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICAgICAgdmlydHVhbCB2 b2lkIGZpbmFsaXplKEhhbmRsZTxVbmtub3duPiwgdm9pZCogY29udGV4dCk7CiAgICAgICAgIH07 CiAKLSAgICAgICAgYm9vbCBpc1ZhbGlkQWxsb2NhdGlvbihzaXplX3QpOwotICAgICAgICB2b2lk IHJlcG9ydEV4dHJhTWVtb3J5Q29zdFNsb3dDYXNlKHNpemVfdCk7CisgICAgICAgIEpTX0VYUE9S VF9QUklWQVRFIGJvb2wgaXNWYWxpZEFsbG9jYXRpb24oc2l6ZV90KTsKKyAgICAgICAgSlNfRVhQ T1JUX1BSSVZBVEUgdm9pZCByZXBvcnRFeHRyYU1lbW9yeUNvc3RTbG93Q2FzZShzaXplX3QpOwog CiAgICAgICAgIC8vIENhbGwgdGhpcyBmdW5jdGlvbiBiZWZvcmUgYW55IG9wZXJhdGlvbiB0aGF0 IG5lZWRzIHRvIGtub3cgd2hpY2ggY2VsbHMKICAgICAgICAgLy8gaW4gdGhlIGhlYXAgYXJlIGxp dmUuIChGb3IgZXhhbXBsZSwgY2FsbCB0aGlzIGZ1bmN0aW9uIGJlZm9yZQpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2hlYXAvTWFjaGluZVN0YWNrTWFya2VyLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFjaGluZVN0YWNrTWFya2VyLmgJKHJldmlzaW9u IDEwMDA5MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hY2hpbmVTdGFja01hcmtl ci5oCSh3b3JraW5nIGNvcHkpCkBAIC00MCw3ICs0MCw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAg ICAgICB2b2lkIGdhdGhlckNvbnNlcnZhdGl2ZVJvb3RzKENvbnNlcnZhdGl2ZVJvb3RzJiwgdm9p ZCogc3RhY2tDdXJyZW50KTsKIAogICAgICAgICB2b2lkIG1ha2VVc2FibGVGcm9tTXVsdGlwbGVU aHJlYWRzKCk7Ci0gICAgICAgIHZvaWQgYWRkQ3VycmVudFRocmVhZCgpOyAvLyBPbmx5IG5lZWRz IHRvIGJlIGNhbGxlZCBieSBjbGllbnRzIHRoYXQgY2FuIHVzZSB0aGUgc2FtZSBoZWFwIGZyb20g bXVsdGlwbGUgdGhyZWFkcy4KKyAgICAgICAgSlNfRVhQT1JUX1BSSVZBVEUgdm9pZCBhZGRDdXJy ZW50VGhyZWFkKCk7IC8vIE9ubHkgbmVlZHMgdG8gYmUgY2FsbGVkIGJ5IGNsaWVudHMgdGhhdCBj YW4gdXNlIHRoZSBzYW1lIGhlYXAgZnJvbSBtdWx0aXBsZSB0aHJlYWRzLgogCiAgICAgcHJpdmF0 ZToKICAgICAgICAgdm9pZCBnYXRoZXJGcm9tQ3VycmVudFRocmVhZChDb25zZXJ2YXRpdmVSb290 cyYsIHZvaWQqIHN0YWNrQ3VycmVudCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVh cC9NYXJrU3RhY2suaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9N YXJrU3RhY2suaAkocmV2aXNpb24gMTAwMDkzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvTWFya1N0YWNrLmgJKHdvcmtpbmcgY29weSkKQEAgLTExMSw3ICsxMTEsNyBAQCBuYW1lc3Bh Y2UgSlNDIHsKICAgICBwcml2YXRlOgogICAgICAgICBNYXJrU3RhY2tTZWdtZW50KiBtX3RvcFNl Z21lbnQ7CiAgICAgICAgIAotICAgICAgICB2b2lkIGV4cGFuZCgpOworICAgICAgICBKU19FWFBP UlRfUFJJVkFURSB2b2lkIGV4cGFuZCgpOwogICAgICAgICAKICAgICAgICAgTWFya1N0YWNrU2Vn bWVudEFsbG9jYXRvciYgbV9hbGxvY2F0b3I7CiAKQEAgLTIzOSw3ICsyMzksNyBAQCBuYW1lc3Bh Y2UgSlNDIHsKICAgICAgICAgfQogCiAgICAgcHJvdGVjdGVkOgotICAgICAgICBzdGF0aWMgdm9p ZCB2YWxpZGF0ZShKU0NlbGwqKTsKKyAgICAgICAgSlNfRVhQT1JUX1BSSVZBVEUgc3RhdGljIHZv aWQgdmFsaWRhdGUoSlNDZWxsKik7CiAKICAgICAgICAgdm9pZCBhcHBlbmQoSlNWYWx1ZSopOwog ICAgICAgICB2b2lkIGFwcGVuZChKU1ZhbHVlKiwgc2l6ZV90IGNvdW50KTsK