71800 2011-11-08 05:01:41 -0800 CSSGradientValue: Devirtualize createGradient(). 2011-11-08 05:25:23 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71666 1 kling kling macpherson webkit.review.bot oldest_to_newest 497958 0 kling 2011-11-08 05:01:41 -0800 Yep. 497959 1 114043 kling 2011-11-08 05:03:03 -0800 Created attachment 114043 Pätch 497960 2 114043 kling 2011-11-08 05:03:30 -0800 Comment on attachment 114043 Pätch DURR didn't actually devirtualize... 497961 3 114044 kling 2011-11-08 05:04:26 -0800 Created attachment 114044 Påtch 497964 4 114044 koivisto 2011-11-08 05:07:26 -0800 Comment on attachment 114044 Påtch r=me 497974 5 kling 2011-11-08 05:25:23 -0800 Committed r99556: <http://trac.webkit.org/changeset/99556> 114043 2011-11-08 05:03:03 -0800 2011-11-08 05:04:26 -0800 Pätch bug-71800.diff text/plain 3728 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyOTFkZmMyLi40ZjA0NmZjIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTEtMTEtMDggIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIENTU0dyYWRpZW50VmFsdWU6IERldmlydHVhbGl6ZSBjcmVhdGVHcmFkaWVudCgpLgorICAg ICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi83MTgwMD4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIGNyZWF0ZUdyYWRpZW50KCkgbm9uLXZpcnR1 YWwgYW5kIGNhbGwgdGhlIGFwcHJvcHJpYXRlIHN1YmNsYXNzCisgICAgICAgIGltcGxlbWVudGF0 aW9uIGluIGltYWdlKCkgYmFzZWQgb24gaXN7TGluZWFyLFJhZGlhbH1HcmFkaWVudCgpLgorCisg ICAgICAgICogY3NzL0NTU0dyYWRpZW50VmFsdWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NT R3JhZGllbnRWYWx1ZTo6aW1hZ2UpOgorICAgICAgICAqIGNzcy9DU1NHcmFkaWVudFZhbHVlLmg6 CisKKzIwMTEtMTEtMDggIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCiAgICAg ICAgIENTU0NhbnZhc1ZhbHVlOiBSZW1vdmUgaW5oZXJpdGFuY2UgZnJvbSBDYW52YXNPYnNlcnZl ci4KICAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvNzE3OTY+CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFkaWVudFZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NHcmFkaWVudFZhbHVlLmNwcAppbmRleCBjZGExNGZiLi4zNTY1NDMxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JhZGllbnRWYWx1ZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvY3NzL0NTU0dyYWRpZW50VmFsdWUuY3BwCkBAIC01OCw3ICs1OCwxNiBAQCBQYXNzUmVm UHRyPEltYWdlPiBDU1NHcmFkaWVudFZhbHVlOjppbWFnZShSZW5kZXJPYmplY3QqIHJlbmRlcmVy LCBjb25zdCBJbnRTaXplJgogICAgIH0KIAogICAgIC8vIFdlIG5lZWQgdG8gY3JlYXRlIGFuIGlt YWdlLgotICAgIFJlZlB0cjxJbWFnZT4gbmV3SW1hZ2UgPSBHZW5lcmF0ZWRJbWFnZTo6Y3JlYXRl KGNyZWF0ZUdyYWRpZW50KHJlbmRlcmVyLCBzaXplKSwgc2l6ZSk7CisgICAgUmVmUHRyPEdyYWRp ZW50PiBncmFkaWVudDsKKworICAgIGlmIChpc0xpbmVhckdyYWRpZW50KCkpCisgICAgICAgIGdy YWRpZW50ID0gc3RhdGljX2Nhc3Q8Q1NTTGluZWFyR3JhZGllbnRWYWx1ZSo+KHRoaXMpLT5jcmVh dGVHcmFkaWVudChyZW5kZXJlciwgc2l6ZSk7CisgICAgZWxzZSB7CisgICAgICAgIEFTU0VSVChp c1JhZGlhbEdyYWRpZW50KCkpOworICAgICAgICBncmFkaWVudCA9IHN0YXRpY19jYXN0PENTU1Jh ZGlhbEdyYWRpZW50VmFsdWUqPih0aGlzKS0+Y3JlYXRlR3JhZGllbnQocmVuZGVyZXIsIHNpemUp OworICAgIH0KKworICAgIFJlZlB0cjxJbWFnZT4gbmV3SW1hZ2UgPSBHZW5lcmF0ZWRJbWFnZTo6 Y3JlYXRlKGdyYWRpZW50LCBzaXplKTsKICAgICBpZiAoY2FjaGVhYmxlKQogICAgICAgICBwdXRJ bWFnZShzaXplLCBuZXdJbWFnZSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NHcmFkaWVudFZhbHVlLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JhZGllbnRWYWx1ZS5o CmluZGV4IDA3MTFkZTIuLjRkNGZlMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NHcmFkaWVudFZhbHVlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyYWRpZW50VmFs dWUuaApAQCAtNzcsOSArNzcsNiBAQCBwcm90ZWN0ZWQ6CiAKICAgICB2b2lkIGFkZFN0b3BzKEdy YWRpZW50KiwgUmVuZGVyT2JqZWN0KiwgUmVuZGVyU3R5bGUqIHJvb3RTdHlsZSwgZmxvYXQgbWF4 TGVuZ3RoRm9yUmVwZWF0ID0gMCk7CiAKLSAgICAvLyBDcmVhdGUgdGhlIGdyYWRpZW50IGZvciBh IGdpdmVuIHNpemUuCi0gICAgdmlydHVhbCBQYXNzUmVmUHRyPEdyYWRpZW50PiBjcmVhdGVHcmFk aWVudChSZW5kZXJPYmplY3QqLCBjb25zdCBJbnRTaXplJikgPSAwOwotCiAgICAgLy8gUmVzb2x2 ZSBwb2ludHMvcmFkaWkgdG8gZnJvbnQgZW5kIHZhbHVlcy4KICAgICBGbG9hdFBvaW50IGNvbXB1 dGVFbmRQb2ludChDU1NQcmltaXRpdmVWYWx1ZSosIENTU1ByaW1pdGl2ZVZhbHVlKiwgUmVuZGVy U3R5bGUqLCBSZW5kZXJTdHlsZSogcm9vdFN0eWxlLCBjb25zdCBJbnRTaXplJik7CiAKQEAgLTEx MSwxNSArMTA4LDE1IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgU3RyaW5nIGNzc1RleHQoKSBj b25zdDsKIAorICAgIC8vIENyZWF0ZSB0aGUgZ3JhZGllbnQgZm9yIGEgZ2l2ZW4gc2l6ZS4KKyAg ICB2aXJ0dWFsIFBhc3NSZWZQdHI8R3JhZGllbnQ+IGNyZWF0ZUdyYWRpZW50KFJlbmRlck9iamVj dCosIGNvbnN0IEludFNpemUmKTsKKwogcHJpdmF0ZToKICAgICBDU1NMaW5lYXJHcmFkaWVudFZh bHVlKENTU0dyYWRpZW50UmVwZWF0IHJlcGVhdCwgYm9vbCBkZXByZWNhdGVkVHlwZSA9IGZhbHNl KQogICAgICAgICA6IENTU0dyYWRpZW50VmFsdWUoTGluZWFyR3JhZGllbnRDbGFzcywgcmVwZWF0 LCBkZXByZWNhdGVkVHlwZSkKICAgICB7CiAgICAgfQogCi0gICAgLy8gQ3JlYXRlIHRoZSBncmFk aWVudCBmb3IgYSBnaXZlbiBzaXplLgotICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxHcmFkaWVudD4g Y3JlYXRlR3JhZGllbnQoUmVuZGVyT2JqZWN0KiwgY29uc3QgSW50U2l6ZSYpOwotCiAgICAgUmVm UHRyPENTU1ByaW1pdGl2ZVZhbHVlPiBtX2FuZ2xlOyAvLyBtYXkgYmUgbnVsbC4KIH07CiAKQEAg LTE0MSwxNSArMTM4LDE1IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldEVuZEhvcml6b250YWxTaXpl KFBhc3NSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IHZhbCkgeyBtX2VuZEhvcml6b250YWxTaXpl ID0gdmFsOyB9CiAgICAgdm9pZCBzZXRFbmRWZXJ0aWNhbFNpemUoUGFzc1JlZlB0cjxDU1NQcmlt aXRpdmVWYWx1ZT4gdmFsKSB7IG1fZW5kVmVydGljYWxTaXplID0gdmFsOyB9CiAKKyAgICAvLyBD cmVhdGUgdGhlIGdyYWRpZW50IGZvciBhIGdpdmVuIHNpemUuCisgICAgdmlydHVhbCBQYXNzUmVm UHRyPEdyYWRpZW50PiBjcmVhdGVHcmFkaWVudChSZW5kZXJPYmplY3QqLCBjb25zdCBJbnRTaXpl Jik7CisKIHByaXZhdGU6CiAgICAgQ1NTUmFkaWFsR3JhZGllbnRWYWx1ZShDU1NHcmFkaWVudFJl cGVhdCByZXBlYXQsIGJvb2wgZGVwcmVjYXRlZFR5cGUgPSBmYWxzZSkKICAgICAgICAgOiBDU1NH cmFkaWVudFZhbHVlKFJhZGlhbEdyYWRpZW50Q2xhc3MsIHJlcGVhdCwgZGVwcmVjYXRlZFR5cGUp CiAgICAgewogICAgIH0KIAotICAgIC8vIENyZWF0ZSB0aGUgZ3JhZGllbnQgZm9yIGEgZ2l2ZW4g c2l6ZS4KLSAgICB2aXJ0dWFsIFBhc3NSZWZQdHI8R3JhZGllbnQ+IGNyZWF0ZUdyYWRpZW50KFJl bmRlck9iamVjdCosIGNvbnN0IEludFNpemUmKTsKLQogICAgIC8vIFJlc29sdmUgcG9pbnRzL3Jh ZGlpIHRvIGZyb250IGVuZCB2YWx1ZXMuCiAgICAgZmxvYXQgcmVzb2x2ZVJhZGl1cyhDU1NQcmlt aXRpdmVWYWx1ZSosIFJlbmRlclN0eWxlKiwgUmVuZGVyU3R5bGUqIHJvb3RTdHlsZSwgZmxvYXQq IHdpZHRoT3JIZWlnaHQgPSAwKTsKIAo= 114044 2011-11-08 05:04:26 -0800 2011-11-08 05:07:26 -0800 Påtch bug-71800.diff text/plain 3712 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyOTFkZmMyLi40ZjA0NmZjIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTEtMTEtMDggIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIENTU0dyYWRpZW50VmFsdWU6IERldmlydHVhbGl6ZSBjcmVhdGVHcmFkaWVudCgpLgorICAg ICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi83MTgwMD4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIGNyZWF0ZUdyYWRpZW50KCkgbm9uLXZpcnR1 YWwgYW5kIGNhbGwgdGhlIGFwcHJvcHJpYXRlIHN1YmNsYXNzCisgICAgICAgIGltcGxlbWVudGF0 aW9uIGluIGltYWdlKCkgYmFzZWQgb24gaXN7TGluZWFyLFJhZGlhbH1HcmFkaWVudCgpLgorCisg ICAgICAgICogY3NzL0NTU0dyYWRpZW50VmFsdWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NT R3JhZGllbnRWYWx1ZTo6aW1hZ2UpOgorICAgICAgICAqIGNzcy9DU1NHcmFkaWVudFZhbHVlLmg6 CisKKzIwMTEtMTEtMDggIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCiAgICAg ICAgIENTU0NhbnZhc1ZhbHVlOiBSZW1vdmUgaW5oZXJpdGFuY2UgZnJvbSBDYW52YXNPYnNlcnZl ci4KICAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvNzE3OTY+CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFkaWVudFZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NHcmFkaWVudFZhbHVlLmNwcAppbmRleCBjZGExNGZiLi4zNTY1NDMxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JhZGllbnRWYWx1ZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvY3NzL0NTU0dyYWRpZW50VmFsdWUuY3BwCkBAIC01OCw3ICs1OCwxNiBAQCBQYXNzUmVm UHRyPEltYWdlPiBDU1NHcmFkaWVudFZhbHVlOjppbWFnZShSZW5kZXJPYmplY3QqIHJlbmRlcmVy LCBjb25zdCBJbnRTaXplJgogICAgIH0KIAogICAgIC8vIFdlIG5lZWQgdG8gY3JlYXRlIGFuIGlt YWdlLgotICAgIFJlZlB0cjxJbWFnZT4gbmV3SW1hZ2UgPSBHZW5lcmF0ZWRJbWFnZTo6Y3JlYXRl KGNyZWF0ZUdyYWRpZW50KHJlbmRlcmVyLCBzaXplKSwgc2l6ZSk7CisgICAgUmVmUHRyPEdyYWRp ZW50PiBncmFkaWVudDsKKworICAgIGlmIChpc0xpbmVhckdyYWRpZW50KCkpCisgICAgICAgIGdy YWRpZW50ID0gc3RhdGljX2Nhc3Q8Q1NTTGluZWFyR3JhZGllbnRWYWx1ZSo+KHRoaXMpLT5jcmVh dGVHcmFkaWVudChyZW5kZXJlciwgc2l6ZSk7CisgICAgZWxzZSB7CisgICAgICAgIEFTU0VSVChp c1JhZGlhbEdyYWRpZW50KCkpOworICAgICAgICBncmFkaWVudCA9IHN0YXRpY19jYXN0PENTU1Jh ZGlhbEdyYWRpZW50VmFsdWUqPih0aGlzKS0+Y3JlYXRlR3JhZGllbnQocmVuZGVyZXIsIHNpemUp OworICAgIH0KKworICAgIFJlZlB0cjxJbWFnZT4gbmV3SW1hZ2UgPSBHZW5lcmF0ZWRJbWFnZTo6 Y3JlYXRlKGdyYWRpZW50LCBzaXplKTsKICAgICBpZiAoY2FjaGVhYmxlKQogICAgICAgICBwdXRJ bWFnZShzaXplLCBuZXdJbWFnZSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NHcmFkaWVudFZhbHVlLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JhZGllbnRWYWx1ZS5o CmluZGV4IDA3MTFkZTIuLmU3ZjZiNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NHcmFkaWVudFZhbHVlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyYWRpZW50VmFs dWUuaApAQCAtNzcsOSArNzcsNiBAQCBwcm90ZWN0ZWQ6CiAKICAgICB2b2lkIGFkZFN0b3BzKEdy YWRpZW50KiwgUmVuZGVyT2JqZWN0KiwgUmVuZGVyU3R5bGUqIHJvb3RTdHlsZSwgZmxvYXQgbWF4 TGVuZ3RoRm9yUmVwZWF0ID0gMCk7CiAKLSAgICAvLyBDcmVhdGUgdGhlIGdyYWRpZW50IGZvciBh IGdpdmVuIHNpemUuCi0gICAgdmlydHVhbCBQYXNzUmVmUHRyPEdyYWRpZW50PiBjcmVhdGVHcmFk aWVudChSZW5kZXJPYmplY3QqLCBjb25zdCBJbnRTaXplJikgPSAwOwotCiAgICAgLy8gUmVzb2x2 ZSBwb2ludHMvcmFkaWkgdG8gZnJvbnQgZW5kIHZhbHVlcy4KICAgICBGbG9hdFBvaW50IGNvbXB1 dGVFbmRQb2ludChDU1NQcmltaXRpdmVWYWx1ZSosIENTU1ByaW1pdGl2ZVZhbHVlKiwgUmVuZGVy U3R5bGUqLCBSZW5kZXJTdHlsZSogcm9vdFN0eWxlLCBjb25zdCBJbnRTaXplJik7CiAKQEAgLTEx MSwxNSArMTA4LDE1IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgU3RyaW5nIGNzc1RleHQoKSBj b25zdDsKIAorICAgIC8vIENyZWF0ZSB0aGUgZ3JhZGllbnQgZm9yIGEgZ2l2ZW4gc2l6ZS4KKyAg ICBQYXNzUmVmUHRyPEdyYWRpZW50PiBjcmVhdGVHcmFkaWVudChSZW5kZXJPYmplY3QqLCBjb25z dCBJbnRTaXplJik7CisKIHByaXZhdGU6CiAgICAgQ1NTTGluZWFyR3JhZGllbnRWYWx1ZShDU1NH cmFkaWVudFJlcGVhdCByZXBlYXQsIGJvb2wgZGVwcmVjYXRlZFR5cGUgPSBmYWxzZSkKICAgICAg ICAgOiBDU1NHcmFkaWVudFZhbHVlKExpbmVhckdyYWRpZW50Q2xhc3MsIHJlcGVhdCwgZGVwcmVj YXRlZFR5cGUpCiAgICAgewogICAgIH0KIAotICAgIC8vIENyZWF0ZSB0aGUgZ3JhZGllbnQgZm9y IGEgZ2l2ZW4gc2l6ZS4KLSAgICB2aXJ0dWFsIFBhc3NSZWZQdHI8R3JhZGllbnQ+IGNyZWF0ZUdy YWRpZW50KFJlbmRlck9iamVjdCosIGNvbnN0IEludFNpemUmKTsKLQogICAgIFJlZlB0cjxDU1NQ cmltaXRpdmVWYWx1ZT4gbV9hbmdsZTsgLy8gbWF5IGJlIG51bGwuCiB9OwogCkBAIC0xNDEsMTUg KzEzOCwxNSBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRFbmRIb3Jpem9udGFsU2l6ZShQYXNzUmVm UHRyPENTU1ByaW1pdGl2ZVZhbHVlPiB2YWwpIHsgbV9lbmRIb3Jpem9udGFsU2l6ZSA9IHZhbDsg fQogICAgIHZvaWQgc2V0RW5kVmVydGljYWxTaXplKFBhc3NSZWZQdHI8Q1NTUHJpbWl0aXZlVmFs dWU+IHZhbCkgeyBtX2VuZFZlcnRpY2FsU2l6ZSA9IHZhbDsgfQogCisgICAgLy8gQ3JlYXRlIHRo ZSBncmFkaWVudCBmb3IgYSBnaXZlbiBzaXplLgorICAgIFBhc3NSZWZQdHI8R3JhZGllbnQ+IGNy ZWF0ZUdyYWRpZW50KFJlbmRlck9iamVjdCosIGNvbnN0IEludFNpemUmKTsKKwogcHJpdmF0ZToK ICAgICBDU1NSYWRpYWxHcmFkaWVudFZhbHVlKENTU0dyYWRpZW50UmVwZWF0IHJlcGVhdCwgYm9v bCBkZXByZWNhdGVkVHlwZSA9IGZhbHNlKQogICAgICAgICA6IENTU0dyYWRpZW50VmFsdWUoUmFk aWFsR3JhZGllbnRDbGFzcywgcmVwZWF0LCBkZXByZWNhdGVkVHlwZSkKICAgICB7CiAgICAgfQog Ci0gICAgLy8gQ3JlYXRlIHRoZSBncmFkaWVudCBmb3IgYSBnaXZlbiBzaXplLgotICAgIHZpcnR1 YWwgUGFzc1JlZlB0cjxHcmFkaWVudD4gY3JlYXRlR3JhZGllbnQoUmVuZGVyT2JqZWN0KiwgY29u c3QgSW50U2l6ZSYpOwotCiAgICAgLy8gUmVzb2x2ZSBwb2ludHMvcmFkaWkgdG8gZnJvbnQgZW5k IHZhbHVlcy4KICAgICBmbG9hdCByZXNvbHZlUmFkaXVzKENTU1ByaW1pdGl2ZVZhbHVlKiwgUmVu ZGVyU3R5bGUqLCBSZW5kZXJTdHlsZSogcm9vdFN0eWxlLCBmbG9hdCogd2lkdGhPckhlaWdodCA9 IDApOwogCg==