71689 2011-11-07 07:54:21 -0800 Remove initPageTransitionEvent method 2011-11-07 09:16:31 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68791 1 dominicc dominicc abarth ojan webkit.review.bot oldest_to_newest 497171 0 dominicc 2011-11-07 07:54:21 -0800 The HTML5 spec has removed this method in favor of a constructor: <http://www.whatwg.org/specs/web-apps/current-work/#pagetransitionevent>. Code Search doesn’t turn up anyone using this method. We should remove it. 497172 1 113867 dominicc 2011-11-07 08:02:38 -0800 Created attachment 113867 Patch 497222 2 113867 ojan 2011-11-07 09:05:40 -0800 Comment on attachment 113867 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113867&action=review > Source/WebCore/ChangeLog:8 > + Removing a method, so no new tests. It's worth adding a line here that this was removed from the spec. People could go look at the bug, but it's worth saving the effort. 497230 3 dominicc 2011-11-07 09:16:31 -0800 Committed r99431: <http://trac.webkit.org/changeset/99431> 113867 2011-11-07 08:02:38 -0800 2011-11-07 09:05:40 -0800 Patch bug-71689-20111107080237.patch text/plain 3212 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogOTk0MjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwNzc0OWYxNDUyZDc5MjNh ZmM4NTBjMWIwMjIzNTM0ZjExZTI1N2IyLi4xYmVjMWVhYTU3NzNiZDE5OTVhZDUwODkwNTc2OWJl MzRlZmE4Zjc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMDcgIERvbWlu aWMgQ29vbmV5ICA8ZG9taW5pY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBpbml0 UGFnZVRyYW5zaXRpb25FdmVudCBtZXRob2QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTcxNjg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmVtb3ZpbmcgYSBtZXRob2QsIHNvIG5vIG5ldyB0ZXN0cy4KKwor ICAgICAgICAqIGRvbS9QYWdlVHJhbnNpdGlvbkV2ZW50LmNwcDoKKyAgICAgICAgKiBkb20vUGFn ZVRyYW5zaXRpb25FdmVudC5oOgorICAgICAgICAqIGRvbS9QYWdlVHJhbnNpdGlvbkV2ZW50Lmlk bDoKKwogMjAxMS0xMS0wNyAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4K IAogICAgICAgICBbQ2hyb21pdW1dIFdlYiBJbnNwZWN0b3I6IHVzZSBuYXRpdmUgd29ya2VyIGlu c3BlY3RvciBpbnN0ZWFkIG9mIGZha2Ugd29ya2VycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL1BhZ2VUcmFuc2l0aW9uRXZlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL1BhZ2VU cmFuc2l0aW9uRXZlbnQuY3BwCmluZGV4IDAzNmVkYjMzZTViZmJmYWI5YTQ5MzBkN2U2ODg0ZjM2 OTgzMTg4NjcuLmZhNDJkMGNmMWE3OTMyNjM1ZjIzNmE2MDlkZTY5YWJmZWM2MTI5OTcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9QYWdlVHJhbnNpdGlvbkV2ZW50LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9kb20vUGFnZVRyYW5zaXRpb25FdmVudC5jcHAKQEAgLTU2LDE5ICs1Niw2 IEBAIFBhZ2VUcmFuc2l0aW9uRXZlbnQ6On5QYWdlVHJhbnNpdGlvbkV2ZW50KCkKIHsKIH0KIAot dm9pZCBQYWdlVHJhbnNpdGlvbkV2ZW50Ojppbml0UGFnZVRyYW5zaXRpb25FdmVudChjb25zdCBB dG9taWNTdHJpbmcmIHR5cGUsIAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBib29sIGNhbkJ1YmJsZUFyZywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgYm9vbCBjYW5jZWxhYmxlQXJnLAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBib29sIHBlcnNpc3RlZCkKLXsKLSAgICBpZiAoZGlzcGF0 Y2hlZCgpKQotICAgICAgICByZXR1cm47Ci0KLSAgICBpbml0RXZlbnQodHlwZSwgY2FuQnViYmxl QXJnLCBjYW5jZWxhYmxlQXJnKTsKLQotICAgIG1fcGVyc2lzdGVkID0gcGVyc2lzdGVkOwotfQot CiBjb25zdCBBdG9taWNTdHJpbmcmIFBhZ2VUcmFuc2l0aW9uRXZlbnQ6OmludGVyZmFjZU5hbWUo KSBjb25zdAogewogICAgIHJldHVybiBldmVudE5hbWVzKCkuaW50ZXJmYWNlRm9yUGFnZVRyYW5z aXRpb25FdmVudDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9QYWdlVHJhbnNpdGlv bkV2ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vUGFnZVRyYW5zaXRpb25FdmVudC5oCmluZGV4 IGU3N2FiNmE3Nzg2ZDgwZGE4ZDg2MDcxNDgwZjkwMTRlZGFiNjQ0ZWMuLjQzNGI0ZWVhN2MwNjhi NmFiMzNjNTJhZTFhYWI4Zjk1ZTk2MGMyYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9QYWdlVHJhbnNpdGlvbkV2ZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1BhZ2VUcmFu c2l0aW9uRXZlbnQuaApAQCAtNTMsMTEgKzUzLDYgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCB+ UGFnZVRyYW5zaXRpb25FdmVudCgpOwogCi0gICAgdm9pZCBpbml0UGFnZVRyYW5zaXRpb25FdmVu dChjb25zdCBBdG9taWNTdHJpbmcmIHR5cGUsIAotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgYm9vbCBjYW5CdWJibGVBcmcsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBib29sIGNhbmNlbGFibGVBcmcsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBi b29sIHBlcnNpc3RlZCk7Ci0KICAgICB2aXJ0dWFsIGNvbnN0IEF0b21pY1N0cmluZyYgaW50ZXJm YWNlTmFtZSgpIGNvbnN0OwogCiAgICAgYm9vbCBwZXJzaXN0ZWQoKSBjb25zdCB7IHJldHVybiBt X3BlcnNpc3RlZDsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1BhZ2VUcmFuc2l0 aW9uRXZlbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvZG9tL1BhZ2VUcmFuc2l0aW9uRXZlbnQuaWRs CmluZGV4IDliYzZiYWMwM2ViMTFjNDVlN2M3NjJmZjA1ODZiNDlhZDAyYWFiNTUuLjkyNGRmYzcw OWYyZWRjZjE4YzQwMmM0MThiOWU5OTI0OWZiNDVmYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2RvbS9QYWdlVHJhbnNpdGlvbkV2ZW50LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20v UGFnZVRyYW5zaXRpb25FdmVudC5pZGwKQEAgLTI5LDEzICsyOSw3IEBAIG1vZHVsZSBldmVudHMg ewogICAgICAgICBDYW5CZUNvbnN0cnVjdGVkLAogICAgICAgICBDdXN0b21Db25zdHJ1Y3Rvcgog ICAgIF0gUGFnZVRyYW5zaXRpb25FdmVudCA6IEV2ZW50IHsKLQogICAgICAgICByZWFkb25seSBh dHRyaWJ1dGUgYm9vbGVhbiBwZXJzaXN0ZWQ7Ci0KLSAgICAgICAgdm9pZCBpbml0UGFnZVRyYW5z aXRpb25FdmVudChpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIERPTVN0cmluZyB0 eXBlQXJnLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluIFtPcHRpb25h bD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gYm9vbGVhbiBjYW5CdWJibGVBcmcsCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZh bHVlXSBib29sZWFuIGNhbmNlbGFibGVBcmcsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBib29sZWFuIHBlcnNp c3RlZCk7CiAgICAgfTsKIAogfQo=