71555 2011-11-04 05:33:28 -0700 [Qt] Compare WebCore and Qt ImageDecoders 2012-03-06 02:00:39 -0800 1 1 1 Unclassified WebKit Images 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 69515 1 zoltan webkit-unassigned christian.sejersen hausmann kbalazs kimmo.t.kinnunen kling loki tonikitoo zalan oldest_to_newest 496171 0 zoltan 2011-11-04 05:33:28 -0700 The goal of this bug is to measure the performance and memory consumption differences between WebCore imagedecoders and QImageDecoder, furthermore - based on the results and the discussions - we should decide either to keep the current QImageDecoder implementation or change to WebCore's imagedecoders as we changed for WebCore's one for the N9 browser. Setup: Slackware 13.1 - 32 bit, Intel(R) Core(TM)2 Duo CPU E6550 @ 2.33GHz, this is a dedicated pc for benchmarking purposes # Memory consumption (Maximum Resident Set Size (RSS), based on kernels smaps information): Methanol suite with 18 custom sites for benchmark imagedecoding. http://zoltan.sed.hu/WebKit/methanol_imgdecoder/fire.html?iter=1 WebCoreImageDecoders: avg 295 624 kbytes +/- 1.6% (min: 290 804 kbytes, max: 303 334 kbytes) QtImageDecoders: avg 293 556 kbytes +/- 2.1% (min: 286 052 kbytes, max: 303 804 kbytes) Methanol suite with the first individual 23 sites from alexa top100. (mirrored) http://zoltan.sed.hu/WebKit/methanolx/fire.html?iter=1 WebCoreImageDecoders: avg 70 856 kbytes +/- 2.5% (min: 68 772 kbytes, max: 73 736 kbytes) QtImageDecoders: avg 70 639 kbytes +/- 1.1% (min: 70 056 kbytes, max: 72 016 kbytes) As we see there are no big differences in the numbers, the memory consumption is almost the same with both type of implementation. # Performance (Methanol provided the results) http://zoltan.sed.hu/WebKit/methanol_imgdecoder/fire.html?iter=1 QtImageDecoders: avg 15 632 ms +/- 5.1% (min: 14 344ms, max: 16 406ms) WebCoreImageDecoders: avg 20 895 ms +/- 5.6% (min: 19 116ms, max: 22314ms) WebCoreImageDecoder is 33.6% slower. Methanol suite with the first individual 23 sites from alexa top100. (mirrored) http://zoltan.sed.hu/WebKit/methanolx/fire.html?iter=1 QtImageDecoders: avg 7 492ms +/- 6.5% (min: 7 124ms, max: 8 216ms) WebCoreImageDecoders: avg 7 798ms +/- 9.06% (min: 7 332ms, max: 9 153ms) WebCoreImageDecoder is 4.08% slower. Based on this results I think we will keep QImageDecoders, but I'm interested in your thoughts! 496172 1 zoltan 2011-11-04 05:34:55 -0700 I did the measurements with the latest Qt 4.8. If anyone would like to reproduce the results I'd gladly upload my WebCoreImgDecoders patch. 496193 2 113655 zoltan 2011-11-04 07:41:11 -0700 Created attachment 113655 alexa top150 I run the robotized version of QtLauncher for the attached sites.txt, what contains the first 150 urls from today's Alexa Top 1,000,000. MaxRSS WebCoreImageDecoders: 196 576 kbytes QtImageDecoders: 189 000 kbytes I will run the benchmark again to verify the results and I will do measurements for performance on Monday. 497021 3 zoltan 2011-11-07 01:42:39 -0800 (In reply to comment #2) > I will run the benchmark again to verify the results and I will do measurements for performance on Monday. On Tuesday. 497942 4 zoltan 2011-11-08 04:33:08 -0800 (In reply to comment #3) > (In reply to comment #2) I finished memory consumption measurements for the first 150 sites from alexa. WebCoreImageDecoders: avg 206 288 kbytes +/- 5.2% (min: 197 644 kbytes, max: 221 216 kbytes) QtImageDecoders: avg 202 241 kbytes +/- 2.4% (min: 197 748 kbytes, max: 208 584 kbytes) I need to use webpagereplay for performance measurements to leave network connection out of account, so it will take some time. :) 498885 5 zoltan 2011-11-09 06:35:25 -0800 (In reply to comment #4) > I need to use webpagereplay for performance measurements to leave network connection out of account, so it will take some time. :) Well, I finished performance measurements for the first top150 alexa sites. WebCoreImageDecoders: avg 187 051ms +/- 0.3% (min: 185 725ms, max: 189 019ms) QtImageDecoders: avg 187 309ms +/- 0.7% (min: 186 243 ms, max: 188 210ms) Hmm, in this test case the results are similar... what is not surprising, since both implementation use the same system libraries. Any thoughts based on results? 500876 6 zalan 2011-11-11 10:12:10 -0800 Kimmo, do you recall what was the actual reason of switching? 505645 7 zoltan 2011-11-18 03:15:56 -0800 (In reply to comment #6) > Kimmo, do you recall what was the actual reason of switching? Kimmo, ping! :) I'm curious to hear your answer! Other topic: I made a statistics on loaded image dimensions and I classify them into some groups: x,y,z := pixels (x) (y) (x*y) count(x*y) 2 2 4 553 4 4 16 22 (4 < z <= 16) 8 8 64 74 (16 < z <= 64) 16 16 256 293 ... 32 32 1024 249 64 64 4096 596 128 128 16384 1032 256 256 65536 1080 512 512 262144 297 1024 1024 1048576 89 2048 2048 4194304 7 3072 3072 9437184 0 4096 4096 16777216 0 In the case of x*y < 4px there are 125 0*0px and 394 1*1px images. 553954 8 hausmann 2012-02-10 02:00:41 -0800 Related bug in this context for a switch: bug #32410 571661 9 zoltan 2012-03-06 02:00:39 -0800 (In reply to comment #8) > Related bug in this context for a switch: bug #32410 Related bugs: - bug #80398 - bug #80400 I close this bug, further measurement isn't needed. 113655 2011-11-04 07:41:11 -0700 2011-11-04 07:41:11 -0700 alexa top150 sites.txt text/plain 2826 zoltan aHR0cDovL2dvb2dsZS5jb20KaHR0cDovL2ZhY2Vib29rLmNvbQpodHRwOi8veW91dHViZS5jb20K aHR0cDovL3lhaG9vLmNvbQpodHRwOi8vd2lraXBlZGlhLm9yZwpodHRwOi8vYmFpZHUuY29tCmh0 dHA6Ly9ibG9nc3BvdC5jb20KaHR0cDovL2xpdmUuY29tCmh0dHA6Ly90d2l0dGVyLmNvbQpodHRw Oi8vcXEuY29tCmh0dHA6Ly9hbWF6b24uY29tCmh0dHA6Ly9saW5rZWRpbi5jb20KaHR0cDovL21z bi5jb20KaHR0cDovL3lhaG9vLmNvLmpwCmh0dHA6Ly90YW9iYW8uY29tCmh0dHA6Ly9nb29nbGUu Y28uaW4KaHR0cDovL3NpbmEuY29tLmNuCmh0dHA6Ly93b3JkcHJlc3MuY29tCmh0dHA6Ly9nb29n bGUuZGUKaHR0cDovL2FwcGxlLmNvbQpodHRwOi8vZ29vZ2xlLmNvbS5oawpodHRwOi8vZWJheS5j b20KaHR0cDovL3lhbmRleC5ydQpodHRwOi8vZ29vZ2xlLmNvLnVrCmh0dHA6Ly9nb29nbGUuY28u anAKaHR0cDovL2dvb2dsZS5mcgpodHRwOi8vYmluZy5jb20KaHR0cDovL3QuY28KaHR0cDovL21p Y3Jvc29mdC5jb20KaHR0cDovL3dlaWJvLmNvbQpodHRwOi8vbWFpbC5ydQpodHRwOi8vMTYzLmNv bQpodHRwOi8vZ29vZ2xlLmNvbS5icgpodHRwOi8vcGF5cGFsLmNvbQpodHRwOi8vZmxpY2tyLmNv bQpodHRwOi8vZ29vZ2xlLml0Cmh0dHA6Ly9zb3NvLmNvbQpodHRwOi8vZ28uY29tCmh0dHA6Ly9m YzIuY29tCmh0dHA6Ly9jcmFpZ3NsaXN0Lm9yZwpodHRwOi8vbGl2ZWphc21pbi5jb20KaHR0cDov L2ltZGIuY29tCmh0dHA6Ly9nb29nbGUuZXMKaHR0cDovL3R1bWJsci5jb20KaHR0cDovL2JiYy5j by51awpodHRwOi8vYXNrLmNvbQpodHRwOi8vdmtvbnRha3RlLnJ1Cmh0dHA6Ly9nb29nbGUucnUK aHR0cDovL3NvaHUuY29tCmh0dHA6Ly9nb29nbGV1c2VyY29udGVudC5jb20KaHR0cDovL3h2aWRl b3MuY29tCmh0dHA6Ly95b3VrdS5jb20KaHR0cDovL3R1ZG91LmNvbQpodHRwOi8vY25uLmNvbQpo dHRwOi8vZ29vZ2xlLmNvbS5teApodHRwOi8vYmFieWxvbi5jb20KaHR0cDovL3hoYW1zdGVyLmNv bQpodHRwOi8vZ29vZ2xlLmNhCmh0dHA6Ly9lc3BuLmdvLmNvbQpodHRwOi8vaWZlbmcuY29tCmh0 dHA6Ly9hb2wuY29tCmh0dHA6Ly96ZWRvLmNvbQpodHRwOi8vY29uZHVpdC5jb20KaHR0cDovL2Fk b2JlLmNvbQpodHRwOi8vYWJvdXQuY29tCmh0dHA6Ly90bWFsbC5jb20KaHR0cDovL21lZGlhZmly ZS5jb20KaHR0cDovL2ViYXkuZGUKaHR0cDovL2JwLmJsb2dzcG90LmNvbQpodHRwOi8vYW1lYmxv LmpwCmh0dHA6Ly9nb29nbGUuY28uaWQKaHR0cDovL3Jha3V0ZW4uY28uanAKaHR0cDovL21lZ2F1 cGxvYWQuY29tCmh0dHA6Ly9nb2RhZGR5LmNvbQpodHRwOi8vcG9ybmh1Yi5jb20KaHR0cDovL2Fs aWJhYmEuY29tCmh0dHA6Ly90aGVwaXJhdGViYXkub3JnCmh0dHA6Ly9pbWd1ci5jb20KaHR0cDov L3VvbC5jb20uYnIKaHR0cDovL29kbm9rbGFzc25pa2kucnUKaHR0cDovL2NuZXQuY29tCmh0dHA6 Ly9nb29nbGUuY29tLmF1Cmh0dHA6Ly9odWZmaW5ndG9ucG9zdC5jb20KaHR0cDovL2dvb2dsZS5j b20udHIKaHR0cDovLzRzaGFyZWQuY29tCmh0dHA6Ly9ueXRpbWVzLmNvbQpodHRwOi8veW91cG9y bi5jb20KaHR0cDovL2FtYXpvbi5kZQpodHRwOi8vbGl2ZWRvb3IuY29tCmh0dHA6Ly9lYmF5LmNv LnVrCmh0dHA6Ly9nb29nbGUucGwKaHR0cDovL3JlbnJlbi5jb20KaHR0cDovL3dvcmRwcmVzcy5v cmcKaHR0cDovL2NoaW5hei5jb20KaHR0cDovL2RhaWx5bW90aW9uLmNvbQpodHRwOi8vMzYwYnV5 LmNvbQpodHRwOi8vZ2xvYm8uY29tCmh0dHA6Ly9hbGlwYXkuY29tCmh0dHA6Ly9uZXRmbGl4LmNv bQpodHRwOi8vY256ei5jb20KaHR0cDovL2xpdmVqb3VybmFsLmNvbQpodHRwOi8vYW1hem9uLmNv LmpwCmh0dHA6Ly9nb29nbGUuY29tLnNhCmh0dHA6Ly9tZWdhY2xpY2suY29tCmh0dHA6Ly9zdGFj a292ZXJmbG93LmNvbQpodHRwOi8vaGFvMTIzLmNvbQpodHRwOi8vYW1hem9uLmNvLnVrCmh0dHA6 Ly92aW1lby5jb20KaHR0cDovL2dvb2dsZS5ubApodHRwOi8vcmVkZGl0LmNvbQpodHRwOi8vc2Vj dXJlc2VydmVyLm5ldApodHRwOi8vYmFkb28uY29tCmh0dHA6Ly94bnh4LmNvbQpodHRwOi8vZG91 YmFuLmNvbQpodHRwOi8vdHViZTguY29tCmh0dHA6Ly9nb29nbGUuY29tLmFyCmh0dHA6Ly9hZGR0 aGlzLmNvbQpodHRwOi8vd2VhdGhlci5jb20KaHR0cDovL2RhaWx5bWFpbC5jby51awpodHRwOi8v cGVuZ3lvdS5jb20KaHR0cDovL2dvby5uZS5qcApodHRwOi8vcmVkdHViZS5jb20KaHR0cDovL3N0 dW1ibGV1cG9uLmNvbQpodHRwOi8vc29nb3UuY29tCmh0dHA6Ly9iYW5rb2ZhbWVyaWNhLmNvbQpo dHRwOi8vZmlsZXN0dWJlLmNvbQpodHRwOi8vZGV2aWFudGFydC5jb20KaHR0cDovL2RvdWJsZWNs aWNrLmNvbQpodHRwOi8vbXlzcGFjZS5jb20KaHR0cDovL3NreXBlLmNvbQpodHRwOi8vdGlhbnlh LmNuCmh0dHA6Ly9nb29nbGUuY24KaHR0cDovL2ZiY2RuLm5ldApodHRwOi8vZ29vZ2xlLmNvbS5w awpodHRwOi8vdG9ycmVudHouZXUKaHR0cDovL3dhcnJpb3Jmb3J1bS5jb20KaHR0cDovL2luZGlh dGltZXMuY29tCmh0dHA6Ly9hd2ViZXIuY29tCmh0dHA6Ly81OC5jb20KaHR0cDovL2ZpbGVzZXJ2 ZS5jb20KaHR0cDovL2FtYXpvbmF3cy5jb20KaHR0cDovL3Bob3RvYnVja2V0LmNvbQpodHRwOi8v b3JrdXQuY29tCmh0dHA6Ly9nb29nbGUuY28udGgKaHR0cDovL2ltYWdlc2hhY2sudXMKaHR0cDov L29ya3V0LmNvbS5icgpodHRwOi8vYXZnLmNvbQpodHRwOi8vb3B0bWQuY29tCmh0dHA6Ly9zb3Vy Y2Vmb3JnZS5uZXQKaHR0cDovL2dvb2dsZS5jb20uZWcK