7150 2006-02-08 22:41:45 -0800 TinyMCE: Undo still enabled after a location change, crashes if performed 2006-03-02 11:38:03 -0800 1 1 1 Unclassified WebKit HTML Editing 420+ Mac OS X 10.4 RESOLVED FIXED http://tinymce.moxiecode.com/example_full.php?example=true InRadar P2 Normal --- 6627 1 c.petersen87 justin.garcia oldest_to_newest 31918 0 c.petersen87 2006-02-08 22:41:45 -0800 After editing text in Tiny MCE then navigated to a different page, selecting undo typing from the Edit menu results in crash. This crash occurs with TOT Webkit. STEPS TO REPRODUCE 1. With TOT Webkit, go to http://tinymce.moxiecode.com/example_full.php?example=true 2. Place caret in textarea field and type a few characters 3. Navigate to another page 4. Select Undo Typing from the Edit menu. A crash occurs. RESULTS Undo Typing should not be active after different page has been loaded. However, Undo Typing menu item is active and results in a crash when selected. 31919 1 c.petersen87 2006-02-08 22:43:24 -0800 This bug is also in Radar as <rdar://4433765> 34713 2 6806 justin.garcia 2006-03-02 00:15:38 -0800 Created attachment 6806 patch undo/redo operations registered by subframes weren't cleared on a location change. clearUndoRedoOperations was only called from didOpenURL, and thus was only called for the main frame. At first I tried calling it for all childFrames in didOpenURL, but by the time that didOpenURL is called, all of the subframes have already been detached/destroyed. So I moved the call to clearUndoRedoOperations to closeURL, and it is now called for subframes as they are detached. 6806 2006-03-02 00:15:38 -0800 2006-03-02 02:42:37 -0800 patch 7150.txt text/plain 3640 justin.garcia SW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvdW5kby91bmRvLWlmcmFtZS1sb2NhdGlvbi1jaGFu Z2UuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3VuZG8vdW5kby1pZnJh bWUtbG9jYXRpb24tY2hhbmdlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0 aW5nL3VuZG8vdW5kby1pZnJhbWUtbG9jYXRpb24tY2hhbmdlLmh0bWwJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsNTUgQEAKKworPHNjcmlwdCBzcmM9Ii4uL2VkaXRpbmcuanMiPjwvc2NyaXB0Pgor PGlmcmFtZSBuYW1lPSJpZnJhbWUiIHNyYz0iLi4vcmVzb3VyY2VzL2NvbnRlbnRlZGl0YWJsZS1p ZnJhbWUtc3JjLmh0bWwiPjwvaWZyYW1lPgorPHVsIGlkPSJjb25zb2xlIj48L3VsPgorCis8c2Ny aXB0PgorZnVuY3Rpb24gbG9nKG1lc3NhZ2UpIHsKKyAgICB2YXIgY29uc29sZSA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJjb25zb2xlIik7CisgICAgdmFyIGxpID0gZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgibGkiKTsKKyAgICB2YXIgdGV4dCA9IGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKG1l c3NhZ2UpOworICAgIGxpLmFwcGVuZENoaWxkKHRleHQpOworICAgIGNvbnNvbGUuYXBwZW5kQ2hp bGQobGkpOworfQorCitmdW5jdGlvbiBwYXJ0MSgpIHsKKworICAgIC8vIEhhY2sgdG8gZm9jdXMg dGhlIGZyYW1lLCBzaG91bGQgYmUgYWJsZSB0byBkbyBmcmFtZXNbJ2lmcmFtZSddLmZvY3VzKCkK KyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyg1MCwgNTApOworICAgIGV2ZW50U2VuZGVyLm1v dXNlRG93bigpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKKyAgICAKKyAgICAvLyBIYWNr IHRvIHBlcmZvcm0gdGhlIGVkaXRpbmcgY29tbWFuZC4gIFNob3VsZCBiZSBhYmxlIHRvIAorICAg IC8vIGNhbGwgZXhlY0NvbW1hbmQgb24gdGhlIG1haW4gZG9jdW1lbnQuCisgICAgZnJhbWVzWydp ZnJhbWUnXS5kb2N1bWVudC5leGVjQ29tbWFuZCgnSW5zZXJ0VGV4dCcsIGZhbHNlLCAnYycpOwor ICAgIAorICAgIHdpbmRvdy5sb2NhdGlvbiA9IHdpbmRvdy5sb2NhdGlvbi50b1N0cmluZygpICsg Ij9wYXJ0MiI7Cit9CisKK2Z1bmN0aW9uIHBhcnQyKCkgeworICAgIGlmICghZG9jdW1lbnQucXVl cnlDb21tYW5kRW5hYmxlZCgnVW5kbycpKQorICAgICAgICBsb2coIlN1Y2Nlc3MiKTsKKyAgICBl bHNlCisgICAgICAgIGxvZygiRmFpbHVyZSwgVW5kbyB3YXMgc3RpbGwgZW5hYmxlZCBhZnRlciB0 aGUgbG9jYXRpb24gY2hhbmdlZC4iKTsKKyAgICAgICAgCisgICAgd2luZG93LmxheW91dFRlc3RD b250cm9sbGVyLm5vdGlmeURvbmUoKTsKK30KKworZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICBp ZiAoIXdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgcmV0dXJuOworCisgICAg aWYgKHdpbmRvdy5sb2NhdGlvbi50b1N0cmluZygpLmluZGV4T2YoIj9wYXJ0MiIpID09IC0xKSB7 CisgICAgICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cisg ICAgICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAg IC8vIEdpdmUgdGhlIGlmcmFtZSBhIG1vbWVudCB0byBjb21lIGludG8gYmVpbmcuCisgICAgICAg IHdpbmRvdy5zZXRUaW1lb3V0KHBhcnQxLCAxMDApOworICAgIH0gZWxzZSB7CisgICAgICAgIHBh cnQyKCk7CisgICAgfQorCit9CisKK3J1blRlc3QoKTsKKworPC9zY3JpcHQ+ClwgTm8gbmV3bGlu ZSBhdCBlbmQgb2YgZmlsZQpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy91bmRvL3VuZG8taWZy YW1lLWxvY2F0aW9uLWNoYW5nZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZWRpdGluZy91bmRvL3VuZG8taWZyYW1lLWxvY2F0aW9uLWNoYW5nZS1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3VuZG8vdW5kby1pZnJhbWUtbG9j YXRpb24tY2hhbmdlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMCBAQAor RURJVElORyBERUxFR0FURTogc2hvdWxkQmVnaW5FZGl0aW5nSW5ET01SYW5nZTpyYW5nZSBmcm9t IDAgb2YgQk9EWSA+IEhUTUwgPiAjZG9jdW1lbnQgdG8gMSBvZiBCT0RZID4gSFRNTCA+ICNkb2N1 bWVudAorRURJVElORyBERUxFR0FURTogd2ViVmlld0RpZEJlZ2luRWRpdGluZzpXZWJWaWV3RGlk QmVnaW5FZGl0aW5nTm90aWZpY2F0aW9uCitFRElUSU5HIERFTEVHQVRFOiBzaG91bGRDaGFuZ2VT ZWxlY3RlZERPTVJhbmdlOihudWxsKSB0b0RPTVJhbmdlOnJhbmdlIGZyb20gMCBvZiBCT0RZID4g SFRNTCA+ICNkb2N1bWVudCB0byAwIG9mIEJPRFkgPiBIVE1MID4gI2RvY3VtZW50IGFmZmluaXR5 Ok5TU2VsZWN0aW9uQWZmaW5pdHlEb3duc3RyZWFtIHN0aWxsU2VsZWN0aW5nOkZBTFNFCitFRElU SU5HIERFTEVHQVRFOiB3ZWJWaWV3RGlkQ2hhbmdlU2VsZWN0aW9uOldlYlZpZXdEaWRDaGFuZ2VT ZWxlY3Rpb25Ob3RpZmljYXRpb24KK0VESVRJTkcgREVMRUdBVEU6IHNob3VsZENoYW5nZVNlbGVj dGVkRE9NUmFuZ2U6cmFuZ2UgZnJvbSAwIG9mIEJPRFkgPiBIVE1MID4gI2RvY3VtZW50IHRvIDAg b2YgQk9EWSA+IEhUTUwgPiAjZG9jdW1lbnQgdG9ET01SYW5nZTpyYW5nZSBmcm9tIDEgb2YgI3Rl eHQgPiBCT0RZID4gSFRNTCA+ICNkb2N1bWVudCB0byAxIG9mICN0ZXh0ID4gQk9EWSA+IEhUTUwg PiAjZG9jdW1lbnQgYWZmaW5pdHk6TlNTZWxlY3Rpb25BZmZpbml0eURvd25zdHJlYW0gc3RpbGxT ZWxlY3Rpbmc6RkFMU0UKK0VESVRJTkcgREVMRUdBVEU6IHdlYlZpZXdEaWRDaGFuZ2VTZWxlY3Rp b246V2ViVmlld0RpZENoYW5nZVNlbGVjdGlvbk5vdGlmaWNhdGlvbgorRURJVElORyBERUxFR0FU RTogd2ViVmlld0RpZENoYW5nZTpXZWJWaWV3RGlkQ2hhbmdlTm90aWZpY2F0aW9uCisKK1N1Y2Nl c3MKKwpJbmRleDogV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3BhZ2UvRnJhbWUuY3BwCShyZXZpc2lvbiAxMzA4MSkKKysrIFdlYkNvcmUvcGFnZS9GcmFtZS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTIxMCw3ICsyMTAsNiBAQCBib29sIEZyYW1lOjpkaWRPcGVu VVJMKGNvbnN0IEtVUkwgJnVybCkKICAgCiAgIC8vIGNsZWFyIGxhc3QgZWRpdCBjb21tYW5kCiAg IGQtPm1fbGFzdEVkaXRDb21tYW5kID0gRWRpdENvbW1hbmRQdHIoKTsKLSAgY2xlYXJVbmRvUmVk b09wZXJhdGlvbnMoKTsKICAgCiAgIFVSTEFyZ3MgYXJncyggZC0+bV9leHRlbnNpb24tPnVybEFy Z3MoKSApOwogCkBAIC0zMDM4LDYgKzMwMzcsNyBAQCBib29sIEZyYW1lOjpjbG9zZVVSTCgpCiB7 CiAgICAgc2F2ZURvY3VtZW50U3RhdGUoKTsKICAgICBzdG9wTG9hZGluZyh0cnVlKTsKKyAgICBj bGVhclVuZG9SZWRvT3BlcmF0aW9ucygpOwogICAgIHJldHVybiB0cnVlOwogfQogCg==