71364 2011-11-02 07:17:06 -0700 CSSStyleRule: Devirtualize selectorText() 2012-06-08 12:32:59 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 34984 1 kling kling dglazkov macpherson webkit.review.bot oldest_to_newest 494601 0 kling 2011-11-02 07:17:06 -0700 CSSStyleRule: Devirtualize selectorText() 494602 1 113314 kling 2011-11-02 07:18:30 -0700 Created attachment 113314 Purposeful patch 494604 2 113314 kling 2011-11-02 07:19:54 -0700 Comment on attachment 113314 Purposeful patch View in context: https://bugs.webkit.org/attachment.cgi?id=113314&action=review > Source/WebCore/css/CSSStyleRule.cpp:50 > + return static_cast<CSSPageRule*>(this)->selectorText(); should be <const CSSPageRule*> 494607 3 113314 webkit.review.bot 2011-11-02 07:22:47 -0700 Comment on attachment 113314 Purposeful patch Attachment 113314 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10190295 494609 4 113314 koivisto 2011-11-02 07:23:14 -0700 Comment on attachment 113314 Purposeful patch View in context: https://bugs.webkit.org/attachment.cgi?id=113314&action=review r=me > Source/WebCore/css/CSSStyleRule.cpp:50 > String CSSStyleRule::selectorText() const > { > + if (isPageRule()) > + return static_cast<CSSPageRule*>(this)->selectorText(); It would be less confusing if the subclass function had a different name (pageSelectorText() perhaps?). 494614 5 113314 webkit-ews 2011-11-02 07:25:28 -0700 Comment on attachment 113314 Purposeful patch Attachment 113314 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10148256 494619 6 113317 kling 2011-11-02 07:41:35 -0700 Created attachment 113317 Patch for laundry 494639 7 113317 webkit.review.bot 2011-11-02 08:45:20 -0700 Comment on attachment 113317 Patch for laundry Clearing flags on attachment: 113317 Committed r99063: <http://trac.webkit.org/changeset/99063> 494640 8 webkit.review.bot 2011-11-02 08:45:25 -0700 All reviewed patches have been landed. Closing bug. 113314 2011-11-02 07:18:30 -0700 2011-11-02 07:41:35 -0700 Purposeful patch bug-71364.diff text/plain 2347 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxOTVmZjhlLi40MTVhMDJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTEtMTEtMDIgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIENTU1N0eWxlUnVsZTogRGV2aXJ0dWFsaXplIHNlbGVjdG9yVGV4dCgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTM2NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhdmUgQ1NTU3R5bGVSdWxlOjpz ZWxlY3RvclRleHQoKSByZWRpcmVjdCB0byBDU1NQYWdlUnVsZTo6c2VsZWN0b3JUZXh0KCkKKyAg ICAgICAgaWYgdHlwZSgpIGlzIFBBR0VfUlVMRS4KKworICAgICAgICAqIGNzcy9DU1NQYWdlUnVs ZS5oOgorICAgICAgICAqIGNzcy9DU1NTdHlsZVJ1bGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q1NTU3R5bGVSdWxlOjpzZWxlY3RvclRleHQpOgorICAgICAgICAqIGNzcy9DU1NTdHlsZVJ1bGUu aDoKKworMjAxMS0xMS0wMiAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CisKICAg ICAgICAgQ1NTUnVsZTogRGV2aXJ0dWFsaXplIGNzc1RleHQoKQogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzEyOTIKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvY3NzL0NTU1BhZ2VSdWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFnZVJ1 bGUuaAppbmRleCA5ODUxMTk5Li5kYTJiNzdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTUGFnZVJ1bGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFnZVJ1bGUuaApA QCAtNDEsNyArNDEsNyBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIH5DU1NQYWdlUnVsZSgpOwog Ci0gICAgdmlydHVhbCBTdHJpbmcgc2VsZWN0b3JUZXh0KCkgY29uc3Q7CisgICAgU3RyaW5nIHNl bGVjdG9yVGV4dCgpIGNvbnN0OwogCiBwcml2YXRlOgogICAgIENTU1BhZ2VSdWxlKENTU1N0eWxl U2hlZXQqIHBhcmVudCwgaW50IHNvdXJjZUxpbmUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvY3NzL0NTU1N0eWxlUnVsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVSdWxl LmNwcAppbmRleCA5MGJmNjZlLi44Yjk1NmE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTU3R5bGVSdWxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVSdWxl LmNwcApAQCAtMjMsNiArMjMsNyBAQAogI2luY2x1ZGUgIkNTU1N0eWxlUnVsZS5oIgogCiAjaW5j bHVkZSAiQ1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24uaCIKKyNpbmNsdWRlICJDU1NQYWdlUnVs ZS5oIgogI2luY2x1ZGUgIkNTU1BhcnNlci5oIgogI2luY2x1ZGUgIkNTU1NlbGVjdG9yLmgiCiAj aW5jbHVkZSAiQ1NTU3R5bGVTaGVldC5oIgpAQCAtNDUsNiArNDYsOSBAQCBDU1NTdHlsZVJ1bGU6 On5DU1NTdHlsZVJ1bGUoKQogCiBTdHJpbmcgQ1NTU3R5bGVSdWxlOjpzZWxlY3RvclRleHQoKSBj b25zdAogeworICAgIGlmIChpc1BhZ2VSdWxlKCkpCisgICAgICAgIHJldHVybiBzdGF0aWNfY2Fz dDxDU1NQYWdlUnVsZSo+KHRoaXMpLT5zZWxlY3RvclRleHQoKTsKKwogICAgIFN0cmluZyBzdHI7 CiAgICAgZm9yIChDU1NTZWxlY3RvciogcyA9IHNlbGVjdG9yTGlzdCgpLmZpcnN0KCk7IHM7IHMg PSBDU1NTZWxlY3Rvckxpc3Q6Om5leHQocykpIHsKICAgICAgICAgaWYgKHMgIT0gc2VsZWN0b3JM aXN0KCkuZmlyc3QoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVJ1 bGUuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVJ1bGUuaAppbmRleCA4Mzc0MDY3Li43 MGFmY2NiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVSdWxlLmgKKysr IGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlUnVsZS5oCkBAIC00MCw3ICs0MCw3IEBAIHB1 YmxpYzoKICAgICB9CiAgICAgdmlydHVhbCB+Q1NTU3R5bGVSdWxlKCk7CiAKLSAgICB2aXJ0dWFs IFN0cmluZyBzZWxlY3RvclRleHQoKSBjb25zdDsKKyAgICBTdHJpbmcgc2VsZWN0b3JUZXh0KCkg Y29uc3Q7CiAgICAgdm9pZCBzZXRTZWxlY3RvclRleHQoY29uc3QgU3RyaW5nJik7CiAKICAgICBD U1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbiogc3R5bGUoKSBjb25zdCB7IHJldHVybiBtX3N0eWxl LmdldCgpOyB9Cg== 113317 2011-11-02 07:41:35 -0700 2011-11-02 08:45:19 -0700 Patch for laundry bug-71364-v2.diff text/plain 2871 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxOTVmZjhlLi45YjI5NmFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIg QEAKIDIwMTEtMTEtMDIgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIENTU1N0eWxlUnVsZTogRGV2aXJ0dWFsaXplIHNlbGVjdG9yVGV4dCgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTM2NAorCisgICAgICAgIFJl dmlld2VkIGJ5IEFudHRpIEtvaXZpc3RvLgorCisgICAgICAgIEhhdmUgQ1NTU3R5bGVSdWxlOjpz ZWxlY3RvclRleHQoKSByZWRpcmVjdCB0byBDU1NQYWdlUnVsZTo6cGFnZVNlbGVjdG9yVGV4dCgp CisgICAgICAgIGlmIHR5cGUoKSBpcyBQQUdFX1JVTEUuCisKKyAgICAgICAgKiBjc3MvQ1NTUGFn ZVJ1bGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFnZVJ1bGU6OnBhZ2VTZWxlY3RvclRl eHQpOgorICAgICAgICAqIGNzcy9DU1NQYWdlUnVsZS5oOgorICAgICAgICAqIGNzcy9DU1NTdHls ZVJ1bGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVSdWxlOjpzZWxlY3RvclRleHQp OgorICAgICAgICAqIGNzcy9DU1NTdHlsZVJ1bGUuaDoKKworMjAxMS0xMS0wMiAgQW5kcmVhcyBL bGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CisKICAgICAgICAgQ1NTUnVsZTogRGV2aXJ0dWFsaXpl IGNzc1RleHQoKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzEyOTIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhZ2VSdWxlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYWdlUnVsZS5jcHAKaW5kZXggNjYwMWEzZi4uOTMx OTkzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhZ2VSdWxlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFnZVJ1bGUuY3BwCkBAIC0zNiw3ICszNiw3IEBAIENT U1BhZ2VSdWxlOjp+Q1NTUGFnZVJ1bGUoKQogewogfQogCi1TdHJpbmcgQ1NTUGFnZVJ1bGU6OnNl bGVjdG9yVGV4dCgpIGNvbnN0CitTdHJpbmcgQ1NTUGFnZVJ1bGU6OnBhZ2VTZWxlY3RvclRleHQo KSBjb25zdAogewogICAgIFN0cmluZyB0ZXh0ID0gIkBwYWdlIjsKICAgICBDU1NTZWxlY3Rvciog c2VsZWN0b3IgPSBzZWxlY3Rvckxpc3QoKS5maXJzdCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU1BhZ2VSdWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFnZVJ1bGUu aAppbmRleCA5ODUxMTk5Li40YzMxMzZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTUGFnZVJ1bGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFnZVJ1bGUuaApAQCAt NDEsNyArNDEsNyBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIH5DU1NQYWdlUnVsZSgpOwogCi0g ICAgdmlydHVhbCBTdHJpbmcgc2VsZWN0b3JUZXh0KCkgY29uc3Q7CisgICAgU3RyaW5nIHBhZ2VT ZWxlY3RvclRleHQoKSBjb25zdDsKIAogcHJpdmF0ZToKICAgICBDU1NQYWdlUnVsZShDU1NTdHls ZVNoZWV0KiBwYXJlbnQsIGludCBzb3VyY2VMaW5lKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NTdHlsZVJ1bGUuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlUnVs ZS5jcHAKaW5kZXggOTBiZjY2ZS4uNmIyYWNmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Y3NzL0NTU1N0eWxlUnVsZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlUnVs ZS5jcHAKQEAgLTIzLDYgKzIzLDcgQEAKICNpbmNsdWRlICJDU1NTdHlsZVJ1bGUuaCIKIAogI2lu Y2x1ZGUgIkNTU011dGFibGVTdHlsZURlY2xhcmF0aW9uLmgiCisjaW5jbHVkZSAiQ1NTUGFnZVJ1 bGUuaCIKICNpbmNsdWRlICJDU1NQYXJzZXIuaCIKICNpbmNsdWRlICJDU1NTZWxlY3Rvci5oIgog I2luY2x1ZGUgIkNTU1N0eWxlU2hlZXQuaCIKQEAgLTQ1LDYgKzQ2LDkgQEAgQ1NTU3R5bGVSdWxl Ojp+Q1NTU3R5bGVSdWxlKCkKIAogU3RyaW5nIENTU1N0eWxlUnVsZTo6c2VsZWN0b3JUZXh0KCkg Y29uc3QKIHsKKyAgICBpZiAoaXNQYWdlUnVsZSgpKQorICAgICAgICByZXR1cm4gc3RhdGljX2Nh c3Q8Y29uc3QgQ1NTUGFnZVJ1bGUqPih0aGlzKS0+cGFnZVNlbGVjdG9yVGV4dCgpOworCiAgICAg U3RyaW5nIHN0cjsKICAgICBmb3IgKENTU1NlbGVjdG9yKiBzID0gc2VsZWN0b3JMaXN0KCkuZmly c3QoKTsgczsgcyA9IENTU1NlbGVjdG9yTGlzdDo6bmV4dChzKSkgewogICAgICAgICBpZiAocyAh PSBzZWxlY3Rvckxpc3QoKS5maXJzdCgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1N0eWxlUnVsZS5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlUnVsZS5oCmluZGV4 IDgzNzQwNjcuLjcwYWZjY2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHls ZVJ1bGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVSdWxlLmgKQEAgLTQwLDcg KzQwLDcgQEAgcHVibGljOgogICAgIH0KICAgICB2aXJ0dWFsIH5DU1NTdHlsZVJ1bGUoKTsKIAot ICAgIHZpcnR1YWwgU3RyaW5nIHNlbGVjdG9yVGV4dCgpIGNvbnN0OworICAgIFN0cmluZyBzZWxl Y3RvclRleHQoKSBjb25zdDsKICAgICB2b2lkIHNldFNlbGVjdG9yVGV4dChjb25zdCBTdHJpbmcm KTsKIAogICAgIENTU011dGFibGVTdHlsZURlY2xhcmF0aW9uKiBzdHlsZSgpIGNvbnN0IHsgcmV0 dXJuIG1fc3R5bGUuZ2V0KCk7IH0K