71344 2011-11-01 18:08:51 -0700 Remove initMediaStreamEvent method 2011-11-04 11:12:07 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71345 68791 1 dominicc webkit-unassigned abarth kaustubh.ra ojan webkit.review.bot oldest_to_newest 494377 0 dominicc 2011-11-01 18:08:51 -0700 This method has been removed from the spec draft: <http://www.whatwg.org/specs/web-apps/current-work/multipage/video-conferencing-and-peer-to-peer-communication.html#mediastreamevent> Code Search does not turn up any users: <http://codesearch.google.com/#search/&q=initMediaStreamEvent&type=cs> Since this is new, it is probably safe to remove it when MediaStreamEvent gets a constructor. 494381 1 dominicc 2011-11-01 18:12:58 -0700 Bug 71345 is tracking implementing the MediaStreamEvent constructor. 496161 2 113649 kaustubh.ra 2011-11-04 05:19:23 -0700 Created attachment 113649 Patch 496162 3 kaustubh.ra 2011-11-04 05:19:51 -0700 Added patch for removing initMediaStreamEvent method. 496219 4 113649 dominicc 2011-11-04 09:13:29 -0700 Comment on attachment 113649 Patch The patch looks good to me. You may want to hold off landing this until the MediaStreamEvent constructor is implemented (see bug 71345) otherwise there will be no way to programatically dispatch a MediaStreamEvent. 496250 5 113649 abarth 2011-11-04 10:03:43 -0700 Comment on attachment 113649 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113649&action=review I think its fine to land without the constructor. This feature isn't shipping in any port that I'm aware of. > Source/WebCore/ChangeLog:11 > + No new tests. Removed method. You can test that this method doesn't exist! That will catch us if someone tries to add it back. 496323 6 113649 webkit.review.bot 2011-11-04 11:12:02 -0700 Comment on attachment 113649 Patch Clearing flags on attachment: 113649 Committed r99299: <http://trac.webkit.org/changeset/99299> 496325 7 webkit.review.bot 2011-11-04 11:12:07 -0700 All reviewed patches have been landed. Closing bug. 113649 2011-11-04 05:19:23 -0700 2011-11-04 11:12:02 -0700 Patch 71344_patch.txt text/plain 3060 kaustubh.ra SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk5MjcyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMTEtMDQgIEthdXN0dWJo IEF0cmF3YWxrYXIgIDxrYXVzdHViaEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGlu aXRNZWRpYVN0cmVhbUV2ZW50IG1ldGhvZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzEzNDQKKworICAgICAgICBUaGlzIG1ldGhvZCBoYXMgYmVlbiBy ZW1vdmVkIGZyb20gdGhlIHNwZWMgZHJhZnQuCisgICAgICAgIGh0dHA6Ly93d3cud2hhdHdnLm9y Zy9zcGVjcy93ZWItYXBwcy9jdXJyZW50LXdvcmsvbXVsdGlwYWdlL3ZpZGVvLWNvbmZlcmVuY2lu Zy1hbmQtcGVlci10by1wZWVyLWNvbW11bmljYXRpb24uaHRtbCNtZWRpYXN0cmVhbWV2ZW50CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLiBSZW1vdmVkIG1ldGhvZC4KKworICAgICAgICAqIG1lZGlhc3RyZWFtL01lZGlhU3RyZWFt RXZlbnQuY3BwOgorICAgICAgICAqIG1lZGlhc3RyZWFtL01lZGlhU3RyZWFtRXZlbnQuaDoKKyAg ICAgICAgKiBtZWRpYXN0cmVhbS9NZWRpYVN0cmVhbUV2ZW50LmlkbDoKKwogMjAxMS0xMS0wNCAg VG9tbXkgV2lkZW5mbHljaHQgIDx0b21teXdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbY2hyb21p dW1dIE1lZGlhU3RyZWFtIEFQSTogRml4aW5nIHdyb25nIHBhdGggZm9yIFBlZXJDb25uZWN0aW9u SGFuZGxlci5oIGluIFdlYkNvcmUuZ3lwCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9tZWRpYXN0cmVh bS9NZWRpYVN0cmVhbUV2ZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9tZWRp YXN0cmVhbS9NZWRpYVN0cmVhbUV2ZW50LmNwcAkocmV2aXNpb24gOTkyNjMpCisrKyBTb3VyY2Uv V2ViQ29yZS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbUV2ZW50LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNTcsMTYgKzU3LDYgQEAgTWVkaWFTdHJlYW1FdmVudDo6fk1lZGlhU3RyZWFtRXZlbnQoKQog ewogfQogCi12b2lkIE1lZGlhU3RyZWFtRXZlbnQ6OmluaXRNZWRpYVN0cmVhbUV2ZW50KGNvbnN0 IEF0b21pY1N0cmluZyYgdHlwZSwgYm9vbCBjYW5CdWJibGUsIGJvb2wgY2FuY2VsYWJsZSwgUGFz c1JlZlB0cjxNZWRpYVN0cmVhbT4gc3RyZWFtKQotewotICAgIGlmIChkaXNwYXRjaGVkKCkpCi0g ICAgICAgIHJldHVybjsKLQotICAgIGluaXRFdmVudCh0eXBlLCBjYW5CdWJibGUsIGNhbmNlbGFi bGUpOwotCi0gICAgbV9zdHJlYW0gPSBzdHJlYW07Ci19Ci0KIFBhc3NSZWZQdHI8TWVkaWFTdHJl YW0+IE1lZGlhU3RyZWFtRXZlbnQ6OnN0cmVhbSgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1fc3Ry ZWFtOwpJbmRleDogU291cmNlL1dlYkNvcmUvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1FdmVudC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtRXZl bnQuaAkocmV2aXNpb24gOTkyNjMpCisrKyBTb3VyY2UvV2ViQ29yZS9tZWRpYXN0cmVhbS9NZWRp YVN0cmVhbUV2ZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTQxLDggKzQxLDYgQEAgcHVibGljOgog ICAgIHN0YXRpYyBQYXNzUmVmUHRyPE1lZGlhU3RyZWFtRXZlbnQ+IGNyZWF0ZSgpOwogICAgIHN0 YXRpYyBQYXNzUmVmUHRyPE1lZGlhU3RyZWFtRXZlbnQ+IGNyZWF0ZShjb25zdCBBdG9taWNTdHJp bmcmIHR5cGUsIGJvb2wgY2FuQnViYmxlLCBib29sIGNhbmNlbGFibGUsIFBhc3NSZWZQdHI8TWVk aWFTdHJlYW0+KTsKIAotICAgIHZvaWQgaW5pdE1lZGlhU3RyZWFtRXZlbnQoY29uc3QgQXRvbWlj U3RyaW5nJiB0eXBlLCBib29sIGNhbkJ1YmJsZSwgYm9vbCBjYW5jZWxhYmxlLCBQYXNzUmVmUHRy PE1lZGlhU3RyZWFtPik7Ci0KICAgICAvLyBGcm9tIEV2ZW50VGFyZ2V0LgogICAgIHZpcnR1YWwg Ym9vbCBpc01lZGlhU3RyZWFtRXZlbnQoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtRXZlbnQuaWRsCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtRXZlbnQuaWRsCShy ZXZpc2lvbiA5OTI2MykKKysrIFNvdXJjZS9XZWJDb3JlL21lZGlhc3RyZWFtL01lZGlhU3RyZWFt RXZlbnQuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0zMCwxMSArMzAsNiBAQCBtb2R1bGUgcDJwIHsK ICAgICAgICAgQ29uZGl0aW9uYWw9TUVESUFfU1RSRUFNLAogICAgIF0gTWVkaWFTdHJlYW1FdmVu dCA6IEV2ZW50IHsKICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgTWVkaWFTdHJlYW0gc3RyZWFt OwotCi0gICAgICAgdm9pZCBpbml0TWVkaWFTdHJlYW1FdmVudChpbiBbT3B0aW9uYWw9Q2FsbFdp dGhEZWZhdWx0VmFsdWVdIERPTVN0cmluZyB0eXBlQXJnLAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBib29sZWFuIGNh bkJ1YmJsZUFyZywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluIFtPcHRpb25h bD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gYm9vbGVhbiBjYW5jZWxhYmxlQXJnLAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVl XSBNZWRpYVN0cmVhbSBzdHJlYW1BcmcpOwogICAgIH07CiAKIH0K