71229 2011-10-31 11:08:18 -0700 V8MessageEvent::dataAccessorGetter does not return a reference to its caller 2011-10-31 20:38:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dmichael webkit-unassigned abarth haraken japhet webkit.review.bot oldest_to_newest 493416 0 dmichael 2011-10-31 11:08:18 -0700 V8MessageEvent::dataAccessorGetter does not return a reference to its caller 493418 1 113069 dmichael 2011-10-31 11:08:46 -0700 Created attachment 113069 Patch 493428 2 113069 abarth 2011-10-31 11:53:03 -0700 Comment on attachment 113069 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113069&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) I can haz test? 493429 3 113069 abarth 2011-10-31 11:56:49 -0700 Comment on attachment 113069 Patch This either needs a test or an explanation why a test is impossible. I this case, it seems like a test should be possible. 493440 4 dmichael 2011-10-31 12:19:44 -0700 I have a manual test that demonstrates the problem when using pepper postmessage, which executes script via WebBindings to create & dispatch a MessageEvent. Without this patch, the passed string gets garbled about 1 in ~3000-6000 times. With this patch it succeeds. I haven't been able to reproduce it elsewhere. I can add that test to the bug so anybody who can build a trusted pepper plugin can reproduce, but I'd much rather have a decent automated test in WebKit. I'm still a total n00b in WebKit/V8 land. A couple of questions: (1) Does this look like I'm on the right track? (2) Do you have a suggestion as to how to test this? I'm looking at LayoutTests/fast/events right now, but it would seem easier to test directly on top of the C++, but I'm not sure where to put such a test. 493452 5 113075 dmichael 2011-10-31 13:06:10 -0700 Created attachment 113075 Test that shows MessageEvent's data property getting corrupted. Open the javascript console if you want to see the mismatched strings. Open the page. The renderer will usually crash. What this test does is create 10000 events in sequence, each with a unique and long string for its data contents. Each message is dispatched. We check that the received string matches the one we sent. For me, about 1 in 1500 times, the string does not match. The renderer also seems to crash pretty reliably. I'll try to massage this in to a layout test so it can be checked in. 493456 6 abarth 2011-10-31 13:11:47 -0700 > (1) Does this look like I'm on the right track? Yes, the patch looks fine. (Sorry, distracted at TPAC and can't answer your testing questions.) 493486 7 113085 dmichael 2011-10-31 14:04:06 -0700 Created attachment 113085 Patch 493562 8 haraken 2011-10-31 15:53:35 -0700 Thank you very much for fixing the regression. The change looks good to me. By the way, what makes the test result non-deterministic? The timing of GC? If so, isn't it possible to make the test more deterministic by triggering GC after each MessageEvent? (c.f. How to trigger GC: http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/LayoutTests/fast/dom/resources/script-element-gc.js&exact_package=chromium&q=%22gc()%22%20layouttests&type=cs) 493583 9 dmichael 2011-10-31 16:05:19 -0700 I tried that, and it didn't seem to make it fail any more consistently for me. I can try it again, but if it looks good enough now, we really need it committed to make the NaCl tests start passing again. Thanks guys for looking! 493616 10 113085 abarth 2011-10-31 16:36:36 -0700 Comment on attachment 113085 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113085&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) This line will prevent the patch from being landed. You have a test now, so referencing it is probably the thing to do. > LayoutTests/fast/events/dispatch-message-string-data.html:6 > +<script> I would have expected a call to layoutTestController.dumpAsText() and layoutTestController.waitUntilDone(), etc. These are usually guarded by checking if (window.layoutTestController) . Maybe there here and I don't see them? 493719 11 113122 dmichael 2011-10-31 19:29:18 -0700 Created attachment 113122 Patch 493720 12 113122 abarth 2011-10-31 19:31:39 -0700 Comment on attachment 113122 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113122&action=review > Source/WebCore/ChangeLog:8 > + V8MessageEvent::dataAccessorGetter does not return a reference to its caller > + https://bugs.webkit.org/show_bug.cgi?id=71229 > + > + Reviewed by Adam Barth. > + > + Test: fast/events/dispatch-message-string-data.html Generally we prefer more of an explanation of why you're making this change. Often this duplicates information in the bug comments, but helps folks who stumble upon this commit later. 493729 13 113122 webkit.review.bot 2011-10-31 20:38:05 -0700 Comment on attachment 113122 Patch Clearing flags on attachment: 113122 Committed r98934: <http://trac.webkit.org/changeset/98934> 493730 14 webkit.review.bot 2011-10-31 20:38:10 -0700 All reviewed patches have been landed. Closing bug. 113069 2011-10-31 11:08:46 -0700 2011-10-31 14:04:01 -0700 Patch bug-71229-20111031120845.patch text/plain 1459 dmichael U3VidmVyc2lvbiBSZXZpc2lvbjogOTg3MjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzNGM0ODQ0MDExNWZiNTFk MWNhZDM1YmQwODYyY2ExYTQxMzFlMTZhLi4yYjVjNTE4MTFkYWY3YzIzYjM4MTk3MDgxMzZiZjEy NThmMjYxNGRkIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMzEgIERhdmUg TWljaGFlbCAgPGRtaWNoYWVsQGNocm9taXVtLm9yZz4KKworICAgICAgICBWOE1lc3NhZ2VFdmVu dDo6ZGF0YUFjY2Vzc29yR2V0dGVyIGRvZXMgbm90IHJldHVybiBhIHJlZmVyZW5jZSB0byBpdHMg Y2FsbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 MTIyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4TWVz c2FnZUV2ZW50Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4TWVzc2FnZUV2ZW50Ojpk YXRhQWNjZXNzb3JHZXR0ZXIpOgorCiAyMDExLTEwLTI4ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRt YW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXNldCBsaW5lIG51bWJlcnMgZm9yIHNjcmlwdHMg Z2VuZXJhdGVkIHdpdGggZG9jdW1lbnQud3JpdGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9jdXN0b20vVjhNZXNzYWdlRXZlbnRDdXN0b20uY3BwIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4TWVzc2FnZUV2ZW50Q3VzdG9tLmNwcAppbmRleCAw ZjhmNmY3NjRjOThlYjFlZjY4MzRmNWZmYWIxMWY5M2RiOWE0YmRkLi41ZDE3NWUzNjI3M2I2OWEx MDAyYzU1YTMwMDZhM2JjNzI0Yzk0ZTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhNZXNzYWdlRXZlbnRDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOE1lc3NhZ2VFdmVudEN1c3RvbS5jcHAKQEAgLTU2LDcg KzU2LDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4TWVzc2FnZUV2ZW50OjpkYXRhQWNjZXNz b3JHZXR0ZXIodjg6OkxvY2FsPHY4OjpTdHJpbmc+IG4KICAgICAgICAgaWYgKHNjcmlwdFZhbHVl Lmhhc05vVmFsdWUoKSkKICAgICAgICAgICAgIHJlc3VsdCA9IHY4OjpOdWxsKCk7CiAgICAgICAg IGVsc2UKLSAgICAgICAgICAgIHJlc3VsdCA9IHNjcmlwdFZhbHVlLnY4VmFsdWUoKTsKKyAgICAg ICAgICAgIHJlc3VsdCA9IHY4OjpMb2NhbDx2ODo6VmFsdWU+OjpOZXcoc2NyaXB0VmFsdWUudjhW YWx1ZSgpKTsKICAgICAgICAgYnJlYWs7CiAgICAgfQogCg== 113075 2011-10-31 13:06:10 -0700 2011-10-31 13:06:10 -0700 Test that shows MessageEvent's data property getting corrupted. message_event.html text/html 1781 dmichael PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDwhLS0KICBDb3B5cmlnaHQgKGMpIDIwMTEgVGhlIENo cm9taXVtIEF1dGhvcnMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgVXNlIG9mIHRoaXMgc291cmNl IGNvZGUgaXMgZ292ZXJuZWQgYnkgYSBCU0Qtc3R5bGUgbGljZW5zZSB0aGF0IGNhbiBiZQogIGZv dW5kIGluIHRoZSBMSUNFTlNFIGZpbGUuCiAgLS0+CjxoZWFkPgogIDx0aXRsZT5wb3N0TWVzc2Fn ZSBFeGFtcGxlPC90aXRsZT4KICA8c2NyaXB0PgogIC8vIE1ha2UgYSBsb25nIHByZWZpeCBzdHJp bmcuIFRoaXMgc2VlbXMgdG8gbWFrZSBpdCBtb3JlIGxpa2VseSB0aGF0IGEgdXNlLQogIC8vIGFm dGVyLWZyZWUgcHJvYmxlbSB3aWxsIGNhdXNlIGFuIG9ic2VydmFibGUgZXJyb3IuCiAgdmFyIGtQ cmVmaXggPSAiSGVsbG8iOwogIGZvciAodmFyIGkgPSAwOyBpIDwgMTA7ICsraSkKICAgIGtQcmVm aXggKz0ga1ByZWZpeDsKICB2YXIgbnVtID0gMDsKICB2YXIgZW5kTnVtID0gMTAwMDA7CiAgZnVu Y3Rpb24gSGFuZGxlTWVzc2FnZShtZXNzYWdlX2V2ZW50KSB7CiAgICBpZiAobWVzc2FnZV9ldmVu dC5kYXRhICE9PSBrUHJlZml4ICsgbnVtLnRvU3RyaW5nKCkpIHsKICAgICAgY29uc29sZS5sb2co IkV4cGVjdGVkICciICsgbnVtICsgIicsIEdvdDogJyIgKyBtZXNzYWdlX2V2ZW50LmRhdGEgKyAi JyIpOwogICAgfQogICAgaWYgKG51bSA9PSBlbmROdW0pCiAgICAgIHF1aXQoKTsgLy8/Pz8KICAg IGVsc2UgewogICAgICArK251bTsKICAgICAgc2V0VGltZW91dChTZW5kU3RyaW5nLCAwKTsKICAg IH0KICB9CgogIGZ1bmN0aW9uIFNlbmRTdHJpbmcoKSB7CiAgICB2YXIgdGFyZ2V0ID0gZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoImV2ZW50X3RhcmdldCIpOwogICAgdmFyIG1lc3NhZ2VfZXZlbnQg PSB3aW5kb3cuZG9jdW1lbnQuY3JlYXRlRXZlbnQoJ01lc3NhZ2VFdmVudCcpOwogICAgbWVzc2Fn ZV9ldmVudC5pbml0TWVzc2FnZUV2ZW50KCdtZXNzYWdlJywgIC8vIHR5cGUKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBmYWxzZSwgIC8vIGNhbkJ1YmJsZQogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGZhbHNlLCAgLy8gY2FuY2VsYWJsZQogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGtQcmVmaXggKyBudW0udG9TdHJpbmcoKSwgIC8vIGRhdGEK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnJywgIC8vIG9yaWdpbiBbKl0KICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnJywgIC8vIGxhc3RFdmVudElkCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbnVsbCwgIC8vIHNvdXJjZSBbKl0KICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBbXSk7ICAvLyBwb3J0cwogICAgdGFyZ2V0LmRp c3BhdGNoRXZlbnQobWVzc2FnZV9ldmVudCk7CiAgfQoKICBmdW5jdGlvbiBBZGRMaXN0ZW5lcigp IHsKICAgIHZhciB0YXJnZXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZXZlbnRfdGFyZ2V0 Iik7CiAgICB0YXJnZXQuYWRkRXZlbnRMaXN0ZW5lcigibWVzc2FnZSIsIEhhbmRsZU1lc3NhZ2Us IGZhbHNlKTsKICAgIFNlbmRTdHJpbmcoKTsKICB9CiAgZG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5l cigiRE9NQ29udGVudExvYWRlZCIsIEFkZExpc3RlbmVyLCBmYWxzZSk7CgogIDwvc2NyaXB0Pgo8 L2hlYWQ+Cgo8Ym9keT4KICA8ZGl2IGlkPSJldmVudF90YXJnZXQiPjwvZGl2PgogIDxocj4KPC9i b2R5Pgo8L2h0bWw+Cgo= 113085 2011-10-31 14:04:06 -0700 2011-10-31 19:29:12 -0700 Patch bug-71229-20111031150405.patch text/plain 4318 dmichael U3VidmVyc2lvbiBSZXZpc2lvbjogOTg3MjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzNGM0ODQ0MDExNWZiNTFk MWNhZDM1YmQwODYyY2ExYTQxMzFlMTZhLi4yYjVjNTE4MTFkYWY3YzIzYjM4MTk3MDgxMzZiZjEy NThmMjYxNGRkIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMzEgIERhdmUg TWljaGFlbCAgPGRtaWNoYWVsQGNocm9taXVtLm9yZz4KKworICAgICAgICBWOE1lc3NhZ2VFdmVu dDo6ZGF0YUFjY2Vzc29yR2V0dGVyIGRvZXMgbm90IHJldHVybiBhIHJlZmVyZW5jZSB0byBpdHMg Y2FsbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 MTIyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4TWVz c2FnZUV2ZW50Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4TWVzc2FnZUV2ZW50Ojpk YXRhQWNjZXNzb3JHZXR0ZXIpOgorCiAyMDExLTEwLTI4ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRt YW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXNldCBsaW5lIG51bWJlcnMgZm9yIHNjcmlwdHMg Z2VuZXJhdGVkIHdpdGggZG9jdW1lbnQud3JpdGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9jdXN0b20vVjhNZXNzYWdlRXZlbnRDdXN0b20uY3BwIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4TWVzc2FnZUV2ZW50Q3VzdG9tLmNwcAppbmRleCAw ZjhmNmY3NjRjOThlYjFlZjY4MzRmNWZmYWIxMWY5M2RiOWE0YmRkLi41ZDE3NWUzNjI3M2I2OWEx MDAyYzU1YTMwMDZhM2JjNzI0Yzk0ZTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhNZXNzYWdlRXZlbnRDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOE1lc3NhZ2VFdmVudEN1c3RvbS5jcHAKQEAgLTU2LDcg KzU2LDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4TWVzc2FnZUV2ZW50OjpkYXRhQWNjZXNz b3JHZXR0ZXIodjg6OkxvY2FsPHY4OjpTdHJpbmc+IG4KICAgICAgICAgaWYgKHNjcmlwdFZhbHVl Lmhhc05vVmFsdWUoKSkKICAgICAgICAgICAgIHJlc3VsdCA9IHY4OjpOdWxsKCk7CiAgICAgICAg IGVsc2UKLSAgICAgICAgICAgIHJlc3VsdCA9IHNjcmlwdFZhbHVlLnY4VmFsdWUoKTsKKyAgICAg ICAgICAgIHJlc3VsdCA9IHY4OjpMb2NhbDx2ODo6VmFsdWU+OjpOZXcoc2NyaXB0VmFsdWUudjhW YWx1ZSgpKTsKICAgICAgICAgYnJlYWs7CiAgICAgfQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9mYXN0L2V2ZW50cy9kaXNwYXRjaC1tZXNzYWdlLXN0cmluZy1kYXRhLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Rpc3BhdGNoLW1lc3NhZ2Utc3RyaW5nLWRhdGEtZXhw ZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjRiZjIwYTRmYTIxMmFkNzA3YzQ0NTZhYzZlYWNlMjEyOWFh MWMyOGUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9kaXNwYXRj aC1tZXNzYWdlLXN0cmluZy1kYXRhLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMgQEAKK1RoaXMg aXMgYSB0ZXN0IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzEy MjkgKFY4TWVzc2FnZUV2ZW50OjpkYXRhQWNjZXNzb3JHZXR0ZXIgZG9lcyBub3QgcmV0dXJuIGEg cmVmZXJlbmNlIHRvIGl0cyBjYWxsZXIpLgorCitET05FCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9mYXN0L2V2ZW50cy9kaXNwYXRjaC1tZXNzYWdlLXN0cmluZy1kYXRhLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy9kaXNwYXRjaC1tZXNzYWdlLXN0cmluZy1kYXRhLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uYzAxYTNmZDkyYmMzODQzZjcwNzUzNmQ5OTIzYzkwOTA5ODZmMTIxMAotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Rpc3BhdGNoLW1lc3NhZ2Utc3RyaW5n LWRhdGEuaHRtbApAQCAtMCwwICsxLDU5IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhl YWQ+Cis8cD5UaGlzIGlzIGEgdGVzdCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTcxMjI5IChWOE1lc3NhZ2VFdmVudDo6ZGF0YUFjY2Vzc29yR2V0dGVyIGRvZXMg bm90IHJldHVybiBhIHJlZmVyZW5jZSB0byBpdHMgY2FsbGVyKS4gSWYgaXQgc3VjY2VlZHMsIERP TkUgd2lsbCBhcHBlYXIgYmVsb3cuIElmIGl0IGZhaWxzLCB5b3Ugc2hvdWxkIHNlZSBtZXNzYWdl cyBjb250YWluaW5nIHVuZXhwZWN0ZWQgc3RyaW5ncyB0aGF0IHdlcmUgcmVjZWl2ZWQgYW5kL29y IGEgcmVuZGVyZXIgY3Jhc2guCis8cHJlIGlkPWxvZz48L3ByZT4KKzxzY3JpcHQ+CitmdW5jdGlv biBsb2cobWVzc2FnZSkKK3sKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibG9nIikuaW5u ZXJIVE1MICs9IG1lc3NhZ2UgKyAiPGJyPiI7Cit9CisKK3ZhciBldmVudFRhcmdldDsKKworLy8g TWFrZSBhIGxvbmcgcHJlZml4IHN0cmluZy4gVGhpcyBzZWVtcyB0byBtYWtlIGl0IG1vcmUgbGlr ZWx5IHRoYXQgYSB1c2UtCisvLyBhZnRlci1mcmVlIHByb2JsZW0gd2lsbCBjYXVzZSBhbiBvYnNl cnZhYmxlIGVycm9yLgordmFyIGtQcmVmaXggPSAiSGVsbG8iOworZm9yICh2YXIgaSA9IDA7IGkg PCAxMDsgKytpKQorICAgIGtQcmVmaXggKz0ga1ByZWZpeDsKK3ZhciBudW0gPSAwOwordmFyIGVu ZE51bSA9IDEwMDA7CitmdW5jdGlvbiBIYW5kbGVNZXNzYWdlKG1lc3NhZ2VfZXZlbnQpIHsKKyAg ICBpZiAobWVzc2FnZV9ldmVudC5kYXRhICE9PSBrUHJlZml4ICsgbnVtLnRvU3RyaW5nKCkpIHsK KyAgICAgICAgbG9nKCJFeHBlY3RlZCAnIiArIG51bSArICInLCBHb3Q6ICciICsgbWVzc2FnZV9l dmVudC5kYXRhICsgIiciKTsKKyAgICB9CisgICAgaWYgKG51bSA9PSBlbmROdW0pCisgICAgICAg IGxvZygiRE9ORSIpOworICAgIGVsc2UgeworICAgICAgICArK251bTsKKyAgICAgICAgc2V0VGlt ZW91dChTZW5kU3RyaW5nLCAwKTsKKyAgICB9Cit9CisKK2Z1bmN0aW9uIFNlbmRTdHJpbmcoKSB7 CisgICAgdmFyIHRhcmdldCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJldmVudF90YXJnZXQi KTsKKyAgICB2YXIgbWVzc2FnZV9ldmVudCA9IHdpbmRvdy5kb2N1bWVudC5jcmVhdGVFdmVudCgn TWVzc2FnZUV2ZW50Jyk7CisgICAgbWVzc2FnZV9ldmVudC5pbml0TWVzc2FnZUV2ZW50KCdtZXNz YWdlJywgIC8vIHR5cGUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmFsc2Us ICAvLyBjYW5CdWJibGUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmFsc2Us ICAvLyBjYW5jZWxhYmxlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGtQcmVm aXggKyBudW0udG9TdHJpbmcoKSwgIC8vIGRhdGEKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJycsICAvLyBvcmlnaW4gWypdCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICcnLCAgLy8gbGFzdEV2ZW50SWQKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgbnVsbCwgIC8vIHNvdXJjZSBbKl0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgW10pOyAgLy8gcG9ydHMKKyAgICB0YXJnZXQuZGlzcGF0Y2hFdmVudChtZXNzYWdlX2V2 ZW50KTsKK30KKworZnVuY3Rpb24gQWRkTGlzdGVuZXIoKSB7CisgICAgdmFyIHRhcmdldCA9IGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJldmVudF90YXJnZXQiKTsKKyAgICB0YXJnZXQuYWRkRXZl bnRMaXN0ZW5lcigibWVzc2FnZSIsIEhhbmRsZU1lc3NhZ2UsIGZhbHNlKTsKKyAgICBTZW5kU3Ry aW5nKCk7Cit9Citkb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCJET01Db250ZW50TG9hZGVkIiwg QWRkTGlzdGVuZXIsIGZhbHNlKTsKKworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXYg aWQ9ImV2ZW50X3RhcmdldCI+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+Cg== 113122 2011-10-31 19:29:18 -0700 2011-10-31 20:38:05 -0700 Patch bug-71229-20111031202917.patch text/plain 4636 dmichael U3VidmVyc2lvbiBSZXZpc2lvbjogOTg5MzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxMzc5ZWMyMTEwZWQ2Njk1 YzE5YjI4ZTk4NTIxMTliNGEyZWU0MTJjLi4xMGU1MTY1MjFkZmE5ZmFlZDE2MWQ2YjM5NjFmNWVh N2FmN2RmYzJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMzEgIERhdmUg TWljaGFlbCAgPGRtaWNoYWVsQGNocm9taXVtLm9yZz4KKworICAgICAgICBWOE1lc3NhZ2VFdmVu dDo6ZGF0YUFjY2Vzc29yR2V0dGVyIGRvZXMgbm90IHJldHVybiBhIHJlZmVyZW5jZSB0byBpdHMg Y2FsbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 MTIyOQorCisgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCisKKyAgICAgICAgVGVzdDog ZmFzdC9ldmVudHMvZGlzcGF0Y2gtbWVzc2FnZS1zdHJpbmctZGF0YS5odG1sCisKKyAgICAgICAg KiBiaW5kaW5ncy92OC9jdXN0b20vVjhNZXNzYWdlRXZlbnRDdXN0b20uY3BwOgorICAgICAgICAo V2ViQ29yZTo6VjhNZXNzYWdlRXZlbnQ6OmRhdGFBY2Nlc3NvckdldHRlcik6CisKIDIwMTEtMTAt MzEgIFJlbmF0YSBIb2RvdmFuICA8cmVuaUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gQnVp bGQgZml4IGFmdGVyIHI5ODg1My4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L2N1c3RvbS9WOE1lc3NhZ2VFdmVudEN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhNZXNzYWdlRXZlbnRDdXN0b20uY3BwCmluZGV4IDBmOGY2Zjc2NGM5 OGViMWVmNjgzNGY1ZmZhYjExZjkzZGI5YTRiZGQuLjVkMTc1ZTM2MjczYjY5YTEwMDJjNTVhMzAw NmEzYmM3MjRjOTRlODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1 c3RvbS9WOE1lc3NhZ2VFdmVudEN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvY3VzdG9tL1Y4TWVzc2FnZUV2ZW50Q3VzdG9tLmNwcApAQCAtNTYsNyArNTYsNyBAQCB2 ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhNZXNzYWdlRXZlbnQ6OmRhdGFBY2Nlc3NvckdldHRlcih2 ODo6TG9jYWw8djg6OlN0cmluZz4gbgogICAgICAgICBpZiAoc2NyaXB0VmFsdWUuaGFzTm9WYWx1 ZSgpKQogICAgICAgICAgICAgcmVzdWx0ID0gdjg6Ok51bGwoKTsKICAgICAgICAgZWxzZQotICAg ICAgICAgICAgcmVzdWx0ID0gc2NyaXB0VmFsdWUudjhWYWx1ZSgpOworICAgICAgICAgICAgcmVz dWx0ID0gdjg6OkxvY2FsPHY4OjpWYWx1ZT46Ok5ldyhzY3JpcHRWYWx1ZS52OFZhbHVlKCkpOwog ICAgICAgICBicmVhazsKICAgICB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZl bnRzL2Rpc3BhdGNoLW1lc3NhZ2Utc3RyaW5nLWRhdGEtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvZmFzdC9ldmVudHMvZGlzcGF0Y2gtbWVzc2FnZS1zdHJpbmctZGF0YS1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uYWJkMmEyZTY5M2E5MTQ0YzA0NGEyNWQwYTYyOTM5YjQzZjNmYjU5NwotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Rpc3BhdGNoLW1lc3NhZ2Ut c3RyaW5nLWRhdGEtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNCBAQAorVGhpcyBpcyBhIHRlc3Qg Zm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTIyOSAoVjhNZXNz YWdlRXZlbnQ6OmRhdGFBY2Nlc3NvckdldHRlciBkb2VzIG5vdCByZXR1cm4gYSByZWZlcmVuY2Ug dG8gaXRzIGNhbGxlcikuIElmIGl0IHN1Y2NlZWRzLCBET05FIHdpbGwgYXBwZWFyIGJlbG93LiBJ ZiBpdCBmYWlscywgeW91IHNob3VsZCBzZWUgbWVzc2FnZXMgY29udGFpbmluZyB1bmV4cGVjdGVk IHN0cmluZ3MgdGhhdCB3ZXJlIHJlY2VpdmVkIGFuZC9vciBhIHJlbmRlcmVyIGNyYXNoLgorCitE T05FCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Rpc3BhdGNoLW1lc3Nh Z2Utc3RyaW5nLWRhdGEuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Rpc3BhdGNoLW1l c3NhZ2Utc3RyaW5nLWRhdGEuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yNjQyNmY4YThmZjJhOWJhMzk3MjM0 OTJiYWE3NTQzMDQ1M2U0MzNjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9l dmVudHMvZGlzcGF0Y2gtbWVzc2FnZS1zdHJpbmctZGF0YS5odG1sCkBAIC0wLDAgKzEsNjcgQEAK KzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxwPlRoaXMgaXMgYSB0ZXN0IGZvciBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzEyMjkgKFY4TWVzc2FnZUV2 ZW50OjpkYXRhQWNjZXNzb3JHZXR0ZXIgZG9lcyBub3QgcmV0dXJuIGEgcmVmZXJlbmNlIHRvIGl0 cyBjYWxsZXIpLiBJZiBpdCBzdWNjZWVkcywgRE9ORSB3aWxsIGFwcGVhciBiZWxvdy4gSWYgaXQg ZmFpbHMsIHlvdSBzaG91bGQgc2VlIG1lc3NhZ2VzIGNvbnRhaW5pbmcgdW5leHBlY3RlZCBzdHJp bmdzIHRoYXQgd2VyZSByZWNlaXZlZCBhbmQvb3IgYSByZW5kZXJlciBjcmFzaC4KKzxocj4KKzxw cmUgaWQ9bG9nPjwvcHJlPgorPHNjcmlwdD4KK2Z1bmN0aW9uIGxvZyhtZXNzYWdlKQoreworICAg IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJsb2ciKS5pbm5lckhUTUwgKz0gbWVzc2FnZSArICI8 YnI+IjsKK30KKwordmFyIGV2ZW50VGFyZ2V0OworCisvLyBNYWtlIGEgbG9uZyBwcmVmaXggc3Ry aW5nLiBUaGlzIHNlZW1zIHRvIG1ha2UgaXQgbW9yZSBsaWtlbHkgdGhhdCBhIHVzZS0KKy8vIGFm dGVyLWZyZWUgcHJvYmxlbSB3aWxsIGNhdXNlIGFuIG9ic2VydmFibGUgZXJyb3IuCit2YXIga1By ZWZpeCA9ICJIZWxsbyI7Citmb3IgKHZhciBpID0gMDsgaSA8IDEwOyArK2kpCisgICAga1ByZWZp eCArPSBrUHJlZml4OwordmFyIG51bSA9IDA7Cit2YXIgZW5kTnVtID0gMTAwMDsKK2Z1bmN0aW9u IEhhbmRsZU1lc3NhZ2UobWVzc2FnZV9ldmVudCkgeworICAgIGlmIChtZXNzYWdlX2V2ZW50LmRh dGEgIT09IGtQcmVmaXggKyBudW0udG9TdHJpbmcoKSkgeworICAgICAgICBsb2coIkV4cGVjdGVk ICciICsgbnVtICsgIicsIEdvdDogJyIgKyBtZXNzYWdlX2V2ZW50LmRhdGEgKyAiJyIpOworICAg IH0KKyAgICBpZiAobnVtID09IGVuZE51bSkgeworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5ub3RpZnlEb25lKCk7CisgICAgfQorICAgIGVsc2UgeworICAgICAgICArK251bTsKKyAgICAg ICAgc2V0VGltZW91dChTZW5kU3RyaW5nLCAwKTsKKyAgICB9Cit9CisKK2Z1bmN0aW9uIFNlbmRT dHJpbmcoKSB7CisgICAgdmFyIHRhcmdldCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJldmVu dF90YXJnZXQiKTsKKyAgICB2YXIgbWVzc2FnZV9ldmVudCA9IHdpbmRvdy5kb2N1bWVudC5jcmVh dGVFdmVudCgnTWVzc2FnZUV2ZW50Jyk7CisgICAgbWVzc2FnZV9ldmVudC5pbml0TWVzc2FnZUV2 ZW50KCdtZXNzYWdlJywgIC8vIHR5cGUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgZmFsc2UsICAvLyBjYW5CdWJibGUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgZmFsc2UsICAvLyBjYW5jZWxhYmxlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGtQcmVmaXggKyBudW0udG9TdHJpbmcoKSwgIC8vIGRhdGEKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJycsICAvLyBvcmlnaW4gWypdCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICcnLCAgLy8gbGFzdEV2ZW50SWQKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgbnVsbCwgIC8vIHNvdXJjZSBbKl0KKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgW10pOyAgLy8gcG9ydHMKKyAgICB0YXJnZXQuZGlzcGF0Y2hFdmVudCht ZXNzYWdlX2V2ZW50KTsKK30KKworZnVuY3Rpb24gQWRkTGlzdGVuZXIoKSB7CisgICAgdmFyIHRh cmdldCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJldmVudF90YXJnZXQiKTsKKyAgICB0YXJn ZXQuYWRkRXZlbnRMaXN0ZW5lcigibWVzc2FnZSIsIEhhbmRsZU1lc3NhZ2UsIGZhbHNlKTsKKyAg ICBTZW5kU3RyaW5nKCk7Cit9Citkb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCJET01Db250ZW50 TG9hZGVkIiwgQWRkTGlzdGVuZXIsIGZhbHNlKTsKKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlcikgeworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICBs YXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cit9Citsb2coIkRPTkUiKTsKKwor PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXYgaWQ9ImV2ZW50X3RhcmdldCI+PC9kaXY+ Cis8L2JvZHk+Cis8L2h0bWw+Cg==