70979 2011-10-26 16:27:19 -0700 Overflow on flexitems doesn't work 2012-01-12 10:51:28 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62048 1 ojan tony tony webkit.review.bot oldest_to_newest 491257 0 112614 ojan 2011-10-26 16:27:19 -0700 Created attachment 112614 testcase Specifically, it doesn't scroll. 534266 1 tony 2012-01-11 14:29:00 -0800 This seems to work for me now. I bet adding the layout in the stretch case fixed it. I'll add some tests for it. 534428 2 122133 tony 2012-01-11 17:07:38 -0800 Created attachment 122133 Patch 534531 3 122133 webkit.review.bot 2012-01-11 19:55:52 -0800 Comment on attachment 122133 Patch Clearing flags on attachment: 122133 Committed r104785: <http://trac.webkit.org/changeset/104785> 534532 4 webkit.review.bot 2012-01-11 19:55:56 -0800 All reviewed patches have been landed. Closing bug. 534924 5 tony 2012-01-12 09:51:56 -0800 Hmm, turns out that we get the wrong behavior when we're not using flex-item-align: stretch. I'll debug some more. 534959 6 tony 2012-01-12 10:51:28 -0800 (In reply to comment #5) > Hmm, turns out that we get the wrong behavior when we're not using flex-item-align: stretch. I'll debug some more. Nevermind, it's working properly. The cross direction was auto on the div that have 'overflow: auto' so there was no overflow in the cross direction (in the case of stretch, we would shrink to match the flexbox size and scrollbars would appear). 112614 2011-10-26 16:27:19 -0700 2011-10-26 16:27:19 -0700 testcase scratch.html text/html 289 ojan PGRpdiBzdHlsZT0iYm9yZGVyOiA1cHggc29saWQgcGluazsgZGlzcGxheTogLXdlYmtpdC1mbGV4 Ym94OyBoZWlnaHQ6IDEwMHB4Ij4KICAgIDxkaXYgc3R5bGU9ImJvcmRlcjogNXB4IHNvbGlkIGxp Z2h0Z3JlZW47IHdpZHRoOiAtd2Via2l0LWZsZXgoMSk7IG92ZXJmbG93OiBzY3JvbGw7Ij4KICAg ICAgICBUaGlzIGJveCBzaG91bGQgc2Nyb2xsLgogICAgICAgIDxkaXYgc3R5bGU9ImJvcmRlcjog NXB4IHNvbGlkIGxpZ2h0Ymx1ZTsgaGVpZ2h0OiAzMDBweCI+PC9kaXY+CiAgICA8L2Rpdj4KPC9k aXY+Cg== 122133 2012-01-11 17:07:38 -0800 2012-01-11 19:55:52 -0800 Patch bug-70979-20120111170810.patch text/plain 4593 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NzIxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTkxOTZhOTc1ZGUzYmFjM2VlOGVk MWNjMDYyNTVlNjg4MDczMmE1Ny4uNjVlZDNjZDg3NjMxZGMwNTQxNTA4MTI0MWFhN2Y2Y2YxYmY1 ZmZhZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTExICBUb255IENoYW5nICA8dG9u eUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgT3ZlcmZsb3cgb24gZmxleGl0ZW1zIGRvZXNuJ3Qg d29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA5 NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQg dGVzdCBjYXNlcyBmb3IgZmxleCBpdGVtcyB0aGF0IG92ZXJmbG93LiBUaGVyZSBzaG91bGQgYmUK KyAgICAgICAgbm9uLWRpc2FibGVkIHNjcm9sbGJhcnMuCisKKyAgICAgICAgKiBjc3MzL2ZsZXhi b3gvY2hpbGQtb3ZlcmZsb3ctZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogY3NzMy9m bGV4Ym94L2NoaWxkLW92ZXJmbG93Lmh0bWw6IEFkZGVkLgorCiAyMDEyLTAxLTExICBKb2VsIFdl YmJlciAgPGpnd0Bnb29nbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBzZXRDdXJyZW50VGlt ZSgpIGFuZCBwYXVzZUFuaW1hdGlvbnMoKSBvbiBTVkdTVkdFbGVtZW50CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvY2hpbGQtb3ZlcmZsb3ctZXhwZWN0ZWQuaHRtbCBiL0xh eW91dFRlc3RzL2NzczMvZmxleGJveC9jaGlsZC1vdmVyZmxvdy1leHBlY3RlZC5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjhkMDBiOGEyNTViZTA1MTY2NTI2ZWFlY2Y5ODJkMjE1MzZhOWRkMzMKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvY2hpbGQtb3ZlcmZsb3ctZXhwZWN0 ZWQuaHRtbApAQCAtMCwwICsxLDUxIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+ Cis8c3R5bGU+CisuY29udGFpbmVyIHsKKyAgICBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7CisgICAg bWFyZ2luLXJpZ2h0OiA1cHg7Cit9CisKKy5jb250YWluZXIgPiBkaXYgeworICAgIGJvcmRlcjog NXB4IHNvbGlkIHBpbms7CisgICAgb3ZlcmZsb3c6IGF1dG87CisgICAgaGVpZ2h0OiAxMDBweDsK KyAgICB3aWR0aDogMTAwcHg7Cit9CisKKy5jb250YWluZXIgPiBkaXYgPiBkaXYgeworICAgIHdp ZHRoOiAxMjBweDsKKyAgICBoZWlnaHQ6IDEyMHB4OworICAgIGJhY2tncm91bmQ6IC13ZWJraXQt cmFkaWFsLWdyYWRpZW50KGNlbnRlciwgZWxsaXBzZSBjb3ZlciwgcmdiYSgzMCw4NywxNTMsMSkg MCUscmdiYSg4OSwxNDgsMjAyLDEpIDYyJSxyZ2JhKDk1LDE1NCwyMDcsMC43KSA2OCUscmdiYSgx MjUsMTg1LDIzMiwwKSAxMDAlKTsKK30KKzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgICA8 cD5TY3JvbGxiYXJzIHNob3VsZCB3b3JrIGluIGFsbCB0aGUgZmxleGJveGVzIGFuZCBlYWNoIHJv dyBzaG91bGQgc2hvdyBmb3VyIGlkZW50aWNhbCBib3hlcy48L3A+Cis8L2JvZHk+Cis8c2NyaXB0 PgordmFyIG9yaWdpbnMgPSBbJycsICdib3R0b21MZWZ0JywgJ3RvcFJpZ2h0JywgJyddOworCitv cmlnaW5zLmZvckVhY2goZnVuY3Rpb24ob3JpZ2luKSB7CisgICAgZm9yICh2YXIgaSA9IDA7IGkg PCA0OyArK2kpIHsKKyAgICAgICAgdmFyIGNvbnRhaW5lckNsYXNzID0gJ2NvbnRhaW5lciAnICsg b3JpZ2luOworICAgICAgICBkb2N1bWVudC5ib2R5LmlubmVySFRNTCArPQorICAgICAgICAgICAg IjxkaXYgY2xhc3M9JyIgKyBjb250YWluZXJDbGFzcyArICInPiIgKworICAgICAgICAgICAgIjxk aXY+PGRpdj48L2Rpdj48L2Rpdj4iICsKKyAgICAgICAgICAgICI8L2Rpdj4iOworICAgIH0KKyAg ICBkb2N1bWVudC5ib2R5LmlubmVySFRNTCArPSAiPGJyPiI7Cit9KTsKKworQXJyYXkucHJvdG90 eXBlLmZvckVhY2guY2FsbChkb2N1bWVudC5xdWVyeVNlbGVjdG9yQWxsKCcuYm90dG9tTGVmdCcp LCBmdW5jdGlvbihlbGVtZW50KSB7CisgICAgZWxlbWVudC5maXJzdENoaWxkLnNjcm9sbFRvcCA9 IDEwMDA7Cit9KTsKKworQXJyYXkucHJvdG90eXBlLmZvckVhY2guY2FsbChkb2N1bWVudC5xdWVy eVNlbGVjdG9yQWxsKCcudG9wUmlnaHQnKSwgZnVuY3Rpb24oZWxlbWVudCkgeworICAgIGVsZW1l bnQuZmlyc3RDaGlsZC5zY3JvbGxMZWZ0ID0gMTAwMDsKK30pOworCis8L3NjcmlwdD4KKzwvYm9k eT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9jaGlsZC1v dmVyZmxvdy5odG1sIGIvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L2NoaWxkLW92ZXJmbG93Lmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uZjcwMTMxOThkN2M1YjgzMzY2MGIyMmEyODA4ZDM1ZjczODEwMDkwZgot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9jaGlsZC1vdmVyZmxv dy5odG1sCkBAIC0wLDAgKzEsODIgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4K KzxzdHlsZT4KKy5jb250YWluZXIgeworICAgIGRpc3BsYXk6IGlubGluZS1ibG9jazsKKyAgICBt YXJnaW4tcmlnaHQ6IDVweDsKK30KKworLmhvcml6b250YWwtdGIgeworICAgIC13ZWJraXQtd3Jp dGluZy1tb2RlOiBob3Jpem9udGFsLXRiOworfQorCisuaG9yaXpvbnRhbC1idCB7CisgICAgLXdl YmtpdC13cml0aW5nLW1vZGU6IGhvcml6b250YWwtYnQ7Cit9CisKKy52ZXJ0aWNhbC1ybCB7Cisg ICAgLXdlYmtpdC13cml0aW5nLW1vZGU6IHZlcnRpY2FsLXJsOworfQorCisudmVydGljYWwtbHIg eworICAgIC13ZWJraXQtd3JpdGluZy1tb2RlOiB2ZXJ0aWNhbC1scjsKK30KKworLnJvdyB7Cisg ICAgLXdlYmtpdC1mbGV4LWRpcmVjdGlvbjogcm93OworfQorCisucm93LXJldmVyc2UgeworICAg IC13ZWJraXQtZmxleC1kaXJlY3Rpb246IHJvdy1yZXZlcnNlOworfQorCisuY29sdW1uIHsKKyAg ICAtd2Via2l0LWZsZXgtZGlyZWN0aW9uOiBjb2x1bW47Cit9CisKKy5jb2x1bW4tcmV2ZXJzZSB7 CisgICAgLXdlYmtpdC1mbGV4LWRpcmVjdGlvbjogY29sdW1uLXJldmVyc2U7Cit9CisKKy5mbGV4 Ym94IHsKKyAgICBib3JkZXI6IDVweCBzb2xpZCBwaW5rOworICAgIGRpc3BsYXk6IC13ZWJraXQt ZmxleGJveDsKKyAgICBoZWlnaHQ6IDEwMHB4OworICAgIHdpZHRoOiAxMDBweDsKK30KKworLmZs ZXhib3ggPiBkaXYgeworICAgIG92ZXJmbG93OiBhdXRvOworfQorCisuZmxleGJveCA+IGRpdiA+ IGRpdiB7CisgICAgd2lkdGg6IDEyMHB4OworICAgIGhlaWdodDogMTIwcHg7CisgICAgYmFja2dy b3VuZDogLXdlYmtpdC1yYWRpYWwtZ3JhZGllbnQoY2VudGVyLCBlbGxpcHNlIGNvdmVyLCByZ2Jh KDMwLDg3LDE1MywxKSAwJSxyZ2JhKDg5LDE0OCwyMDIsMSkgNjIlLHJnYmEoOTUsMTU0LDIwNyww LjcpIDY4JSxyZ2JhKDEyNSwxODUsMjMyLDApIDEwMCUpOworfQorPC9zdHlsZT4KKzwvaGVhZD4K Kzxib2R5PgorICAgIDxwPlNjcm9sbGJhcnMgc2hvdWxkIHdvcmsgaW4gYWxsIHRoZSBmbGV4Ym94 ZXMgYW5kIGVhY2ggcm93IHNob3VsZCBzaG93IGZvdXIgaWRlbnRpY2FsIGJveGVzLjwvcD4KKzwv Ym9keT4KKzxzY3JpcHQ+Cit2YXIgd3JpdGluZ01vZGVzID0gWydob3Jpem9udGFsLXRiJywgJ2hv cml6b250YWwtYnQnLCAndmVydGljYWwtcmwnLCAndmVydGljYWwtbHInXTsKK3ZhciBmbGV4RGly ZWN0aW9ucyA9IFsncm93JywgJ2NvbHVtbicsICdyb3ctcmV2ZXJzZScsICdjb2x1bW4tcmV2ZXJz ZSddOword3JpdGluZ01vZGVzLmZvckVhY2goZnVuY3Rpb24od3JpdGluZ01vZGUpIHsKKyAgICBm bGV4RGlyZWN0aW9ucy5mb3JFYWNoKGZ1bmN0aW9uKGZsZXhEaXJlY3Rpb24pIHsKKyAgICAgICAg dmFyIGNvbnRhaW5lckNsYXNzID0gJ2NvbnRhaW5lciAnICsgd3JpdGluZ01vZGU7CisgICAgICAg IHZhciBmbGV4Ym94Q2xhc3MgPSAnZmxleGJveCAnICsgZmxleERpcmVjdGlvbjsKKyAgICAgICAg ZG9jdW1lbnQuYm9keS5pbm5lckhUTUwgKz0KKyAgICAgICAgICAgICI8ZGl2IGNsYXNzPSciICsg Y29udGFpbmVyQ2xhc3MgKyAiJz4iICsKKyAgICAgICAgICAgICI8ZGl2IGNsYXNzPSciICsgZmxl eGJveENsYXNzICsgIic+IiArCisgICAgICAgICAgICAiPGRpdiBzdHlsZT0nd2lkdGg6IC13ZWJr aXQtZmxleCgwIDEgYXV0byk7IGhlaWdodDogLXdlYmtpdC1mbGV4KDAgMSBhdXRvKSc+PGRpdj48 L2Rpdj48L2Rpdj4iICsKKyAgICAgICAgICAgICI8L2Rpdj4iICsKKyAgICAgICAgICAgICI8L2Rp dj4iOworICAgIH0pOworICAgIGRvY3VtZW50LmJvZHkuaW5uZXJIVE1MICs9ICI8YnI+IjsKK30p OworCis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K