70776 2011-10-24 16:21:44 -0700 need tests with nested flexboxes 2012-01-09 16:03:22 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62048 1 ojan ojan tony oldest_to_newest 489762 0 ojan 2011-10-24 16:21:44 -0700 I'm sure we do things wrong. Specifically, nested flexboxes with orthogonal flows are almost certainly doing the wrong thing (see RenderFlexibleBox::hasOrthogonalFlow). 532586 1 121739 ojan 2012-01-09 15:49:23 -0800 Created attachment 121739 Patch 532602 2 ojan 2012-01-09 16:03:22 -0800 Committed r104504: <http://trac.webkit.org/changeset/104504> 121739 2012-01-09 15:49:23 -0800 2012-01-09 15:54:09 -0800 Patch bug-70776-20120109154922.patch text/plain 5656 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NDkxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWFmZTgzYzExMGE4NWNjYjMzYzYz ZTczMWVlMjgyN2FiYjAwNGZhMC4uYmFmNGZmYWFjYjkyODM4MTVlNThjNWVmMjBiODJkNTk5Mjkz OGI2NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAxLTA5ICBPamFuIFZhZmFpICA8b2ph bkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVGVzdHMgZm9yIG5lc3RlZCBmbGV4Ym94ZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNzc2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjc3MzL2ZsZXhi b3gvb3J0aG9nb25hbC1mbGV4LWRpcmVjdGlvbnMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBjc3MzL2ZsZXhib3gvb3J0aG9nb25hbC1mbGV4LWRpcmVjdGlvbnMuaHRtbDogQWRkZWQu CisKIDIwMTItMDEtMDkgIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgW0Nocm9taXVtXSBSZWJhc2VsaW5lIG1lZGlhL21lZGlhLWRvY3VtZW50LWF1ZGlvLXJl cGFpbnQuaHRtbCBmb3IgZ3B1IHRlc3RzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9m bGV4Ym94L29ydGhvZ29uYWwtZmxleC1kaXJlY3Rpb25zLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL2NzczMvZmxleGJveC9vcnRob2dvbmFsLWZsZXgtZGlyZWN0aW9ucy1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uY2EyY2RkNjhjOTQwYTY3NjBhYTRmNzc1MmM0ZWVhYzdmYTBiMzliNQotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9vcnRob2dvbmFsLWZsZXgt ZGlyZWN0aW9ucy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw3IEBACitQQVNTCitQQVNTCitQQVNT CitQQVNTCitQQVNTCitQQVNTCitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL2Zs ZXhib3gvb3J0aG9nb25hbC1mbGV4LWRpcmVjdGlvbnMuaHRtbCBiL0xheW91dFRlc3RzL2NzczMv ZmxleGJveC9vcnRob2dvbmFsLWZsZXgtZGlyZWN0aW9ucy5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmE0ZDNl YzBmM2FmMmFhMWNlMWY2M2U5YWU5NTU3NDg1NjQ4NDU2YWQKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvb3J0aG9nb25hbC1mbGV4LWRpcmVjdGlvbnMuaHRtbApA QCAtMCwwICsxLDEzMiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxzdHlsZT4KK2JvZHkg eworICAgIG1hcmdpbjogMDsKK30KKy5mbGV4Ym94IHsKKyAgICB3aWR0aDogNjAwcHg7CisgICAg ZGlzcGxheTogLXdlYmtpdC1mbGV4Ym94OworICAgIGJhY2tncm91bmQtY29sb3I6ICNhYWE7Cisg ICAgcG9zaXRpb246IHJlbGF0aXZlOworfQorLmZsZXhib3ggPiA6bnRoLWNoaWxkKDEpIHsKKyAg ICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOworfQorLmZsZXhib3ggPiA6bnRoLWNoaWxkKDIpIHsK KyAgICBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsKK30KKworLmZsZXhib3ggPiBkaXYgPiA6bnRo LWNoaWxkKDEpIHsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiBwaW5rOworfQorLmZsZXhib3ggPiBk aXYgPiA6bnRoLWNoaWxkKDIpIHsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiBwdXJwbGU7Cit9CisK Ky5mbGV4Ym94ID4gZGl2ID4gZGl2ID4gOm50aC1jaGlsZCgxKSB7CisgICAgYmFja2dyb3VuZC1j b2xvcjogcmVkOworfQorLmZsZXhib3ggPiBkaXYgPiBkaXYgPiA6bnRoLWNoaWxkKDIpIHsKKyAg ICBiYWNrZ3JvdW5kLWNvbG9yOiB5ZWxsb3c7Cit9CisKKy5uZXN0ZWQgeworICAgIGRpc3BsYXk6 IC13ZWJraXQtZmxleGJveDsgIAorICAgIGJhY2tncm91bmQtY29sb3I6ICNkZGQ7Cit9CisKKy5y dGwgeworICAgIGRpcmVjdGlvbjogcnRsOworfQorLmJ0IHsKKyAgICAtd2Via2l0LXdyaXRpbmct bW9kZTogaG9yaXpvbnRhbC1idDsKK30KKy52ZXJ0aWNhbC1ybCB7CisgICAgLXdlYmtpdC13cml0 aW5nLW1vZGU6IHZlcnRpY2FsLXJsOworfQorLnZlcnRpY2FsLWxyIHsKKyAgICAtd2Via2l0LXdy aXRpbmctbW9kZTogdmVydGljYWwtbHI7Cit9Cisucm93LXJldmVyc2UgeworICAgIC13ZWJraXQt ZmxleC1mbG93OiByb3ctcmV2ZXJzZTsKK30KKy5jb2x1bW4geworICAgIC13ZWJraXQtZmxleC1m bG93OiBjb2x1bW47Cit9CisuY29sdW1uLXJldmVyc2UgeworICAgIC13ZWJraXQtZmxleC1mbG93 OiBjb2x1bW4tcmV2ZXJzZTsKK30KKworLmFsaWduLXN0YXJ0IHsKKyAgICAtd2Via2l0LWZsZXgt YWxpZ246IHN0YXJ0OworfQorPC9zdHlsZT4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRl c3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKzwv c2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9mbGV4Ym94LmpzIj48L3NjcmlwdD4KKzxi b2R5IG9ubG9hZD0iY2hlY2tGbGV4Qm94ZW4oKSI+CisKKzxkaXYgY2xhc3M9ImZsZXhib3giPgor ICAgIDxkaXYgY2xhc3M9ImNvbHVtbiBuZXN0ZWQiPgorICAgICAgICA8ZGl2IGRhdGEtZXhwZWN0 ZWQtaGVpZ2h0PSI1MCIgc3R5bGU9ImhlaWdodDogLXdlYmtpdC1mbGV4KDEgMCAwKTsgd2lkdGg6 IDEwMHB4OyI+PC9kaXY+CisgICAgICAgIDxkaXYgZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjUwIiBz dHlsZT0iaGVpZ2h0OiAtd2Via2l0LWZsZXgoMSAwIDApOyB3aWR0aDogMTAwcHg7Ij48L2Rpdj4K KyAgICA8L2Rpdj4KKyAgICA8ZGl2IGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjUwMCIgc3R5bGU9Indp ZHRoOiAtd2Via2l0LWZsZXgoMSAwIDApOyBoZWlnaHQ6MTAwcHg7Ij48L2Rpdj4KKzwvZGl2Pgor Cis8ZGl2IGNsYXNzPSJmbGV4Ym94Ij4KKyAgICA8ZGl2IGNsYXNzPSJjb2x1bW4gbmVzdGVkIGFs aWduLXN0YXJ0Ij4KKyAgICAgICAgPGRpdiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iMCIgc3R5bGU9 ImhlaWdodDogLXdlYmtpdC1mbGV4KDEgMCAwKTsgd2lkdGg6IDEwMHB4OyI+PC9kaXY+CisgICAg ICAgIDxkaXYgZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjAiIHN0eWxlPSJoZWlnaHQ6IC13ZWJraXQt ZmxleCgxIDAgMCk7IHdpZHRoOiAxMDBweDsiPjwvZGl2PgorICAgIDwvZGl2PgorICAgIDxkaXYg ZGF0YS1leHBlY3RlZC13aWR0aD0iNTAwIiBzdHlsZT0id2lkdGg6IC13ZWJraXQtZmxleCgxIDAg MCk7IGhlaWdodDoxMDBweDsiPjwvZGl2PgorPC9kaXY+CisKKzxkaXYgY2xhc3M9ImZsZXhib3gi PgorICAgIDxkaXYgY2xhc3M9ImNvbHVtbiBuZXN0ZWQgYWxpZ24tc3RhcnQiIHN0eWxlPSJoZWln aHQ6IDUwcHgiPgorICAgICAgICA8ZGl2IGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSIyNSIgc3R5bGU9 ImhlaWdodDogLXdlYmtpdC1mbGV4KDEgMCAwKTsgd2lkdGg6IDEwMHB4OyI+PC9kaXY+CisgICAg ICAgIDxkaXYgZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjI1IiBzdHlsZT0iaGVpZ2h0OiAtd2Via2l0 LWZsZXgoMSAwIDApOyB3aWR0aDogMTAwcHg7Ij48L2Rpdj4KKyAgICA8L2Rpdj4KKyAgICA8ZGl2 IGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjUwMCIgc3R5bGU9IndpZHRoOiAtd2Via2l0LWZsZXgoMSAw IDApOyBoZWlnaHQ6MTAwcHg7Ij48L2Rpdj4KKzwvZGl2PgorCis8ZGl2IGNsYXNzPSJmbGV4Ym94 Ij4KKyAgICA8ZGl2IGNsYXNzPSJjb2x1bW4gbmVzdGVkIiBzdHlsZT0iaGVpZ2h0OiA1MHB4Ij4K KyAgICAgICAgPGRpdiBjbGFzcz0ibmVzdGVkIiBzdHlsZT0iaGVpZ2h0OiAtd2Via2l0LWZsZXgo MSk7IHdpZHRoOiAxMDBweDsiPgorICAgICAgICAgICAgPGRpdiBkYXRhLWV4cGVjdGVkLWhlaWdo dD0iMjUiIHN0eWxlPSJ3aWR0aDogLXdlYmtpdC1mbGV4KDEgMCBhdXRvKTsiPjwvZGl2PgorICAg ICAgICAgICAgPGRpdiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iMjUiIHN0eWxlPSJ3aWR0aDogLXdl YmtpdC1mbGV4KDEgMCBhdXRvKTsiPjwvZGl2PgorICAgICAgICA8L2Rpdj4KKyAgICAgICAgPGRp diBzdHlsZT0iaGVpZ2h0OiAtd2Via2l0LWZsZXgoMSk7Ij48L2Rpdj4KKyAgICA8L2Rpdj4KKyAg ICA8ZGl2IGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjUwMCIgc3R5bGU9IndpZHRoOiAtd2Via2l0LWZs ZXgoMSAwIDApOyBoZWlnaHQ6MTAwcHg7Ij48L2Rpdj4KKzwvZGl2PgorCis8ZGl2IGNsYXNzPSJm bGV4Ym94IGNvbHVtbiIgc3R5bGU9ImhlaWdodDogMTAwcHgiPgorICAgIDxkaXYgY2xhc3M9InJv dy1yZXZlcnNlIG5lc3RlZCIgc3R5bGU9ImhlaWdodDogLXdlYmtpdC1mbGV4KDEpOyB3aWR0aDog MTAwcHg7Ij4KKyAgICAgICAgPGRpdiBkYXRhLWV4cGVjdGVkLXdpZHRoPSI1MCIgc3R5bGU9Indp ZHRoOiAtd2Via2l0LWZsZXgoMSAwIGF1dG8pOyI+PC9kaXY+CisgICAgICAgIDxkaXYgZGF0YS1l eHBlY3RlZC13aWR0aD0iNTAiIHN0eWxlPSJ3aWR0aDogLXdlYmtpdC1mbGV4KDEgMCBhdXRvKTsi PjwvZGl2PgorICAgIDwvZGl2PgorICAgIDxkaXYgZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjUwIiBz dHlsZT0iaGVpZ2h0OiAtd2Via2l0LWZsZXgoMSAwIDApOyI+PC9kaXY+Cis8L2Rpdj4KKworPGRp diBjbGFzcz0iZmxleGJveCBjb2x1bW4tcmV2ZXJzZSIgc3R5bGU9ImhlaWdodDogMTAwcHgiPgor ICAgIDxkaXYgY2xhc3M9InJvdy1yZXZlcnNlIG5lc3RlZCIgc3R5bGU9ImhlaWdodDogLXdlYmtp dC1mbGV4KDEpOyB3aWR0aDogMTAwcHg7Ij4KKyAgICAgICAgPGRpdiBkYXRhLWV4cGVjdGVkLXdp ZHRoPSI1MCIgc3R5bGU9IndpZHRoOiAtd2Via2l0LWZsZXgoMSAwIGF1dG8pOyI+PC9kaXY+Cisg ICAgICAgIDxkaXYgZGF0YS1leHBlY3RlZC13aWR0aD0iNTAiIHN0eWxlPSJ3aWR0aDogLXdlYmtp dC1mbGV4KDEgMCBhdXRvKTsiPjwvZGl2PgorICAgIDwvZGl2PgorICAgIDxkaXYgZGF0YS1leHBl Y3RlZC1oZWlnaHQ9IjUwIiBzdHlsZT0iaGVpZ2h0OiAtd2Via2l0LWZsZXgoMSAwIDApOyI+PC9k aXY+Cis8L2Rpdj4KKworPGRpdiBjbGFzcz0iZmxleGJveCB2ZXJ0aWNhbC1sciIgc3R5bGU9Imhl aWdodDogMTAwcHgiPgorICAgIDxkaXYgY2xhc3M9ImNvbHVtbiBuZXN0ZWQiIHN0eWxlPSJoZWln aHQ6IC13ZWJraXQtZmxleCgxKTsgd2lkdGg6IDEwMHB4OyI+CisgICAgICAgIDxkaXYgZGF0YS1l eHBlY3RlZC13aWR0aD0iNTAiIHN0eWxlPSJ3aWR0aDogLXdlYmtpdC1mbGV4KDEgMCBhdXRvKTsi PjwvZGl2PgorICAgICAgICA8ZGl2IGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjUwIiBzdHlsZT0id2lk dGg6IC13ZWJraXQtZmxleCgxIDAgYXV0byk7Ij48L2Rpdj4KKyAgICA8L2Rpdj4KKyAgICA8ZGl2 IGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSI1MCIgc3R5bGU9ImhlaWdodDogLXdlYmtpdC1mbGV4KDEg MCAwKTsiPjwvZGl2PgorPC9kaXY+CisKKzwvYm9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0 IGVuZCBvZiBmaWxlCg==