70760 2011-10-24 13:57:59 -0700 Plugin tests are failing after switching WK2 to NRWT 2011-10-24 15:25:09 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric eric abarth dpranke ojan simon.fraser webkit.review.bot oldest_to_newest 489613 0 eric 2011-10-24 13:57:59 -0700 http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r98243%20(15595)/results.html Plugin tests are failing after switching WK2 to NRWT This is due to this FIXME in ORWT: # FIXME: We build both DumpRenderTree and WebKitTestRunner for # WebKitTestRunner runs becuase DumpRenderTree still includes # the DumpRenderTreeSupport module and the TestNetscapePlugin. # These two projects should be factored out into their own # projects. buildDumpTool("DumpRenderTree"); buildDumpTool("WebKitTestRunner") if $useWebKitTestRunner; I'll move that hack into build-webkitestrunner instead of ORWT. 489616 1 eric 2011-10-24 13:58:45 -0700 *** Bug 70759 has been marked as a duplicate of this bug. *** 489628 2 eric 2011-10-24 14:09:04 -0700 Actually, doing this in build-webkittestrunner turned out to be a pain. Bleh. 489629 3 112243 eric 2011-10-24 14:10:05 -0700 Created attachment 112243 Patch 489699 4 eric 2011-10-24 15:25:09 -0700 Committed r98288: <http://trac.webkit.org/changeset/98288> 112243 2011-10-24 14:10:05 -0700 2011-10-24 14:14:10 -0700 Patch bug-70760-20111024141003.patch text/plain 1844 eric U3VidmVyc2lvbiBSZXZpc2lvbjogOTgyNTMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1Yjk3M2RhNzIzOWY1OWE3YjJjNjQwMmViNDIxZGYzNDk0 NDNhMzBmLi5kZjU3NjJkMDkwOTcxZjExZGZmMDJhMGY0NDMyZGVkZDM1YTUxOWJhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMTAtMjQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IFBsdWdpbiB0ZXN0cyBhcmUgZmFpbGluZyBhZnRlciBzd2l0Y2hpbmcgV0syIHRvIE5SV1QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNzYwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGVycGV0dWF0ZSB0 aGlzIGhvcnJpYmxlIGhhY2suCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L3dlYmtpdC5weToKKwogMjAxMS0xMC0yNCAgQmFsYXpzIEtlbGVtZW4gIDxrYmFs YXpzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XVtXSzJdIENyYXNoIHdoZW4gcnVubmluZyBw aXhlbCB0ZXN0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC93ZWJraXQucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L3dlYmtpdC5weQppbmRleCBjNWRkZTVmZGQxOWZkMWUwYzljYjZjODBiZWM5ZmU0MWMxODE0 Y2QxLi4wOGU0M2IxOTc4MGJhNDQzZGRkY2RhYzk3YWQyNDUzNDczNGFmMThmIDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQpAQCAt MTEwLDggKzExMCwxNSBAQCBjbGFzcyBXZWJLaXRQb3J0KFBvcnQpOgogICAgICAgICByZXR1cm4g c2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21tYW5kKHJ1bl9zY3JpcHRfY29tbWFuZCwgY3dkPXNlbGYu X2NvbmZpZy53ZWJraXRfYmFzZV9kaXIoKSwgZGVjb2RlX291dHB1dD1kZWNvZGVfb3V0cHV0KQog CiAgICAgZGVmIF9idWlsZF9kcml2ZXIoc2VsZik6CisgICAgICAgICMgRklYTUU6IFdlIGJ1aWxk IGJvdGggRHVtcFJlbmRlclRyZWUgYW5kIFdlYktpdFRlc3RSdW5uZXIgZm9yCisgICAgICAgICMg V2ViS2l0VGVzdFJ1bm5lciBydW5zIGJlY2F1c2UgRHVtcFJlbmRlclRyZWUgc3RpbGwgaW5jbHVk ZXMKKyAgICAgICAgIyB0aGUgRHVtcFJlbmRlclRyZWVTdXBwb3J0IG1vZHVsZSBhbmQgdGhlIFRl c3ROZXRzY2FwZVBsdWdpbi4KKyAgICAgICAgIyBUaGVzZSB0d28gcHJvamVjdHMgc2hvdWxkIGJl IGZhY3RvcmVkIG91dCBpbnRvIHRoZWlyIG93bgorICAgICAgICAjIHByb2plY3RzLgogICAgICAg ICB0cnk6Ci0gICAgICAgICAgICBzZWxmLl9ydW5fc2NyaXB0KHNlbGYuX2RyaXZlcl9idWlsZF9z Y3JpcHRfbmFtZSgpKQorICAgICAgICAgICAgc2VsZi5fcnVuX3NjcmlwdCgiYnVpbGQtZHVtcHJl bmRlcnRyZWUiKQorICAgICAgICAgICAgaWYgc2VsZi5nZXRfb3B0aW9uKCd3ZWJraXRfdGVzdF9y dW5uZXInKToKKyAgICAgICAgICAgICAgICBzZWxmLl9ydW5fc2NyaXB0KCJidWlsZC13ZWJraXR0 ZXN0cnVubmVyIikKICAgICAgICAgZXhjZXB0IFNjcmlwdEVycm9yOgogICAgICAgICAgICAgX2xv Zy5lcnJvcigiRmFpbGVkIHRvIGJ1aWxkICVzIiAlIHNlbGYuZHJpdmVyX25hbWUoKSkKICAgICAg ICAgICAgIHJldHVybiBGYWxzZQo=