70680 2011-10-22 07:12:08 -0700 [WK2][GTK] Application cache directory is incorrectly set 2011-11-08 01:07:48 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 69523 0 zan webkit-unassigned mrobinson pnormand svillar webkit.review.bot oldest_to_newest 488931 0 zan 2011-10-22 07:12:08 -0700 In WebProcess::initializeWebProcess the appcache directory of the cache storage is set from the applicationCacheDirectory parameter that is set in WebContext::ensureProcess. Unluckily this parameter holds the return value of WebContext::applicationCacheDirectory() which returns the current cache directory of the cache storage. So it's basically setting an empty string as the directory, which is wrong. In WebKit1 the appcache directory is set to be the same as for the web databases - "g_get_user_data_dir()/webkit/databases". The same should be done in WebKit2. 488932 1 112089 zan 2011-10-22 07:17:37 -0700 Created attachment 112089 Patch 494588 2 pnormand 2011-11-02 06:43:00 -0700 Not sure why it's been done like this in WebKit1 but storing application cache data in a databases directory seems odd. Can we use a new directory for this? At least in WebKit2? 494684 3 mrobinson 2011-11-02 09:54:29 -0700 For reference Chromium stores this information for me at ~/.config/chromium/Default/Application Cache. 497000 4 zan 2011-11-06 23:57:19 -0800 (In reply to comment #3) > For reference Chromium stores this information for me at ~/.config/chromium/Default/Application Cache. I then propose for application cache directory path to be constructed this way: > g_build_filename(g_get_user_data_dir(), "webkit", "applicationcache", NULL); Once an agreement is made about which name to use, I'll upload a new patch. 497001 5 mrobinson 2011-11-07 00:00:24 -0800 (In reply to comment #4) > (In reply to comment #3) > > For reference Chromium stores this information for me at ~/.config/chromium/Default/Application Cache. > > I then propose for application cache directory path to be constructed this way: > > > g_build_filename(g_get_user_data_dir(), "webkit", "applicationcache", NULL); > > Once an agreement is made about which name to use, I'll upload a new patch. Shouldn't it be something like this? g_build_filename(g_get_user_cache_dir(), "webkitgtk", "applications", NULL); or g_build_filename(g_get_user_cache_dir(), "webkitgtk", "applicationcache", NULL); 497004 6 zan 2011-11-07 00:11:05 -0800 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > For reference Chromium stores this information for me at ~/.config/chromium/Default/Application Cache. > > > > I then propose for application cache directory path to be constructed this way: > > > > > g_build_filename(g_get_user_data_dir(), "webkit", "applicationcache", NULL); > > > > Once an agreement is made about which name to use, I'll upload a new patch. > > Shouldn't it be something like this? > > g_build_filename(g_get_user_cache_dir(), "webkitgtk", "applications", NULL); > > or > > g_build_filename(g_get_user_cache_dir(), "webkitgtk", "applicationcache", NULL); You're right, this sort of data should be put into user's cache directory. Regarding the name of bottom directory, I'd prefer 'applications' or perhaps nothing, simply putting cached data into ~/.cache/webkitgtk (if application cache is the only cached data). Repeating the word 'cache' in the path is not helpful. Just to note, this again shows just how wrong it is that WebKit1 puts appcache into database directory. If there's interest/need, I can open another bug. 497221 7 mrobinson 2011-11-07 09:05:37 -0800 (In reply to comment #6) > Just to note, this again shows just how wrong it is that WebKit1 puts appcache into database directory. If there's interest/need, I can open another bug. Yeah, I thnk we should fix both WebKit1 and WebKit2. The name of top-level directory should be "webkitgtk" too, since we no longer pretend to be the only game in town. 497761 8 113995 zan 2011-11-07 23:05:39 -0800 Created attachment 113995 Now the appcache directory most likely looks something like ~/.cache/webkitgtk/applications 497762 9 zan 2011-11-07 23:07:28 -0800 (In reply to comment #8) > Created an attachment (id=113995) [details] > Now the appcache directory most likely looks something like ~/.cache/webkitgtk/applications Sorry for the long name, mixed up flags when uploading through webkit-patch. 497795 10 113995 pnormand 2011-11-07 23:58:57 -0800 Comment on attachment 113995 Now the appcache directory most likely looks something like ~/.cache/webkitgtk/applications Thanks Zan! 497797 11 mrobinson 2011-11-08 00:05:48 -0800 (In reply to comment #10) > (From update of attachment 113995 [details]) > Thanks Zan! Zan do you mind also changing the WebKit2 database directory to relfect the new "webkitgtk" name? I don't think we can in WebKit1, because it's an API break. 497833 12 113995 webkit.review.bot 2011-11-08 01:07:44 -0800 Comment on attachment 113995 Now the appcache directory most likely looks something like ~/.cache/webkitgtk/applications Clearing flags on attachment: 113995 Committed r99537: <http://trac.webkit.org/changeset/99537> 497834 13 webkit.review.bot 2011-11-08 01:07:48 -0800 All reviewed patches have been landed. Closing bug. 112089 2011-10-22 07:17:37 -0700 2011-11-07 23:04:45 -0800 Patch bug-70680-20111022161735.patch text/plain 1501 zan U3VidmVyc2lvbiBSZXZpc2lvbjogOTgxOTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA5ZGRkNGFkY2VmN2I4MTRi MzY3OGRkODVkYjhlNWMwMjBkOTA2YjQzLi4zZGIxMDAzMGUyNGQzNGI5Mjg4YjA2NDI1ZDhhOGNl NjI5M2ZhNTE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMjIgIFphbiBE b2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KKworICAgICAgICBbV0syXVtHVEtdIEFw cGxpY2F0aW9uIGNhY2hlIGRpcmVjdG9yeSBpcyBpbmNvcnJlY3RseSBzZXQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNjgwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXMgaW4gV2ViS2l0MSwgZGF0YWJh c2UgZGlyZWN0b3J5IHNob3VsZCBiZSB1c2VkIGFzIHRoZQorICAgICAgICBhcHBsaWNhdGlvbiBj YWNoZSBkaXJlY3RvcnkgYXMgd2VsbC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvV2ViQ29u dGV4dEd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OmFwcGxpY2F0aW9uQ2Fj aGVEaXJlY3RvcnkpOgorCiAyMDExLTEwLTIxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBw bGUuY29tPgogCiAgICAgICAgIFtXSzJdIENsaWNraW5nIGEgcHJpbnQgYnV0dG9uIGluIGEgUERG IGRvZXNuJ3QgZG8gYW55dGhpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9ndGsvV2ViQ29udGV4dEd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dl YkNvbnRleHRHdGsuY3BwCmluZGV4IDc1ZjEzNWYwN2RiZmQwMDlkZDEyNGEwYTY1NzBmMDg0Zjc3 YWQ3YjguLjIxOTA4NDAzZWE5M2JjMDI4ZDJmYWRmZjQwZjM4OTJlODcxMzExYTQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViQ29udGV4dEd0ay5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJDb250ZXh0R3RrLmNwcApAQCAtMjcsMTMg KzI3LDExIEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiV2ViQ29udGV4dC5oIgog Ci0jaW5jbHVkZSAiQXBwbGljYXRpb25DYWNoZVN0b3JhZ2UuaCIKLQogbmFtZXNwYWNlIFdlYktp dCB7CiAKIFdURjo6U3RyaW5nIFdlYkNvbnRleHQ6OmFwcGxpY2F0aW9uQ2FjaGVEaXJlY3Rvcnko KQogewotICAgIHJldHVybiBXZWJDb3JlOjpjYWNoZVN0b3JhZ2UoKS5jYWNoZURpcmVjdG9yeSgp OworICAgIHJldHVybiBwbGF0Zm9ybURlZmF1bHREYXRhYmFzZURpcmVjdG9yeSgpOwogfQogCiB2 b2lkIFdlYkNvbnRleHQ6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MoV2ViUHJvY2Vzc0Ny ZWF0aW9uUGFyYW1ldGVycyYpCg== 113995 2011-11-07 23:05:39 -0800 2011-11-08 01:07:44 -0800 Now the appcache directory most likely looks something like ~/.cache/webkitgtk/applications bug-70680-20111108080538.patch text/plain 1623 zan U3VidmVyc2lvbiBSZXZpc2lvbjogOTk1MjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA1YWQ1ZjRmODU5MWU1YWIz Y2ZhZjBhZjA1MmM5MDNlMzBmMzJiOTZjLi4yYTdkMjU3NGU1ZGE3ZmFkNTRiMThkMzMxYWEwODA2 ODE2ZTJkMTU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMDcgIFphbiBE b2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KKworICAgICAgICBbV0syXVtHVEtdIEFw cGxpY2F0aW9uIGNhY2hlIGRpcmVjdG9yeSBpcyBpbmNvcnJlY3RseSBzZXQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNjgwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29ycmVjdGx5IHNldCBhcHBsaWNh dGlvbiBjYWNoZSBkaXJlY3RvcnkgdG8gYmUgaW4gY3VycmVudAorICAgICAgICB1c2VyJ3MgZGVm YXVsdCBjYWNoZSBkaXJlY3RvcnkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL1dlYkNvbnRl eHRHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0OjphcHBsaWNhdGlvbkNhY2hl RGlyZWN0b3J5KToKKwogMjAxMS0xMS0wNyAgRW1pbCBBIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2ZXJ0IHBsYXRmb3JtIGFuZCBzY3JvbGxpbmcgdG8gaW50cwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJDb250ZXh0R3RrLmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViQ29udGV4dEd0ay5jcHAKaW5kZXggZDc0 OTBhYzRjMDE2YmE2ZDU5MGU4MDhmODFmM2E1YmM2OWEyMzE4MS4uM2IwMzRhNjgyOWM5MGQ2YTc3 ZjI2ZjdkNGQ0MjU3YTAxZGExNDYxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL2d0ay9XZWJDb250ZXh0R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv Z3RrL1dlYkNvbnRleHRHdGsuY3BwCkBAIC0yOSwxMyArMjksMTIgQEAKICNpbmNsdWRlIDxXZWJD b3JlL0ZpbGVTeXN0ZW0uaD4KICNpbmNsdWRlIDx3dGYvZ29iamVjdC9HT3duUHRyLmg+CiAKLSNp bmNsdWRlICJBcHBsaWNhdGlvbkNhY2hlU3RvcmFnZS5oIgotCiBuYW1lc3BhY2UgV2ViS2l0IHsK IAogV1RGOjpTdHJpbmcgV2ViQ29udGV4dDo6YXBwbGljYXRpb25DYWNoZURpcmVjdG9yeSgpCiB7 Ci0gICAgcmV0dXJuIFdlYkNvcmU6OmNhY2hlU3RvcmFnZSgpLmNhY2hlRGlyZWN0b3J5KCk7Cisg ICAgR093blB0cjxnY2hhcj4gY2FjaGVEaXJlY3RvcnkoZ19idWlsZF9maWxlbmFtZShnX2dldF91 c2VyX2NhY2hlX2RpcigpLCAid2Via2l0Z3RrIiwgImFwcGxpY2F0aW9ucyIsIE5VTEwpKTsKKyAg ICByZXR1cm4gV2ViQ29yZTo6ZmlsZW5hbWVUb1N0cmluZyhjYWNoZURpcmVjdG9yeS5nZXQoKSk7 CiB9CiAKIHZvaWQgV2ViQ29udGV4dDo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2VzcyhXZWJQ cm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJikK