70614 2011-10-21 09:39:26 -0700 [Chromium] Expose deviceScaleFactor to WebKit API 2011-11-04 10:10:16 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 70559 1 fsamuel fsamuel fishd rjkroege webkit.review.bot oldest_to_newest 488440 0 fsamuel 2011-10-21 09:39:26 -0700 Fairly straightforward. One of the many small pieces that needs to fall into place to implement viewport meta tag in Chromium. 495520 1 fsamuel 2011-11-03 09:19:01 -0700 deviceScaleFactor is the same value as window.devicePixelRatio. This ratio is also determined by computeViewportAttributes (deviceDPI / targetDensityDPI). So the correct application of deviceScaleFactor is as follows: 1. Once the viewport attributes are computed, we call back into the renderer (render_view_impl.cc). The devicePixelratio is passed into the renderer. 2. The renderer sets WebKit's deviceScaleFactor along with the PageScaleFactor. 495848 2 113569 fsamuel 2011-11-03 16:17:33 -0700 Created attachment 113569 Patch 495855 3 webkit.review.bot 2011-11-03 16:21:50 -0700 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 496057 4 113569 fishd 2011-11-03 22:41:33 -0700 Comment on attachment 113569 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113569&action=review > Source/WebKit/chromium/public/WebView.h:219 > + // Used by the viewport tag. The ratio of the current device's screen DPI to the target nit: comments like "Used by the viewport tag" could pretty quickly become stale. if someone else starts using the deviceScaleFactor information for something else, then they would most likely not think to update this comment. as this is API comments, it probably doesn't matter to the embedder how this field will be used. instead, they just need to know what the field means and what they may set its value to be. recommendation: leave out the "Used by the viewport tag" bit. 496257 5 113672 fsamuel 2011-11-04 10:07:51 -0700 Created attachment 113672 Patch 496258 6 113672 fsamuel 2011-11-04 10:10:11 -0700 Comment on attachment 113672 Patch Clearing flags on attachment: 113672 Committed r99291: <http://trac.webkit.org/changeset/99291> 496259 7 fsamuel 2011-11-04 10:10:16 -0700 All reviewed patches have been landed. Closing bug. 113569 2011-11-03 16:17:33 -0700 2011-11-04 10:07:46 -0700 Patch bug-70614-20111103191732.patch text/plain 3553 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogOTkyMzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MGZhZDE1YTNlMzYxMzY3YTdjNjc0MDhjNmJjYjAyMDEwMjIwOTEyZS4uYmM4OGZiOThhNDI0MGU1 ZGQ2OGZhNGU4NmQxYWQ4MjQyNTkzYWY3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyNSBAQAorMjAxMS0xMS0wMyAgRmFkeSBTYW11ZWwgIDxmc2FtdWVsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEV4cG9zZSBkZXZpY2VTY2FsZUZhY3RvciB0byBX ZWJLaXQgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MDYxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoaXMgZXhwb3NlcyB0aGUgZGV2aWNlIHNjYWxlIGZhY3RvciB0byB0aGUgQ2hyb21pdW0tV2Vi S2l0IEFQSS4KKyAgICAgICAgVGhpcyBzY2FsZSBmYWN0b3IgaXMgdGhlIHJhdGlvIGJldHdlZW4g dGhlIGN1cnJlbnQgZGV2aWNlJ3MgRFBJCisgICAgICAgIGFuZCB0aGUgdGFyZ2V0IGRldmljZSdz IERQSS4gCisKKyAgICAgICAgRm9yIGRldGFpbHMgb24gaG93IHRoaXMgY2FuIGJlIGFjY2Vzc2Vk IGZyb20gQ1NTIGFuZCBqYXZhc2NyaXB0LCBwbGVhc2UKKyAgICAgICAgc2VlIGhlcmU6CisKKyAg ICAgICAgaHR0cDovL2RldmVsb3Blci5hbmRyb2lkLmNvbS9ndWlkZS93ZWJhcHBzL3RhcmdldGlu Zy5odG1sI0RlbnNpdHlDU1MKKworICAgICAgICAqIHB1YmxpYy9XZWJWaWV3Lmg6CisgICAgICAg ICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OmRl dmljZVNjYWxlRmFjdG9yKToKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnNldERldmlj ZVNjYWxlRmFjdG9yKToKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuaDoKKwogMjAxMS0xMS0w MyAgRGFuaWVsIENoZW5nICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21p dW1dIFJlbW92ZSB1bnVzZWQgY2xpcGJvYXJkIG1ldGhvZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYlZpZXcuaAppbmRleCA3NWUwYmIwMzQzZTg2Mzg0YjNjNDMwOWZhNjRlZGFlZGNi MTlmNTk2Li4xNzU4ODRjYmRjOGZmYjhkNGM1YThlMDRmN2JmNjg3MGJhNDViODQzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oCkBAIC0yMTYsNiArMjE2LDEzIEBAIHB1 YmxpYzoKICAgICAvLyBPbiB0aGUgb3RoZXIgaGFuZCwgem9vbWluZyBhZmZlY3RzIGxheW91dCBv ZiB0aGUgcGFnZS4KICAgICB2aXJ0dWFsIHZvaWQgc2NhbGVQYWdlKGZsb2F0IHNjYWxlRmFjdG9y LCBXZWJQb2ludCBvcmlnaW4pID0gMDsKIAorICAgIC8vIFVzZWQgYnkgdGhlIHZpZXdwb3J0IHRh Zy4gVGhlIHJhdGlvIG9mIHRoZSBjdXJyZW50IGRldmljZSdzIHNjcmVlbiBEUEkgdG8gdGhlIHRh cmdldAorICAgIC8vIGRldmljZSdzIHNjcmVlbiBEUEkuCisgICAgdmlydHVhbCBmbG9hdCBkZXZp Y2VTY2FsZUZhY3RvcigpIGNvbnN0ID0gMDsKKworICAgIC8vIFVzZWQgYnkgdGhlIHZpZXdwb3J0 IHRhZy4gU2V0cyB0aGUgcmF0aW8gYXMgY29tcHV0ZWQgYnkgY29tcHV0ZVZpZXdwb3J0QXR0cmli dXRlcy4KKyAgICB2aXJ0dWFsIHZvaWQgc2V0RGV2aWNlU2NhbGVGYWN0b3IoZmxvYXQpID0gMDsK KwogCiAgICAgLy8gRml4ZWQgTGF5b3V0IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlZpZXdJbXBsLmNwcAppbmRleCA0OGZiM2UwYTk4ZjNhYjJhYzE1NDE1YjA1NzVlZmFhMzA0MDBh MDgzLi44M2NmZjgzNzViMmE0ZmExYmZjYzdlZDI3MjgxNDE1MGQ4OTJjM2NlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCkBAIC0xODUzLDYgKzE4NTMsMjIg QEAgdm9pZCBXZWJWaWV3SW1wbDo6c2NhbGVQYWdlKGZsb2F0IHNjYWxlRmFjdG9yLCBXZWJQb2lu dCBvcmlnaW4pCiAgICAgcGFnZSgpLT5zZXRQYWdlU2NhbGVGYWN0b3Ioc2NhbGVGYWN0b3IsIG9y aWdpbik7CiB9CiAKK2Zsb2F0IFdlYlZpZXdJbXBsOjpkZXZpY2VTY2FsZUZhY3RvcigpIGNvbnN0 Cit7CisgICAgaWYgKCFwYWdlKCkpCisgICAgICAgIHJldHVybiAxOworCisgICAgcmV0dXJuIHBh Z2UoKS0+ZGV2aWNlU2NhbGVGYWN0b3IoKTsKK30KKwordm9pZCBXZWJWaWV3SW1wbDo6c2V0RGV2 aWNlU2NhbGVGYWN0b3IoZmxvYXQgc2NhbGVGYWN0b3IpCit7CisgICAgaWYgKCFwYWdlKCkpCisg ICAgICAgIHJldHVybjsKKworICAgIHBhZ2UoKS0+c2V0RGV2aWNlU2NhbGVGYWN0b3Ioc2NhbGVG YWN0b3IpOworfQorCiBib29sIFdlYlZpZXdJbXBsOjppc0ZpeGVkTGF5b3V0TW9kZUVuYWJsZWQo KSBjb25zdAogewogICAgIGlmICghcGFnZSgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlZpZXdJbXBsLmgKaW5kZXggOTkxMWE1ZjhhYzBlZGI5ODkzMThlYWMxMTJhMjVlNTcwZDY5ZTFi Zi4uYTlkMDA0MjZlNjhmYmIwN2RiMDhkNzA4ODJmZDIzMDhjMDljNDYyNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCkBAIC0xNTksNiArMTU5LDggQEAgcHVibGlj OgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb3VibGUgbWF4aW11bVpvb21M ZXZlbCk7CiAgICAgdmlydHVhbCBmbG9hdCBwYWdlU2NhbGVGYWN0b3IoKSBjb25zdDsKICAgICB2 aXJ0dWFsIHZvaWQgc2NhbGVQYWdlKGZsb2F0IHNjYWxlRmFjdG9yLCBXZWJQb2ludCBvcmlnaW4p OworICAgIHZpcnR1YWwgZmxvYXQgZGV2aWNlU2NhbGVGYWN0b3IoKSBjb25zdDsKKyAgICB2aXJ0 dWFsIHZvaWQgc2V0RGV2aWNlU2NhbGVGYWN0b3IoZmxvYXQpOwogICAgIHZpcnR1YWwgYm9vbCBp c0ZpeGVkTGF5b3V0TW9kZUVuYWJsZWQoKSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQgZW5hYmxl Rml4ZWRMYXlvdXRNb2RlKGJvb2wgZW5hYmxlKTsKICAgICB2aXJ0dWFsIFdlYlNpemUgZml4ZWRM YXlvdXRTaXplKCkgY29uc3Q7Cg== 113672 2011-11-04 10:07:51 -0700 2011-11-04 10:10:11 -0700 Patch bug-70614-20111104130749.patch text/plain 3529 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogOTkyODQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MWQ4OTc3MzQ3NDNjMGIyZDQ0ZTAyMGUxYmJlNTFmYWU1ODA3ZGEzYS4uM2U2MTU2ZjM3YWI0YWZh YjZmYTE5NjIxZGMyMzk1NzIyMzE4NmQ1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyNSBAQAorMjAxMS0xMS0wNCAgRmFkeSBTYW11ZWwgIDxmc2FtdWVsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEV4cG9zZSBkZXZpY2VTY2FsZUZhY3RvciB0byBX ZWJLaXQgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MDYxNAorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KKworICAgICAgICBU aGlzIGV4cG9zZXMgdGhlIGRldmljZSBzY2FsZSBmYWN0b3IgdG8gdGhlIENocm9taXVtLVdlYktp dCBBUEkuCisgICAgICAgIFRoaXMgc2NhbGUgZmFjdG9yIGlzIHRoZSByYXRpbyBiZXR3ZWVuIHRo ZSBjdXJyZW50IGRldmljZSdzIERQSQorICAgICAgICBhbmQgdGhlIHRhcmdldCBkZXZpY2UncyBE UEkuIAorCisgICAgICAgIEZvciBkZXRhaWxzIG9uIGhvdyB0aGlzIGNhbiBiZSBhY2Nlc3NlZCBm cm9tIENTUyBhbmQgamF2YXNjcmlwdCwgcGxlYXNlCisgICAgICAgIHNlZSBoZXJlOgorCisgICAg ICAgIGh0dHA6Ly9kZXZlbG9wZXIuYW5kcm9pZC5jb20vZ3VpZGUvd2ViYXBwcy90YXJnZXRpbmcu aHRtbCNEZW5zaXR5Q1NTCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVmlldy5oOgorICAgICAgICAq IHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpkZXZp Y2VTY2FsZUZhY3Rvcik6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpzZXREZXZpY2VT Y2FsZUZhY3Rvcik6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmg6CisKIDIwMTEtMTEtMDIg IFhpYW9tZWkgSmkgIDx4amlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEVuYWJsZSBjdHJsLWFy cm93IG1vdmUgY3Vyc29yIGJ5IHdvcmQgaW4gdmlzdWFsIG9yZGVyIGluIGNyLXdpbiBieSBjb21t YW5kIGxpbmUgZmxhZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYlZpZXcuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaAppbmRl eCA3NWUwYmIwMzQzZTg2Mzg0YjNjNDMwOWZhNjRlZGFlZGNiMTlmNTk2Li4xY2M0ZmQxZjJmMzk1 NjhlYmU4YzNhYmFlZWRmYjM1OWE4YTliYzIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJWaWV3LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViVmlldy5oCkBAIC0yMTYsNiArMjE2LDEyIEBAIHB1YmxpYzoKICAgICAvLyBPbiB0aGUg b3RoZXIgaGFuZCwgem9vbWluZyBhZmZlY3RzIGxheW91dCBvZiB0aGUgcGFnZS4KICAgICB2aXJ0 dWFsIHZvaWQgc2NhbGVQYWdlKGZsb2F0IHNjYWxlRmFjdG9yLCBXZWJQb2ludCBvcmlnaW4pID0g MDsKIAorICAgIC8vIFRoZSByYXRpbyBvZiB0aGUgY3VycmVudCBkZXZpY2UncyBzY3JlZW4gRFBJ IHRvIHRoZSB0YXJnZXQgZGV2aWNlJ3Mgc2NyZWVuIERQSS4KKyAgICB2aXJ0dWFsIGZsb2F0IGRl dmljZVNjYWxlRmFjdG9yKCkgY29uc3QgPSAwOworCisgICAgLy8gU2V0cyB0aGUgcmF0aW8gYXMg Y29tcHV0ZWQgYnkgY29tcHV0ZVZpZXdwb3J0QXR0cmlidXRlcy4KKyAgICB2aXJ0dWFsIHZvaWQg c2V0RGV2aWNlU2NhbGVGYWN0b3IoZmxvYXQpID0gMDsKKwogCiAgICAgLy8gRml4ZWQgTGF5b3V0 IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNw cCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCA0OGZi M2UwYTk4ZjNhYjJhYzE1NDE1YjA1NzVlZmFhMzA0MDBhMDgzLi44M2NmZjgzNzViMmE0ZmExYmZj YzdlZDI3MjgxNDE1MGQ4OTJjM2NlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuY3BwCkBAIC0xODUzLDYgKzE4NTMsMjIgQEAgdm9pZCBXZWJWaWV3SW1wbDo6c2Nh bGVQYWdlKGZsb2F0IHNjYWxlRmFjdG9yLCBXZWJQb2ludCBvcmlnaW4pCiAgICAgcGFnZSgpLT5z ZXRQYWdlU2NhbGVGYWN0b3Ioc2NhbGVGYWN0b3IsIG9yaWdpbik7CiB9CiAKK2Zsb2F0IFdlYlZp ZXdJbXBsOjpkZXZpY2VTY2FsZUZhY3RvcigpIGNvbnN0Cit7CisgICAgaWYgKCFwYWdlKCkpCisg ICAgICAgIHJldHVybiAxOworCisgICAgcmV0dXJuIHBhZ2UoKS0+ZGV2aWNlU2NhbGVGYWN0b3Io KTsKK30KKwordm9pZCBXZWJWaWV3SW1wbDo6c2V0RGV2aWNlU2NhbGVGYWN0b3IoZmxvYXQgc2Nh bGVGYWN0b3IpCit7CisgICAgaWYgKCFwYWdlKCkpCisgICAgICAgIHJldHVybjsKKworICAgIHBh Z2UoKS0+c2V0RGV2aWNlU2NhbGVGYWN0b3Ioc2NhbGVGYWN0b3IpOworfQorCiBib29sIFdlYlZp ZXdJbXBsOjppc0ZpeGVkTGF5b3V0TW9kZUVuYWJsZWQoKSBjb25zdAogewogICAgIGlmICghcGFn ZSgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwu aCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKaW5kZXggOTkxMWE1 ZjhhYzBlZGI5ODkzMThlYWMxMTJhMjVlNTcwZDY5ZTFiZi4uYTlkMDA0MjZlNjhmYmIwN2RiMDhk NzA4ODJmZDIzMDhjMDljNDYyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3 SW1wbC5oCkBAIC0xNTksNiArMTU5LDggQEAgcHVibGljOgogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBkb3VibGUgbWF4aW11bVpvb21MZXZlbCk7CiAgICAgdmlydHVhbCBmbG9h dCBwYWdlU2NhbGVGYWN0b3IoKSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQgc2NhbGVQYWdlKGZs b2F0IHNjYWxlRmFjdG9yLCBXZWJQb2ludCBvcmlnaW4pOworICAgIHZpcnR1YWwgZmxvYXQgZGV2 aWNlU2NhbGVGYWN0b3IoKSBjb25zdDsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0RGV2aWNlU2NhbGVG YWN0b3IoZmxvYXQpOwogICAgIHZpcnR1YWwgYm9vbCBpc0ZpeGVkTGF5b3V0TW9kZUVuYWJsZWQo KSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQgZW5hYmxlRml4ZWRMYXlvdXRNb2RlKGJvb2wgZW5h YmxlKTsKICAgICB2aXJ0dWFsIFdlYlNpemUgZml4ZWRMYXlvdXRTaXplKCkgY29uc3Q7Cg==