70416 2011-10-19 07:13:33 -0700 NRWT doesn't support ORWT's --root option, but should 2011-10-24 13:53:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 34984 1 aroben eric abarth dpranke eric ojan webkit-bug-importer webkit.review.bot oldest_to_newest 486760 0 aroben 2011-10-19 07:13:33 -0700 ORWT supports a --root flag that tells it where to find the built copy of WebKit. NRWT should support this option, too. 486762 1 webkit-bug-importer 2011-10-19 07:14:08 -0700 <rdar://problem/10310764> 489473 2 112217 eric 2011-10-24 11:31:04 -0700 Created attachment 112217 Patch 489475 3 eric 2011-10-24 11:31:26 -0700 Please let me know if this behaves as you would expect it should. 489482 4 112217 aroben 2011-10-24 11:38:49 -0700 Comment on attachment 112217 Patch The behavior of the test looks right to me. I'll let an NRWT aficionado r+ the patch. 489604 5 112217 webkit.review.bot 2011-10-24 13:53:22 -0700 Comment on attachment 112217 Patch Clearing flags on attachment: 112217 Committed r98279: <http://trac.webkit.org/changeset/98279> 489605 6 webkit.review.bot 2011-10-24 13:53:27 -0700 All reviewed patches have been landed. Closing bug. 112217 2011-10-24 11:31:04 -0700 2011-10-24 13:53:22 -0700 Patch bug-70416-20111024113102.patch text/plain 5565 eric U3VidmVyc2lvbiBSZXZpc2lvbjogOTgyNTMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1Yjk3M2RhNzIzOWY1OWE3YjJjNjQwMmViNDIxZGYzNDk0 NDNhMzBmLi5iNmZmMGVjYTE5ZGNjNzFlZjJiYzBhOTYyOThiOWEwYTgwNzMwOWQ0IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMTAtMjQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IE5SV1QgZG9lc24ndCBzdXBwb3J0IE9SV1QncyAtLXJvb3Qgb3B0aW9uLCBidXQgc2hvdWxkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDQxNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBzdXBwb3J0 IGZvciBPUldUJ3MgLS1yb290IG9wdGlvbiB3aGljaCBpcyB1c2VkIGZvcgorICAgICAgICBydW5u aW5nIHRlc3RzIHdpdGggYSBuaWdodGx5IGJ1aWxkIG9mIFdlYktpdC4KKworICAgICAgICAqIFNj cmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHM6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5OgorICAgICAgICAgLSB3ZWJraXRfYnVpbGRfcGF0aCB3 YXMgbmV2ZXIgY2FsbGVkIGJ5IGFueSBjb2RlLCByZW1vdmVkLgorICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5OgorICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisKIDIwMTEtMTAtMjQg IEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF1bV0sy XSBDcmFzaCB3aGVuIHJ1bm5pbmcgcGl4ZWwgdGVzdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMgYi9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRl c3RzCmluZGV4IDY4ZTljMjM5M2UxNDZiYjI4MjZkNGMyNTQwMmZiMzUyNzk4NDQwZTguLjVmNTNk NzQ5YmM2NTI1OWQ3YmZhZTQ4OTliMWJhYmJkNGVlNzljMTIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdl YmtpdC10ZXN0cwpAQCAtNDQwLDcgKzQ0MCw3IEBAIGNoZGlyV2ViS2l0KCk7CiAKIGlmICghZGVm aW5lZCgkcm9vdCkgJiYgISRub0J1aWxkRHVtcFRvb2wpIHsKICAgICAjIEZJWE1FOiBXZSBidWls ZCBib3RoIER1bXBSZW5kZXJUcmVlIGFuZCBXZWJLaXRUZXN0UnVubmVyIGZvcgotICAgICMgV2Vi S2l0VGVzdFJ1bm5lciBydW5zIGJlY3Vhc2UgRHVtcFJlbmRlclRyZWUgc3RpbGwgaW5jbHVkZXMK KyAgICAjIFdlYktpdFRlc3RSdW5uZXIgcnVucyBiZWNhdXNlIER1bXBSZW5kZXJUcmVlIHN0aWxs IGluY2x1ZGVzCiAgICAgIyB0aGUgRHVtcFJlbmRlclRyZWVTdXBwb3J0IG1vZHVsZSBhbmQgdGhl IFRlc3ROZXRzY2FwZVBsdWdpbi4KICAgICAjIFRoZXNlIHR3byBwcm9qZWN0cyBzaG91bGQgYmUg ZmFjdG9yZWQgb3V0IGludG8gdGhlaXIgb3duCiAgICAgIyBwcm9qZWN0cy4KZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQppbmRleCBkNTIyNzFj OWQzYmM5YmMzY2EyNTZlOTQ5OTc1ODk0OGM3ZDU2MTYzLi40MjJhMDVkZmI3YTI4ZGJhMGZkOTEx Yzk3ZmQ3MGZmZGJmZTVjMzQ5IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L2Jhc2UucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9iYXNlLnB5CkBAIC04ODUsOCArODg1LDYgQEAgY2xhc3MgUG9ydChvYmpl Y3QpOgogICAgICMgVGhlIHJvdXRpbmVzIGJlbG93IHNob3VsZCBvbmx5IGJlIGNhbGxlZCBieSBy b3V0aW5lcyBpbiB0aGlzIGNsYXNzCiAgICAgIyBvciBhbnkgb2YgaXRzIHN1YmNsYXNzZXMuCiAg ICAgIwotICAgIGRlZiBfd2Via2l0X2J1aWxkX2RpcmVjdG9yeShzZWxmLCBhcmdzKToKLSAgICAg ICAgcmV0dXJuIHNlbGYuX2NvbmZpZy5idWlsZF9kaXJlY3RvcnkoYXJnc1swXSkKIAogICAgIGRl ZiBfdXNlc19hcGFjaGUoc2VsZik6CiAgICAgICAgIHJldHVybiBUcnVlCmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CmluZGV4IGM1ZGRl NWZkZDE5ZmQxZTBjOWNiNmM4MGJlYzlmZTQxYzE4MTRjZDEuLjM1ZWE5YmUzZjgyMDAwYjA2ZGJj YzM4ZmU2ZDA2MDUyMTY0MmFiODUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CkBAIC0xMjUsNyArMTI1LDggQEAgY2xhc3MgV2Vi S2l0UG9ydChQb3J0KToKICAgICAgICAgcmV0dXJuIFRydWUKIAogICAgIGRlZiBjaGVja19idWls ZChzZWxmLCBuZWVkc19odHRwKToKLSAgICAgICAgaWYgc2VsZi5nZXRfb3B0aW9uKCdidWlsZCcp IGFuZCBub3Qgc2VsZi5fYnVpbGRfZHJpdmVyKCk6CisgICAgICAgICMgSWYgd2UncmUgdXNpbmcg YSBwcmUtYnVpbHQgY29weSBvZiBXZWJLaXQgKC0tcm9vdCksIHdlIGFzc3VtZSBpdCBhbHNvIGlu Y2x1ZGVzIGEgYnVpbGQgb2YgRFJULgorICAgICAgICBpZiBub3Qgc2VsZi5nZXRfb3B0aW9uKCdy b290JykgYW5kIHNlbGYuZ2V0X29wdGlvbignYnVpbGQnKSBhbmQgbm90IHNlbGYuX2J1aWxkX2Ry aXZlcigpOgogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAgICAgICAgIGlmIG5vdCBzZWxmLl9j aGVja19kcml2ZXIoKToKICAgICAgICAgICAgIHJldHVybiBGYWxzZQpAQCAtMzY0LDggKzM2NSwx MSBAQCBjbGFzcyBXZWJLaXRQb3J0KFBvcnQpOgogICAgICAgICByZXR1cm4gdGVzdHNfdG9fc2tp cAogCiAgICAgZGVmIF9idWlsZF9wYXRoKHNlbGYsICpjb21wcyk6Ci0gICAgICAgIHJldHVybiBz ZWxmLl9maWxlc3lzdGVtLmpvaW4oc2VsZi5fY29uZmlnLmJ1aWxkX2RpcmVjdG9yeSgKLSAgICAg ICAgICAgIHNlbGYuZ2V0X29wdGlvbignY29uZmlndXJhdGlvbicpKSwgKmNvbXBzKQorICAgICAg ICAjIC0tcm9vdCBpcyB1c2VkIGZvciBydW5uaW5nIHdpdGggYSBwcmUtYnVpbHQgcm9vdCAobGlr ZSBmcm9tIGEgbmlnaHRseSB6aXApLgorICAgICAgICBidWlsZF9kaXJlY3RvcnkgPSBzZWxmLmdl dF9vcHRpb24oJ3Jvb3QnKQorICAgICAgICBpZiBub3QgYnVpbGRfZGlyZWN0b3J5OgorICAgICAg ICAgICAgYnVpbGRfZGlyZWN0b3J5ID0gc2VsZi5fY29uZmlnLmJ1aWxkX2RpcmVjdG9yeShzZWxm LmdldF9vcHRpb24oJ2NvbmZpZ3VyYXRpb24nKSkKKyAgICAgICAgcmV0dXJuIHNlbGYuX2ZpbGVz eXN0ZW0uam9pbihidWlsZF9kaXJlY3RvcnksICpjb21wcykKIAogICAgIGRlZiBfcGF0aF90b19k cml2ZXIoc2VsZik6CiAgICAgICAgIHJldHVybiBzZWxmLl9idWlsZF9wYXRoKHNlbGYuZHJpdmVy X25hbWUoKSkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvd2Via2l0X3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC93ZWJraXRfdW5pdHRlc3QucHkKaW5kZXggYTc3YzExMTI0ZmM5ODRmZDE5MWFj MDkxMWNjZjcwNTEzMWViYjk4OS4uYzE2ZWM4NzQ0OGYxZjQ2YmE2MDMyN2FiMTUwMzIxN2EwN2Yy ZTg0NyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC93ZWJraXRfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC93ZWJraXRfdW5pdHRlc3QucHkKQEAgLTEyNSw2ICsxMjUsMTEgQEAgY2xhc3Mg V2ViS2l0UG9ydFRlc3QocG9ydF90ZXN0Y2FzZS5Qb3J0VGVzdENhc2UpOgogICAgICAgICBwb3J0 Ll9vcHRpb25zID0gTW9ja09wdGlvbnMod2Via2l0X3Rlc3RfcnVubmVyPVRydWUpCiAgICAgICAg IHNlbGYuYXNzZXJ0RXF1YWwocG9ydC5fc2tpcHBlZF9maWxlX3NlYXJjaF9wYXRocygpLCBzZXQo Wyd0ZXN0d2Via2l0cG9ydCcsICd0ZXN0d2Via2l0cG9ydC12ZXJzaW9uJywgJ3Rlc3R3ZWJraXRw b3J0LXdrMicsICd3azInXSkpCiAKKyAgICBkZWYgdGVzdF9yb290X29wdGlvbihzZWxmKToKKyAg ICAgICAgcG9ydCA9IFRlc3RXZWJLaXRQb3J0KCkKKyAgICAgICAgcG9ydC5fb3B0aW9ucyA9IE1v Y2tPcHRpb25zKHJvb3Q9Jy9mb28nKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHBvcnQuX3Bh dGhfdG9fZHJpdmVyKCksICIvZm9vL0R1bXBSZW5kZXJUcmVlIikKKwogICAgIGRlZiB0ZXN0X3Rl c3RfZXhwZWN0YXRpb25zKHNlbGYpOgogICAgICAgICAjIENoZWNrIHRoYXQgd2UgcmVhZCBib3Ro IHRoZSBleHBlY3RhdGlvbnMgZmlsZSBhbmQgYW55dGhpbmcgaW4gYQogICAgICAgICAjIFNraXBw ZWQgZmlsZSwgYW5kIHRoYXQgd2UgaW5jbHVkZSB0aGUgZmVhdHVyZSBhbmQgcGxhdGZvcm0gY2hl Y2tzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVu X3dlYmtpdF90ZXN0cy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1 bl93ZWJraXRfdGVzdHMucHkKaW5kZXggNzI0NWY5YjJiZjczMWUxMjVlM2Q0MWQ5NzJlMzNmNGRk OWUzNTlmYy4uMzg2MDhiNmU0NGM5NjljZGZlZDUzMGY5ZGRiNzVlZDNmNDgxNWY3ZiAxMDA3NTUK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0 cy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0 X3Rlc3RzLnB5CkBAIC0yNTIsNiArMjUyLDggQEAgZGVmIHBhcnNlX2FyZ3MoYXJncz1Ob25lKToK ICAgICAgICAgICAgIGhlbHA9IlJ1biBhIGNvbmN1cnJlbnQgSmF2YVNjcmlwdCB0aHJlYWQgd2l0 aCBlYWNoIHRlc3QiKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0td2Via2l0LXRl c3QtcnVubmVyIiwgIi0yIiwgYWN0aW9uPSJzdG9yZV90cnVlIiwKICAgICAgICAgICAgIGhlbHA9 IlVzZSBXZWJLaXRUZXN0UnVubmVyIHJhdGhlciB0aGFuIER1bXBSZW5kZXJUcmVlLiIpLAorICAg ICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1yb290IiwgYWN0aW9uPSJzdG9yZSIsCisgICAg ICAgICAgICBoZWxwPSJQYXRoIHRvIGEgcHJlLWJ1aWx0IHJvb3Qgb2YgV2ViS2l0IChmb3IgcnVu bmluZyB0ZXN0cyB1c2luZyBhIG5pZ2h0bHkgYnVpbGQgb2YgV2ViS2l0KSIpLAogICAgIF0KIAog ICAgIG9sZF9ydW5fd2Via2l0X3Rlc3RzX2NvbXBhdCA9IFsK