70297 2011-10-17 18:58:00 -0700 [Qt] Send mouse move events when we handle HoverEnter/Leave in QDesktopWebView 2011-10-18 07:27:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 70238 1 cmarcelo cmarcelo hausmann kling menard oldest_to_newest 485735 0 cmarcelo 2011-10-17 18:58:00 -0700 [Qt] Send mouse move events when we handle HoverEnter/Leave in QDesktopWebView 485739 1 111370 cmarcelo 2011-10-17 19:06:39 -0700 Created attachment 111370 Patch 485950 2 111370 menard 2011-10-18 04:18:51 -0700 Comment on attachment 111370 Patch On a side note the bug always existed even in WK1. Caio was trying to fix the API test failure for WK2 and we discovered that hover events were not properly handled. Rather than a workaround in the test itself, I'm supporting the fact that we're trying to fix it. 485972 3 111370 hausmann 2011-10-18 05:12:52 -0700 Comment on attachment 111370 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111370&action=review > Source/WebKit2/ChangeLog:11 > + While HoverEvent is in practice equivalent to HoverMove, the HoverLeave event is a bit different HoverEvent -> HoverEnterEvent (to be fixed before landing :) 485987 4 cmarcelo 2011-10-18 05:57:56 -0700 Committed r97744: <http://trac.webkit.org/changeset/97744> 111370 2011-10-17 19:06:39 -0700 2011-10-18 05:12:52 -0700 Patch bug-70297-20111017230659.patch text/plain 3830 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogOTc2MzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAwNDVjYzMzZTAzNjE5ZWNi NWQ2NjMwNWUyZjZiYjJjYzllYmMwYjY4Li43ZWE0MDNjN2JjYzRiZDk3ZTY1OTEzZWNjMWJhNWYz MDY0NTZjMWY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMTAtMTcgIENhaW8g TWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4K KworICAgICAgICBbUXRdIFNlbmQgbW91c2UgbW92ZSBldmVudHMgd2hlbiB3ZSBoYW5kbGUgSG92 ZXJFbnRlci9MZWF2ZSBpbiBRRGVza3RvcFdlYlZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMjk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUXQgdHJlYXQgdGhlIGZpcnN0IGFuZCBsYXN0IGhvdmVy IG1vdmVtZW50cyBhcyBzcGVjaWFsIEhvdmVyTW92ZSBhbmQgSG92ZXJMZWF2ZSBldmVudHMsIGJ1 dAorICAgICAgICBXZWJLaXQgZG9lc24ndCBtYWtlIHRoZSBkaWZmZXJlbmNlLCBzbyB3ZSBuZWVk IHRvIGNyZWF0ZSBtb3ZlIGV2ZW50cyBmb3IgdGhlbS4KKworICAgICAgICBXaGlsZSBIb3ZlckV2 ZW50IGlzIGluIHByYWN0aWNlIGVxdWl2YWxlbnQgdG8gSG92ZXJNb3ZlLCB0aGUgSG92ZXJMZWF2 ZSBldmVudCBpcyBhIGJpdCBkaWZmZXJlbnQKKyAgICAgICAgYmVjYXVzZSB3ZSB3YW50IHRvIGVt dWxhdGUgdGhhdCB0aGUgbW91c2UgaXMgbm90IG9ubHkgbGVhdmluZyB0aGUgY3VycmVudCBub2Rl LCBidXQgY29tcGxldGVseQorICAgICAgICBsZWF2aW5nIHRoZSB3aG9sZSBkb2N1bWVudC4gVGhl IHdheSB0byBkbyB0aGlzIGlzIHRvIG1hbnVmYWN0dXJlIGEgbW92ZSBldmVudCB3aXRoIGEgdmVy eSBmYXIKKyAgICAgICAgcG9zaXRpb24sIGFuZCB3YXMgaW5zcGlyZWQgYnkgV2ViVmlldzo6aGFu ZGxlTW91c2VFdmVudCgpIGluIFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwLgorCisgICAg ICAgIFRoaXMgcGF0Y2ggZml4ZXMgRGVza3RvcFdlYlZpZXdMaW5rSG92ZXJlZCBRTUwgdGVzdHMu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvcWRlc2t0b3B3ZWJwYWdlcHJveHkuY3BwOgorICAg ICAgICAoUURlc2t0b3BXZWJQYWdlUHJveHk6OmhhbmRsZUV2ZW50KToKKyAgICAgICAgKFFEZXNr dG9wV2ViUGFnZVByb3h5OjpoYW5kbGVIb3ZlckxlYXZlRXZlbnQpOgorICAgICAgICAqIFVJUHJv Y2Vzcy9xdC9xZGVza3RvcHdlYnBhZ2Vwcm94eS5oOgorCiAyMDExLTEwLTE3ICBBZGEgQ2hhbiAg PGFkYWNoYW5AYXBwbGUuY29tPgogCiAgICAgICAgIENhbGxpbmcgV0tQYWdlTG9hZEFsdGVybmF0 ZUhUTUxTdHJpbmcoKSB3aGVyZSBiYXNlVVJMIGRvZXMgbm90IHBvaW50IHRvIGEgZGlyZWN0b3J5 IGNhdXNlcyBhbiBpbnZhbGlkIG1lc3NhZ2UgdG8gYmUgcmV0dXJuZWQgZnJvbSBXZWJQcm9jZXNz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvcWRlc2t0b3B3ZWJwYWdl cHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L3FkZXNrdG9wd2VicGFnZXBy b3h5LmNwcAppbmRleCBhMTQyZGQ0YzIzMzY3NDZhZjY4ZGY0MjQxODkwNmRmNTMwYzFiYmMyLi5j NzJkMWVkODJkNjI3MDE0ZTExYzkxNmU3ZmZlZGIyMmM3NTIzZmZkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvcWRlc2t0b3B3ZWJwYWdlcHJveHkuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9xZGVza3RvcHdlYnBhZ2Vwcm94eS5jcHAKQEAgLTEw MCw2ICsxMDAsOSBAQCBib29sIFFEZXNrdG9wV2ViUGFnZVByb3h5OjpoYW5kbGVFdmVudChRRXZl bnQqIGV2KQogICAgICAgICByZXR1cm4gaGFuZGxlTW91c2VEb3VibGVDbGlja0V2ZW50KHJlaW50 ZXJwcmV0X2Nhc3Q8UU1vdXNlRXZlbnQqPihldikpOwogICAgIGNhc2UgUUV2ZW50OjpXaGVlbDoK ICAgICAgICAgcmV0dXJuIGhhbmRsZVdoZWVsRXZlbnQocmVpbnRlcnByZXRfY2FzdDxRV2hlZWxF dmVudCo+KGV2KSk7CisgICAgY2FzZSBRRXZlbnQ6OkhvdmVyTGVhdmU6CisgICAgICAgIHJldHVy biBoYW5kbGVIb3ZlckxlYXZlRXZlbnQocmVpbnRlcnByZXRfY2FzdDxRSG92ZXJFdmVudCo+KGV2 KSk7CisgICAgY2FzZSBRRXZlbnQ6OkhvdmVyRW50ZXI6IC8vIEZhbGwtdGhyb3VnaCwgZm9yIFdl YktpdCB0aGUgZGlzdGluY3Rpb24gZG9lc24ndCBtYXR0ZXIuCiAgICAgY2FzZSBRRXZlbnQ6Okhv dmVyTW92ZToKICAgICAgICAgcmV0dXJuIGhhbmRsZUhvdmVyTW92ZUV2ZW50KHJlaW50ZXJwcmV0 X2Nhc3Q8UUhvdmVyRXZlbnQqPihldikpOwogICAgIGNhc2UgUUV2ZW50OjpEcmFnRW50ZXI6CkBA IC0xNjMsNiArMTY2LDE0IEBAIGJvb2wgUURlc2t0b3BXZWJQYWdlUHJveHk6OmhhbmRsZVdoZWVs RXZlbnQoUVdoZWVsRXZlbnQqIGV2KQogICAgIHJldHVybiBldi0+aXNBY2NlcHRlZCgpOwogfQog Citib29sIFFEZXNrdG9wV2ViUGFnZVByb3h5OjpoYW5kbGVIb3ZlckxlYXZlRXZlbnQoUUhvdmVy RXZlbnQqIGV2KQoreworICAgIC8vIFRvIGdldCB0aGUgY29ycmVjdCBiZWhhdmlvciBvZiBtb3Vz ZW91dCwgd2UgbmVlZCB0byB0dXJuIHRoZSBMZWF2ZSBldmVudCBvZiBvdXIgd2VidmlldyBpbnRv IGEgbW91c2UgbW92ZQorICAgIC8vIHRvIGEgdmVyeSBmYXIgcmVnaW9uLgorICAgIFFIb3ZlckV2 ZW50IGZha2VFdmVudChRRXZlbnQ6OkhvdmVyTW92ZSwgUVBvaW50KElOVF9NSU4sIElOVF9NSU4p LCBldi0+b2xkUG9zKCkpOworICAgIHJldHVybiBoYW5kbGVIb3Zlck1vdmVFdmVudCgmZmFrZUV2 ZW50KTsKK30KKwogYm9vbCBRRGVza3RvcFdlYlBhZ2VQcm94eTo6aGFuZGxlSG92ZXJNb3ZlRXZl bnQoUUhvdmVyRXZlbnQqIGV2KQogewogICAgIFFNb3VzZUV2ZW50IG1lKFFFdmVudDo6TW91c2VN b3ZlLCBldi0+cG9zKCksIFF0OjpOb0J1dHRvbiwgUXQ6Ok5vQnV0dG9uLCBRdDo6Tm9Nb2RpZmll cik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvcWRlc2t0b3B3ZWJw YWdlcHJveHkuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9xZGVza3RvcHdlYnBhZ2Vw cm94eS5oCmluZGV4IDYxZDU2ODIyZmU2ZDQwYWJjMjcwZWYzZWQxZTQ3ZWJlM2EwNjBlMDQuLjBi YjA4MTU5NTA4ZTE1MzRlNDIxNDQzNmNiNzZlYzVlNTI2NmEyZmMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9xZGVza3RvcHdlYnBhZ2Vwcm94eS5oCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9xZGVza3RvcHdlYnBhZ2Vwcm94eS5oCkBAIC01Niw2ICs1 Niw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBoYW5kbGVNb3VzZVJlbGVhc2VFdmVudChRTW91c2VF dmVudCopOwogICAgIGJvb2wgaGFuZGxlTW91c2VEb3VibGVDbGlja0V2ZW50KFFNb3VzZUV2ZW50 Kik7CiAgICAgYm9vbCBoYW5kbGVXaGVlbEV2ZW50KFFXaGVlbEV2ZW50Kik7CisgICAgYm9vbCBo YW5kbGVIb3ZlckxlYXZlRXZlbnQoUUhvdmVyRXZlbnQqKTsKICAgICBib29sIGhhbmRsZUhvdmVy TW92ZUV2ZW50KFFIb3ZlckV2ZW50Kik7CiAgICAgYm9vbCBoYW5kbGVEcmFnRW50ZXJFdmVudChR RHJhZ0VudGVyRXZlbnQqKTsKICAgICBib29sIGhhbmRsZURyYWdMZWF2ZUV2ZW50KFFEcmFnTGVh dmVFdmVudCopOwo=