70236 2011-10-17 07:27:13 -0700 [Qt][WK2][meta] Fix failing API tests 2014-02-03 03:19:04 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED INVALID Qt, QtTriaged P2 Normal --- 96928 66664 70237 70238 70525 70715 71311 72612 72633 72916 73292 73994 74176 74180 74923 76906 77554 80247 81143 81771 82167 82483 82700 85049 87236 88870 89871 90372 91888 91900 94949 95968 96531 97561 97907 98045 98296 100224 100247 100661 100758 101167 101168 103875 103889 104574 114680 118129 118134 118138 118357 118360 118384 118389 1 ossy webkit-unassigned abecsi cmarcelo hausmann kbalazs menard ossy webkit.review.bot oldest_to_newest 485130 0 ossy 2011-10-17 07:27:13 -0700 It is a meta bug for fixing failing API tests. 485161 1 111267 menard 2011-10-17 08:21:51 -0700 Created attachment 111267 Patch 485167 2 webkit.review.bot 2011-10-17 08:26:16 -0700 Attachment 111267 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style. 485168 3 111267 ossy 2011-10-17 08:28:00 -0700 Comment on attachment 111267 Patch Clearing flags on attachment: 111267 Committed r97623: <http://trac.webkit.org/changeset/97623> 485169 4 ossy 2011-10-17 08:28:07 -0700 All reviewed patches have been landed. Closing bug. 485171 5 ossy 2011-10-17 08:28:49 -0700 . 490952 6 ossy 2011-10-26 09:54:55 -0700 There are too many failing API tests for long time, so API tests aren't ready for making the bot red if a test fails. From now a failing API test doesn't make the WK2 bot red, but its build step is orange. 490985 7 menard 2011-10-26 10:20:21 -0700 (In reply to comment #6) > There are too many failing API tests for long time, so API tests aren't ready for making the bot red if a test fails. From now a failing API test doesn't make the WK2 bot red, but its build step is orange. NOOOOO please.... It's a real issue. Almost all the QtWebKit community is in dev days so we don't have time to look at it *right now*. But we will. Let's not go back to the past and let it broken. Any API breakage is as important as LayoutTests breakage. By any chance did you catch the faulty revision or the import of Qt5 that it broke? I recall they were properly green last week. 494087 8 ossy 2011-11-01 13:08:30 -0700 (In reply to comment #7) > (In reply to comment #6) > > There are too many failing API tests for long time, so API tests aren't ready for making the bot red if a test fails. From now a failing API test doesn't make the WK2 bot red, but its build step is orange. > > NOOOOO please.... > > It's a real issue. Almost all the QtWebKit community is in dev days so we don't have time to look at it *right now*. But we will. Let's not go back to the past and let it broken. Any API breakage is as important as LayoutTests breakage. > > By any chance did you catch the faulty revision or the import of Qt5 that it broke? I recall they were properly green last week. There are 10 failing API tests now, I filed bug reports for all fails which block this bug. I don't think if always red bot is a good idea. Always red bot _can't_ get regressions and _can't_ send email if there is a new regression. We can catch new regressions easily if the bot is green almost always. In this case the green/red change means a possible new regression. I can't fix failing API tests myself, but API maintainer can. 494118 9 menard 2011-11-01 13:58:40 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > There are too many failing API tests for long time, so API tests aren't ready for making the bot red if a test fails. From now a failing API test doesn't make the WK2 bot red, but its build step is orange. > > > > NOOOOO please.... > > > > It's a real issue. Almost all the QtWebKit community is in dev days so we don't have time to look at it *right now*. But we will. Let's not go back to the past and let it broken. Any API breakage is as important as LayoutTests breakage. > > > > By any chance did you catch the faulty revision or the import of Qt5 that it broke? I recall they were properly green last week. > > There are 10 failing API tests now, I filed bug reports for all fails which block this bug. I don't think if always red bot is a good idea. Always red bot _can't_ get regressions and _can't_ send email if there is a new regression. We can catch new regressions easily if the bot is green almost always. In this case the green/red change means a possible new regression. I can't fix failing API tests myself, but API maintainer can. But szeged build bots doesn't send email/add comments on bugs even if you are the first guilty revision and I think that's the problem. Of course I do see why it doesn't do it because our bots there are not that stable or not meant to be used by other contributors. But would it be possible that they comment on bugs that matters for QtWebKit like the ones with [Qt] because today people don't care about API tests because they don't get warn on their original bug id. At least the WK2 could do so that would force people to care about them. It seems that except FAIL! : qmltests::DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy() window not shown they seems to be easily fixable. The latter seems to be a race triggered in V8 with a recent change. Hopefully we can get that fixed in the next Qt update. 501356 10 jesus 2011-11-11 21:23:14 -0800 Alexis, all the API tests are currently passing, right?! 504856 11 ossy 2011-11-17 08:00:31 -0800 The answer was yes, but now we have 2 new fails: https://bugs.webkit.org/show_bug.cgi?id=72612 504867 12 ossy 2011-11-17 08:12:30 -0800 (In reply to comment #9) > But szeged build bots doesn't send email/add comments on bugs even if you are the first guilty revision and I think that's the problem. Of course I do see why it doesn't do it because our bots there are not that stable or not meant to be used by other contributors. But would it be possible that they comment on bugs that matters for QtWebKit like the ones with [Qt] because today people don't care about API tests because they don't get warn on their original bug id. At least the WK2 could do so that would force people to care about them. I remember that sheriffbot commented bugs regularly if somebody caused a regression. But it was disabled, because folks didn't want to get SPAM. Buildbot on its own can't send e-mails if a commit increases the number of failing layout or API tests. Buildbot can send e-mail when its color changes from green to red. (or from all red revision) Of course it is possible to implement a sophisticated script which polls buildbot page regularly, parse its output, find who break which layout or API tests and send e-mail if the bug title has [Qt] prefix, etc. Is there any volunteer for it? 507558 13 menard 2011-11-22 06:19:24 -0800 (In reply to comment #12) > (In reply to comment #9) > > But szeged build bots doesn't send email/add comments on bugs even if you are the first guilty revision and I think that's the problem. Of course I do see why it doesn't do it because our bots there are not that stable or not meant to be used by other contributors. But would it be possible that they comment on bugs that matters for QtWebKit like the ones with [Qt] because today people don't care about API tests because they don't get warn on their original bug id. At least the WK2 could do so that would force people to care about them. > > I remember that sheriffbot commented bugs regularly if somebody caused a regression. But it was disabled, because folks didn't want to get SPAM. > Buildbot on its own can't send e-mails if a commit increases the number of > failing layout or API tests. Buildbot can send e-mail when its color changes > from green to red. (or from all red revision) > > Of course it is possible to implement a sophisticated script which polls buildbot page regularly, parse its output, find who break which layout or API tests and send e-mail if the bug title has [Qt] prefix, etc. Is there any volunteer for it? All green now. 975326 14 jturcotte 2014-02-03 03:19:04 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 111267 2011-10-17 08:21:51 -0700 2011-10-17 08:27:59 -0700 Patch bug-70236-20111017122135.patch text/plain 1527 menard U3VidmVyc2lvbiBSZXZpc2lvbjogOTc2MDIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxNjFiYWZkY2MxNmU4Y2NhZmU1OGUzYzdjNmJhMjE4ZTMx MDk2NzkwLi45MjQxZWQ0ZGI3NmE3N2RiZDdkMDEwN2Y3NzQ2MzJkYWYyMjA0NzBlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMTAtMTcgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgW1F0XVtXSzJdW21ldGFdIEZpeCBmYWlsaW5nIEFQSSB0ZXN0cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAyMzYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBvcmRlciB0byBy dW4gV2ViS2l0MiBBUEkgdGVzdHMgd2UgbmVlZCB0aGUgV2ViUHJvY2VzcyB0byBiZSBpbgorICAg ICAgICB0aGUgcGF0aCBzbyBsZXQncyBhZGQgdGhlIGJpbiBkaXJlY3Rvcnkgd2hlbiBydW5uaW5n IHRoZSBBUEkgdGVzdHMgb2YgUXQuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1xdHdlYmtpdC10 ZXN0czoKKwogMjAxMS0xMC0xNiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAg ICAgICAgIEFsd2F5cyBlbmFibGUgRU5BQkxFKERPTV9TVE9SQUdFKQpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy9ydW4tcXR3ZWJraXQtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1xdHdlYmtp dC10ZXN0cwppbmRleCA3ODMwNzg1ZjBmNmE3MmY4NzQ5MmRiMjQ0Zjk4MDU3ZmYyODJlMGU1Li41 ZmI3MmFhNDBlYzc0NGJlNzFlYmI1MTk2ZjJlMGQyZDgxYjcxODEwIDEwMDc1NQotLS0gYS9Ub29s cy9TY3JpcHRzL3J1bi1xdHdlYmtpdC10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1xdHdl YmtpdC10ZXN0cwpAQCAtMjEyLDYgKzIxMiw5IEBAIGNsYXNzIE1haW4oTG9nKToKICAgICAgICAg cW1sX2ltcG9ydF9wYXRoID0gc2VsZi5fb3B0aW9ucy5wYXRoICsgIi4uLy4uLy4uL2ltcG9ydHMi CiAgICAgICAgIHFtbF9pbXBvcnRfcGF0aCArPSAiOiIgKyBzZWxmLl9vcHRpb25zLnBhdGggKyAi Li4vLi4vLi4vLi4vLi4vaW1wb3J0cyIKICAgICAgICAgb3MucHV0ZW52KCJRTUxfSU1QT1JUX1BB VEgiLCBxbWxfaW1wb3J0X3BhdGgpCisgICAgICAgIHBhdGggPSBvcy5nZXRlbnYoIlBBVEgiKQor ICAgICAgICBwYXRoICs9ICI6IiArIHNlbGYuX29wdGlvbnMucGF0aCArICIuLi8uLi8uLi8uLi8u Li9iaW4iCisgICAgICAgIG9zLnB1dGVudigiUEFUSCIsIHBhdGgpCiAgICAgICAgIHNlbGYuZGVi dWcoIlNlYXJjaGluZyBleGVjdXRhYmxlcy4uLiIpCiAgICAgICAgIHRlc3RzX2V4ZWN1dGFibGVz ID0gc2VsZi5maW5kX3Rlc3RzX3BhdGhzKHNlbGYuX29wdGlvbnMucGF0aCkKICAgICAgICAgc2Vs Zi5kZWJ1ZygiRm91bmQ6ICVzIiwgbGVuKHRlc3RzX2V4ZWN1dGFibGVzKSkK