70214 2011-10-16 21:15:14 -0700 Generate MessageChannel constructor for JSC by [Constructor] IDL 2011-10-16 23:01:46 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 65839 0 haraken webkit-unassigned abarth ap dominicc sam webkit.review.bot oldest_to_newest 484900 0 haraken 2011-10-16 21:15:14 -0700 Currently, the MessageChannel constructor in JSC is written manually as a custom constructor. We should replace this with automatically generated code by the [Constructor] IDL. 484903 1 111206 haraken 2011-10-16 21:33:01 -0700 Created attachment 111206 Patch 484940 2 111206 webkit.review.bot 2011-10-16 23:01:41 -0700 Comment on attachment 111206 Patch Clearing flags on attachment: 111206 Committed r97586: <http://trac.webkit.org/changeset/97586> 484941 3 webkit.review.bot 2011-10-16 23:01:46 -0700 All reviewed patches have been landed. Closing bug. 111206 2011-10-16 21:33:01 -0700 2011-10-16 23:01:41 -0700 Patch bug-70214-20111017133259.patch text/plain 2867 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTc1ODIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1Y2E2MTJmYWY1YmVhMDRl MDlhZjZiNDE2MzQxYjYyYTljMmMxNTY4Li42ZTdkODBjNDgxZjgwODZhMzIzM2QzM2MyZjZlNzRm NThjOGIxZmI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMgQEAKIDIwMTEtMTAtMTYgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCisgICAgICAgIEdlbmVyYXRlIE1lc3Nh Z2VDaGFubmVsIGNvbnN0cnVjdG9yIGJ5IFtDb25zdHJ1Y3Rvcl0gSURMCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDIxNAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggZ2VuZXJhdGVzIGFu IE1lc3NhZ2VDaGFubmVsIGNvbnN0cnVjdG9yIGZvciBKU0MgYnkgW0NvbnN0cnVjdG9yXSBJREws CisgICAgICAgIGJ1dCBWOCBpcyBzdGlsbCB1c2luZyBhIGN1c3RvbSBjb25zdHJ1Y3RvciBzaW5j ZSB0aGUgVjggY29uc3RydWN0b3IgcmVxdWlyZXMgc3BlY2lhbCBsb2dpYy4KKworICAgICAgICBU ZXN0czogZmFzdC9kb20vZ2xvYmFsLWNvbnN0cnVjdG9ycy5odG1sCisgICAgICAgICAgICAgICBm YXN0L2V2ZW50cy9tZXNzYWdlLXBvcnQuaHRtbAorICAgICAgICAgICAgICAgZmFzdC9ldmVudHMv bWVzc2FnZS1wb3J0LW5vLXdyYXBwZXIuaHRtbAorICAgICAgICAgICAgICAgZmFzdC9kb20vV2lu ZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1hcmdzLmh0bWwKKworICAgICAgICAqIGJpbmRpbmdzL2pz L0pTTWVzc2FnZUNoYW5uZWxDdXN0b20uY3BwOiBSZW1vdmVkIHRoZSBNZXNzYWdlQ2hhbm5lbCBj b25zdHJ1Y3Rvci4KKyAgICAgICAgKiBkb20vTWVzc2FnZUNoYW5uZWwuaWRsOiBHZW5lcmF0ZXMg dGhlIE1lc3NhZ2VDaGFubmVsIGNvbnN0cnVjdG9yIGZvciBKU0MuCisKKzIwMTEtMTAtMTYgIEtl bnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIEdlbmVyYXRlIFhN TEh0dHBSZXF1ZXN0IGNvbnN0cnVjdG9yIGZvciBKU0MgYnkgW0NvbnN0cnVjdG9yXSBJREwKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMjA4CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTWVzc2FnZUNoYW5uZWxDdXN0 b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNNZXNzYWdlQ2hhbm5lbEN1c3Rv bS5jcHAKaW5kZXggOGEwNDdhMTIwNjkxMjY5YjVhYzI3ODdkY2JiZGY4NzU1YmQzM2QxOS4uYmVl YTMyZTVjNGNmYThhYTI2YWE1Y2IzYjc2NTdiMGZkNDk3OTUzYyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvSlNNZXNzYWdlQ2hhbm5lbEN1c3RvbS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNNZXNzYWdlQ2hhbm5lbEN1c3RvbS5jcHAKQEAgLTQ4 LDE0ICs0OCw0IEBAIHZvaWQgSlNNZXNzYWdlQ2hhbm5lbDo6dmlzaXRDaGlsZHJlbihKU0NlbGwq IGNlbGwsIFNsb3RWaXNpdG9yJiB2aXNpdG9yKQogICAgICAgICB2aXNpdG9yLmFkZE9wYXF1ZVJv b3QocG9ydCk7CiB9CiAKLUVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgSlNNZXNzYWdlQ2hh bm5lbENvbnN0cnVjdG9yOjpjb25zdHJ1Y3RKU01lc3NhZ2VDaGFubmVsKEV4ZWNTdGF0ZSogZXhl YykKLXsKLSAgICBKU01lc3NhZ2VDaGFubmVsQ29uc3RydWN0b3IqIGpzQ29uc3RydWN0b3IgPSBz dGF0aWNfY2FzdDxKU01lc3NhZ2VDaGFubmVsQ29uc3RydWN0b3IqPihleGVjLT5jYWxsZWUoKSk7 Ci0gICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCA9IGpzQ29uc3RydWN0b3ItPnNj cmlwdEV4ZWN1dGlvbkNvbnRleHQoKTsKLSAgICBpZiAoIWNvbnRleHQpCi0gICAgICAgIHJldHVy biB0aHJvd1ZNRXJyb3IoZXhlYywgY3JlYXRlUmVmZXJlbmNlRXJyb3IoZXhlYywgIk1lc3NhZ2VD aGFubmVsIGNvbnN0cnVjdG9yIGFzc29jaWF0ZWQgZG9jdW1lbnQgaXMgdW5hdmFpbGFibGUiKSk7 Ci0KLSAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGFzT2JqZWN0KHRvSlMoZXhlYywganNDb25z dHJ1Y3Rvci0+Z2xvYmFsT2JqZWN0KCksIE1lc3NhZ2VDaGFubmVsOjpjcmVhdGUoY29udGV4dCkp KSk7Ci19Ci0KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2RvbS9NZXNzYWdlQ2hhbm5lbC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTWVzc2FnZUNo YW5uZWwuaWRsCmluZGV4IDQ3MjMxYjAxMWU5NWE2NjA2ZDc3YTlhZWIyODgwOWYzNTliNGYyMDgu LmQ0MTVkOTBmNDA1ZDFiYjBiMWJmOTMxNzMyZWJkZjAzYzEyNWM0MzMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9NZXNzYWdlQ2hhbm5lbC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUv ZG9tL01lc3NhZ2VDaGFubmVsLmlkbApAQCAtMjgsNyArMjgsOSBAQCBtb2R1bGUgZXZlbnRzIHsK IAogICAgIGludGVyZmFjZSBbCiAgICAgICAgIENhbkJlQ29uc3RydWN0ZWQsCi0gICAgICAgIEN1 c3RvbUNvbnN0cnVjdG9yLAorICAgICAgICBDb25zdHJ1Y3RvciwKKyAgICAgICAgQ2FsbFdpdGg9 U2NyaXB0RXhlY3V0aW9uQ29udGV4dCwKKyAgICAgICAgVjhDdXN0b21Db25zdHJ1Y3RvciwKICAg ICAgICAgQ3VzdG9tTWFya0Z1bmN0aW9uLAogICAgICAgICBOb1N0YXRpY1RhYmxlcwogICAgIF0g TWVzc2FnZUNoYW5uZWwgewo=