70208 2011-10-16 18:44:41 -0700 Generate XMLHttpRequest constructor for JSC by [Constructor] IDL 2011-10-16 20:13:08 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 65839 0 haraken webkit-unassigned abarth ap dominicc sam webkit.review.bot oldest_to_newest 484867 0 haraken 2011-10-16 18:44:41 -0700 Currently, the XMLHttpRequest constructor in JSC is written manually as a custom constructor. We should replace this with automatically generated code by the [Constructor] IDL. 484876 1 111197 haraken 2011-10-16 19:09:56 -0700 Created attachment 111197 Patch 484888 2 111197 webkit.review.bot 2011-10-16 20:13:01 -0700 Comment on attachment 111197 Patch Clearing flags on attachment: 111197 Committed r97581: <http://trac.webkit.org/changeset/97581> 484889 3 webkit.review.bot 2011-10-16 20:13:08 -0700 All reviewed patches have been landed. Closing bug. 111197 2011-10-16 19:09:56 -0700 2011-10-16 20:13:01 -0700 Patch bug-70208-20111017110955.patch text/plain 6083 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTc1NzgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNTliNDRhMzRkMzVkNWIw ODNiNTQ3M2FkOTcyODMxYjBiMzg4MWQzLi5kMjk1YWJlY2JkMjY5M2M2MmVjMzA2ZmU2Y2Y0MDBm YTMxOGEwZjI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjYgQEAKIDIwMTEtMTAtMTYgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCisgICAgICAgIEdlbmVyYXRlIFhNTEh0 dHBSZXF1ZXN0IGNvbnN0cnVjdG9yIGZvciBKU0MgYnkgW0NvbnN0cnVjdG9yXSBJREwKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMjA4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBnZW5l cmF0ZXMgYW4gWE1MSHR0cFJlcXVlc3QgY29uc3RydWN0b3IgZm9yIEpTQyBieSBbQ29uc3RydWN0 b3JdIElETCwKKyAgICAgICAgYnV0IFY4IGlzIHN0aWxsIHVzaW5nIGEgY3VzdG9tIGNvbnN0cnVj dG9yIHNpbmNlIHRoZSBWOCBjb25zdHJ1Y3RvciByZXF1aXJlcyBhIHNwZWNpYWwgbG9naWMuCisK KyAgICAgICAgVGVzdHM6IGZhc3QvZG9tL2dsb2JhbC1jb25zdHJ1Y3RvcnMuaHRtbAorICAgICAg ICAgICAgICAgZmFzdC9kb20vWE1MSHR0cFJlcXVlc3QtY29uc3RhbnRzLmh0bWwKKyAgICAgICAg ICAgICAgIGZhc3QvZG9tL3htbGh0dHByZXF1ZXN0LWNvbnN0cnVjdG9yLWluLWRldGFjaGVkLWRv Y3VtZW50Lmh0bWwKKyAgICAgICAgICAgICAgIGh0dHAvdGVzdHMvc2VjdXJpdHkvY29va2llcy94 bWxodHRwcmVxdWVzdC5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU1hNTEh0dHBSZXF1 ZXN0Q3VzdG9tLmNwcDogUmVtb3ZlZCBhbiBYTUxIdHRwUmVxdWVzdCBjdXN0b20gY29uc3RydWN0 b3IuCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06IEN1cnJl bnRseSwgQ29kZUdlbmVyYXRvclY4LnBtIGdlbmVyYXRlcyBjb25zdHJ1Y3RvciBjb2RlIHdoZW5l dmVyIFtDb25zdHJ1Y3Rvcl0gaXMgc3BlY2lmaWVkLCBldmVuIGlmIFtWOEN1c3RvbUNvbnN0cnVj dG9yXSBpcyBzcGVjaWZpZWQuIFRoaXMgaXMgd3JvbmcuIFRoaXMgcGF0Y2ggZml4ZXMgdGhlIGNv bmRpdGlvbiB3aGVyZSB0aGUgY29uc3RydWN0b3IgY29kZSBpcyBnZW5lcmF0ZWQuCisgICAgICAg ICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdE9iai5jcHA6IFVwZGF0ZWQgYSBydW4t YmluZGluZy10ZXN0cyByZXN1bHQuCisgICAgICAgICogeG1sL1hNTEh0dHBSZXF1ZXN0Lmg6IEFk ZGVkIGEgbmVjZXNzYXJ5IGhlYWRlci4KKyAgICAgICAgKiB4bWwvWE1MSHR0cFJlcXVlc3QuaWRs OiBWOCBpcyBzdGlsbCB1c2luZyBhIGN1c3RvbSBjb25zdHJ1Y3Rvci4KKworMjAxMS0xMC0xNiAg S2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgU3VwcG9ydCBb Q29uc3RydWN0b3JdIElETCBmb3IgSlNDLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzAxMDEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvSlNYTUxIdHRwUmVxdWVzdEN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU1hNTEh0dHBSZXF1ZXN0Q3VzdG9tLmNwcAppbmRleCA2MmY2MTY5OThhOGU3OGZj ZTgwYjhkZTAyODRkMDcxODhlYzI2MDNkLi4wNzhiNGI1MDY3NGVkMDNiMTgyMmM3NTFkY2U2ZDVh NzFkYzdhMzgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1hNTEh0 dHBSZXF1ZXN0Q3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1hN TEh0dHBSZXF1ZXN0Q3VzdG9tLmNwcApAQCAtMjAzLDE1ICsyMDMsNCBAQCBKU1ZhbHVlIEpTWE1M SHR0cFJlcXVlc3Q6OnJlc3BvbnNlKEV4ZWNTdGF0ZSogZXhlYykgY29uc3QKICAgICByZXR1cm4g anNVbmRlZmluZWQoKTsKIH0KIAotRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBKU1hNTEh0 dHBSZXF1ZXN0Q29uc3RydWN0b3I6OmNvbnN0cnVjdEpTWE1MSHR0cFJlcXVlc3QoRXhlY1N0YXRl KiBleGVjKQotewotICAgIEpTWE1MSHR0cFJlcXVlc3RDb25zdHJ1Y3RvcioganNDb25zdHJ1Y3Rv ciA9IHN0YXRpY19jYXN0PEpTWE1MSHR0cFJlcXVlc3RDb25zdHJ1Y3Rvcio+KGV4ZWMtPmNhbGxl ZSgpKTsKLSAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0ID0ganNDb25zdHJ1Y3Rv ci0+c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpOwotICAgIGlmICghY29udGV4dCkKLSAgICAgICAg cmV0dXJuIHRocm93Vk1FcnJvcihleGVjLCBjcmVhdGVSZWZlcmVuY2VFcnJvcihleGVjLCAiWE1M SHR0cFJlcXVlc3QgY29uc3RydWN0b3IgYXNzb2NpYXRlZCBkb2N1bWVudCBpcyB1bmF2YWlsYWJs ZSIpKTsKLQotICAgIFJlZlB0cjxYTUxIdHRwUmVxdWVzdD4geG1sSHR0cFJlcXVlc3QgPSBYTUxI dHRwUmVxdWVzdDo6Y3JlYXRlKGNvbnRleHQpOwotICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUo Q1JFQVRFX0RPTV9XUkFQUEVSKGV4ZWMsIGpzQ29uc3RydWN0b3ItPmdsb2JhbE9iamVjdCgpLCBY TUxIdHRwUmVxdWVzdCwgeG1sSHR0cFJlcXVlc3QuZ2V0KCkpKTsKLX0KLQogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yVjgucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVH ZW5lcmF0b3JWOC5wbQppbmRleCA3MWFjZTZmYTljMmJkNjdhZmE5MDkxMzgyNTc3ZGJlZGEwODY5 NDRiLi4wMzBjZTU1ODRlZWQ5NGIxZGQ5ZjVjZWNkNjgyNzhkZDRlMWZjYzk3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAt MjE1Myw5ICsyMTUzLDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+ICR7Y2xhc3NOYW1lfTo6Y29u c3RydWN0b3JDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcmcKIH0KIAogRU5ECi0gICAg fQotCi0gICAgaWYgKCRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkNvbnN0cnVjdG9y In0pIHsKKyAgICB9IGVsc2lmICgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDYW5C ZUNvbnN0cnVjdGVkIn0gJiYgISgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJWOEN1 c3RvbUNvbnN0cnVjdG9yIn0gfHwgJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ3Vz dG9tQ29uc3RydWN0b3IifSkpIHsKICAgICAgICAgR2VuZXJhdGVDb25zdHJ1Y3RvckNhbGxiYWNr KCRkYXRhTm9kZS0+Y29uc3RydWN0b3IsICRkYXRhTm9kZSwgJGludGVyZmFjZU5hbWUpOwogICAg IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4 L1Y4VGVzdE9iai5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgv VjhUZXN0T2JqLmNwcAppbmRleCBiNDQyYTFlMGI3ZmNjODhhNjIxMjI0MTMwZTRmY2M5ZDg4OTg0 YjAxLi4wYThkYjM0Y2FkYzk2ZTZmZmI5MzkxODgwMjVjZWJhZWEzZDcwYWNlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0T2JqLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0T2JqLmNw cApAQCAtMTM4NiwyNCArMTM4Niw2IEBAIENPTVBJTEVfQVNTRVJUKDB4MDEgPT0gVGVzdE9iajo6 Q09OU1RfVkFMVUVfMTIsIFRlc3RPYmpFbnVtQ09OU1RfVkFMVUVfMTJJc1dyb25nCiBDT01QSUxF X0FTU0VSVCgwWDIwID09IFRlc3RPYmo6OkNPTlNUX1ZBTFVFXzEzLCBUZXN0T2JqRW51bUNPTlNU X1ZBTFVFXzEzSXNXcm9uZ1VzZURvbnRDaGVja0VudW1zKTsKIENPTVBJTEVfQVNTRVJUKDB4MWFi YyA9PSBUZXN0T2JqOjpDT05TVF9WQUxVRV8xNCwgVGVzdE9iakVudW1DT05TVF9WQUxVRV8xNElz V3JvbmdVc2VEb250Q2hlY2tFbnVtcyk7CiAKLXY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOFRlc3RP Ymo6OmNvbnN0cnVjdG9yQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncykKLXsKLSAg ICBJTkNfU1RBVFMoIkRPTS5UZXN0T2JqLkNvbnN0cnVjdG9yIik7Ci0KLSAgICBpZiAoIWFyZ3Mu SXNDb25zdHJ1Y3RDYWxsKCkpCi0gICAgICAgIHJldHVybiB0aHJvd0Vycm9yKCJET00gb2JqZWN0 IGNvbnN0cnVjdG9yIGNhbm5vdCBiZSBjYWxsZWQgYXMgYSBmdW5jdGlvbi4iLCBWOFByb3h5OjpU eXBlRXJyb3IpOwotCi0gICAgaWYgKEFsbG93QWxsb2NhdGlvbjo6Y3VycmVudCgpKQotICAgICAg ICByZXR1cm4gYXJncy5Ib2xkZXIoKTsKLQotICAgIFJlZlB0cjxUZXN0T2JqPiBvYmogPSBUZXN0 T2JqOjpjcmVhdGUoKTsKLQotICAgIFY4RE9NV3JhcHBlcjo6c2V0RE9NV3JhcHBlcihhcmdzLkhv bGRlcigpLCAmaW5mbywgb2JqLmdldCgpKTsKLSAgICBvYmotPnJlZigpOwotICAgIFY4RE9NV3Jh cHBlcjo6c2V0SlNXcmFwcGVyRm9yRE9NT2JqZWN0KG9iai5nZXQoKSwgdjg6OlBlcnNpc3RlbnQ8 djg6Ok9iamVjdD46Ok5ldyhhcmdzLkhvbGRlcigpKSk7Ci0gICAgcmV0dXJuIGFyZ3MuSG9sZGVy KCk7Ci19Ci0KIHN0YXRpYyB2ODo6UGVyc2lzdGVudDx2ODo6RnVuY3Rpb25UZW1wbGF0ZT4gQ29u ZmlndXJlVjhUZXN0T2JqVGVtcGxhdGUodjg6OlBlcnNpc3RlbnQ8djg6OkZ1bmN0aW9uVGVtcGxh dGU+IGRlc2MpCiB7CiAgICAgZGVzYy0+UmVhZE9ubHlQcm90b3R5cGUoKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5oIGIvU291cmNlL1dlYkNvcmUveG1s L1hNTEh0dHBSZXF1ZXN0LmgKaW5kZXggYWU1MGI0ODE5NWI4NjAxMmM4YmM4NTBjOGZiZjQzMDZh YTY4ZWIzYy4uY2E3NjM1MzFkYjI5OGRlMmQ0MDQ0NTRkYzEyNTlkMzI5YTAxNjM0NiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmgKKysrIGIvU291cmNlL1dl YkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmgKQEAgLTI3LDYgKzI3LDcgQEAKICNpbmNsdWRlICJF dmVudFRhcmdldC5oIgogI2luY2x1ZGUgIkZvcm1EYXRhLmgiCiAjaW5jbHVkZSAiUmVzb3VyY2VS ZXNwb25zZS5oIgorI2luY2x1ZGUgIlNlY3VyaXR5T3JpZ2luLmgiCiAjaW5jbHVkZSAiVGhyZWFk YWJsZUxvYWRlckNsaWVudC5oIgogI2luY2x1ZGUgIlhNTEh0dHBSZXF1ZXN0UHJvZ3Jlc3NFdmVu dFRocm90dGxlLmgiCiAjaW5jbHVkZSA8d3RmL093blB0ci5oPgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmlkbCBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxI dHRwUmVxdWVzdC5pZGwKaW5kZXggZDRkMDZjODU2ZDM0NzVlNmQ1MzU2YTc0MjYxZDkxZDk0NzI4 NzNiYi4uNTRmZGY2MTgwYjVmYWNlMWM1ZDg5M2MyNGNmY2JmMWRhMzc0ZTUzNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmlkbAorKysgYi9Tb3VyY2UvV2Vi Q29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaWRsCkBAIC0zMSw3ICszMSw5IEBAIG1vZHVsZSB4bWwg ewogICAgIGludGVyZmFjZSBbCiAgICAgICAgIEFjdGl2ZURPTU9iamVjdCwKICAgICAgICAgQ2Fu QmVDb25zdHJ1Y3RlZCwKLSAgICAgICAgQ3VzdG9tQ29uc3RydWN0b3IsCisgICAgICAgIENvbnN0 cnVjdG9yLAorICAgICAgICBDYWxsV2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0LAorICAgICAg ICBWOEN1c3RvbUNvbnN0cnVjdG9yLAogICAgICAgICBDdXN0b21NYXJrRnVuY3Rpb24sCiAgICAg ICAgIEV2ZW50VGFyZ2V0LAogICAgICAgICBOb1N0YXRpY1RhYmxlcwo=