69801 2011-10-10 16:43:37 -0700 Regarding constructor, replace [ConstructorWith=...] IDL with [CallWith=...] IDL 2011-10-13 16:44:56 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 69799 65839 0 haraken webkit-unassigned abarth annacc dominicc sam webkit.review.bot oldest_to_newest 481288 0 haraken 2011-10-10 16:43:37 -0700 As for constructors, [ConstructorWith=...] has the same meaning as [CallWith=...]. We should deprecate [ConstructorWith=...]. This is a clean-up bug for the bug 65839. 481298 1 abarth 2011-10-10 16:56:39 -0700 @Kentaro: CallWith should also be the first arguments to the constructors, not the last as ConstructorWith appears to be. 481309 2 haraken 2011-10-10 17:08:07 -0700 abarth: There are two options. Deprecate [ConstructorWith=...] or deprecate [CallWith=...]. I first thought that deprecating [ConstructorWith=...] will make more sense, since [CallWith=...] is used here and there and I did not care the position of arguments. I want to keep the position of arguments of existing constructors as it is (i.e. the last). So, as for constructors, I would like to deprecate [CallWith=...]. 481322 3 abarth 2011-10-10 17:13:04 -0700 See also Bug 69799 > I want to keep the position of arguments of existing constructors as it is Why? 481341 4 haraken 2011-10-10 17:30:08 -0700 (In reply to comment #3) > > I want to keep the position of arguments of existing constructors as it is > > Why? Just because all the existing custom constructors that are using ScriptExecutionContext are putting it as the last argument. > See also Bug 69799 Ah, sorry, I noticed it now. I agree to it. Before uploading this patch, I will wait for the above patch landed. 483138 5 110832 haraken 2011-10-13 05:35:37 -0700 Created attachment 110832 Patch 483139 6 110833 haraken 2011-10-13 05:37:37 -0700 Created attachment 110833 Patch 483343 7 110833 abarth 2011-10-13 11:34:48 -0700 Comment on attachment 110833 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110833&action=review > Source/WebCore/ChangeLog:7 > + As for constructors, [ConstructorWith=...] has the same meaning as [CallWith=...]. > + We should deprecate [ConstructorWith=...]. This is a clean-up bug for the bug 65839. It's somewhat less obvious what CallWith means as an attribute of the whole interface. I guess it makes sense for JavaScript where the interface *is* the constructor, but it probably makes somewhat less sense for other languages. I still think this patch is a win though. > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1549 > - if ($dataNode->extendedAttributes->{"ConstructorWith"} && $dataNode->extendedAttributes->{"ConstructorWith"} eq "ScriptExecutionContext") { > + if ($dataNode->extendedAttributes->{"CallWith"} && $dataNode->extendedAttributes->{"CallWith"} eq "ScriptExecutionContext") { Do we not need a similar change to CodeGeneratorJSC.pm ? I guess all these interfaces have JSCustomConstructor. > Source/WebCore/fileapi/FileReader.idl:-41 > - ConstructorWith=ScriptExecutionContext, This doesn't need CallWith ? I guess not if we can compile without it. 483565 8 haraken 2011-10-13 15:37:40 -0700 (In reply to comment #7) > (From update of attachment 110833 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=110833&action=review > > > Source/WebCore/ChangeLog:7 > > + As for constructors, [ConstructorWith=...] has the same meaning as [CallWith=...]. > > + We should deprecate [ConstructorWith=...]. This is a clean-up bug for the bug 65839. > > It's somewhat less obvious what CallWith means as an attribute of the whole interface. I guess it makes sense for JavaScript where the interface *is* the constructor, but it probably makes somewhat less sense for other languages. I still think this patch is a win though. > > > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1549 > > - if ($dataNode->extendedAttributes->{"ConstructorWith"} && $dataNode->extendedAttributes->{"ConstructorWith"} eq "ScriptExecutionContext") { > > + if ($dataNode->extendedAttributes->{"CallWith"} && $dataNode->extendedAttributes->{"CallWith"} eq "ScriptExecutionContext") { > > Do we not need a similar change to CodeGeneratorJSC.pm ? I guess all these interfaces have JSCustomConstructor. No, because [ConstructorWith] is the IDL that I introduced when I implemented [Constructor] IDL for V8, in other words, [ConstructorWith] is not yet implemented in JSC. > > > Source/WebCore/fileapi/FileReader.idl:-41 > > - ConstructorWith=ScriptExecutionContext, > > This doesn't need CallWith ? I guess not if we can compile without it. It has CallWith. You can find it by clicking "20 below" link of FileReader.idl diff. I just removed ConstructorWith because FileReader.idl has both ConstructorWith and CallWith. Thanks for reviewing these patches, Adam! 483643 9 110833 webkit.review.bot 2011-10-13 16:44:51 -0700 Comment on attachment 110833 Patch Clearing flags on attachment: 110833 Committed r97424: <http://trac.webkit.org/changeset/97424> 483644 10 webkit.review.bot 2011-10-13 16:44:56 -0700 All reviewed patches have been landed. Closing bug. 110832 2011-10-13 05:35:37 -0700 2011-10-13 05:37:30 -0700 Patch bug-69801-20111013213536.patch text/plain 5145 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTczNjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxY2Y4OGI3YzA3Y2JiNDE5 YWVkNThhNDZkN2UyZTk4Y2RjM2JlNzM0Li43NjA1ZDJlM2MxMWY4MWQ0NWZiMDIyMDZkMmU5NTBm Zjg2NTFkNTU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMTAtMTMgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlZ2FyZGluZyBjb25z dHJ1Y3RvciwgcmVwbGFjZSBbQ29uc3RydWN0b3JXaXRoPS4uLl0gSURMIHdpdGggW0NhbGxXaXRo PS4uLl0gSURMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02OTgwMQorCisgICAgICAgIEFzIGZvciBjb25zdHJ1Y3RvcnMsIFtDb25zdHJ1Y3RvcldpdGg9 Li4uXSBoYXMgdGhlIHNhbWUgbWVhbmluZyBhcyBbQ2FsbFdpdGg9Li4uXS4gV2Ugc2hvdWxkIGRl cHJlY2F0ZSBbQ29uc3RydWN0b3JXaXRoPS4uLl0uIFRoaXMgaXMgYSBjbGVhbi11cCBidWcgZm9y IHRoZSBidWcgNjU4MzkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBzaW5jZSBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAg ICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbTogUmVwbGFjZWQgW0Nv bnN0cnVjdG9yV2l0aD0uLi5dIElETCB3aXRoIFtDYWxsV2l0aD0uLi5dIElETC4KKyAgICAgICAg KEdlbmVyYXRlQ29uc3RydWN0b3JDYWxsYmFjayk6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0 cy90ZXN0L1Rlc3RJbnRlcmZhY2UuaWRsOiBEaXR0by4KKyAgICAgICAgKiBmaWxlYXBpL0ZpbGVS ZWFkZXIuaWRsOiBEaXR0by4KKyAgICAgICAgKiBwMnAvUGVlckNvbm5lY3Rpb24uaWRsOiBEaXR0 by4KKyAgICAgICAgKiBwYWdlL0V2ZW50U291cmNlLmlkbDogRGl0dG8uCisgICAgICAgICogd29y a2Vycy9Xb3JrZXIuaWRsOiBEaXR0by4KKwogMjAxMS0xMC0xMyAgTWlraGFpbCBOYWdhbm92ICA8 bW5hZ2Fub3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtDaHJvbWl1 bV0gQWRkIGFuIGFiaWxpdHkgdG8gbG9vayB1cCBhbmQgZXhwbG9yZSBhbiBvYmplY3QgZnJvbSBh IGhlYXAgcHJvZmlsZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yVjgucG0KaW5kZXggYTI3NmEzNGM5OTc0YjE3ZWFkZTc1YzFmYzRjMjgzY2Y3 MTEyODM0NS4uZjZmNTE1ZjI3YWIzY2M5MTU3NWEwMmI4ZmI2YWQ0MmU1ODM5NTY3NiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0K KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0K QEAgLTE1NDYsNyArMTU0Niw3IEBAIEVORAogICAgIHB1c2goQGltcGxDb250ZW50LCAkcGFyYW1l dGVyQ2hlY2tTdHJpbmcpOwogCiAgICAgbXkgQGNvbnRleHRBcmd1bWVudDsKLSAgICBpZiAoJGRh dGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ29uc3RydWN0b3JXaXRoIn0gJiYgJGRhdGFO b2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ29uc3RydWN0b3JXaXRoIn0gZXEgIlNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQiKSB7CisgICAgaWYgKCRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVz LT57IkNhbGxXaXRoIn0gJiYgJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ2FsbFdp dGgifSBlcSAiU2NyaXB0RXhlY3V0aW9uQ29udGV4dCIpIHsKICAgICAgICAgcHVzaChAY29udGV4 dEFyZ3VtZW50LCAiY29udGV4dCIpOwogICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgPDxFTkQp OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVz dEludGVyZmFjZS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVz dEludGVyZmFjZS5pZGwKaW5kZXggNzQ3NGRhY2QwMDg4MWZlNGI3NzZkYjlmY2Q1NmExMWRiMTBl Y2E0Yy4uYjYxZDJhYWIxNjNmY2RiZGQwYWZhM2QxOGQ3NmM1NjgyZWY5ZjA5NiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RJbnRlcmZhY2UuaWRs CisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0SW50ZXJmYWNl LmlkbApAQCAtMzQsNyArMzQsNiBAQCBtb2R1bGUgdGVzdCB7CiAgICAgICAgIENhbkJlQ29uc3Ry dWN0ZWQsCiAgICAgICAgIENhbGxXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsCiAgICAgICAg IENvbnN0cnVjdG9yKGluIERPTVN0cmluZyBzdHIxLCBpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZh dWx0VmFsdWVdIERPTVN0cmluZyBzdHIyKSwKLSAgICAgICAgQ29uc3RydWN0b3JXaXRoPVNjcmlw dEV4ZWN1dGlvbkNvbnRleHQsCiAgICAgICAgIFY4Q29uc3RydWN0b3JTZXRzQWN0aXZlRE9NV3Jh cHBlciwKICAgICAgICAgQ29uc3RydWN0b3JSYWlzZXNFeGNlcHRpb24KICAgICBdIFRlc3RJbnRl cmZhY2UgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9GaWxlUmVhZGVyLmlk bCBiL1NvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvRmlsZVJlYWRlci5pZGwKaW5kZXggYWE5OGIwOWU4 MmJkMDAwZDY0ZTc4MjQ5YTVlNmIzMzk2MjZjNzdjYS4uYzYxNGVjOWMzNmRlMjlhMWU2MDRjN2Mw YjJkNzNmMmIzNWRiNjA0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9GaWxl UmVhZGVyLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL0ZpbGVSZWFkZXIuaWRsCkBA IC0zOCw3ICszOCw2IEBAIG1vZHVsZSBodG1sIHsKICAgICAgICAgRXZlbnRUYXJnZXQsCiAgICAg ICAgIE5vU3RhdGljVGFibGVzLAogICAgICAgICBDb25zdHJ1Y3RvciwKLSAgICAgICAgQ29uc3Ry dWN0b3JXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsCiAgICAgICAgIFY4Q29uc3RydWN0b3JT ZXRzQWN0aXZlRE9NV3JhcHBlcgogICAgIF0gRmlsZVJlYWRlciB7CiAgICAgICAgIC8vIHJlYWR5 IHN0YXRlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcDJwL1BlZXJDb25uZWN0aW9uLmlk bCBiL1NvdXJjZS9XZWJDb3JlL3AycC9QZWVyQ29ubmVjdGlvbi5pZGwKaW5kZXggNzM4ODI0YWJk OTQ1Y2Q2YjM1NTc1MzgwOWVmZmQ3NDgxN2NkODA3MS4uNzgyMjFlY2I4ODc4NTk2Yzk3YWMxMmUy YjgzNDliNTY0NmY2MWJjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcDJwL1BlZXJDb25u ZWN0aW9uLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wMnAvUGVlckNvbm5lY3Rpb24uaWRsCkBA IC0zMCw3ICszMCw3IEBAIG1vZHVsZSBwMnAgewogICAgICAgICBDYW5CZUNvbnN0cnVjdGVkLAog ICAgICAgICBDb25zdHJ1Y3RvclBhcmFtZXRlcnM9MiwKICAgICAgICAgQ29uc3RydWN0b3IoaW4g RE9NU3RyaW5nIHNlcnZlckNvbmZpZ3VyYXRpb24sIGluIFtDYWxsYmFjaz1GdW5jdGlvbk9ubHld IFNpZ25hbGluZ0NhbGxiYWNrIHNpZ25hbGluZ0NhbGxiYWNrKSwKLSAgICAgICAgQ29uc3RydWN0 b3JXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsCisgICAgICAgIENhbGxXaXRoPVNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQsCiAgICAgICAgIEpTQ3VzdG9tQ29uc3RydWN0b3IsCiAgICAgICAgIFY4 Q29uc3RydWN0b3JTZXRzQWN0aXZlRE9NV3JhcHBlciwKICAgICAgICAgRXZlbnRUYXJnZXQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRTb3VyY2UuaWRsIGIvU291cmNlL1dl YkNvcmUvcGFnZS9FdmVudFNvdXJjZS5pZGwKaW5kZXggZTI1MDAwYzM2MjdmZGRhODMyNTdmYmJk Y2M3YTczYTNhMWJkNTBmMS4uMWE4YTg1ZmZjNDg4ZWZkOTgzNTlmZmJiZjU1OWI2M2JmMWUxZTc5 NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudFNvdXJjZS5pZGwKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9FdmVudFNvdXJjZS5pZGwKQEAgLTM3LDcgKzM3LDcgQEAgbW9k dWxlIHdpbmRvdyB7CiAgICAgICAgIEpTQ3VzdG9tQ29uc3RydWN0b3IsCiAgICAgICAgIENvbnN0 cnVjdG9yUGFyYW1ldGVycz0xLAogICAgICAgICBDb25zdHJ1Y3RvcihpbiBET01TdHJpbmcgc2Ny aXB0VXJsKSwKLSAgICAgICAgQ29uc3RydWN0b3JXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQs CisgICAgICAgIENhbGxXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsCiAgICAgICAgIENvbnN0 cnVjdG9yUmFpc2VzRXhjZXB0aW9uLAogICAgICAgICBWOENvbnN0cnVjdG9yU2V0c0FjdGl2ZURP TVdyYXBwZXIsCiAgICAgICAgIEV2ZW50VGFyZ2V0LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvd29ya2Vycy9Xb3JrZXIuaWRsIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXIuaWRs CmluZGV4IDhjNTljMGE3MDFlZGI1NGMzYjgyODBiNzViZDlkNjBlYWRlZDI0YzYuLjA4OGRiOGU4 NDZiYTk1OTU2MzgyOThkZjIwNmUzNGFlZDY4Yjg3OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3dvcmtlcnMvV29ya2VyLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtl ci5pZGwKQEAgLTM0LDcgKzM0LDcgQEAgbW9kdWxlIHRocmVhZHMgewogICAgICAgICBKU0N1c3Rv bUNvbnN0cnVjdG9yLAogICAgICAgICBDb25zdHJ1Y3RvclBhcmFtZXRlcnM9MSwKICAgICAgICAg Q29uc3RydWN0b3IoaW4gRE9NU3RyaW5nIHNjcmlwdFVybCksCi0gICAgICAgIENvbnN0cnVjdG9y V2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0LAorICAgICAgICBDYWxsV2l0aD1TY3JpcHRFeGVj dXRpb25Db250ZXh0LAogICAgICAgICBDb25zdHJ1Y3RvclJhaXNlc0V4Y2VwdGlvbiwKICAgICAg ICAgVjhDb25zdHJ1Y3RvclNldHNBY3RpdmVET01XcmFwcGVyLAogICAgICAgICBHZW5lcmF0ZU5h dGl2ZUNvbnZlcnRlciwK 110833 2011-10-13 05:37:37 -0700 2011-10-13 16:44:51 -0700 Patch bug-69801-20111013213736.patch text/plain 5154 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTczNjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxY2Y4OGI3YzA3Y2JiNDE5 YWVkNThhNDZkN2UyZTk4Y2RjM2JlNzM0Li45MDEzZTk1MTNjNzVkZGE1ZTEyY2Y3NWE5N2VhN2Nm NDQ3ZGY1ZTZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMTAtMTMgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlZ2FyZGluZyBjb25z dHJ1Y3RvciwgcmVwbGFjZSBbQ29uc3RydWN0b3JXaXRoPS4uLl0gSURMIHdpdGggW0NhbGxXaXRo PS4uLl0gSURMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02OTgwMQorCisgICAgICAgIEFzIGZvciBjb25zdHJ1Y3RvcnMsIFtDb25zdHJ1Y3RvcldpdGg9 Li4uXSBoYXMgdGhlIHNhbWUgbWVhbmluZyBhcyBbQ2FsbFdpdGg9Li4uXS4KKyAgICAgICAgV2Ug c2hvdWxkIGRlcHJlY2F0ZSBbQ29uc3RydWN0b3JXaXRoPS4uLl0uIFRoaXMgaXMgYSBjbGVhbi11 cCBidWcgZm9yIHRoZSBidWcgNjU4MzkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBzaW5jZSBubyBjaGFuZ2UgaW4gYmVoYXZp b3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbTogUmVw bGFjZWQgW0NvbnN0cnVjdG9yV2l0aD0uLi5dIElETCB3aXRoIFtDYWxsV2l0aD0uLi5dIElETC4K KyAgICAgICAgKEdlbmVyYXRlQ29uc3RydWN0b3JDYWxsYmFjayk6CisgICAgICAgICogYmluZGlu Z3Mvc2NyaXB0cy90ZXN0L1Rlc3RJbnRlcmZhY2UuaWRsOiBEaXR0by4KKyAgICAgICAgKiBmaWxl YXBpL0ZpbGVSZWFkZXIuaWRsOiBEaXR0by4KKyAgICAgICAgKiBwMnAvUGVlckNvbm5lY3Rpb24u aWRsOiBEaXR0by4KKyAgICAgICAgKiBwYWdlL0V2ZW50U291cmNlLmlkbDogRGl0dG8uCisgICAg ICAgICogd29ya2Vycy9Xb3JrZXIuaWRsOiBEaXR0by4KKwogMjAxMS0xMC0xMyAgTWlraGFpbCBO YWdhbm92ICA8bW5hZ2Fub3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IFtDaHJvbWl1bV0gQWRkIGFuIGFiaWxpdHkgdG8gbG9vayB1cCBhbmQgZXhwbG9yZSBhbiBvYmpl Y3QgZnJvbSBhIGhlYXAgcHJvZmlsZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggYTI3NmEzNGM5OTc0YjE3ZWFkZTc1YzFm YzRjMjgzY2Y3MTEyODM0NS4uZjZmNTE1ZjI3YWIzY2M5MTU3NWEwMmI4ZmI2YWQ0MmU1ODM5NTY3 NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9yVjgucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9yVjgucG0KQEAgLTE1NDYsNyArMTU0Niw3IEBAIEVORAogICAgIHB1c2goQGltcGxDb250ZW50 LCAkcGFyYW1ldGVyQ2hlY2tTdHJpbmcpOwogCiAgICAgbXkgQGNvbnRleHRBcmd1bWVudDsKLSAg ICBpZiAoJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ29uc3RydWN0b3JXaXRoIn0g JiYgJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ29uc3RydWN0b3JXaXRoIn0gZXEg IlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQiKSB7CisgICAgaWYgKCRkYXRhTm9kZS0+ZXh0ZW5kZWRB dHRyaWJ1dGVzLT57IkNhbGxXaXRoIn0gJiYgJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMt PnsiQ2FsbFdpdGgifSBlcSAiU2NyaXB0RXhlY3V0aW9uQ29udGV4dCIpIHsKICAgICAgICAgcHVz aChAY29udGV4dEFyZ3VtZW50LCAiY29udGV4dCIpOwogICAgICAgICBwdXNoKEBpbXBsQ29udGVu dCwgPDxFTkQpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L3Rlc3QvVGVzdEludGVyZmFjZS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L3Rlc3QvVGVzdEludGVyZmFjZS5pZGwKaW5kZXggNzQ3NGRhY2QwMDg4MWZlNGI3NzZkYjlmY2Q1 NmExMWRiMTBlY2E0Yy4uYjYxZDJhYWIxNjNmY2RiZGQwYWZhM2QxOGQ3NmM1NjgyZWY5ZjA5NiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RJbnRl cmZhY2UuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0 SW50ZXJmYWNlLmlkbApAQCAtMzQsNyArMzQsNiBAQCBtb2R1bGUgdGVzdCB7CiAgICAgICAgIENh bkJlQ29uc3RydWN0ZWQsCiAgICAgICAgIENhbGxXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQs CiAgICAgICAgIENvbnN0cnVjdG9yKGluIERPTVN0cmluZyBzdHIxLCBpbiBbT3B0aW9uYWw9Q2Fs bFdpdGhEZWZhdWx0VmFsdWVdIERPTVN0cmluZyBzdHIyKSwKLSAgICAgICAgQ29uc3RydWN0b3JX aXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsCiAgICAgICAgIFY4Q29uc3RydWN0b3JTZXRzQWN0 aXZlRE9NV3JhcHBlciwKICAgICAgICAgQ29uc3RydWN0b3JSYWlzZXNFeGNlcHRpb24KICAgICBd IFRlc3RJbnRlcmZhY2UgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9GaWxl UmVhZGVyLmlkbCBiL1NvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvRmlsZVJlYWRlci5pZGwKaW5kZXgg YWE5OGIwOWU4MmJkMDAwZDY0ZTc4MjQ5YTVlNmIzMzk2MjZjNzdjYS4uYzYxNGVjOWMzNmRlMjlh MWU2MDRjN2MwYjJkNzNmMmIzNWRiNjA0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZmls ZWFwaS9GaWxlUmVhZGVyLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL0ZpbGVSZWFk ZXIuaWRsCkBAIC0zOCw3ICszOCw2IEBAIG1vZHVsZSBodG1sIHsKICAgICAgICAgRXZlbnRUYXJn ZXQsCiAgICAgICAgIE5vU3RhdGljVGFibGVzLAogICAgICAgICBDb25zdHJ1Y3RvciwKLSAgICAg ICAgQ29uc3RydWN0b3JXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsCiAgICAgICAgIFY4Q29u c3RydWN0b3JTZXRzQWN0aXZlRE9NV3JhcHBlcgogICAgIF0gRmlsZVJlYWRlciB7CiAgICAgICAg IC8vIHJlYWR5IHN0YXRlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcDJwL1BlZXJDb25u ZWN0aW9uLmlkbCBiL1NvdXJjZS9XZWJDb3JlL3AycC9QZWVyQ29ubmVjdGlvbi5pZGwKaW5kZXgg NzM4ODI0YWJkOTQ1Y2Q2YjM1NTc1MzgwOWVmZmQ3NDgxN2NkODA3MS4uNzgyMjFlY2I4ODc4NTk2 Yzk3YWMxMmUyYjgzNDliNTY0NmY2MWJjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcDJw L1BlZXJDb25uZWN0aW9uLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wMnAvUGVlckNvbm5lY3Rp b24uaWRsCkBAIC0zMCw3ICszMCw3IEBAIG1vZHVsZSBwMnAgewogICAgICAgICBDYW5CZUNvbnN0 cnVjdGVkLAogICAgICAgICBDb25zdHJ1Y3RvclBhcmFtZXRlcnM9MiwKICAgICAgICAgQ29uc3Ry dWN0b3IoaW4gRE9NU3RyaW5nIHNlcnZlckNvbmZpZ3VyYXRpb24sIGluIFtDYWxsYmFjaz1GdW5j dGlvbk9ubHldIFNpZ25hbGluZ0NhbGxiYWNrIHNpZ25hbGluZ0NhbGxiYWNrKSwKLSAgICAgICAg Q29uc3RydWN0b3JXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsCisgICAgICAgIENhbGxXaXRo PVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsCiAgICAgICAgIEpTQ3VzdG9tQ29uc3RydWN0b3IsCiAg ICAgICAgIFY4Q29uc3RydWN0b3JTZXRzQWN0aXZlRE9NV3JhcHBlciwKICAgICAgICAgRXZlbnRU YXJnZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRTb3VyY2UuaWRsIGIv U291cmNlL1dlYkNvcmUvcGFnZS9FdmVudFNvdXJjZS5pZGwKaW5kZXggZTI1MDAwYzM2MjdmZGRh ODMyNTdmYmJkY2M3YTczYTNhMWJkNTBmMS4uMWE4YTg1ZmZjNDg4ZWZkOTgzNTlmZmJiZjU1OWI2 M2JmMWUxZTc5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudFNvdXJjZS5p ZGwKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudFNvdXJjZS5pZGwKQEAgLTM3LDcgKzM3 LDcgQEAgbW9kdWxlIHdpbmRvdyB7CiAgICAgICAgIEpTQ3VzdG9tQ29uc3RydWN0b3IsCiAgICAg ICAgIENvbnN0cnVjdG9yUGFyYW1ldGVycz0xLAogICAgICAgICBDb25zdHJ1Y3RvcihpbiBET01T dHJpbmcgc2NyaXB0VXJsKSwKLSAgICAgICAgQ29uc3RydWN0b3JXaXRoPVNjcmlwdEV4ZWN1dGlv bkNvbnRleHQsCisgICAgICAgIENhbGxXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsCiAgICAg ICAgIENvbnN0cnVjdG9yUmFpc2VzRXhjZXB0aW9uLAogICAgICAgICBWOENvbnN0cnVjdG9yU2V0 c0FjdGl2ZURPTVdyYXBwZXIsCiAgICAgICAgIEV2ZW50VGFyZ2V0LApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXIuaWRsIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9X b3JrZXIuaWRsCmluZGV4IDhjNTljMGE3MDFlZGI1NGMzYjgyODBiNzViZDlkNjBlYWRlZDI0YzYu LjA4OGRiOGU4NDZiYTk1OTU2MzgyOThkZjIwNmUzNGFlZDY4Yjg3OGMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3Jr ZXJzL1dvcmtlci5pZGwKQEAgLTM0LDcgKzM0LDcgQEAgbW9kdWxlIHRocmVhZHMgewogICAgICAg ICBKU0N1c3RvbUNvbnN0cnVjdG9yLAogICAgICAgICBDb25zdHJ1Y3RvclBhcmFtZXRlcnM9MSwK ICAgICAgICAgQ29uc3RydWN0b3IoaW4gRE9NU3RyaW5nIHNjcmlwdFVybCksCi0gICAgICAgIENv bnN0cnVjdG9yV2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0LAorICAgICAgICBDYWxsV2l0aD1T Y3JpcHRFeGVjdXRpb25Db250ZXh0LAogICAgICAgICBDb25zdHJ1Y3RvclJhaXNlc0V4Y2VwdGlv biwKICAgICAgICAgVjhDb25zdHJ1Y3RvclNldHNBY3RpdmVET01XcmFwcGVyLAogICAgICAgICBH ZW5lcmF0ZU5hdGl2ZUNvbnZlcnRlciwK