69603 2011-10-06 23:04:02 -0700 Change enum value names for TextTrack::readyState and TextTrack::mode 2011-10-07 01:10:59 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 69460 1 annacc annacc webkit.review.bot oldest_to_newest 479812 0 annacc 2011-10-06 23:04:02 -0700 I think these names are conflicting with a Windows #define. See this error: http://build.webkit.org/builders/Chromium%20Win%20Release/builds/32643/steps/compile-webkit/logs/stdio 479814 1 110093 annacc 2011-10-06 23:07:14 -0700 Created attachment 110093 Patch 479863 2 110093 webkit.review.bot 2011-10-07 01:10:55 -0700 Comment on attachment 110093 Patch Clearing flags on attachment: 110093 Committed r96914: <http://trac.webkit.org/changeset/96914> 479864 3 webkit.review.bot 2011-10-07 01:10:59 -0700 All reviewed patches have been landed. Closing bug. 110093 2011-10-06 23:07:14 -0700 2011-10-07 01:10:55 -0700 Patch bug-69603-20111006230713.patch text/plain 3532 annacc U3VidmVyc2lvbiBSZXZpc2lvbjogOTY5MDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhYjUwNDc5Yzc4MzQyMWE0 OTcwM2Q1YjBiNzJlMmZmM2NmYzVkOGUxLi5lYmJjNTc1YzE3M2ZkNjJjZDliZGNjMzk0NzZkMjZh MTg1MTc2YzM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMTAtMDYgIEFubmEg Q2F2ZW5kZXIgIDxhbm5hY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENoYW5nZSBlbnVtIHZh bHVlIG5hbWVzIGZvciBUZXh0VHJhY2s6OnJlYWR5U3RhdGUgYW5kIFRleHRUcmFjazo6bW9kZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk2MDMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMuIE5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogaHRtbC9Mb2FkYWJsZVRleHRU cmFjay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMb2FkYWJsZVRleHRUcmFjazo6dHJhY2tMb2Fk U3RhcnRlZCk6CisgICAgICAgIChXZWJDb3JlOjpMb2FkYWJsZVRleHRUcmFjazo6dHJhY2tMb2Fk RXJyb3IpOgorICAgICAgICAoV2ViQ29yZTo6TG9hZGFibGVUZXh0VHJhY2s6OnRyYWNrTG9hZENv bXBsZXRlZCk6CisgICAgICAgICogaHRtbC9UZXh0VHJhY2suY3BwOgorICAgICAgICAoV2ViQ29y ZTo6VGV4dFRyYWNrOjpUZXh0VHJhY2spOgorICAgICAgICAoV2ViQ29yZTo6VGV4dFRyYWNrOjpz ZXRNb2RlKToKKyAgICAgICAgKiBodG1sL1RleHRUcmFjay5oOgorCiAyMDExLTEwLTA2ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByOTY4OTYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s L0xvYWRhYmxlVGV4dFRyYWNrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTG9hZGFibGVUZXh0 VHJhY2suY3BwCmluZGV4IDRlYjI0ODVjNGI1MDZkYmU4ODExMmEyNzM4OWZmOWZlMzRhOTgzMTku LjczNjc2YWJhYzM4NzFlNDI1ZjU1MGNhMWVhNTIxNGUzZGE5ZjVlNWMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvTG9hZGFibGVUZXh0VHJhY2suY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvTG9hZGFibGVUZXh0VHJhY2suY3BwCkBAIC01OCwxNyArNTgsMTcgQEAgdm9pZCBM b2FkYWJsZVRleHRUcmFjazo6bmV3Q3Vlc1BhcnNlZCgpCiAKIHZvaWQgTG9hZGFibGVUZXh0VHJh Y2s6OnRyYWNrTG9hZFN0YXJ0ZWQoKQogewotICAgIHNldFJlYWR5U3RhdGUoVGV4dFRyYWNrOjpM T0FESU5HKTsKKyAgICBzZXRSZWFkeVN0YXRlKFRleHRUcmFjazo6TG9hZGluZyk7CiB9CiAKIHZv aWQgTG9hZGFibGVUZXh0VHJhY2s6OnRyYWNrTG9hZEVycm9yKCkKIHsKLSAgICBzZXRSZWFkeVN0 YXRlKFRleHRUcmFjazo6RVJST1IpOworICAgIHNldFJlYWR5U3RhdGUoVGV4dFRyYWNrOjpFcnJv cik7CiB9CiAKIHZvaWQgTG9hZGFibGVUZXh0VHJhY2s6OnRyYWNrTG9hZENvbXBsZXRlZCgpCiB7 Ci0gICAgc2V0UmVhZHlTdGF0ZShUZXh0VHJhY2s6OkxPQURFRCk7CisgICAgc2V0UmVhZHlTdGF0 ZShUZXh0VHJhY2s6OkxvYWRlZCk7CiB9CiAKIHZvaWQgTG9hZGFibGVUZXh0VHJhY2s6Om5ld0N1 ZXNMb2FkZWQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0VHJhY2suY3Bw IGIvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0VHJhY2suY3BwCmluZGV4IGNiMGIwNDZkNTRiZmNj MTI0YzNjODIwNDgxOTk4OGFkY2EyYjg5NjAuLjIzMmExM2U5ZTE0YzVkNWIyNTEzMTlmZmI5Mzk5 OWJkOTcxMjEwMGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dFRyYWNrLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRUcmFjay5jcHAKQEAgLTQyLDggKzQyLDgg QEAgVGV4dFRyYWNrOjpUZXh0VHJhY2soY29uc3QgU3RyaW5nJiBraW5kLCBjb25zdCBTdHJpbmcm IGxhYmVsLCBjb25zdCBTdHJpbmcmIGxhbmcKICAgICA6IG1fa2luZChraW5kKQogICAgICwgbV9s YWJlbChsYWJlbCkKICAgICAsIG1fbGFuZ3VhZ2UobGFuZ3VhZ2UpCi0gICAgLCBtX3JlYWR5U3Rh dGUoVGV4dFRyYWNrOjpOT05FKQotICAgICwgbV9tb2RlKFRleHRUcmFjazo6U0hPV0lORykKKyAg ICAsIG1fcmVhZHlTdGF0ZShUZXh0VHJhY2s6Ok5vbmUpCisgICAgLCBtX21vZGUoVGV4dFRyYWNr OjpTaG93aW5nKQogewogfQogCkBAIC04NSw3ICs4NSw3IEBAIHZvaWQgVGV4dFRyYWNrOjpzZXRN b2RlKHVuc2lnbmVkIHNob3J0IG1vZGUsIEV4Y2VwdGlvbkNvZGUmIGVjKQogewogICAgIC8vIDQu OC4xMC4xMi41IE9uIHNldHRpbmcgdGhlIG1vZGUsIGlmIHRoZSBuZXcgdmFsdWUgaXMgbm90IGVp dGhlciAwLCAxLCBvciAyLAogICAgIC8vIHRoZSB1c2VyIGFnZW50IG11c3QgdGhyb3cgYW4gSU5W QUxJRF9BQ0NFU1NfRVJSIGV4Y2VwdGlvbi4KLSAgICBpZiAobW9kZSA9PSBUZXh0VHJhY2s6Ok9G RiB8fCBtb2RlID09IFRleHRUcmFjazo6SElEREVOIHx8IG1vZGUgPT0gVGV4dFRyYWNrOjpTSE9X SU5HKQorICAgIGlmIChtb2RlID09IFRleHRUcmFjazo6T2ZmIHx8IG1vZGUgPT0gVGV4dFRyYWNr OjpIaWRkZW4gfHwgbW9kZSA9PSBUZXh0VHJhY2s6OlNob3dpbmcpCiAgICAgICAgIG1fbW9kZSA9 IHN0YXRpY19jYXN0PE1vZGU+KG1vZGUpOwogICAgIGVsc2UKICAgICAgICAgZWMgPSBJTlZBTElE X0FDQ0VTU19FUlI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRUcmFjay5o IGIvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0VHJhY2suaAppbmRleCA5YTgyZjgzZWUxZjcyZGFl ZDZjNjJjMTAwYjViNTQwNzM4MTBmZmEyLi44YzNjNjYzY2NhNDQ1NzU5YzJjNjI1OTI2YWQ1ZWM5 NjY5NDI3NmRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRUcmFjay5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dFRyYWNrLmgKQEAgLTU4LDEwICs1OCwxMCBAQCBw dWJsaWM6CiAgICAgU3RyaW5nIGxhYmVsKCkgY29uc3Q7CiAgICAgU3RyaW5nIGxhbmd1YWdlKCkg Y29uc3Q7CiAKLSAgICBlbnVtIFJlYWR5U3RhdGUgeyBOT05FLCBMT0FESU5HLCBMT0FERUQsIEVS Uk9SIH07CisgICAgZW51bSBSZWFkeVN0YXRlIHsgTm9uZSwgTG9hZGluZywgTG9hZGVkLCBFcnJv ciB9OwogICAgIFJlYWR5U3RhdGUgcmVhZHlTdGF0ZSgpIGNvbnN0OwogCi0gICAgZW51bSBNb2Rl IHsgT0ZGID0gMCwgSElEREVOID0gMSwgU0hPV0lORyA9IDIgfTsKKyAgICBlbnVtIE1vZGUgeyBP ZmYgPSAwLCBIaWRkZW4gPSAxLCBTaG93aW5nID0gMiB9OwogICAgIE1vZGUgbW9kZSgpIGNvbnN0 OwogICAgIHZvaWQgc2V0TW9kZSh1bnNpZ25lZCBzaG9ydCwgRXhjZXB0aW9uQ29kZSYpOwogCg==