69408 2011-10-05 02:02:02 -0700 WebSocket: Add extensions attribute 2011-10-05 20:36:51 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 50099 1 yutak yutak abarth ap joenotcharles tkent webkit.review.bot oldest_to_newest 478234 0 yutak 2011-10-05 02:02:02 -0700 Implement WebSocket's .extensions attribute. This attribute should always return an empty string, as no protocol extensions are supported for now. http://dev.w3.org/html5/websockets/#the-websocket-interface interface WebSocket { ... readonly attribute DOMString extensions; ... }; Chromium bug: http://code.google.com/p/chromium/issues/detail?id=99142 478285 1 109776 yutak 2011-10-05 05:21:17 -0700 Created attachment 109776 Patch 478884 2 109776 tkent 2011-10-05 19:29:26 -0700 Comment on attachment 109776 Patch Looks good. 478912 3 109776 webkit.review.bot 2011-10-05 20:36:47 -0700 Comment on attachment 109776 Patch Clearing flags on attachment: 109776 Committed r96785: <http://trac.webkit.org/changeset/96785> 478913 4 webkit.review.bot 2011-10-05 20:36:51 -0700 All reviewed patches have been landed. Closing bug. 109776 2011-10-05 05:21:17 -0700 2011-10-05 20:36:47 -0700 Patch bug-69408-20111005212116.patch text/plain 7353 yutak U3VidmVyc2lvbiBSZXZpc2lvbjogOTY2NTAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjM2EzOWJmNTQyNmUzZmRlY2I3Yzhh ZGFjNWY1YzcyYWI4YzMzYWViLi5jMGY2Yzc1NWJhMTk1ZGRjYTM5NmE4Y2IwN2IxMmFlZDYyNmI2 MzljIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTAtMDUgIFl1dGEgS2l0YW11cmEgIDx5 dXRha0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViU29ja2V0OiBBZGQgZXh0ZW5zaW9ucyBh dHRyaWJ1dGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY5NDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oaXhpZTc2L3VuZGVmaW5lZC1hdHRyaWJ1dGVz LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oaXhp ZTc2L3VuZGVmaW5lZC1hdHRyaWJ1dGVzLmh0bWw6CisgICAgICAgIEFkZGVkICJleHRlbnNpb25z IiBhdHRyaWJ1dGUgdG8gdGhlIGxpc3QgYmVjYXVzZSBpdCBzaG91bGRuJ3QgYmUgZGVmaW5lZAor ICAgICAgICB3aGVuIGhpeGllLTc2IHByb3RvY29sIGlzIHVzZWQuCisgICAgICAgICogaHR0cC90 ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaHliaS9leHRlbnNpb25zLWV4cGVjdGVkLnR4dDogQWRkZWQu CisgICAgICAgICogaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaHliaS9leHRlbnNpb25zLmh0 bWw6CisgICAgICAgIEFkZGVkLiBUZXN0IHdoZXRoZXIgLmV4dGVuc2lvbnMgYXR0cmlidXRlIGFs d2F5cyByZXR1cm5zIGFuIGVtcHR5IHN0cmluZy4KKwogMjAxMS0xMC0wNCAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVwZGF0ZSBYUCByZXN1bHRzIGZvciB0aGUg Zm9udCBzaGFwaW5nIHBhdGNoLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93 ZWJzb2NrZXQvdGVzdHMvaGl4aWU3Ni91bmRlZmluZWQtYXR0cmlidXRlcy1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oaXhpZTc2L3VuZGVmaW5l ZC1hdHRyaWJ1dGVzLWV4cGVjdGVkLnR4dAppbmRleCA0MDI2M2VmM2VkMTRkN2E3YTgzODMxODRi MDhjMTdiNTZhMTEzNzNkLi5iNjU3NzNmMmEzNzFmMWU1Zjg2OTYyNThjMGFkMGY3ZTM1ODA1ZTI1 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oaXhp ZTc2L3VuZGVmaW5lZC1hdHRyaWJ1dGVzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oaXhpZTc2L3VuZGVmaW5lZC1hdHRyaWJ1dGVzLWV4 cGVjdGVkLnR4dApAQCAtMyw2ICszLDcgQEAgVGVzdCBXZWJTb2NrZXQgYXR0cmlidXRlcyB3aGlj aCBzaG91bGQgbm90IGJlIGRlZmluZWQgd2hlbiBoaXhpZS03NiBwcm90b2NvbCBpcwogT24gc3Vj Y2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQg YnkgIlRFU1QgQ09NUExFVEUiLgogCiBQQVNTIHdzLmJpbmFyeVR5cGUgaXMgdW5kZWZpbmVkLgor UEFTUyB3cy5leHRlbnNpb25zIGlzIHVuZGVmaW5lZC4KIFBBU1Mgd3MucHJvdG9jb2wgaXMgdW5k ZWZpbmVkLgogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oaXhpZTc2L3VuZGVmaW5lZC1h dHRyaWJ1dGVzLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9o aXhpZTc2L3VuZGVmaW5lZC1hdHRyaWJ1dGVzLmh0bWwKaW5kZXggM2E5ZjY1NjYwOGExOTBmOTA2 NWU3YmQyMzJmYTc3MTExNmU3MDNhOC4uOTg1YTdhMjg4YjAxOWUxYjdmMzg3NzgwMDY2ZTNiNjVj OGE4M2RlNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVz dHMvaGl4aWU3Ni91bmRlZmluZWQtYXR0cmlidXRlcy5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2hpeGllNzYvdW5kZWZpbmVkLWF0dHJpYnV0ZXMuaHRt bApAQCAtMTMsNiArMTMsNyBAQCBkZXNjcmlwdGlvbigiVGVzdCBXZWJTb2NrZXQgYXR0cmlidXRl cyB3aGljaCBzaG91bGQgbm90IGJlIGRlZmluZWQgd2hlbiBoaXhpZS03NgogdmFyIHdzID0gbmV3 IFdlYlNvY2tldCgid3M6Ly8xMjcuMC4wLjE6ODg4MC93ZWJzb2NrZXQvdGVzdHMvaGl4aWU3Ni9z aW1wbGUiKTsKIAogc2hvdWxkQmVVbmRlZmluZWQoIndzLmJpbmFyeVR5cGUiKTsKK3Nob3VsZEJl VW5kZWZpbmVkKCJ3cy5leHRlbnNpb25zIik7CiBzaG91bGRCZVVuZGVmaW5lZCgid3MucHJvdG9j b2wiKTsKIAogdmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJpL2V4dGVuc2lvbnMtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaHliaS9leHRl bnNpb25zLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mNWQwMGM4ZDQwYTdiYmQ2MzExNWM3ODZi NmY0MmFkNzFjMjBjZTdiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy93ZWJzb2NrZXQvdGVzdHMvaHliaS9leHRlbnNpb25zLWV4cGVjdGVkLnR4dApAQCAtMCwwICsx LDEwIEBACitUZXN0IFdlYlNvY2tldC5leHRlbnNpb25zIGF0dHJpYnV0ZS4KKworT24gc3VjY2Vz cywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkg IlRFU1QgQ09NUExFVEUiLgorCitQQVNTIHdzLmV4dGVuc2lvbnMgaXMgIiIKK1BBU1Mgd3MuZXh0 ZW5zaW9ucyBpcyAiIgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENP TVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rl c3RzL2h5YmkvZXh0ZW5zaW9ucy5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJzb2Nr ZXQvdGVzdHMvaHliaS9leHRlbnNpb25zLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uY2RjNWI0ZTNmNTYxNzQ0 MmI0NmZjNWJlOTYyM2QwZmJiOTg0YzAxMAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvZXh0ZW5zaW9ucy5odG1sCkBAIC0wLDAg KzEsMjcgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5 bGVzaGVldCIgaHJlZj0iLi4vLi4vLi4vLi4vanMtdGVzdC1yZXNvdXJjZXMvanMtdGVzdC1zdHls ZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uLy4uL2pzLXRlc3QtcmVzb3VyY2VzL2pzLXRl c3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPGRpdiBpZD0iZGVzY3JpcHRp b24iPjwvZGl2PgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0PgorZGVzY3JpcHRp b24oIlRlc3QgV2ViU29ja2V0LmV4dGVuc2lvbnMgYXR0cmlidXRlLiIpOworCitpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLm92ZXJyaWRl UHJlZmVyZW5jZSgiV2ViS2l0SGl4aWU3NldlYlNvY2tldFByb3RvY29sRW5hYmxlZCIsIDApOwor Cit2YXIgd3MgPSBuZXcgV2ViU29ja2V0KCJ3czovL2xvY2FsaG9zdDo4ODgwL3dlYnNvY2tldC90 ZXN0cy9oeWJpL3NpbXBsZSIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJ3cy5leHRlbnNpb25z IiwgIiIpOworCisvLyBleHRlbnNpb25zIGF0dHJpYnV0ZSBpcyByZWFkLW9ubHkuCit3cy5leHRl bnNpb25zID0gImZvbyI7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoIndzLmV4dGVuc2lvbnMiLCAi Iik7CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0 IHNyYz0iLi4vLi4vLi4vLi4vanMtdGVzdC1yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Nj cmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1YmRmOWIyMzNjZTI5ZDYzZGY0 YTI4YzcyMGVkZjliMDU4MTA5YjE4Li41MDQ3NjdiZTdlMjgxNTAzYTM5NGYyYjU1ZGEzYWI1NDVj NTFiMThlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMTAtMDUgIFl1dGEgS2l0 YW11cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViU29ja2V0OiBBZGQgZXh0 ZW5zaW9ucyBhdHRyaWJ1dGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY5NDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkIFdlYlNvY2tldCdzICJleHRlbnNpb25zIiBhdHRyaWJ1dGUgYXMgc3BlY2lm aWVkIGluIHRoZSBXZWJTb2NrZXQgQVBJCisgICAgICAgIDxodHRwOi8vZGV2LnczLm9yZy9odG1s NS93ZWJzb2NrZXRzLyN0aGUtd2Vic29ja2V0LWludGVyZmFjZT4uCisKKyAgICAgICAgV2ViU29j a2V0IHByb3RvY29sIGV4dGVuc2lvbiBpcyBub3QgaW1wbGVtZW50ZWQgYXQgYWxsLCB0aHVzIHRo aXMgYXR0cmlidXRlCisgICAgICAgIGFsd2F5cyByZXR1cm5zIGFuIGVtcHR5IHN0cmluZy4KKwor ICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJpL2V4dGVuc2lvbnMu aHRtbAorICAgICAgICAgICAgICBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oaXhpZTc2L3Vu ZGVmaW5lZC1hdHRyaWJ1dGVzLmh0bWwgKHVwZGF0ZWQpCisKKyAgICAgICAgKiB3ZWJzb2NrZXRz L1dlYlNvY2tldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJTb2NrZXQ6OmV4dGVuc2lvbnMp OgorICAgICAgICBJZiB0aGUgaGl4aWUtNzYgcHJvdG9jb2wgaXMgY2hvc2VuLCB3ZSBuZWVkIHRv IHJldHVybiAidW5kZWZpbmVkIiBpbiBvcmRlciB0bworICAgICAgICBrZWVwIGJlaGF2aW9yIG9m IHRoZSBwb3J0cyB3aGljaCBoYXZlIG5vdCB1c2VkIHRoZSBuZXdlciBoeWJpIHByb3RvY29sIHll dC4KKyAgICAgICAgKiB3ZWJzb2NrZXRzL1dlYlNvY2tldC5oOgorICAgICAgICAqIHdlYnNvY2tl dHMvV2ViU29ja2V0LmlkbDoKKwogMjAxMS0xMC0wNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJz Y2FAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeGVzIGZvciBldmVyeW9uZS4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0LmNwcAppbmRleCA5YWZhOTU3NTg3YmY4OWJlYzE0 MDYzZTYyZTA0ZWNhNmE0OWFkNmM0Li45ZTBmNzM1ZTRkNDYxZTE4MjY4NDkxZGNkOGI3MTkxNDU2 YTM3MDcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXQuY3BwCkBAIC0zNjks NiArMzY5LDE0IEBAIFN0cmluZyBXZWJTb2NrZXQ6OnByb3RvY29sKCkgY29uc3QKICAgICByZXR1 cm4gbV9zdWJwcm90b2NvbDsKIH0KIAorU3RyaW5nIFdlYlNvY2tldDo6ZXh0ZW5zaW9ucygpIGNv bnN0Cit7CisgICAgaWYgKG1fdXNlSGl4aWU3NlByb3RvY29sKQorICAgICAgICByZXR1cm4gU3Ry aW5nKCk7CisgICAgLy8gV2ViU29ja2V0IHByb3RvY29sIGV4dGVuc2lvbiBpcyBub3Qgc3VwcG9y dGVkIHlldC4KKyAgICByZXR1cm4gIiI7Cit9CisKIFN0cmluZyBXZWJTb2NrZXQ6OmJpbmFyeVR5 cGUoKSBjb25zdAogewogICAgIGlmIChtX3VzZUhpeGllNzZQcm90b2NvbCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0LmggYi9Tb3VyY2UvV2ViQ29yZS93 ZWJzb2NrZXRzL1dlYlNvY2tldC5oCmluZGV4IGM2MjFlM2QxNzU5MzI0ZjA1MmI2YTEyMjQ1YWYy NTAzNzRmNTk5MmIuLjE5MzI1NzFmYWFkZDJiYmJkMjhiMDljYTRmZDJlOWM5YmIwYjU0NzIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0LmgKKysrIGIvU291 cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXQuaApAQCAtNzksNiArNzksNyBAQCBwdWJs aWM6CiAgICAgdW5zaWduZWQgbG9uZyBidWZmZXJlZEFtb3VudCgpIGNvbnN0OwogCiAgICAgU3Ry aW5nIHByb3RvY29sKCkgY29uc3Q7CisgICAgU3RyaW5nIGV4dGVuc2lvbnMoKSBjb25zdDsKIAog ICAgIFN0cmluZyBiaW5hcnlUeXBlKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRCaW5hcnlUeXBlKGNv bnN0IFN0cmluZyYgYmluYXJ5VHlwZSwgRXhjZXB0aW9uQ29kZSYpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXQuaWRsIGIvU291cmNlL1dlYkNvcmUvd2Vi c29ja2V0cy9XZWJTb2NrZXQuaWRsCmluZGV4IGRmMjBiYTZlYzkzZjk5YmUxYzQ4ZDA1ZGY1YWE0 YjYwZDk4MzVlZDIuLjMwNTFkZDhhNzY4MzY0NTJjOTAxMTk0ZTk5ZGY5ZDlkYjYzYzQxMjEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0LmlkbAorKysgYi9T b3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldC5pZGwKQEAgLTU5LDYgKzU5LDcgQEAg bW9kdWxlIHdlYnNvY2tldHMgewogICAgICAgICBhdHRyaWJ1dGUgRXZlbnRMaXN0ZW5lciBvbmNs b3NlOwogCiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBbQ29udmVydE51bGxTdHJpbmdUbz1V bmRlZmluZWRdIERPTVN0cmluZyBwcm90b2NvbDsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRl IFtDb252ZXJ0TnVsbFN0cmluZ1RvPVVuZGVmaW5lZF0gRE9NU3RyaW5nIGV4dGVuc2lvbnM7CiAK ICAgICAgICAgYXR0cmlidXRlIFtDb252ZXJ0TnVsbFN0cmluZ1RvPVVuZGVmaW5lZF0gRE9NU3Ry aW5nIGJpbmFyeVR5cGUKICAgICAgICAgICAgIHNldHRlciByYWlzZXMoRE9NRXhjZXB0aW9uKTsK