69011 2011-09-28 11:41:51 -0700 FTPDirectoryDocument Shows Garbled String for Last Modified Date 2011-09-28 13:46:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned joepeck webkit.review.bot oldest_to_newest 474869 0 joepeck 2011-09-28 11:41:51 -0700 Opening ftp://ftp.oracle.com in a browser that uses WebCore's FTPDirectoryDocument was including a semi-garbage incorrect string for the Last Modified Date. It looks like this was due to a change that removed some string corrosion and accidentally introduced pointer arithmetic: http://trac.webkit.org/changeset/86542/trunk/Source/WebCore/html/FTPDirectoryDocument.cpp dateString = months[month] + ' ' + String::number(fileTime.tm_mday) + ", " + String::number(fileTime.tm_year); The first two pieces are (char* + char) instead of the desired (WTF::String + char) and result in an unexpected prefix for dateString. Patch to follow. 474872 1 joepeck 2011-09-28 11:44:24 -0700 Typo, I meant: "coercion". 474877 2 109043 joepeck 2011-09-28 11:57:06 -0700 Created attachment 109043 [PATCH] Proposed Fix I also switched from + ' ' to + " " which would have caused a compiler issue and help catch this earlier, but if you want we can switch that space back to a char. The important part was to force the first expr to be a WTF::String. 474953 3 109043 webkit.review.bot 2011-09-28 13:17:42 -0700 Comment on attachment 109043 [PATCH] Proposed Fix Clearing flags on attachment: 109043 Committed r96253: <http://trac.webkit.org/changeset/96253> 474954 4 webkit.review.bot 2011-09-28 13:17:46 -0700 All reviewed patches have been landed. Closing bug. 474979 5 joepeck 2011-09-28 13:46:05 -0700 <rdar://problem/10173710> 109043 2011-09-28 11:57:06 -0700 2011-09-28 13:17:42 -0700 [PATCH] Proposed Fix ftp-fix.patch text/plain 1590 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2NzQxZjNjLi4yNmQzYjg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDktMjggIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKwor ICAgICAgICBGVFBEaXJlY3RvcnlEb2N1bWVudCBTaG93cyBHYXJibGVkIFN0cmluZyBmb3IgTGFz dCBNb2RpZmllZCBEYXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02OTAxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZvcmNlIFdURjo6U3RyaW5nIGNvbmNhdGVuYXRpb24gaW5zdGVhZCBvZiBhbiBhY2Np ZGVudGFsIGNoYXIqIHBvaW50ZXIgYWRkaXRpb24uCisKKyAgICAgICAgKiBodG1sL0ZUUERpcmVj dG9yeURvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnByb2Nlc3NGaWxlRGF0ZVN0cmlu Zyk6CisKIDIwMTEtMDktMjggIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAg ICAgICBDU1AgZG9lc24ndCB3b3JrIGZvciBhIHdpZGUgdmFyaWV0eSBvZiBjYXNlcwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9GVFBEaXJlY3RvcnlEb2N1bWVudC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0ZUUERpcmVjdG9yeURvY3VtZW50LmNwcAppbmRleCBkZGJhODFmLi43 MzlhOGYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0ZUUERpcmVjdG9yeURvY3Vt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ZUUERpcmVjdG9yeURvY3VtZW50LmNw cApAQCAtMjUzLDkgKzI1Myw5IEBAIHN0YXRpYyBTdHJpbmcgcHJvY2Vzc0ZpbGVEYXRlU3RyaW5n KGNvbnN0IEZUUFRpbWUmIGZpbGVUaW1lKQogICAgIFN0cmluZyBkYXRlU3RyaW5nOwogCiAgICAg aWYgKGZpbGVUaW1lLnRtX3llYXIgPiAtMSkKLSAgICAgICAgZGF0ZVN0cmluZyA9IG1vbnRoc1tt b250aF0gKyAnICcgKyBTdHJpbmc6Om51bWJlcihmaWxlVGltZS50bV9tZGF5KSArICIsICIgKyBT dHJpbmc6Om51bWJlcihmaWxlVGltZS50bV95ZWFyKTsKKyAgICAgICAgZGF0ZVN0cmluZyA9IFN0 cmluZyhtb250aHNbbW9udGhdKSArICIgIiArIFN0cmluZzo6bnVtYmVyKGZpbGVUaW1lLnRtX21k YXkpICsgIiwgIiArIFN0cmluZzo6bnVtYmVyKGZpbGVUaW1lLnRtX3llYXIpOwogICAgIGVsc2UK LSAgICAgICAgZGF0ZVN0cmluZyA9IG1vbnRoc1ttb250aF0gKyAnICcgKyBTdHJpbmc6Om51bWJl cihmaWxlVGltZS50bV9tZGF5KSArICIsICIgKyBTdHJpbmc6Om51bWJlcihub3cudG1feWVhcik7 CisgICAgICAgIGRhdGVTdHJpbmcgPSBTdHJpbmcobW9udGhzW21vbnRoXSkgKyAiICIgKyBTdHJp bmc6Om51bWJlcihmaWxlVGltZS50bV9tZGF5KSArICIsICIgKyBTdHJpbmc6Om51bWJlcihub3cu dG1feWVhcik7CiAKICAgICByZXR1cm4gZGF0ZVN0cmluZyArIHRpbWVPZkRheTsKIH0K