68976 2011-09-27 23:58:20 -0700 watchlist: Suggest corrections for typos and improve error message consistency. 2011-09-28 10:27:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 68822 1 levin levin abarth eric webkit.review.bot oldest_to_newest 474546 0 levin 2011-09-27 23:58:20 -0700 See summary. 474552 1 108974 levin 2011-09-28 00:08:00 -0700 Created attachment 108974 Patch 474816 2 108974 webkit.review.bot 2011-09-28 10:27:13 -0700 Comment on attachment 108974 Patch Clearing flags on attachment: 108974 Committed r96232: <http://trac.webkit.org/changeset/96232> 474817 3 webkit.review.bot 2011-09-28 10:27:17 -0700 All reviewed patches have been landed. Closing bug. 108974 2011-09-28 00:08:00 -0700 2011-09-28 10:27:13 -0700 Patch bug-68976-20110928000758.patch text/plain 5882 levin U3VidmVyc2lvbiBSZXZpc2lvbjogOTYxOTEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyMzdiMGYxYjZjNWQ1NzI3MjBlOGExYTRmOTc0ODQ2Yzg3 MWVlYTRlLi5lYmRkMjdjMmNhZDAxNDQ0ODU5MTM0MDA0NzA2ZjQ1MDU1ZThiZWU2IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDktMjcgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIHdhdGNobGlzdDogU3VnZ2VzdCBjb3JyZWN0aW9ucyBmb3IgdHlwb3MgYW5kIGltcHJvdmUg ZXJyb3IgbWVzc2FnZSBjb25zaXN0ZW5jeS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTY4OTc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi93YXRjaGxpc3Qvd2F0 Y2hsaXN0cGFyc2VyLnB5OiBBZGQgc3VnZ2VzdGlvbnMKKyAgICAgICAgZm9yIHR5cG9zIGFuZCBp bXByb3ZlIGNvbnNpc3RlbmN5IG9mIHRoZSBlcnJvciBtZXNzYWdlcy4KKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi93YXRjaGxpc3Qvd2F0Y2hsaXN0cGFyc2VyX3VuaXR0ZXN0LnB5 OiBBZGQgdGVzdHMKKyAgICAgICAgYW5kIGltcHJvdmUgdGhlIHJlZ2V4IHRoYXQgd2VyZSBhbHJl YWR5IHByZXNlbnQuCisKIDIwMTEtMDktMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KIAogICAgICAgICBnYXJkZW4tby1tYXRpYyBzaG91bGQgbG9hZCBmYXN0ZXIgYW5kIGluZm9y bSB0aGUgdXNlciB3aGF0IGlzIGhhcHBlbmluZwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9jb21tb24vd2F0Y2hsaXN0L3dhdGNobGlzdHBhcnNlci5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL3dhdGNobGlzdC93YXRjaGxpc3RwYXJzZXIucHkKaW5kZXggZjNj YzExODU2N2ExMTcwYjllZmUxNmNhZTJjMGI5ZjcwMTlhMWYwYS4uZTYyZGIyY2ZlMzE0ZDU5OTg1 NjdkZTEwMTcwMzM1NzQ4N2YyY2M5MCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vd2F0Y2hsaXN0L3dhdGNobGlzdHBhcnNlci5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi93YXRjaGxpc3Qvd2F0Y2hsaXN0cGFyc2VyLnB5CkBAIC0yNiw2ICsy Niw3IEBACiAjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4g QU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQogIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklT RUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCitpbXBvcnQgZGlmZmxpYgog aW1wb3J0IHJlCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi53YXRjaGxpc3Qud2F0Y2hsaXN0IGltcG9y dCBXYXRjaExpc3QKIGZyb20gd2Via2l0cHkuY29tbW9uLndhdGNobGlzdC5maWxlbmFtZXBhdHRl cm4gaW1wb3J0IEZpbGVuYW1lUGF0dGVybgpAQCAtNTYsNyArNTcsOSBAQCBjbGFzcyBXYXRjaExp c3RQYXJzZXIob2JqZWN0KToKICAgICAgICAgZm9yIHNlY3Rpb24gaW4gZGljdGlvbmFyeToKICAg ICAgICAgICAgIHBhcnNlciA9IHNlbGYuX3NlY3Rpb25fcGFyc2Vycy5nZXQoc2VjdGlvbikKICAg ICAgICAgICAgIGlmIG5vdCBwYXJzZXI6Ci0gICAgICAgICAgICAgICAgcmFpc2UgRXhjZXB0aW9u KCdVbmtub3duIHNlY3Rpb24gIiVzIiBpbiB3YXRjaCBsaXN0LicgJSBzZWN0aW9uKQorICAgICAg ICAgICAgICAgIHJhaXNlIEV4Y2VwdGlvbigoJ1Vua25vd24gc2VjdGlvbiAiJXMiIGluIHdhdGNo IGxpc3QuJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKyBzZWxmLl9zdWdnZXN0 X3dvcmRzKHNlY3Rpb24sIHNlbGYuX3NlY3Rpb25fcGFyc2Vycy5rZXlzKCkpKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAlIHNlY3Rpb24pCiAgICAgICAgICAgICBwYXJzZXIoZGlj dGlvbmFyeVtzZWN0aW9uXSwgd2F0Y2hfbGlzdCkKIAogICAgICAgICByZXR1cm4gd2F0Y2hfbGlz dApAQCAtNjQsNiArNjcsMTIgQEAgY2xhc3MgV2F0Y2hMaXN0UGFyc2VyKG9iamVjdCk6CiAgICAg ZGVmIF9ldmFsX3dhdGNoX2xpc3Qoc2VsZiwgd2F0Y2hfbGlzdF9jb250ZW50cyk6CiAgICAgICAg IHJldHVybiBldmFsKHdhdGNoX2xpc3RfY29udGVudHMsIHsnX19idWlsdGluc19fJzogTm9uZX0s IE5vbmUpCiAKKyAgICBkZWYgX3N1Z2dlc3Rfd29yZHMoc2VsZiwgaW52YWxpZF93b3JkLCB2YWxp ZF93b3Jkcyk6CisgICAgICAgIGNsb3NlX21hdGNoZXMgPSBkaWZmbGliLmdldF9jbG9zZV9tYXRj aGVzKGludmFsaWRfd29yZCwgdmFsaWRfd29yZHMpCisgICAgICAgIGlmIG5vdCBjbG9zZV9tYXRj aGVzOgorICAgICAgICAgICAgcmV0dXJuICcnCisgICAgICAgIHJldHVybiAnXG5cblBlcmhhcHMg aXQgc2hvdWxkIGJlICVzLicgJSAoJyBvciAnLmpvaW4oY2xvc2VfbWF0Y2hlcykpCisKICAgICBk ZWYgX3BhcnNlX2RlZmluaXRpb25fc2VjdGlvbihzZWxmLCBkZWZpbml0aW9uX3NlY3Rpb24sIHdh dGNoX2xpc3QpOgogICAgICAgICBkZWZpbml0aW9ucyA9IHt9CiAgICAgICAgIGZvciBuYW1lIGlu IGRlZmluaXRpb25fc2VjdGlvbjoKQEAgLTc2LDcgKzg1LDkgQEAgY2xhc3MgV2F0Y2hMaXN0UGFy c2VyKG9iamVjdCk6CiAgICAgICAgICAgICBmb3IgcGF0dGVybl90eXBlIGluIGRlZmluaXRpb246 CiAgICAgICAgICAgICAgICAgcGF0dGVybl9wYXJzZXIgPSBzZWxmLl9kZWZpbml0aW9uX3BhdHRl cm5fcGFyc2Vycy5nZXQocGF0dGVybl90eXBlKQogICAgICAgICAgICAgICAgIGlmIG5vdCBwYXR0 ZXJuX3BhcnNlcjoKLSAgICAgICAgICAgICAgICAgICAgcmFpc2UgRXhjZXB0aW9uKCdJbnZhbGlk IHBhdHRlcm4gdHlwZSAiJXMiIGluIGRlZmluaXRpb24gIiVzIi4nICUgKHBhdHRlcm5fdHlwZSwg bmFtZSkpCisgICAgICAgICAgICAgICAgICAgIHJhaXNlIEV4Y2VwdGlvbigoJ1Vua25vd24gcGF0 dGVybiB0eXBlICIlcyIgaW4gZGVmaW5pdGlvbiAiJXMiLicKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICArIHNlbGYuX3N1Z2dlc3Rfd29yZHMocGF0dGVybl90eXBlLCBzZWxm Ll9kZWZpbml0aW9uX3BhdHRlcm5fcGFyc2Vycy5rZXlzKCkpKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJSAocGF0dGVybl90eXBlLCBuYW1lKSkKIAogICAgICAgICAgICAg ICAgIHBhdHRlcm4gPSBwYXR0ZXJuX3BhcnNlcihkZWZpbml0aW9uW3BhdHRlcm5fdHlwZV0pCiAg ICAgICAgICAgICAgICAgZGVmaW5pdGlvbnNbbmFtZV0uYXBwZW5kKHBhdHRlcm4pCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi93YXRjaGxpc3Qvd2F0Y2hsaXN0cGFy c2VyX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vd2F0Y2hsaXN0 L3dhdGNobGlzdHBhcnNlcl91bml0dGVzdC5weQppbmRleCBlMGE0Mzk0NjlhMzAyNTA1Y2VlM2My ODNhZjBhM2Y1YTA3NGNhNjc1Li4xNzhlYTM2ZDgxOWZhNTgzMjNkNjAyZWJjZmJjNjY0NTBiNzYx YzQ4IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi93YXRjaGxpc3Qv d2F0Y2hsaXN0cGFyc2VyX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL3dhdGNobGlzdC93YXRjaGxpc3RwYXJzZXJfdW5pdHRlc3QucHkKQEAgLTUzLDYgKzUz LDEyIEBAIGNsYXNzIFdhdGNoTGlzdFBhcnNlclRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAg ICAgICBzZWxmLmFzc2VydFJhaXNlc1JlZ2V4cCgnVW5rbm93biBzZWN0aW9uICJGT08iIGluIHdh dGNoIGxpc3QuJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5fd2F0Y2hf bGlzdF9wYXJzZXIucGFyc2UsIHdhdGNoX2xpc3Rfd2l0aF9iYWRfc2VjdGlvbikKIAorICAgIGRl ZiB0ZXN0X3NlY3Rpb25fdHlwbyhzZWxmKToKKyAgICAgICAgd2F0Y2hfbGlzdF93aXRoX2JhZF9z ZWN0aW9uID0gKCd7IkRFRklOVElPTlMiOiB7fX0nKQorICAgICAgICBzZWxmLmFzc2VydFJhaXNl c1JlZ2V4cChyJ1Vua25vd24gc2VjdGlvbiAiREVGSU5USU9OUyIgaW4gd2F0Y2ggbGlzdFwuXHMq JworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKyByJ1BlcmhhcHMgaXQgc2hvdWxkIGJl IERFRklOSVRJT05TXC4nLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxmLl93 YXRjaF9saXN0X3BhcnNlci5wYXJzZSwgd2F0Y2hfbGlzdF93aXRoX2JhZF9zZWN0aW9uKQorCiAg ICAgZGVmIHRlc3RfYmFkX2RlZmluaXRpb24oc2VsZik6CiAgICAgICAgIHdhdGNoX2xpc3Rfd2l0 aF9iYWRfZGVmaW5pdGlvbiA9ICgKICAgICAgICAgICAgICd7JwpAQCAtNjMsNyArNjksNyBAQCBj bGFzcyBXYXRjaExpc3RQYXJzZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgICAg ICcgICAgIH0sJwogICAgICAgICAgICAgJ30nKQogCi0gICAgICAgIHNlbGYuX3ZlcmlmeUV4Y2Vw dGlvbignSW52YWxpZCBjaGFyYWN0ZXIgInwiIGluIGRlZmluaXRpb24gIldhdGNoTGlzdDF8QSIu JywKKyAgICAgICAgc2VsZi5fdmVyaWZ5RXhjZXB0aW9uKHInSW52YWxpZCBjaGFyYWN0ZXIgIlx8 IiBpbiBkZWZpbml0aW9uICJXYXRjaExpc3QxXHxBIlwuJywKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHNlbGYuX3dhdGNoX2xpc3RfcGFyc2VyLnBhcnNlLCB3YXRjaF9saXN0X3dpdGhf YmFkX2RlZmluaXRpb24pCiAKICAgICBkZWYgdGVzdF9iYWRfbWF0Y2hfdHlwZShzZWxmKToKQEAg LTc2LDUgKzgyLDE5IEBAIGNsYXNzIFdhdGNoTGlzdFBhcnNlclRlc3QodW5pdHRlc3QuVGVzdENh c2UpOgogICAgICAgICAgICAgJyAgICAgfSwnCiAgICAgICAgICAgICAnfScpCiAKLSAgICAgICAg c2VsZi5fdmVyaWZ5RXhjZXB0aW9uKCdJbnZhbGlkIHBhdHRlcm4gdHlwZSAibm90aGluZ19tYXRj aGVzX3RoaXMiIGluIGRlZmluaXRpb24gIldhdGNoTGlzdDEiLicsCisgICAgICAgIHNlbGYuX3Zl cmlmeUV4Y2VwdGlvbignVW5rbm93biBwYXR0ZXJuIHR5cGUgIm5vdGhpbmdfbWF0Y2hlc190aGlz IiBpbiBkZWZpbml0aW9uICJXYXRjaExpc3QxIi4nLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgc2VsZi5fd2F0Y2hfbGlzdF9wYXJzZXIucGFyc2UsIHdhdGNoX2xpc3Rfd2l0aF9iYWRf bWF0Y2hfdHlwZSkKKworICAgIGRlZiB0ZXN0X21hdGNoX3R5cGVfdHlwbyhzZWxmKToKKyAgICAg ICAgd2F0Y2hfbGlzdF93aXRoX2JhZF9tYXRjaF90eXBlID0gKAorICAgICAgICAgICAgJ3snCisg ICAgICAgICAgICAnICAgICJERUZJTklUSU9OUyI6IHsnCisgICAgICAgICAgICAnICAgICAgICAi V2F0Y2hMaXN0MSI6IHsnCisgICAgICAgICAgICAnICAgICAgICAgICAgImlmbGVuYW1lIjogciIu KlxcTXlGaWxlTmFtZVxcLmNwcCIsJworICAgICAgICAgICAgJyAgICAgICAgfSwnCisgICAgICAg ICAgICAnICAgICB9LCcKKyAgICAgICAgICAgICd9JykKKworICAgICAgICBzZWxmLl92ZXJpZnlF eGNlcHRpb24ocidVbmtub3duIHBhdHRlcm4gdHlwZSAiaWZsZW5hbWUiIGluIGRlZmluaXRpb24g IldhdGNoTGlzdDEiXC5ccyonCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICArIHInUGVy aGFwcyBpdCBzaG91bGQgYmUgZmlsZW5hbWVcLicsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBzZWxmLl93YXRjaF9saXN0X3BhcnNlci5wYXJzZSwgd2F0Y2hfbGlzdF93aXRoX2JhZF9t YXRjaF90eXBlKQo=