68867 2011-09-26 22:05:54 -0700 [EFL] Remove *void* parameter in internal functions 2011-10-12 18:56:23 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68209 1 gyuyoung.kim gyuyoung.kim gyuyoung.kim leandro lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 473674 0 gyuyoung.kim 2011-09-26 22:05:54 -0700 As one among efforts which are more compliant with WebKit coding style, we need to remove *void* parameter in internal functions. But, it looks we need to discuss to remove *void* parameter in public functions further. 473806 1 lucas.de.marchi 2011-09-27 02:36:13 -0700 (In reply to comment #0) > As one among efforts which are more compliant with WebKit coding style, we need to remove *void* parameter in internal functions. But, it looks we need to discuss to remove *void* parameter in public functions further. We *can't* remove void on public headers. Please, do it only for internal ones. 474467 2 108956 gyuyoung.kim 2011-09-27 20:46:58 -0700 Created attachment 108956 Patch 474468 3 gyuyoung.kim 2011-09-27 20:47:59 -0700 Ok, this patch is only related to internal functions. 474486 4 108956 lucas.de.marchi 2011-09-27 21:44:43 -0700 Comment on attachment 108956 Patch informal r+ 474682 5 108956 webkit.review.bot 2011-09-28 05:34:27 -0700 Comment on attachment 108956 Patch Clearing flags on attachment: 108956 Committed r96217: <http://trac.webkit.org/changeset/96217> 474683 6 webkit.review.bot 2011-09-28 05:34:31 -0700 All reviewed patches have been landed. Closing bug. 108956 2011-09-27 20:46:58 -0700 2011-09-28 05:34:27 -0700 Patch bug-68867-20110928124657.patch text/plain 3074 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogOTYxNzkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBmZTFiOTAyOGIz YzU0ZTRhOGFmNjRmNWM2NjhkZGMxYzEyZGViYTc5Li5mMWE0MTc3NDRlZDc1ODdhNWQ5N2NjZGUw OWM3ZmRiYzUwOTNmOTEwIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEt MDktMjcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAg ICBbRUZMXSBSZW1vdmUgKnZvaWQqIHBhcmFtZXRlciBpbiBpbnRlcm5hbCBmdW5jdGlvbnMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4ODY3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXMgYSBzdGVwIHRv IGxldCBld2sgYmUgY29tcGxpYW50IHdpdGggd2Via2l0IGNvZGluZyBzdHlsZSwKKyAgICAgICAg d2UgbmVlZCB0byByZW1vdmUgKnZvaWQqIHBhcmFtZXRlciBpbiBpbnRlcm5hbCBmdW5jdGlvbnMu CisKKyAgICAgICAgKiBld2svZXdrX3ByaXZhdGUuaDoKKyAgICAgICAgKiBld2svZXdrX3NldHRp bmdzLmNwcDoKKyAgICAgICAgKGV3a19zZXR0aW5nc193ZWJfZGF0YWJhc2VfZGVmYXVsdF9xdW90 YV9nZXQpOgorICAgICAgICAqIGV3ay9ld2tfdXRpbC5jcHA6CisgICAgICAgIChld2tfdXRpbF9k cGlfZ2V0KToKKwogMjAxMS0wOS0yNyAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8a3Vib0Bwcm9m dXNpb24ubW9iaT4KIAogICAgICAgICBbRUZMXSBNYWtlIGV3a192aWV3IGVtaXQgdGhlICJsb2Fk LGRvY3VtZW50LGZpbmlzaGVkIiBzaWduYWwuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9ld2svZXdrX3ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5o CmluZGV4IGZjODJiYTA0ODNhNDY1OWJjN2Y4MDg5ZjVmMmFlNWViNmQ0YmNlZjUuLmYzODk5YmRl N2YxMmZkY2FhZDFjYjZmYjY3ZmE1YWQ0MDU1MmU0MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf cHJpdmF0ZS5oCkBAIC0xNDYsNyArMTQ2LDcgQEAgYm9vbCBld2tfdmlld19mb2N1c19jYW5fY3lj bGUoRXZhc19PYmplY3QgKm8sIEV3a19Gb2N1c19EaXJlY3Rpb24gZGlyZWN0aW9uKTsKIHZvaWQg ZXdrX3ZpZXdfanNfd2luZG93X29iamVjdF9jbGVhcihFdmFzX09iamVjdCogbywgRXZhc19PYmpl Y3QqIGZyYW1lKTsKICNlbmRpZgogCi1pbnQgZXdrX3V0aWxfZHBpX2dldCh2b2lkKTsKK2ludCBl d2tfdXRpbF9kcGlfZ2V0KCk7CiB2b2lkIGV3a191dGlsX2phdmFzY3JpcHRfZ2NfY29sbGVjdCgp Owogdm9pZCBld2tfdXRpbF9qYXZhc2NyaXB0X2djX2FsdGVybmF0ZV90aHJlYWRfY29sbGVjdChF aW5hX0Jvb2wgd2FpdFVudGlsRG9uZSk7CiB1bnNpZ25lZCBld2tfdXRpbF9qYXZhc2NyaXB0X2dj X29iamVjdF9jb3VudF9nZXQoKTsKQEAgLTIxOCw3ICsyMTgsNyBAQCB2b2lkIGV3a192aWV3X2Nv bnRlbnRzX3NpemVfY2hhbmdlZChFdmFzX09iamVjdCogbywgRXZhc19Db29yZCB3LCBFdmFzX0Nv b3JkIGgpOwogCiBXZWJDb3JlOjpGbG9hdFJlY3QgZXdrX3ZpZXdfcGFnZV9yZWN0X2dldChjb25z dCBFdmFzX09iamVjdCogbyk7CiAKLWNvbnN0IGNoYXIqIGV3a19zZXR0aW5nc19kZWZhdWx0X3Vz ZXJfYWdlbnRfZ2V0KHZvaWQpOworY29uc3QgY2hhciogZXdrX3NldHRpbmdzX2RlZmF1bHRfdXNl cl9hZ2VudF9nZXQoKTsKIAogdm9pZCBld2tfZnJhbWVfZWRpdG9yX2NsaWVudF9jb250ZW50c19j aGFuZ2VkKEV2YXNfT2JqZWN0KiBvKTsKIHZvaWQgZXdrX2ZyYW1lX2VkaXRvcl9jbGllbnRfc2Vs ZWN0aW9uX2NoYW5nZWQoRXZhc19PYmplY3QqIG8pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3Nl dHRpbmdzLmNwcAppbmRleCBlYWUzZGJhMTQ5YzEwMTkzOGMyNjdjNjVlY2U3NTQ3ZjBlOGQ1MDBm Li44M2RiNTM4MzAyM2YxNTIyNTE3OWZmMTdmZjYwYjI1MmJiNTc0MjliIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcApAQCAtNzksNyArNzksNyBAQCBzdGF0aWMgV1RGOjpT dHJpbmcgX2V3a19zZXR0aW5nc193ZWJraXRfb3NfdmVyc2lvbl9nZXQoKQogICAgIHJldHVybiB1 YV9vc192ZXJzaW9uOwogfQogCi11aW50NjRfdCBld2tfc2V0dGluZ3Nfd2ViX2RhdGFiYXNlX2Rl ZmF1bHRfcXVvdGFfZ2V0KHZvaWQpCit1aW50NjRfdCBld2tfc2V0dGluZ3Nfd2ViX2RhdGFiYXNl X2RlZmF1bHRfcXVvdGFfZ2V0KCkKIHsKICNpZiBFTkFCTEUoU1FMX0RBVEFCQVNFKQogICAgIHJl dHVybiBfZXdrX2RlZmF1bHRfd2ViX2RhdGFiYXNlX3F1b3RhOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a191dGlsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf dXRpbC5jcHAKaW5kZXggNjlmZTZmMDJlOWExZjRmMGVhODMwODQ4NDg2YzA3ZjYzODNiOThiYS4u YjdjOWZmMzlkZjgxNGMyOWI2ZWE5NmUyMDUwMTUxMmEyNjgyZmE5OCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a191dGlsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3V0aWwuY3BwCkBAIC0xNjMsNyArMTYzLDcgQEAgdW5zaWduZWQgZXdrX3V0aWxfd29y a2VyX3RocmVhZF9jb3VudCgpCiAgKgogICogQHJldHVybiBkZXZpY2UncyBkcGkgdmFsdWUuCiAg Ki8KLWludCBld2tfdXRpbF9kcGlfZ2V0KHZvaWQpCitpbnQgZXdrX3V0aWxfZHBpX2dldCgpCiB7 CiAjaWZkZWYgSEFWRV9FQ09SRV9YCiAgICAgcmV0dXJuIGVjb3JlX3hfZHBpX2dldCgpOwo=