68793 2011-09-26 00:37:34 -0700 Implement a CloseEvent constructor for V8 2011-09-26 18:35:18 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 67824 1 haraken webkit-unassigned abarth ap dominicc sam webkit.review.bot oldest_to_newest 473001 0 haraken 2011-09-26 00:37:34 -0700 We have been implementing constructors of Events. CloseEvent has a constructor in JSC (https://bugs.webkit.org/show_bug.cgi?id=68340), but do not have it in V8. 473017 1 108641 haraken 2011-09-26 01:01:38 -0700 Created attachment 108641 Patch 473617 2 108641 webkit.review.bot 2011-09-26 18:35:14 -0700 Comment on attachment 108641 Patch Clearing flags on attachment: 108641 Committed r96061: <http://trac.webkit.org/changeset/96061> 473618 3 webkit.review.bot 2011-09-26 18:35:18 -0700 All reviewed patches have been landed. Closing bug. 108641 2011-09-26 01:01:38 -0700 2011-09-26 18:35:14 -0700 Patch bug-68793-20110926170136.patch text/plain 6278 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTU5MzYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2YTgwZTU0MmVlZDQ2MTk1NDgxNzMx ZDY2NTkzMmJlMWYwYzg5ZWExLi41M2QxZTBmMjM4MjRmYzY0M2Q0YmM2NWVjMmM5N2IwMzAyN2Zh ZDJlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMjYgIEtlbnRhcm8gSGFyYSAgPGhh cmFrZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEltcGxlbWVudCBhIENsb3NlRXZlbnQgY29u c3RydWN0b3IgZm9yIFY4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02ODc5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEVuYWJsZWQgY2xvc2UtZXZlbnQtY29uc3RydWN0b3IuaHRtbCwgc2luY2Ugbm93IFY4 IGhhcyB0aGUgQ2xvc2VFdmVudCBjb25zdHJ1Y3Rvci4KKworICAgICAgICAqIHBsYXRmb3JtL2No cm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMS0wOS0yNSAgS2VudGFybyBIYXJh ICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IGEgQ2xvc2VFdmVu dCBjb25zdHJ1Y3RvciBmb3IgSlNDCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJv bWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKaW5kZXggZmM0OWM0YmZjMTU1MTE3MGY0OGNjMjM0 MjMwYThkYThlMzA5NWRhMC4uZWY4ZGQ4ZTBjZjM0OWIyM2JmNjcyYWI5OGE4OTg3NTI5NTliNDk5 MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3Rh dGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0 YXRpb25zLnR4dApAQCAtNjksOSArNjksNiBAQCBCVUdDUjg0NTcyIFNLSVAgOiBzdG9yYWdlL3N0 b3JhZ2VpbmZvLXF1ZXJ5LXVzYWdlLmh0bWwgPSBGQUlMCiBCVUdDUjg0NTcyIFNLSVAgOiBzdG9y YWdlL3N0b3JhZ2VpbmZvLXJlcXVlc3QtcXVvdGEuaHRtbCA9IEZBSUwKIEJVR0NSODQ1NzIgU0tJ UCA6IHN0b3JhZ2Uvc3RvcmFnZWluZm8tbm8tY2FsbGJhY2tzLmh0bWwgPSBGQUlMCiAKLS8vIFRo aXMgd2lsbCBzb29uIGJlIGZpeGVkIGFmdGVyIGltcGxlbWVudGluZyBhIENsb3NlRXZlbnQgY29u c3RydWN0b3IgZm9yIFY4LgotQlVHV0s2ODM0MCA6IGZhc3QvZXZlbnRzL2NvbnN0cnVjdG9ycy9j bG9zZS1ldmVudC1jb25zdHJ1Y3Rvci5odG1sID0gRkFJTAotCiAvLyBBbmltYXRpb24gQVBJIGlz IGRpc2FibGVkLiAgRGVhbiBKYWNrc29uIGhhcyBwcm9taXNlZCAoYXMgb2YgQXVnLiAyNSwgMjAx MSkKIC8vIHRvIHJlLWVuYWJsZSB0aGVzZSAiaW4gdGhlIG5leHQgZmV3IHdlZWtzIi4KIEJVR1BL QVNUSU5HIFNLSVAgOiBhbmltYXRpb25zL2FuaW1hdGlvbi1hcGktMS5odG1sID0gVEVYVApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IGZmZGY0NTJmNjUxODgyOWI1MTY3YmI1ZGQzNjRiOTE5YjExYjI5M2UuLmNmNGNk OWY5ZDhmMjZhMzdhYmI0MzBiMGY1ZGE2MTQ2YmYyMTMwOWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxOSBAQAorMjAxMS0wOS0yNiAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgSW1wbGVtZW50IGEgQ2xvc2VFdmVudCBjb25zdHJ1Y3RvciBmb3IgVjgKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4NzkzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZmFzdC9l dmVudHMvY29uc3RydWN0b3JzL2Nsb3NlLWV2ZW50LWNvbnN0cnVjdG9yLmh0bWwKKworICAgICAg ICAqIGJpbmRpbmdzL3Y4L09wdGlvbnNPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6T3B0 aW9uc09iamVjdDo6Z2V0S2V5KTogSnVzdCByZW1vdmVkIGFuIGV4dHJhIHNwYWNlLgorICAgICAg ICAoV2ViQ29yZTo6T3B0aW9uc09iamVjdDo6Z2V0S2V5VmFsdWUpOiBSZXR1cm5zIGFuIHVuc2ln bmVkIHNob3J0IHZhbHVlIGNvcnJlc3BvbmRpbmcgdG8gdGhlIGdpdmVuIGtleS4KKyAgICAgICAg KiBiaW5kaW5ncy92OC9PcHRpb25zT2JqZWN0Lmg6CisgICAgICAgICogYmluZGluZ3MvdjgvY3Vz dG9tL1Y4RXZlbnRDb25zdHJ1Y3RvcnMuY3BwOiBBZGRlZCB0aGUgQ2xvc2VFdmVudCBjb25zdHJ1 Y3Rvci4KKyAgICAgICAgKiB3ZWJzb2NrZXRzL0Nsb3NlRXZlbnQuaWRsOiBBZGRlZCBhICdWOEN1 c3RvbUNvbnN0cnVjdG9yJyBhdHRyaWJ1dGUuCisKIDIwMTEtMDktMjUgIE1hcmsgSGFobmVuYmVy ZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgY3VzdG9tIHZ0YWJsZSBz dHJ1Y3QgdG8gQ2xhc3NJbmZvIHN0cnVjdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvT3B0aW9uc09iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9P cHRpb25zT2JqZWN0LmNwcAppbmRleCBkZDZkOWUwOGI2YTEwNTQ3NDI1NjE5ZjhhMWVkZjJhMTUy MzAyMzlmLi40MzM4NzUyZWJlNWVkMGYwYTVlMGRjZjE5YzMwNzRjOTJhOThmYjY5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9PcHRpb25zT2JqZWN0LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9PcHRpb25zT2JqZWN0LmNwcApAQCAtMTc1LDExICsx NzUsMjQgQEAgYm9vbCBPcHRpb25zT2JqZWN0OjpnZXRLZXkoY29uc3QgU3RyaW5nJiBrZXksIHY4 OjpMb2NhbDx2ODo6VmFsdWU+JiB2YWx1ZSkgY29uc3QKICAgICBpZiAoIW9wdGlvbnMtPkhhcyh2 OEtleSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB2YWx1ZSA9IG9wdGlvbnMtPkdldCh2 OEtleSk7Ci0gICAgaWYgKHZhbHVlLklzRW1wdHkoKSkgCisgICAgaWYgKHZhbHVlLklzRW1wdHko KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIHJldHVybiB0cnVlOwogfQogCitib29sIE9w dGlvbnNPYmplY3Q6OmdldEtleVZhbHVlKGNvbnN0IFN0cmluZyYga2V5LCB1bnNpZ25lZCBzaG9y dCYgdmFsdWUpIGNvbnN0Cit7CisgICAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gdjhWYWx1ZTsKKyAg ICBpZiAoIWdldEtleShrZXksIHY4VmFsdWUpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAg ICB2ODo6TG9jYWw8djg6OkludDMyPiB2OEludDMyID0gdjhWYWx1ZS0+VG9JbnQzMigpOworICAg IGlmICh2OEludDMyLklzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIHZhbHVl ID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQgc2hvcnQ+KHY4SW50MzItPlZhbHVlKCkpOworICAgIHJl dHVybiB0cnVlOworfQorCiBib29sIE9wdGlvbnNPYmplY3Q6OmdldEtleVZhbHVlKGNvbnN0IFN0 cmluZyYga2V5LCB1bnNpZ25lZCBsb25nIGxvbmcmIHZhbHVlKSBjb25zdAogewogICAgIHY4OjpM b2NhbDx2ODo6VmFsdWU+IHY4VmFsdWU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9PcHRpb25zT2JqZWN0LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9PcHRp b25zT2JqZWN0LmgKaW5kZXggZTEyNzE1NmQxMTQzOTdiZjQ2NmQ0ZDMxM2M0OTJhZjVhZTVhZmJk MC4uZTg3NDUzNWI2OWY4YzJlMWVkZjc1MzBmNTU0YTdmNGMyZGY1YmM1MSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvT3B0aW9uc09iamVjdC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L09wdGlvbnNPYmplY3QuaApAQCAtNzcsNiArNzcsNyBAQCBwdWJs aWM6CiAgICAgICAgIHZhbHVlID0gU2NyaXB0VmFsdWUodjhWYWx1ZSk7CiAgICAgICAgIHJldHVy biB0cnVlOwogICAgIH0KKyAgICBib29sIGdldEtleVZhbHVlKGNvbnN0IFN0cmluZyYga2V5LCB1 bnNpZ25lZCBzaG9ydCYgdmFsdWUpIGNvbnN0OwogICAgIGJvb2wgZ2V0S2V5VmFsdWUoY29uc3Qg U3RyaW5nJiBrZXksIHVuc2lnbmVkIGxvbmcgbG9uZyYgdmFsdWUpIGNvbnN0OwogCiBwcml2YXRl OgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RXZlbnRD b25zdHJ1Y3RvcnMuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RXZl bnRDb25zdHJ1Y3RvcnMuY3BwCmluZGV4IDMyN2E5NmM1OTM5MjI0ZjNhNmEyYjE2NDBhYjY5YThh ZThiMTA4MDAuLjU4ZGM0YTQ0YTAzYTdlYjJkOTQ1OTM4NjI5ZGFiNjRhNDNjNTZiNzggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEV2ZW50Q29uc3RydWN0 b3JzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhFdmVudENv bnN0cnVjdG9ycy5jcHAKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNp bmNsdWRlICJFdmVudENvbnN0cnVjdG9ycy5oIgogCisjaW5jbHVkZSAiQ2xvc2VFdmVudC5oIgog I2luY2x1ZGUgIkN1c3RvbUV2ZW50LmgiCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNpbmNsdWRl ICJEb2N1bWVudEZyYWdtZW50LmgiCkBAIC00Miw2ICs0Myw3IEBACiAjaW5jbHVkZSAiT3B0aW9u c09iamVjdC5oIgogI2luY2x1ZGUgIlY4QmluZGluZy5oIgogI2luY2x1ZGUgIlY4QmluZGluZ01h Y3Jvcy5oIgorI2luY2x1ZGUgIlY4Q2xvc2VFdmVudC5oIgogI2luY2x1ZGUgIlY4Q3VzdG9tRXZl bnQuaCIKICNpbmNsdWRlICJWOERvY3VtZW50LmgiCiAjaW5jbHVkZSAiVjhFdmVudC5oIgpAQCAt MTA4LDYgKzExMCw3IEBAIElOU1RBTlRJQVRFX0lOSVRJQUxJWklOR19DT05TVFJVQ1RPUl9GT1Jf Q1VTVE9NX0VWRU5UKERJQ1RJT05BUllfU1RBUlQsIERJQ1RJT05BCiBJTlNUQU5USUFURV9JTklU SUFMSVpJTkdfQ09OU1RSVUNUT1JfRk9SX1BST0dSRVNTX0VWRU5UKERJQ1RJT05BUllfU1RBUlQs IERJQ1RJT05BUllfRU5ELCBGSUxMX1BBUkVOVF9QUk9QRVJUSUVTLCBGSUxMX1BST1BFUlRZKQog SU5TVEFOVElBVEVfSU5JVElBTElaSU5HX0NPTlNUUlVDVE9SX0ZPUl9XRUJLSVRfQU5JTUFUSU9O X0VWRU5UKERJQ1RJT05BUllfU1RBUlQsIERJQ1RJT05BUllfRU5ELCBGSUxMX1BBUkVOVF9QUk9Q RVJUSUVTLCBGSUxMX1BST1BFUlRZKQogSU5TVEFOVElBVEVfSU5JVElBTElaSU5HX0NPTlNUUlVD VE9SX0ZPUl9IQVNIX0NIQU5HRV9FVkVOVChESUNUSU9OQVJZX1NUQVJULCBESUNUSU9OQVJZX0VO RCwgRklMTF9QQVJFTlRfUFJPUEVSVElFUywgRklMTF9QUk9QRVJUWSkKK0lOU1RBTlRJQVRFX0lO SVRJQUxJWklOR19DT05TVFJVQ1RPUl9GT1JfQ0xPU0VfRVZFTlQoRElDVElPTkFSWV9TVEFSVCwg RElDVElPTkFSWV9FTkQsIEZJTExfUEFSRU5UX1BST1BFUlRJRVMsIEZJTExfUFJPUEVSVFkpCiAK IAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd2Vi c29ja2V0cy9DbG9zZUV2ZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvQ2xvc2VF dmVudC5pZGwKaW5kZXggZThkNmM5M2U1ZjgwZWQ2OTk2OTVmODdmMmI3MzY4NThhZDNjMzNiZi4u N2ViY2EzNDAwYTczNzg0Mjg5ZTI4MTNmNGYxNzRmYjViMmI2ZGQ2YSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9DbG9zZUV2ZW50LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29y ZS93ZWJzb2NrZXRzL0Nsb3NlRXZlbnQuaWRsCkBAIC0zMyw3ICszMyw4IEBAIG1vZHVsZSBldmVu dHMgewogICAgIGludGVyZmFjZSBbCiAgICAgICAgIE5vU3RhdGljVGFibGVzLAogICAgICAgICBD YW5CZUNvbnN0cnVjdGVkLAotICAgICAgICBDdXN0b21Db25zdHJ1Y3RGdW5jdGlvbgorICAgICAg ICBDdXN0b21Db25zdHJ1Y3RGdW5jdGlvbiwKKyAgICAgICAgVjhDdXN0b21Db25zdHJ1Y3Rvcgog ICAgIF0gQ2xvc2VFdmVudCA6IEV2ZW50IHsKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGJv b2xlYW4gd2FzQ2xlYW47CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSB1bnNpZ25lZCBzaG9y dCBjb2RlOwo=