68356 2011-09-19 06:43:24 -0700 [EFL] Don't try to free user-provided list 2011-09-21 12:20:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68231 1 lucas.de.marchi lucas.de.marchi gyuyoung.kim lucas.de.marchi rakuco ryuan.choi tonikitoo oldest_to_newest 469366 0 lucas.de.marchi 2011-09-19 06:43:24 -0700 [EFL] Don't try to free user-provided list 469367 1 107847 lucas.de.marchi 2011-09-19 06:51:01 -0700 Created attachment 107847 Patch 469375 2 107847 rakuco 2011-09-19 07:21:27 -0700 Comment on attachment 107847 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107847&action=review Informal r+ from my side. > Source/WebKit/efl/ChangeLog:10 > + (or whatever function is required to destroy it). However it just not Small nit if you're really freak: it just not didn't use -> not only did it use; but also -> but it also 469392 3 107854 lucas.de.marchi 2011-09-19 08:03:49 -0700 Created attachment 107854 Patch 469817 4 gyuyoung.kim 2011-09-19 17:21:33 -0700 LGTM, 471006 5 lucas.de.marchi 2011-09-21 11:58:37 -0700 Committed r95656: <http://trac.webkit.org/changeset/95656> 471037 6 107854 lucas.de.marchi 2011-09-21 12:20:13 -0700 Comment on attachment 107854 Patch Clearing "cq?" flag. 107847 2011-09-19 06:51:01 -0700 2011-09-19 08:03:42 -0700 Patch bug-68356-20110919105221.patch text/plain 1856 lucas.de.marchi U3VidmVyc2lvbiBSZXZpc2lvbjogOTU0MTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA2OWM2MGEyMjVk ODgyNmNkMTJjNTM1MzM5Yjk0YjEwODQ4YzA3MzA2Li40NTdjOWFkNjk5NDc1ZGVjODA3NzY3YTZh ODE2OGUxY2RmYTJiNjdlIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEt MDktMTkgIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hpQHByb2Z1c2lvbi5tb2JpPgor CisgICAgICAgIFtFRkxdIERvbid0IHRyeSB0byBmcmVlIHVzZXItcHJvdmlkZWQgbGlzdAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjgzNTYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIGNvZGluZy1zdHls ZSBjbGVhbnVwIHJldmVhbGVkIHRoYXQgd2Ugd2VyZSB1c2luZyBFSU5BX0xJU1RfRlJFRSBpbiBh CisgICAgICAgIHdyb25nIG1hbm5lci4gSWYgd2UgaW50ZW5kZWQgdG8gZnJlZSB0aGUgZGF0YSwg d2Ugc2hvdWxkIGNhbGwgZnJlZSgpCisgICAgICAgIChvciB3aGF0ZXZlciBmdW5jdGlvbiBpcyBy ZXF1aXJlZCB0byBkZXN0cm95IGl0KS4gSG93ZXZlciBpdCBqdXN0IG5vdAorICAgICAgICBkaWRu J3QgdXNlIHRoZSB3cm9uZyBFRkwgYXBpIGJ1dCBhbHNvIGludHJvZHVjZWQgYSBjaGFuZ2UgaW4g YmVoYXZpb3IsCisgICAgICAgIGZyZWVpbmcgdXNlci1wcm92aWRlZCBkYXRhLgorCisgICAgICAg ICogZXdrL2V3a19mcmFtZS5jcHA6CisgICAgICAgIChld2tfZnJhbWVfZmVlZF90b3VjaF9ldmVu dCk6IGRvIG5vdCBmcmVlIHVzZXItcHJvdmlkZWQgZGF0YS4KKwogMjAxMS0wOS0xNyAgTWloYWkg UGFycGFyaXRhICA8bWloYWlwQGNocm9taXVtLm9yZz4KIAogICAgICAgICBGcmFtZUxvYWRlckNs aWVudCBCYWNrRm9yd2FyZExpc3QtcmVsYXRlZCBtZXRob2RzIGFyZSB1bnN1ZWQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwIGIvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a19mcmFtZS5jcHAKaW5kZXggZGE0MzQ0MGVhYmM0NzQ0MWZjZGQ5N2U2Yjc5OWU1 ZmI0YjMzOWZhYS4uY2QwN2JhOTNjYWM5MzE0NGYwZDU2M2E5ZjQ1ZjBmMDcxNjk5NmRjNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAKQEAgLTkzMCwxMSArOTMwLDggQEAgRWluYV9C b29sIGV3a19mcmFtZV9mZWVkX3RvdWNoX2V2ZW50KEV2YXNfT2JqZWN0ICpvLCBFd2tfVG91Y2hf RXZlbnRfVHlwZSBhY3Rpb24KICAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTl9WQUwocG9p bnRzLCBFSU5BX0ZBTFNFKTsKICAgICBFV0tfRlJBTUVfU0RfR0VUKG8sIHNkKTsKIAotICAgIGlm ICghc2QgfHwgIXNkLT5mcmFtZSB8fCAhZXdrX3ZpZXdfbmVlZF90b3VjaF9ldmVudHNfZ2V0KHNk LT52aWV3KSkgewotICAgICAgICB2b2lkICpwb2ludDsKLSAgICAgICAgRUlOQV9MSVNUX0ZSRUUo cG9pbnRzLCBwb2ludCk7CisgICAgaWYgKCFzZCB8fCAhc2QtPmZyYW1lIHx8ICFld2tfdmlld19u ZWVkX3RvdWNoX2V2ZW50c19nZXQoc2QtPnZpZXcpKQogICAgICAgICByZXR1cm4gRUlOQV9GQUxT RTsKLSAgICB9CiAKICAgICBFdmFzX0Nvb3JkIHgsIHk7CiAgICAgZXZhc19vYmplY3RfZ2VvbWV0 cnlfZ2V0KHNkLT52aWV3LCAmeCwgJnksIDAsIDApOwo= 107854 2011-09-19 08:03:49 -0700 2011-09-21 12:20:13 -0700 Patch bug-68356-20110919120508.patch text/plain 1856 lucas.de.marchi U3VidmVyc2lvbiBSZXZpc2lvbjogOTU0MTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA2OWM2MGEyMjVk ODgyNmNkMTJjNTM1MzM5Yjk0YjEwODQ4YzA3MzA2Li5mOTFiNzNhYzk3NTJmMjYxY2FmNTUyODhl OWRjM2FmYzViZTNjZWE5IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEt MDktMTkgIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hpQHByb2Z1c2lvbi5tb2JpPgor CisgICAgICAgIFtFRkxdIERvbid0IHRyeSB0byBmcmVlIHVzZXItcHJvdmlkZWQgbGlzdAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjgzNTYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIGNvZGluZy1zdHls ZSBjbGVhbnVwIHJldmVhbGVkIHRoYXQgd2Ugd2VyZSB1c2luZyBFSU5BX0xJU1RfRlJFRSBpbiBh CisgICAgICAgIHdyb25nIG1hbm5lci4gSWYgd2UgaW50ZW5kZWQgdG8gZnJlZSB0aGUgZGF0YSwg d2Ugc2hvdWxkIGNhbGwgZnJlZSgpCisgICAgICAgIChvciB3aGF0ZXZlciBmdW5jdGlvbiBpcyBy ZXF1aXJlZCB0byBkZXN0cm95IGl0KS4gSG93ZXZlciBub3Qgb25seSBpdAorICAgICAgICBkaWQg dXNlIHRoZSB3cm9uZyBFRkwgYXBpIGJ1dCBpdCBhbHNvIGludHJvZHVjZWQgYSBjaGFuZ2UgaW4g YmVoYXZpb3IsCisgICAgICAgIGZyZWVpbmcgdXNlci1wcm92aWRlZCBkYXRhLgorCisgICAgICAg ICogZXdrL2V3a19mcmFtZS5jcHA6CisgICAgICAgIChld2tfZnJhbWVfZmVlZF90b3VjaF9ldmVu dCk6IGRvIG5vdCBmcmVlIHVzZXItcHJvdmlkZWQgZGF0YS4KKwogMjAxMS0wOS0xNyAgTWloYWkg UGFycGFyaXRhICA8bWloYWlwQGNocm9taXVtLm9yZz4KIAogICAgICAgICBGcmFtZUxvYWRlckNs aWVudCBCYWNrRm9yd2FyZExpc3QtcmVsYXRlZCBtZXRob2RzIGFyZSB1bnN1ZWQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwIGIvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a19mcmFtZS5jcHAKaW5kZXggZGE0MzQ0MGVhYmM0NzQ0MWZjZGQ5N2U2Yjc5OWU1 ZmI0YjMzOWZhYS4uY2QwN2JhOTNjYWM5MzE0NGYwZDU2M2E5ZjQ1ZjBmMDcxNjk5NmRjNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAKQEAgLTkzMCwxMSArOTMwLDggQEAgRWluYV9C b29sIGV3a19mcmFtZV9mZWVkX3RvdWNoX2V2ZW50KEV2YXNfT2JqZWN0ICpvLCBFd2tfVG91Y2hf RXZlbnRfVHlwZSBhY3Rpb24KICAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTl9WQUwocG9p bnRzLCBFSU5BX0ZBTFNFKTsKICAgICBFV0tfRlJBTUVfU0RfR0VUKG8sIHNkKTsKIAotICAgIGlm ICghc2QgfHwgIXNkLT5mcmFtZSB8fCAhZXdrX3ZpZXdfbmVlZF90b3VjaF9ldmVudHNfZ2V0KHNk LT52aWV3KSkgewotICAgICAgICB2b2lkICpwb2ludDsKLSAgICAgICAgRUlOQV9MSVNUX0ZSRUUo cG9pbnRzLCBwb2ludCk7CisgICAgaWYgKCFzZCB8fCAhc2QtPmZyYW1lIHx8ICFld2tfdmlld19u ZWVkX3RvdWNoX2V2ZW50c19nZXQoc2QtPnZpZXcpKQogICAgICAgICByZXR1cm4gRUlOQV9GQUxT RTsKLSAgICB9CiAKICAgICBFdmFzX0Nvb3JkIHgsIHk7CiAgICAgZXZhc19vYmplY3RfZ2VvbWV0 cnlfZ2V0KHNkLT52aWV3LCAmeCwgJnksIDAsIDApOwo=