68292 2011-09-16 16:57:34 -0700 Rename ENABLE(OPENTYPE_SANITIZER) to USE(OPENTYPE_SANITIZER) 2011-09-19 15:54:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68012 1 abarth abarth eric webkit.review.bot oldest_to_newest 468900 0 abarth 2011-09-16 16:57:34 -0700 Rename ENABLE(OPENTYPE_SANITIZER) to USE(OPENTYPE_SANITIZER) 468904 1 107748 abarth 2011-09-16 16:59:21 -0700 Created attachment 107748 Patch 468948 2 107748 eric 2011-09-16 17:58:15 -0700 Comment on attachment 107748 Patch Why USE? Isn't this a feature? 468949 3 107748 eric 2011-09-16 17:58:58 -0700 Comment on attachment 107748 Patch Do we have other sanitizers we can use? What happens when this is disabled? 468965 4 abarth 2011-09-16 18:18:14 -0700 > Why USE? Isn't this a feature? Nope. It's just a library: http://code.google.com/p/ots/ > Do we have other sanitizers we can use? What happens when this is disabled? Folks who don't use the sanitizer just use the fonts directly, which increases security risk. 469766 5 107748 abarth 2011-09-19 15:53:49 -0700 Comment on attachment 107748 Patch Clearing flags on attachment: 107748 Committed r95487: <http://trac.webkit.org/changeset/95487> 469767 6 abarth 2011-09-19 15:53:52 -0700 All reviewed patches have been landed. Closing bug. 107748 2011-09-16 16:59:21 -0700 2011-09-19 15:53:48 -0700 Patch bug-68292-20110916165920.patch text/plain 6639 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1MzM0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDktMTYgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZW5hbWUgRU5BQkxFKE9QRU5UWVBF X1NBTklUSVpFUikgdG8gVVNFKE9QRU5UWVBFX1NBTklUSVpFUikKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MjkyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3BlblR5cGUgU2FuaXRpemVyIGlzIGEgbGli cmFyeSBmb3Igc2FuaXRpemluZyB0eXBlIGFuZCBub3QgYSBmZWF0dXJlLgorICAgICAgICBUaGVy ZWZvcmUgdGhpcyBtYWNybyBzaG91bGQgc2F5IHRoYXQgd2UgVVNFIHRoZSBsaWJyYXJ5LgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvV09GRkZpbGVGb3JtYXQuY3BwOgorICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL1dPRkZGaWxlRm9ybWF0Lmg6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvbWFjL0ZvbnRDdXN0b21QbGF0Zm9ybURhdGEuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Y3JlYXRlRm9udEN1c3RvbVBsYXRmb3JtRGF0YSk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3Mvb3BlbnR5cGUvT3BlblR5cGVTYW5pdGl6ZXIuY3BwOgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL29wZW50eXBlL09wZW5UeXBlU2FuaXRpemVyLmg6CisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9Gb250Q3VzdG9tUGxhdGZvcm1EYXRhLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OmNyZWF0ZUZvbnRDdXN0b21QbGF0Zm9ybURhdGEpOgorICAgICAgICAoV2ViQ29yZTo6 Rm9udEN1c3RvbVBsYXRmb3JtRGF0YTo6c3VwcG9ydHNGb3JtYXQpOgorCiAyMDExLTA5LTE2ICBN YXggUGVyZXBlbGl0c3luICA8cHBoMzRyQGdtYWlsLmNvbT4KIAogICAgICAgICBTZXQgYnV0IG5v dCB1c2VkIHZhcmlhYmxlcyBjbGVhbnVwIChnY2MgNC42KQpJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvV09GRkZpbGVGb3JtYXQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dPRkZGaWxlRm9ybWF0LmNwcAkocmV2aXNpb24g OTUzMzEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9XT0ZGRmlsZUZvcm1h dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3LDcgKzI3LDcgQEAKICNpbmNsdWRlICJXT0ZGRmls ZUZvcm1hdC5oIgogI2luY2x1ZGUgPHpsaWIuaD4KIAotI2lmICFFTkFCTEUoT1BFTlRZUEVfU0FO SVRJWkVSKQorI2lmICFVU0UoT1BFTlRZUEVfU0FOSVRJWkVSKQogCiAjaW5jbHVkZSAiU2hhcmVk QnVmZmVyLmgiCiAKQEAgLTI1MSw0ICsyNTEsNCBAQCBib29sIGNvbnZlcnRXT0ZGVG9TZm50KFNo YXJlZEJ1ZmZlciogd29mCiAgICAgCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKLSNlbmRpZiAv LyAhRU5BQkxFKE9QRU5UWVBFX1NBTklUSVpFUikKKyNlbmRpZiAvLyAhVVNFKE9QRU5UWVBFX1NB TklUSVpFUikKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dPRkZGaWxl Rm9ybWF0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv V09GRkZpbGVGb3JtYXQuaAkocmV2aXNpb24gOTUzMzEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9XT0ZGRmlsZUZvcm1hdC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw3ICsy Niw3IEBACiAjaWZuZGVmIFdPRkZGaWxlRm9ybWF0X2gKICNkZWZpbmUgV09GRkZpbGVGb3JtYXRf aAogCi0jaWYgIUVOQUJMRShPUEVOVFlQRV9TQU5JVElaRVIpCisjaWYgIVVTRShPUEVOVFlQRV9T QU5JVElaRVIpCiAKICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAKQEAgLTQzLDYgKzQzLDYgQEAg Ym9vbCBjb252ZXJ0V09GRlRvU2ZudChTaGFyZWRCdWZmZXIqIHdvZgogCiB9IC8vIG5hbWVzcGFj ZSBXZWJDb3JlCiAKLSNlbmRpZiAvLyAhRU5BQkxFKE9QRU5UWVBFX1NBTklUSVpFUikKKyNlbmRp ZiAvLyAhVVNFKE9QRU5UWVBFX1NBTklUSVpFUikKIAogI2VuZGlmIC8vIFdPRkZGaWxlRm9ybWF0 X2gKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Gb250Q3VzdG9t UGxhdGZvcm1EYXRhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9tYWMvRm9udEN1c3RvbVBsYXRmb3JtRGF0YS5jcHAJKHJldmlzaW9uIDk1MzMxKQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0ZvbnRDdXN0b21QbGF0Zm9y bURhdGEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Nyw3ICs5Nyw3IEBAIEZvbnRDdXN0b21QbGF0 Zm9ybURhdGEqIGNyZWF0ZUZvbnRDdXN0b20KIHsKICAgICBBU1NFUlRfQVJHKGJ1ZmZlciwgYnVm ZmVyKTsKIAotI2lmIEVOQUJMRShPUEVOVFlQRV9TQU5JVElaRVIpCisjaWYgVVNFKE9QRU5UWVBF X1NBTklUSVpFUikKICAgICBPcGVuVHlwZVNhbml0aXplciBzYW5pdGl6ZXIoYnVmZmVyKTsKICAg ICBSZWZQdHI8U2hhcmVkQnVmZmVyPiB0cmFuc2NvZGVCdWZmZXIgPSBzYW5pdGl6ZXIuc2FuaXRp emUoKTsKICAgICBpZiAoIXRyYW5zY29kZUJ1ZmZlcikKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL29wZW50eXBlL09wZW5UeXBlU2FuaXRpemVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVudHlwZS9PcGVuVHlwZVNh bml0aXplci5jcHAJKHJldmlzaW9uIDk1MzMxKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvb3BlbnR5cGUvT3BlblR5cGVTYW5pdGl6ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yOSw3ICsyOSw3IEBACiAgKi8KIAogI2luY2x1ZGUgImNvbmZpZy5oIgotI2lmIEVOQUJMRShP UEVOVFlQRV9TQU5JVElaRVIpCisjaWYgVVNFKE9QRU5UWVBFX1NBTklUSVpFUikKICNpbmNsdWRl ICJPcGVuVHlwZVNhbml0aXplci5oIgogCiAjaW5jbHVkZSAiU2hhcmVkQnVmZmVyLmgiCkBAIC02 Niw0ICs2Niw0IEBAIFBhc3NSZWZQdHI8U2hhcmVkQnVmZmVyPiBPcGVuVHlwZVNhbml0aXoKIAog fSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCi0jZW5kaWYgLy8gRU5BQkxFKE9QRU5UWVBFX1NBTklU SVpFUikKKyNlbmRpZiAvLyBVU0UoT1BFTlRZUEVfU0FOSVRJWkVSKQpJbmRleDogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnR5cGUvT3BlblR5cGVTYW5pdGl6ZXIuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVudHlwZS9PcGVu VHlwZVNhbml0aXplci5oCShyZXZpc2lvbiA5NTMzMSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL29wZW50eXBlL09wZW5UeXBlU2FuaXRpemVyLmgJKHdvcmtpbmcgY29weSkK QEAgLTMxLDcgKzMxLDcgQEAKICNpZm5kZWYgT3BlblR5cGVTYW5pdGl6ZXJfaAogI2RlZmluZSBP cGVuVHlwZVNhbml0aXplcl9oCiAKLSNpZiBFTkFCTEUoT1BFTlRZUEVfU0FOSVRJWkVSKQorI2lm IFVTRShPUEVOVFlQRV9TQU5JVElaRVIpCiAjaW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KIAogbmFt ZXNwYWNlIFdlYkNvcmUgewpAQCAtNTMsNSArNTMsNSBAQCBwcml2YXRlOgogCiB9IC8vIG5hbWVz cGFjZSBXZWJDb3JlCiAKLSNlbmRpZiAvLyBFTkFCTEUoT1BFTlRZUEVfU0FOSVRJWkVSKQorI2Vu ZGlmIC8vIFVTRShPUEVOVFlQRV9TQU5JVElaRVIpCiAjZW5kaWYgLy8gT3BlblR5cGVTYW5pdGl6 ZXJfaApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Gb250Q3Vz dG9tUGxhdGZvcm1EYXRhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9za2lhL0ZvbnRDdXN0b21QbGF0Zm9ybURhdGEuY3BwCShyZXZpc2lvbiA5NTMz MSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvRm9udEN1c3RvbVBs YXRmb3JtRGF0YS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3MCw3ICsxNzAsNyBAQCBGb250Q3Vz dG9tUGxhdGZvcm1EYXRhKiBjcmVhdGVGb250Q3VzdG9tCiB7CiAgICAgQVNTRVJUX0FSRyhidWZm ZXIsIGJ1ZmZlcik7CiAKLSNpZiBFTkFCTEUoT1BFTlRZUEVfU0FOSVRJWkVSKQorI2lmIFVTRShP UEVOVFlQRV9TQU5JVElaRVIpCiAgICAgT3BlblR5cGVTYW5pdGl6ZXIgc2FuaXRpemVyKGJ1ZmZl cik7CiAgICAgUmVmUHRyPFNoYXJlZEJ1ZmZlcj4gdHJhbnNjb2RlQnVmZmVyID0gc2FuaXRpemVy LnNhbml0aXplKCk7CiAgICAgaWYgKCF0cmFuc2NvZGVCdWZmZXIpCkBAIC0yMDMsNyArMjAzLDcg QEAgRm9udEN1c3RvbVBsYXRmb3JtRGF0YSogY3JlYXRlRm9udEN1c3RvbQogYm9vbCBGb250Q3Vz dG9tUGxhdGZvcm1EYXRhOjpzdXBwb3J0c0Zvcm1hdChjb25zdCBTdHJpbmcmIGZvcm1hdCkKIHsK ICAgICByZXR1cm4gZXF1YWxJZ25vcmluZ0Nhc2UoZm9ybWF0LCAidHJ1ZXR5cGUiKSB8fCBlcXVh bElnbm9yaW5nQ2FzZShmb3JtYXQsICJvcGVudHlwZSIpCi0jaWYgRU5BQkxFKE9QRU5UWVBFX1NB TklUSVpFUikKKyNpZiBVU0UoT1BFTlRZUEVfU0FOSVRJWkVSKQogICAgICAgICB8fCBlcXVhbEln bm9yaW5nQ2FzZShmb3JtYXQsICJ3b2ZmIikKICNlbmRpZgogICAgIDsKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5NTMzNCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDktMTYg IEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZW5hbWUgRU5BQkxF KE9QRU5UWVBFX1NBTklUSVpFUikgdG8gVVNFKE9QRU5UWVBFX1NBTklUSVpFUikKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MjkyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmZWF0dXJlcy5neXBpOgor CiAyMDExLTA5LTE2ICBOYXQgRHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBb Y2hyb21pdW1dIENyZWF0ZSBXZWJHTCBsYXllciBmb3IgZ3JhcGhpY3MgY29udGV4dHMgb24gZGVt YW5kCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCShyZXZpc2lvbiA5NTMz MSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQkod29ya2luZyBjb3B5 KQpAQCAtNjUsNyArNjUsNiBAQAogICAgICAgJ0VOQUJMRV9NSFRNTD0xJywKICAgICAgICdFTkFC TEVfTk9USUZJQ0FUSU9OUz0xJywKICAgICAgICdFTkFCTEVfT0ZGTElORV9XRUJfQVBQTElDQVRJ T05TPTEnLAotICAgICAgJ0VOQUJMRV9PUEVOVFlQRV9TQU5JVElaRVI9MScsCiAgICAgICAnRU5B QkxFX09SSUVOVEFUSU9OX0VWRU5UUz0wJywKICAgICAgICdFTkFCTEVfUEFHRV9WSVNJQklMSVRZ X0FQST0xJywKICAgICAgICdFTkFCTEVfUFJPR1JFU1NfVEFHPTEnLApAQCAtOTQsNiArOTMsNyBA QAogICAgICAgIyBXVEZfVVNFX0RZTkFNSUNfQU5OT1RBVElPTlM9MSBtYXkgYmUgZGVmaW5lZCBp biBidWlsZC9jb21tb24uZ3lwaQogICAgICAgIyBXZSBjYW4ndCBkZWZpbmUgaXQgaGVyZSBiZWNh dXNlIGl0IHNob3VsZCBiZSBwcmVzZW50IG9ubHkKICAgICAgICMgaW4gRGVidWcgb3IgcmVsZWFz ZV92YWxncmluZF9idWlsZD0xIGJ1aWxkcy4KKyAgICAgICdXVEZfVVNFX09QRU5UWVBFX1NBTklU SVpFUj0xJywKICAgICAgICdXVEZfVVNFX1dFQlA9MScsCiAgICAgICAnV1RGX1VTRV9XRUJLSVRf SU1BR0VfREVDT0RFUlM9MScsCiAgICAgXSwK