68229 2011-09-16 01:03:24 -0700 [GTK] Linker error with double inclusion of ScrollbarThemeMock.cpp 2011-09-16 08:42:24 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 mdwajahatali.siddiqui webkit-unassigned amruthraj mrobinson simon.fraser oldest_to_newest 468371 0 mdwajahatali.siddiqui 2011-09-16 01:03:24 -0700 Gtk build is broken on svn rev# 95275 as ScrollbarThemeMock.cpp is mistakenly included twice in Source/WebCore/GNUmakefile.list.am. This is added from attachment committed from https://bugs.webkit.org/show_bug.cgi?id=68134 --- a/Source/WebCore/GNUmakefile.list.am +++ b/Source/WebCore/GNUmakefile.list.am @@ -2686,6 +2686,8 @@ webcore_sources += \ Source/WebCore/platform/mock/GeolocationClientMock.h \ Source/WebCore/platform/mock/GeolocationServiceMock.cpp \ Source/WebCore/platform/mock/GeolocationServiceMock.h \ + Source/WebCore/platform/mock/ScrollbarThemeMock.cpp \ + Source/WebCore/platform/mock/ScrollbarThemeMock.cpp \ Source/WebCore/platform/mock/SpeechInputClientMock.cpp \ Source/WebCore/platform/mock/SpeechInputClientMock.h \ Source/WebCore/platform/network/AuthenticationChallengeBase.cpp \ Attached patch corrects this issue 468376 1 107619 mdwajahatali.siddiqui 2011-09-16 01:12:43 -0700 Created attachment 107619 linker error fix fixing this issue by removing double inclusion. 468379 2 107620 mdwajahatali.siddiqui 2011-09-16 01:19:43 -0700 Created attachment 107620 linker error fix updated changelog updating changelog 468389 3 107620 alex 2011-09-16 01:39:24 -0700 Comment on attachment 107620 linker error fix updated changelog View in context: https://bugs.webkit.org/attachment.cgi?id=107620&action=review Thanks for the patch but I've already fixed the issue http://trac.webkit.org/changeset/95280, this kind of patches do not need review. Could you remove the r? tag? > Source/WebCore/GNUmakefile.list.am:-2688 > - Source/WebCore/platform/mock/ScrollbarThemeMock.cpp \ I think we do not have to remove the line but change .cpp for .h. 468397 4 mdwajahatali.siddiqui 2011-09-16 02:19:35 -0700 fixed in http://trac.webkit.org/changeset/95280 468398 5 mdwajahatali.siddiqui 2011-09-16 02:22:12 -0700 fixed in http://trac.webkit.org/changeset/95280 468503 6 simon.fraser 2011-09-16 08:42:24 -0700 Thanks for fixing! 107619 2011-09-16 01:12:43 -0700 2011-09-16 01:19:43 -0700 linker error fix linker_error_fix.patch text/plain 1335 mdwajahatali.siddiqui SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUubGlzdC5hbQkocmV2aXNpb24gOTUyNzUpCisrKyBT b3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5saXN0LmFtCSh3b3JraW5nIGNvcHkpCkBAIC0yNjg1 LDcgKzI2ODUsNiBAQAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21vY2svR2VvbG9jYXRpb25T ZXJ2aWNlTW9jay5jcHAgXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21vY2svR2VvbG9jYXRp b25TZXJ2aWNlTW9jay5oIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tb2NrL1Njcm9sbGJh clRoZW1lTW9jay5jcHAgXAotCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21vY2svU2Nyb2xsYmFy VGhlbWVNb2NrLmNwcCBcCiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbW9jay9TcGVlY2hJbnB1 dENsaWVudE1vY2suY3BwIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tb2NrL1NwZWVjaElu cHV0Q2xpZW50TW9jay5oIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0F1dGhl bnRpY2F0aW9uQ2hhbGxlbmdlQmFzZS5jcHAgXApJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTUy NzUpCisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNSBAQAorMjAxMS0wOS0xNiAgV2FqYWhhdCBTaWRkaXF1aSAgPG1kd2FqYWhhdGFsaS5zaWRk aXF1aUBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgW0dUS10gTGlua2VyIGVycm9yIHdpdGggZG91 YmxlIGluY2x1c2lvbiBvZiBTY3JvbGxiYXJUaGVtZU1vY2suaAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjgyMjkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAg ICAgICAqIEdOVW1ha2VmaWxlLmxpc3QuYW06IHJlbW92aW5nIFNjcm9sbGJhclRoZW1lTW9jay5o IHdoaWNoIHdhcyAKKyAgICAgICAgYWRkZWQgdHdpY2UuCisKIDIwMTEtMDktMTYgIExlbyBZYW5n ICA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtRdF0gQ3Jhc2ggd2hl biBkcmFnZ2luZyBnb29nbGUgbWFwcy4K 107620 2011-09-16 01:19:43 -0700 2011-09-16 02:19:09 -0700 linker error fix updated changelog linker_error_fix1.patch text/plain 1339 mdwajahatali.siddiqui SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUubGlzdC5hbQkocmV2aXNpb24gOTUyNzUpCisrKyBT b3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5saXN0LmFtCSh3b3JraW5nIGNvcHkpCkBAIC0yNjg1 LDcgKzI2ODUsNiBAQAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21vY2svR2VvbG9jYXRpb25T ZXJ2aWNlTW9jay5jcHAgXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21vY2svR2VvbG9jYXRp b25TZXJ2aWNlTW9jay5oIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tb2NrL1Njcm9sbGJh clRoZW1lTW9jay5jcHAgXAotCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21vY2svU2Nyb2xsYmFy VGhlbWVNb2NrLmNwcCBcCiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbW9jay9TcGVlY2hJbnB1 dENsaWVudE1vY2suY3BwIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tb2NrL1NwZWVjaElu cHV0Q2xpZW50TW9jay5oIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0F1dGhl bnRpY2F0aW9uQ2hhbGxlbmdlQmFzZS5jcHAgXApJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTUy NzUpCisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNSBAQAorMjAxMS0wOS0xNiAgV2FqYWhhdCBTaWRkaXF1aSAgPG1kd2FqYWhhdGFsaS5zaWRk aXF1aUBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgW0dUS10gTGlua2VyIGVycm9yIHdpdGggZG91 YmxlIGluY2x1c2lvbiBvZiBTY3JvbGxiYXJUaGVtZU1vY2suY3BwCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODIyOQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisg ICAgICAgICogR05VbWFrZWZpbGUubGlzdC5hbTogcmVtb3ZpbmcgU2Nyb2xsYmFyVGhlbWVNb2Nr LmNwcCB3aGljaCB3YXMgCisgICAgICAgIGFkZGVkIHR3aWNlLgorCiAyMDExLTA5LTE2ICBMZW8g WWFuZyAgPGxlby55YW5nQHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbUXRdIENyYXNo IHdoZW4gZHJhZ2dpbmcgZ29vZ2xlIG1hcHMuCg==