6812 2006-01-25 18:34:20 -0800 Missing focus ring on new text fields 2006-02-16 14:45:34 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 6986 1 adele adele oldest_to_newest 29960 0 adele 2006-01-25 18:34:20 -0800 29972 1 adele 2006-01-25 20:38:43 -0800 I tried adding a case for TextFieldAppearance in RenderObject::paintOutline, and the outline it draws is the wrong size - its inside the NSTextFieldCell border. 30430 2 darin 2006-01-28 17:12:37 -0800 These bugs that block us switching to the new text field shoul not be marked P1. Once we turn it on, these would be P1/major bugs, of course, but at the moment they are just part of the "switch to a new text field" task and should not be in the P1 list. 32825 3 6517 adele 2006-02-15 16:09:58 -0800 Created attachment 6517 test case 32826 4 6518 adele 2006-02-15 16:11:32 -0800 Created attachment 6518 focus patch We'll have to file followup bugs about minor differences in focus ring appearance. The ring is the same as the one we draw for contenteditable divs, but its not quite the same as the one AppKit draws. 32878 5 adele 2006-02-15 17:10:38 -0800 Note- I explored using AppKit to draw this focus ring, but the default mechanism in NSTextFieldCell expects a contentView and a field editor. I think having the engine draw the ring is ultimately the right solution, and we'll have to iron out the visual details. 32881 6 6522 adele 2006-02-15 17:24:46 -0800 Created attachment 6522 patch w/ Changelog 32933 7 justin.garcia 2006-02-16 00:32:03 -0800 return !style->hasAppearance() || style->appearance() == TextFieldAppearance is a little nicer than: if (!style->hasAppearance() || style->appearance() == TextFieldAppearance) return true; return false; Also I think that shouldEngineDrawFocusRingForStyle, might be better than engineShouldDrawFocusRing. engineShouldDrawFocusRing sounds like you're telling someone something, not asking a question and shouldXXX seems to be the convention in WebCore. 33019 8 adele 2006-02-16 10:16:03 -0800 I've made justin's recommended changes 33052 9 6522 darin 2006-02-16 12:59:05 -0800 Comment on attachment 6522 patch w/ Changelog Looks fine. RenderTheme::engineShouldDrawFocusRing could be written as just a return statement, since if (x) return true; return false; is the same as return x; 33057 10 hyatt 2006-02-16 13:08:20 -0800 I'd rather you just called this supportsFocusRing and inverted it... you're asking the theme if it can draw the focus ring. It should answer YES or NO. I don't like asking the theme if it "can't" draw the focus ring. Invert the API. 33060 11 adele 2006-02-16 13:16:47 -0800 Dave's suggestion makes sense. I will make that change before committing. 6517 2006-02-15 16:09:58 -0800 2006-02-15 16:09:58 -0800 test case focus.html text/html 319 adele Q2xpY2sgaW4gZWFjaCBib3ggdG8gY29tcGFyZSBmb2N1cyByaW5ncy4KPGJyPjxicj4KPGlucHV0 IHR5cGU9InRleHQiIHZhbHVlPSJOZXcgdGV4dCBmaWVsZCIgc3R5bGU9Ii1raHRtbC1hcHBlYXJh bmNlOiB0ZXh0ZmllbGQiPjwvaW5wdXQ+Cjxicj48YnI+CjxkaXYgY29udGVudGVkaXRhYmxlIHN0 eWxlPSJib3JkZXI6IHNvbGlkIHRoaW4gZ3JleSI+Q29udGVudGVkaXRhYmxlIERpdjwvZGl2Pgo8 YnI+PGJyPgo8aW5wdXQgdHlwZT0idGV4dCIgdmFsdWU9Ik9sZCB0ZXh0IGZpZWxkIiBzdHlsZT0i LWtodG1sLWFwcGVhcmFuY2U6IG5vbmUiPjwvaW5wdXQ+Cg== 6518 2006-02-15 16:11:32 -0800 2006-02-15 17:24:46 -0800 focus patch focus_engine.txt text/plain 1991 adele SW5kZXg6IHJlbmRlcmluZy9yZW5kZXJfdGhlbWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSByZW5kZXJpbmcv cmVuZGVyX3RoZW1lLmgJKHJldmlzaW9uIDEyODIxKQorKysgcmVuZGVyaW5nL3JlbmRlcl90aGVt ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC04NSw2ICs4NSw5IEBACiAgICAgLy8gb2xkIHRoZW1lLgog ICAgIHZvaWQgdGhlbWVDaGFuZ2VkKCk7CiAKKyAgICAvLyBBIG1ldGhvZCBhc2tpbmcgaWYgdGhl IGVuZ2luZSBzaG91bGQgZHJhdyB0aGUgZm9jdXMgcmluZy4KKyAgICB2aXJ0dWFsIGJvb2wgZW5n aW5lU2hvdWxkRHJhd0ZvY3VzUmluZyhjb25zdCBSZW5kZXJTdHlsZSogc3R5bGUpIGNvbnN0Owor ICAgIAogcHJvdGVjdGVkOgogICAgIC8vIE1ldGhvZHMgZm9yIHN0YXRlIHF1ZXJ5aW5nCiAgICAg Ym9vbCBpc0NoZWNrZWQoY29uc3QgUmVuZGVyT2JqZWN0KiBvKSBjb25zdDsKSW5kZXg6IHJlbmRl cmluZy9yZW5kZXJfdGhlbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHJlbmRlcmluZy9yZW5kZXJfdGhl bWUuY3BwCShyZXZpc2lvbiAxMjgyMSkKKysrIHJlbmRlcmluZy9yZW5kZXJfdGhlbWUuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMjUsNiArMTI1LDEzIEBACiAgICAgcmV0dXJuIGZhbHNlOwogfQog Citib29sIFJlbmRlclRoZW1lOjplbmdpbmVTaG91bGREcmF3Rm9jdXNSaW5nKGNvbnN0IFJlbmRl clN0eWxlKiBzdHlsZSkgY29uc3QKK3sKKyAgICBpZiAoIXN0eWxlLT5oYXNBcHBlYXJhbmNlKCkg fHwgc3R5bGUtPmFwcGVhcmFuY2UoKSA9PSBUZXh0RmllbGRBcHBlYXJhbmNlKQorICAgICAgICBy ZXR1cm4gdHJ1ZTsKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKIGJvb2wgUmVuZGVyVGhlbWU6OnN0 YXRlQ2hhbmdlZChSZW5kZXJPYmplY3QqIG8sIENvbnRyb2xTdGF0ZSBzdGF0ZSkgY29uc3QKIHsK ICAgICAvLyBEZWZhdWx0IGltcGxlbWVudGF0aW9uIGFzc3VtZXMgdGhlIGNvbnRyb2xzIGRvbnQg cmVzcG9uZCB0byBjaGFuZ2VzIGluIDpob3ZlciBzdGF0ZQpJbmRleDogcmVuZGVyaW5nL3JlbmRl cl9vYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHJlbmRlcmluZy9yZW5kZXJfb2JqZWN0LmNwcAko cmV2aXNpb24gMTI4MjEpCisrKyByZW5kZXJpbmcvcmVuZGVyX29iamVjdC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTUyLDYgKzUyLDcgQEAKICNpbmNsdWRlICJyZW5kZXJfaW5saW5lLmgiCiAjaW5j bHVkZSAicmVuZGVyX2xpbmUuaCIKICNpbmNsdWRlICJyZW5kZXJfbGlzdC5oIgorI2luY2x1ZGUg InJlbmRlcl90aGVtZS5oIgogI2luY2x1ZGUgIlZpc2libGVQb3NpdGlvbi5oIgogI2luY2x1ZGUg PHFtYXRyaXguaD4KICNpbmNsdWRlIDxxcGFpbnRlci5oPgpAQCAtMTM1MCw3ICsxMzUxLDcgQEAK ICAgICBpbnQgb2Zmc2V0ID0gc3R5bGUtPm91dGxpbmVPZmZzZXQoKTsKICAgICAKICAgICBpZiAo c3R5bGUtPm91dGxpbmVTdHlsZUlzQXV0bygpKSB7Ci0gICAgICAgIGlmICghc3R5bGUtPmhhc0Fw cGVhcmFuY2UoKSkgeworICAgICAgICBpZiAodGhlbWUoKS0+ZW5naW5lU2hvdWxkRHJhd0ZvY3Vz UmluZyhzdHlsZSkpIHsKICAgICAgICAgICAgIC8vIE9ubHkgcGFpbnQgdGhlIGZvY3VzIHJpbmcg YnkgaGFuZCBpZiB0aGVyZSBpcyBubyBjdXN0b20gYXBwZWFyYW5jZQogICAgICAgICAgICAgLy8g c3BlY2lmaWVkLiAgT3RoZXJ3aXNlIHdlIGxldCB0aGUgdGhlbWUgcGFpbnQgdGhlIGZvY3VzIHJp bmcsIHNpbmNlIHRoZSByaW5nCiAgICAgICAgICAgICAvLyBtaWdodCBub3QgYmUgcmVjdGFuZ3Vs YXIgKG9yIG1hdGNoIHRoZSBkaW1lbnNpb25zIG9mIHRoZSBjb250cm9sIGV4YWN0bHkpLgo= 6522 2006-02-15 17:24:46 -0800 2006-02-16 12:59:05 -0800 patch w/ Changelog focus_engine.txt text/plain 2889 adele SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEyODM3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDYtMDIt MTUgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gRml4ZWQgaHR0cDovL2J1Z3ppbGxhLm9w ZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD02ODEyCisgICAgICAgIE1pc3NpbmcgZm9jdXMg cmluZyBvbiBuZXcgdGV4dCBmaWVsZHMKKworICAgICAgICBUZXN0czoKKyAgICAgICAgKiBmYXN0 L2Zvcm1zL2lucHV0LWFwcGVhcmFuY2UtZm9jdXMuaHRtbDogVXBkYXRlZC4KKworICAgICAgICAq IHJlbmRlcmluZy9yZW5kZXJfb2JqZWN0LmNwcDogKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6cGFp bnRPdXRsaW5lKTogCisgICAgICAgICBjYWxsIGVuZ2luZVNob3VsZERyYXdGb2N1c1JpbmcgaW5z dGVhZCBvZiBjaGVja2luZyB0aGUgYXBwZWFyYW5jZS4KKyAgICAgICAgKiByZW5kZXJpbmcvcmVu ZGVyX3RoZW1lLmNwcDogKGtodG1sOjpSZW5kZXJUaGVtZTo6ZW5naW5lU2hvdWxkRHJhd0ZvY3Vz UmluZyk6IEFkZGVkLiAKKyAgICAgICAgIENoZWNrcyBhcHBlYXJhbmNlLCBhbmQgYWxsb3dzIGVu Z2luZSB0byBkcmF3IGZvY3VzIHJpbmcgZm9yIHRleHQgZmllbGRzLgorICAgICAgICAqIHJlbmRl cmluZy9yZW5kZXJfdGhlbWUuaDoKKwogMjAwNi0wMi0xNSAgR2VvZmZyZXkgR2FyZW4gIDxnZ2Fy ZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMuCkluZGV4OiByZW5kZXJp bmcvcmVuZGVyX3RoZW1lLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcmVuZGVyaW5nL3JlbmRlcl90aGVtZS5o CShyZXZpc2lvbiAxMjgyMSkKKysrIHJlbmRlcmluZy9yZW5kZXJfdGhlbWUuaAkod29ya2luZyBj b3B5KQpAQCAtODUsNiArODUsOSBAQAogICAgIC8vIG9sZCB0aGVtZS4KICAgICB2b2lkIHRoZW1l Q2hhbmdlZCgpOwogCisgICAgLy8gQSBtZXRob2QgYXNraW5nIGlmIHRoZSBlbmdpbmUgc2hvdWxk IGRyYXcgdGhlIGZvY3VzIHJpbmcuCisgICAgdmlydHVhbCBib29sIGVuZ2luZVNob3VsZERyYXdG b2N1c1JpbmcoY29uc3QgUmVuZGVyU3R5bGUqIHN0eWxlKSBjb25zdDsKKyAgICAKIHByb3RlY3Rl ZDoKICAgICAvLyBNZXRob2RzIGZvciBzdGF0ZSBxdWVyeWluZwogICAgIGJvb2wgaXNDaGVja2Vk KGNvbnN0IFJlbmRlck9iamVjdCogbykgY29uc3Q7CkluZGV4OiByZW5kZXJpbmcvcmVuZGVyX3Ro ZW1lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSByZW5kZXJpbmcvcmVuZGVyX3RoZW1lLmNwcAkocmV2aXNp b24gMTI4MjEpCisrKyByZW5kZXJpbmcvcmVuZGVyX3RoZW1lLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTI1LDYgKzEyNSwxMyBAQAogICAgIHJldHVybiBmYWxzZTsKIH0KIAorYm9vbCBSZW5kZXJU aGVtZTo6ZW5naW5lU2hvdWxkRHJhd0ZvY3VzUmluZyhjb25zdCBSZW5kZXJTdHlsZSogc3R5bGUp IGNvbnN0Cit7CisgICAgaWYgKCFzdHlsZS0+aGFzQXBwZWFyYW5jZSgpIHx8IHN0eWxlLT5hcHBl YXJhbmNlKCkgPT0gVGV4dEZpZWxkQXBwZWFyYW5jZSkKKyAgICAgICAgcmV0dXJuIHRydWU7Cisg ICAgcmV0dXJuIGZhbHNlOworfQorCiBib29sIFJlbmRlclRoZW1lOjpzdGF0ZUNoYW5nZWQoUmVu ZGVyT2JqZWN0KiBvLCBDb250cm9sU3RhdGUgc3RhdGUpIGNvbnN0CiB7CiAgICAgLy8gRGVmYXVs dCBpbXBsZW1lbnRhdGlvbiBhc3N1bWVzIHRoZSBjb250cm9scyBkb250IHJlc3BvbmQgdG8gY2hh bmdlcyBpbiA6aG92ZXIgc3RhdGUKSW5kZXg6IHJlbmRlcmluZy9yZW5kZXJfb2JqZWN0LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSByZW5kZXJpbmcvcmVuZGVyX29iamVjdC5jcHAJKHJldmlzaW9uIDEyODIx KQorKysgcmVuZGVyaW5nL3JlbmRlcl9vYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Miw2 ICs1Miw3IEBACiAjaW5jbHVkZSAicmVuZGVyX2lubGluZS5oIgogI2luY2x1ZGUgInJlbmRlcl9s aW5lLmgiCiAjaW5jbHVkZSAicmVuZGVyX2xpc3QuaCIKKyNpbmNsdWRlICJyZW5kZXJfdGhlbWUu aCIKICNpbmNsdWRlICJWaXNpYmxlUG9zaXRpb24uaCIKICNpbmNsdWRlIDxxbWF0cml4Lmg+CiAj aW5jbHVkZSA8cXBhaW50ZXIuaD4KQEAgLTEzNTAsNyArMTM1MSw3IEBACiAgICAgaW50IG9mZnNl dCA9IHN0eWxlLT5vdXRsaW5lT2Zmc2V0KCk7CiAgICAgCiAgICAgaWYgKHN0eWxlLT5vdXRsaW5l U3R5bGVJc0F1dG8oKSkgewotICAgICAgICBpZiAoIXN0eWxlLT5oYXNBcHBlYXJhbmNlKCkpIHsK KyAgICAgICAgaWYgKHRoZW1lKCktPmVuZ2luZVNob3VsZERyYXdGb2N1c1Jpbmcoc3R5bGUpKSB7 CiAgICAgICAgICAgICAvLyBPbmx5IHBhaW50IHRoZSBmb2N1cyByaW5nIGJ5IGhhbmQgaWYgdGhl cmUgaXMgbm8gY3VzdG9tIGFwcGVhcmFuY2UKICAgICAgICAgICAgIC8vIHNwZWNpZmllZC4gIE90 aGVyd2lzZSB3ZSBsZXQgdGhlIHRoZW1lIHBhaW50IHRoZSBmb2N1cyByaW5nLCBzaW5jZSB0aGUg cmluZwogICAgICAgICAgICAgLy8gbWlnaHQgbm90IGJlIHJlY3Rhbmd1bGFyIChvciBtYXRjaCB0 aGUgZGltZW5zaW9ucyBvZiB0aGUgY29udHJvbCBleGFjdGx5KS4K