68061 2011-09-14 00:40:40 -0700 Add a script to figure out area of expertise of contributors 2013-02-10 19:19:03 -0800 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 72090 72243 1 rniwa webkit-unassigned cmarcelo eric laszlo.gombos paroga peter zoltan oldest_to_newest 466892 0 rniwa 2011-09-14 00:40:40 -0700 Instead of each contributor manually figuring out where his/her area of expertise is, we should automatically figure it out from change log entries. 467288 1 eric 2011-09-14 13:31:05 -0700 This is slightly related to the webkit-patch suggest-reviewers code I suspect. :) You might look at http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/queries.py#L47 Even if you don't re-use existing code, it's possible suggest-reviewers will want to be augmented to include your new fanciness. Also, we've long considered having a bot automatically run suggest-reviewers (some more refined version than current) and auto-cc people on bugs they're likely to wish to review. 467290 2 rniwa 2011-09-14 13:32:39 -0700 (In reply to comment #1) > Also, we've long considered having a bot automatically run suggest-reviewers (some more refined version than current) and auto-cc people on bugs they're likely to wish to review. Yeah, that'll be a really cool feature to build on top of this. 468054 3 107545 leandro 2011-09-15 13:56:59 -0700 Created attachment 107545 Classifier, proof of concept 1 I won't be able to work on this script until next Monday, so I'm attaching the current proof of concept so it can be improved/reviewed. To determine people who actively works on a certain port, it seems decent enough. For more granularity, there's a lot of room for improvements. One of these improvements would be using a better classifier, probably based on a Naive Bayes classifier or a Perceptron network based on the changelog entry's description, like Ryosuke suggested on IRC. Also, I did not check Eric's code to suggest reviewers, but I'm positive it (or parts of it) could be used as well. 500215 4 rniwa 2011-11-10 13:31:40 -0800 *** Bug 71957 has been marked as a duplicate of this bug. *** 107545 2011-09-15 13:56:59 -0700 2011-09-15 13:56:59 -0700 Classifier, proof of concept 1 get-area-of-expertise.py text/plain 5644 leandro IyEvdXNyL2Jpbi9weXRob24KCmltcG9ydCBjb2RlY3MKaW1wb3J0IG9zCmltcG9ydCByZQppbXBv cnQgc2ltcGxlanNvbgppbXBvcnQgc3lzCmZyb20gY29sbGVjdGlvbnMgaW1wb3J0IGRlZmF1bHRk aWN0CmZyb20gd2Via2l0cHkuY29tbW9uLmNoZWNrb3V0LmNoYW5nZWxvZyBpbXBvcnQgQ2hhbmdl TG9nCmZyb20gd2Via2l0cHkuY29tbW9uLmNvbmZpZy5jb21taXR0ZXJzIGltcG9ydCBDb21taXR0 ZXJMaXN0Cgprbm93bl9wb3J0cyA9IHNldChbJ2NmJywgJ2Nocm9taXVtJywgJ2VmbCcsICdndGsn LCAnaGFpa3UnLCAnbWFjJywgJ3F0JywgJ3dpbicsICd3aW5jZScsICd3eCddKQpwbGF0Zm9ybV9y ZWdleHAgPSByZS5jb21waWxlKHIncGxhdGZvcm0vKD9QPHN1YnN5c3RlbT5bYS16XSspLyg/UDxw b3J0PlthLXpdKykvJykKY2FtZWxjYXNlX3JlZ2V4cCA9IHJlLmNvbXBpbGUocicoKD86XnxbQS1a XSlbYS16XSspJykKCmRlZiBnZXRfd2ViY29yZV9leHBlcnRpc2UodG9wbGV2ZWxfZGlyLCB0b3Vj aGVkX2ZpbGVzKToKICAgIGV4cGVydGlzZSA9IFtdCiAgICBmb3IgdG91Y2hlZF9maWxlIGluIHRv dWNoZWRfZmlsZXM6CiAgICAgICAgbWF0Y2ggPSBwbGF0Zm9ybV9yZWdleHAubWF0Y2godG91Y2hl ZF9maWxlKQogICAgICAgIGlmIG1hdGNoOgogICAgICAgICAgICBwb3J0ID0gbWF0Y2guZ3JvdXAo J3BvcnQnKQogICAgICAgICAgICBpZiBwb3J0IGluIGtub3duX3BvcnRzOgogICAgICAgICAgICAg ICAgZXhwZXJ0aXNlLmFwcGVuZCgncG9ydDolcycgJSBwb3J0KQogICAgICAgICAgICAgICAgY29u dGludWUKICAgICAgICAgICAgCiAgICAgICAgICAgIHN1YnN5c3RlbSA9IG1hdGNoLmdyb3VwKCdz dWJzeXN0ZW0nKQogICAgICAgICAgICBleHBlcnRpc2UuYXBwZW5kKCd3ZWJjb3JlOiVzOiVzJyAl IChzdWJzeXN0ZW0sIHRvdWNoZWRfZmlsZS5zcGxpdChvcy5wYXRoLnNlcClbMl0pKQogICAgICAg ICAgICBjb250aW51ZQogICAgICAgIAogICAgICAgIGlmICcvJyBpbiB0b3VjaGVkX2ZpbGU6CiAg ICAgICAgICAgIGZpbGVuYW1lX2NvbXBvbmVudHMgPSB0b3VjaGVkX2ZpbGUuc3BsaXQob3MucGF0 aC5zZXApCiAgICAgICAgICAgIGlmIGZpbGVuYW1lX2NvbXBvbmVudHNbMF0gPT0gInBsYXRmb3Jt IjoKICAgICAgICAgICAgICAgIGlmIGZpbGVuYW1lX2NvbXBvbmVudHNbMV0gaW4ga25vd25fcG9y dHM6CiAgICAgICAgICAgICAgICAgICAgZXhwZXJ0aXNlLmFwcGVuZCgncG9ydDolcycgJSBmaWxl bmFtZV9jb21wb25lbnRzWzFdKQogICAgICAgICAgICAgICAgZWxpZiBub3QgJy4nIGluIGZpbGVu YW1lX2NvbXBvbmVudHNbLTFdOgogICAgICAgICAgICAgICAgICAgIGV4cGVydGlzZS5hcHBlbmQo J3dlYmNvcmU6cGxhdGZvcm06JXMnICUgZmlsZW5hbWVfY29tcG9uZW50c1sxXSkKICAgICAgICAg ICAgZWxpZiBub3QgJy4nIGluIGZpbGVuYW1lX2NvbXBvbmVudHNbMF0gYW5kIG5vdCBmaWxlbmFt ZV9jb21wb25lbnRzWzBdWzBdLmlzdGl0bGUoKToKICAgICAgICAgICAgICAgIGV4cGVydGlzZS5h cHBlbmQoJ3dlYmNvcmU6JXMnICUgZmlsZW5hbWVfY29tcG9uZW50c1swXSkKICAgICAgICAKICAg IHJldHVybiBleHBlcnRpc2UKCmRlZiBnZXRfd2Via2l0X2V4cGVydGlzZSh0b3BsZXZlbF9kaXIs IHRvdWNoZWRfZmlsZXMpOgogICAgcG9ydCA9IG9zLnBhdGguYmFzZW5hbWUodG9wbGV2ZWxfZGly KQogICAgaWYgcG9ydCBpbiBrbm93bl9wb3J0czoKICAgICAgICByZXR1cm4gWydwb3J0OiVzJyAl IHBvcnRdCiAgICByZXR1cm4gW10KCmRlZiBnZXRfanNjX2V4cGVydGlzZSh0b3BsZXZlbF9kaXIs IHRvdWNoZWRfZmlsZXMpOgogICAgZXhwZXJ0aXNlID0gW10KICAgIGZvciB0b3VjaGVkX2ZpbGUg aW4gdG91Y2hlZF9maWxlczoKICAgICAgICBpZiAnLycgaW4gdG91Y2hlZF9maWxlOgogICAgICAg ICAgICBmaWxlX2NvbXBvbmVudHMgPSB0b3VjaGVkX2ZpbGUuc3BsaXQob3MucGF0aC5zZXApCiAg ICAgICAgICAgIGlmIG5vdCAnLicgaW4gZmlsZV9jb21wb25lbnRzWzBdIGFuZCAoZmlsZV9jb21w b25lbnRzWzBdID09ICdBUEknIG9yIG5vdCBmaWxlX2NvbXBvbmVudHNbMF1bMF0uaXN0aXRsZSgp KToKICAgICAgICAgICAgICAgIGV4cGVydGlzZS5hcHBlbmQoJ2pzYzolcycgJSBmaWxlX2NvbXBv bmVudHNbMF0pCiAgICByZXR1cm4gZXhwZXJ0aXNlCgpkZWYgZ2V0X2V4cGVydGlzZV9hcmVhc19i eV90b3VjaGVkX2ZpbGVzKHRvcGxldmVsX2RpciwgdG91Y2hlZF9maWxlcyk6CiAgICBpZiB0b3Bs ZXZlbF9kaXIuc3RhcnRzd2l0aCgnU291cmNlL1dlYktpdCcpOgogICAgICAgIHJldHVybiBnZXRf d2Via2l0X2V4cGVydGlzZSh0b3BsZXZlbF9kaXIsIHRvdWNoZWRfZmlsZXMpCiAgICBpZiB0b3Bs ZXZlbF9kaXIuc3RhcnRzd2l0aCgnU291cmNlL1dlYkNvcmUnKToKICAgICAgICByZXR1cm4gZ2V0 X3dlYmNvcmVfZXhwZXJ0aXNlKHRvcGxldmVsX2RpciwgdG91Y2hlZF9maWxlcykgICAgCiAgICBp ZiB0b3BsZXZlbF9kaXIuc3RhcnRzd2l0aCgnU291cmNlL0phdmFTY3JpcHRDb3JlJyk6CiAgICAg ICAgcmV0dXJuIGdldF9qc2NfZXhwZXJ0aXNlKHRvcGxldmVsX2RpciwgdG91Y2hlZF9maWxlcykK ICAgIHJldHVybiBbXQoKZGVmIHVwZGF0ZV9leHBlcnRpc2VfYXJlYXNfYnlfdG91Y2hlZF9maWxl cyhjb250cmlidXRvciwgdG9wbGV2ZWxfZGlyLCB0b3VjaGVkX2ZpbGVzLCB3ZWlnaHQ9MSk6CiAg ICBleHBlcnRpc2VfYXJlYXMgPSBnZXRfZXhwZXJ0aXNlX2FyZWFzX2J5X3RvdWNoZWRfZmlsZXMo dG9wbGV2ZWxfZGlyLCB0b3VjaGVkX2ZpbGVzKQogICAgZm9yIGFyZWEgaW4gZXhwZXJ0aXNlX2Fy ZWFzOgogICAgICAgIGNvbnRyaWJ1dG9yLmFyZWFzW2FyZWFdICs9IHdlaWdodAoKZGVmIG5vcm1h bGl6ZV9leHBlcnRpc2UoZXhwZXJ0aXNlX2RpY3QpOgogICAgdG90YWxfY2hhbmdlcyA9IHN1bShl eHBlcnRpc2VfZGljdC52YWx1ZXMoKSkKICAgIHJldHVybiBkaWN0KChhcmVhLCBmbG9hdChjaGFu Z2VzKSAvIHRvdGFsX2NoYW5nZXMpIGZvciBhcmVhLCBjaGFuZ2VzIGluIGV4cGVydGlzZV9kaWN0 Lml0ZW1zKCkpCgpkZWYgZ2V0X3RvcF9leHBlcnRpc2VfYXJlYXMobm9ybWFsaXplZCk6CiAgICBk ZWYgaXNfdG9wX2FyZWEoYXJlYSwgbm9ybWFsaXplZF9jaGFuZ2VzKToKICAgICAgICBpZiBhcmVh LnN0YXJ0c3dpdGgoJ3BvcnQ6Jyk6CiAgICAgICAgICAgIHJldHVybiBub3JtYWxpemVkX2NoYW5n ZXMgPj0gMC4yNQogICAgICAgIHJldHVybiBub3JtYWxpemVkX2NoYW5nZXMgPiAwLjA1CiAgICAg ICAgCiAgICByZXR1cm4gW2FyZWEgZm9yIGFyZWEsIG5vcm1hbGl6ZWRfY2hhbmdlcyBpbiBub3Jt YWxpemVkLml0ZW1zKCkgaWYgaXNfdG9wX2FyZWEoYXJlYSwgbm9ybWFsaXplZF9jaGFuZ2VzKV0K CmRlZiBlcmFzZV9saW5lKCk6CiAgICBzeXMuc3RkZXJyLndyaXRlKCdcMDMzWzJLXHInKQoKaWYg X19uYW1lX18gPT0gJ19fbWFpbl9fJzoKICAgIGNoYW5nZWxvZ19maWxlcyA9IFsKICAgICAgICAn Q2hhbmdlTG9nJywKICAgICAgICAnU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZycsCiAg ICAgICAgJ1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9xdC9DaGFuZ2VMb2cnLAogICAgICAgICdTb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cnLAogICAgICAgICdTb3VyY2UvVGhpcmRQYXJ0 eS9DaGFuZ2VMb2cnLAogICAgICAgICdTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cnLAogICAgICAg ICdTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cnLAogICAgICAgICdTb3VyY2UvV2ViS2l0L2NmL0No YW5nZUxvZycsCiAgICAgICAgJ1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nJywKICAgICAgICAnU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cnLAogICAgICAgICdTb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cnLAogICAgICAgICdTb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cnLAogICAg ICAgICdTb3VyY2UvV2ViS2l0L2hhaWt1L0NoYW5nZUxvZycsCiAgICAgICAgJ1NvdXJjZS9XZWJL aXQvbWFjL0NoYW5nZUxvZycsCiAgICAgICAgJ1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nJywK ICAgICAgICAnU291cmNlL1dlYktpdC93aW5jZS9DaGFuZ2VMb2cnLAogICAgICAgICdTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cnLAogICAgICAgICdTb3VyY2UvV2ViS2l0L3d4L0NoYW5nZUxv ZycsCiAgICAgICAgJ1Rvb2xzL0NoYW5nZUxvZycsCiAgICAgICAgJ1dlYnNpdGVzL2J1Z3Mud2Vi a2l0Lm9yZy9DaGFuZ2VMb2cnLAogICAgICAgICdXZWJzaXRlcy93ZWJraXQub3JnL0NoYW5nZUxv ZycsCiAgICBdCgogICAgY29tbWl0dGVyX2xpc3QgPSBDb21taXR0ZXJMaXN0KCkKCiAgICBmb3Ig Y29udHJpYnV0b3IgaW4gY29tbWl0dGVyX2xpc3QuY29udHJpYnV0b3JzKCk6CiAgICAgICAgaWYg bm90IGhhc2F0dHIoY29udHJpYnV0b3IsICdhcmVhcycpOgogICAgICAgICAgICBjb250cmlidXRv ci5hcmVhcyA9IGRlZmF1bHRkaWN0KGxhbWJkYSAqaWdub3JlOiAwKQoKICAgIGZvciBpbmRleCwg Y2hhbmdlbG9nIGluIGVudW1lcmF0ZShjaGFuZ2Vsb2dfZmlsZXMpOgogICAgICAgIGVyYXNlX2xp bmUoKQogICAgICAgIHN5cy5zdGRvdXQud3JpdGUoJyVzIFJlYWRpbmc6ICVzJyAlICgnfC8tXFwn W2luZGV4ICYgM10sIGNoYW5nZWxvZykpCgogICAgICAgIHRvcGxldmVsX2RpciA9IG9zLnBhdGgu ZGlybmFtZShjaGFuZ2Vsb2cpCiAgICAgICAgY2hhbmdlbG9nID0gY29kZWNzLm9wZW4oY2hhbmdl bG9nLCBlbmNvZGluZz0ndXRmOCcpCiAgICAgICAgZm9yIGVudHJ5IGluIENoYW5nZUxvZy5wYXJz ZV9lbnRyaWVzX2Zyb21fZmlsZShjaGFuZ2Vsb2cpOgogICAgICAgICAgICBjb250cmlidXRvciA9 IGNvbW1pdHRlcl9saXN0LmNvbnRyaWJ1dG9yX2J5X2VtYWlsKGVudHJ5LmF1dGhvcl9lbWFpbCgp KQogICAgICAgICAgICBpZiBub3QgY29udHJpYnV0b3I6CiAgICAgICAgICAgICAgICBjb250aW51 ZQoKICAgICAgICAgICAgdXBkYXRlX2V4cGVydGlzZV9hcmVhc19ieV90b3VjaGVkX2ZpbGVzKGNv bnRyaWJ1dG9yLCB0b3BsZXZlbF9kaXIsIGVudHJ5LnRvdWNoZWRfZmlsZXMoKSkKCiAgICAgICAg ICAgIHJldmlld2VyID0gZW50cnkucmV2aWV3ZXIoKQogICAgICAgICAgICBpZiByZXZpZXdlcjoK ICAgICAgICAgICAgICAgIHVwZGF0ZV9leHBlcnRpc2VfYXJlYXNfYnlfdG91Y2hlZF9maWxlcyhy ZXZpZXdlciwgdG9wbGV2ZWxfZGlyLCBlbnRyeS50b3VjaGVkX2ZpbGVzKCksIHdlaWdodD0yKQoK ICAgIGVyYXNlX2xpbmUoKSAgICAKCiAgICBvdXRwdXQgPSB7fQogICAgZm9yIGNvbnRyaWJ1dG9y IGluIGNvbW1pdHRlcl9saXN0LmNvbnRyaWJ1dG9ycygpOgogICAgICAgIGlmIGhhc2F0dHIoY29u dHJpYnV0b3IsICdhcmVhcycpOgogICAgICAgICAgICBub3JtYWxpemVkX2FyZWFzID0gbm9ybWFs aXplX2V4cGVydGlzZShjb250cmlidXRvci5hcmVhcykKICAgICAgICAgICAgb3V0cHV0W2NvbnRy aWJ1dG9yLmJ1Z3ppbGxhX2VtYWlsKCldID0gZ2V0X3RvcF9leHBlcnRpc2VfYXJlYXMobm9ybWFs aXplZF9hcmVhcykKCiAgICBwcmludCBzaW1wbGVqc29uLmR1bXBzKG91dHB1dCwgaW5kZW50PTQp Cg==