68033 2011-09-13 14:55:44 -0700 Implement globalFlag for WebKitTestRunner 2011-09-14 11:59:57 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED InRadar P2 Enhancement --- 68091 28633 1 jonlee jonlee aroben jonlee simon.fraser webkit-bug-importer oldest_to_newest 466575 0 jonlee 2011-09-13 14:55:44 -0700 layoutTestController should have globalFlag like DumpRenderTree 466600 1 jonlee 2011-09-13 15:23:17 -0700 <rdar://problem/10119204> 466632 2 107247 jonlee 2011-09-13 15:50:24 -0700 Created attachment 107247 Patch 466637 3 simon.fraser 2011-09-13 16:03:53 -0700 What the heck is globalFlag? Can it have a better name? 466638 4 jonlee 2011-09-13 16:05:07 -0700 It's a flag that's globally accessible across all windows. It existed in DRT (grep for globalFlag in the layout tests). 466653 5 107247 darin 2011-09-13 16:19:57 -0700 Comment on attachment 107247 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107247&action=review This is OK. But it would be best to also include the patches that can be removed from the Skipped list. > Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h:205 > + bool m_globalFlag; Need to initialize m_globalFlag in the constructor instead of letting it have a random uninitialized value at first. Also probably need to reset it in between tests. 466668 6 jonlee 2011-09-13 16:32:04 -0700 (In reply to comment #5) > This is OK. But it would be best to also include the patches that can be removed from the Skipped list. I will comb through the list and upload a new patch. > Need to initialize m_globalFlag in the constructor instead of letting it have a random uninitialized value at first. Done > Also probably need to reset it in between tests. If I'm reading the code correctly I believe a new layout test controller is created for each test. 467148 7 107357 jonlee 2011-09-14 11:01:48 -0700 Created attachment 107357 Patch 467153 8 jonlee 2011-09-14 11:05:34 -0700 To expedite the patch, I've decided to instead add a new task to enable the tests that use globalFlag. 467201 9 jonlee 2011-09-14 11:59:57 -0700 Committed r95109: <http://trac.webkit.org/changeset/95109> 107247 2011-09-13 15:50:24 -0700 2011-09-14 11:01:44 -0700 Patch bug-68033-20110913155020.patch text/plain 2468 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogOTUwNDQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzZTgwZmIzODAxZGEyZDcwZjQ4ZGVmNTdiNmY5Yjk5NGI5 N2FmZmU4Li5iZGZlZjYxMjljZmYzOTU0YmZhZTNiYWFjMWQ4OTkxZjIwMTAwMzViIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDktMTMgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgorCisgICAgICAgIElt cGxlbWVudCBnbG9iYWxGbGFnIGZvciBXZWJLaXRUZXN0UnVubmVyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODAzMworICAgICAgICA8cmRhcjovL3By b2JsZW0vMTAxMTkyMDQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0JpbmRpbmdzL0xheW91 dFRlc3RDb250cm9sbGVyLmlkbDogUG9ydGluZyBnbG9iYWxGbGFnIGZyb20gRFJUCisgICAgICAg ICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5o OgorICAgICAgICAoV1RSOjpMYXlvdXRUZXN0Q29udHJvbGxlcjo6Z2xvYmFsRmxhZyk6IHNpbXBs ZSBnZXR0ZXIKKyAgICAgICAgKFdUUjo6TGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldEdsb2JhbEZs YWcpOiBzaW1wbGUgc2V0dGVyCisKIDIwMTEtMDktMTMgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQWRkIEFsaWNlIGFuZCBBcnllaCB0byB0aGUgbGlzdCBvZiBj b250cmlidXRvcnMuCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVk QnVuZGxlL0JpbmRpbmdzL0xheW91dFRlc3RDb250cm9sbGVyLmlkbCBiL1Rvb2xzL1dlYktpdFRl c3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvQmluZGluZ3MvTGF5b3V0VGVzdENvbnRyb2xsZXIuaWRs CmluZGV4IGYxNDY4ZDAyY2NiMWViNzAxZjIzYmFjMzcwYTQ5ZGZhOWVhY2E3ZDQuLjUyMWFiN2Mw YTYwMGNjZTVmY2VjNzMwMmUyYjdiNDhhYzE3M2Y5N2IgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvQmluZGluZ3MvTGF5b3V0VGVzdENvbnRyb2xsZXIu aWRsCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvQmluZGluZ3Mv TGF5b3V0VGVzdENvbnRyb2xsZXIuaWRsCkBAIC02Niw2ICs2Niw5IEBAIG1vZHVsZSBXVFIgewog ICAgICAgICBET01TdHJpbmcgbWFya2VyVGV4dEZvckxpc3RJdGVtKGluIG9iamVjdCBlbGVtZW50 KTsKICAgICAgICAgdW5zaWduZWQgbG9uZyB3aW5kb3dDb3VudCgpOwogCisgICAgICAgIC8vIFNw ZWNpYWwgRE9NIHZhcmlhYmxlcy4KKyAgICAgICAgYXR0cmlidXRlIGJvb2xlYW4gZ2xvYmFsRmxh ZzsKKwogICAgICAgICAvLyBSZXBhaW50IHRlc3RpbmcuCiAgICAgICAgIHZvaWQgdGVzdFJlcGFp bnQoKTsKICAgICAgICAgdm9pZCByZXBhaW50U3dlZXBIb3Jpem9udGFsbHkoKTsKZGlmZiAtLWdp dCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvTGF5b3V0VGVzdENvbnRy b2xsZXIuaCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvTGF5b3V0VGVz dENvbnRyb2xsZXIuaAppbmRleCA5MWUzNDY2MmRlOTQ1ZGE3NGRkYzIwYTY4ZDg2ZWI5NjdmMmZi MGJkLi42YTlhMTFlN2I3OWU0ZjAyODczNjI4NTdhN2M5ZTE4NTBkOTBiZjRkIDEwMDY0NAotLS0g YS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xheW91dFRlc3RDb250cm9s bGVyLmgKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRU ZXN0Q29udHJvbGxlci5oCkBAIC0xNjksNiArMTY5LDkgQEAgcHVibGljOgogICAgIHZvaWQgc2V0 VGV4dERpcmVjdGlvbihKU1N0cmluZ1JlZik7CiAKICAgICB2b2lkIHNldFNob3VsZFN0YXlPblBh Z2VBZnRlckhhbmRsaW5nQmVmb3JlVW5sb2FkKGJvb2wpOworICAgIAorICAgIGJvb2wgZ2xvYmFs RmxhZygpIGNvbnN0IHsgcmV0dXJuIG1fZ2xvYmFsRmxhZzsgfQorICAgIHZvaWQgc2V0R2xvYmFs RmxhZyhib29sIHZhbHVlKSB7IG1fZ2xvYmFsRmxhZyA9IHZhbHVlOyB9CiAKIHByaXZhdGU6CiAg ICAgc3RhdGljIGNvbnN0IGRvdWJsZSB3YWl0VG9EdW1wV2F0Y2hkb2dUaW1lckludGVydmFsOwpA QCAtMTk4LDYgKzIwMSw4IEBAIHByaXZhdGU6CiAKICAgICBib29sIG1fcG9saWN5RGVsZWdhdGVF bmFibGVkOwogICAgIGJvb2wgbV9wb2xpY3lEZWxlZ2F0ZVBlcm1pc3NpdmU7CisgICAgCisgICAg Ym9vbCBtX2dsb2JhbEZsYWc7CiAKICAgICBQbGF0Zm9ybVRpbWVyUmVmIG1fd2FpdFRvRHVtcFdh dGNoZG9nVGltZXI7CiB9Owo= 107357 2011-09-14 11:01:48 -0700 2011-09-14 11:31:00 -0700 Patch bug-68033-20110914110147.patch text/plain 3269 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogOTUwNDQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzZTgwZmIzODAxZGEyZDcwZjQ4ZGVmNTdiNmY5Yjk5NGI5 N2FmZmU4Li5hMDI0Y2RkNzk4NmRhNWM2NjlhZjlkMWUxZGU1ZjA1MjA1ODQxMjA5IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDktMTQgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgorCisgICAgICAgIElt cGxlbWVudCBnbG9iYWxGbGFnIGZvciBXZWJLaXRUZXN0UnVubmVyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODAzMworICAgICAgICA8cmRhcjovL3By b2JsZW0vMTAxMTkyMDQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0JpbmRpbmdzL0xheW91 dFRlc3RDb250cm9sbGVyLmlkbDogUG9ydGluZyBnbG9iYWxGbGFnIGZyb20gRFJUCisgICAgICAg ICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5j cHA6CisgICAgICAgIChXVFI6OkxheW91dFRlc3RDb250cm9sbGVyOjpMYXlvdXRUZXN0Q29udHJv bGxlcik6IGluaXRpYWxpemUgbV9nbG9iYWxGbGFnIHRvIGZhbHNlCisgICAgICAgICogV2ViS2l0 VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5oOiBhZGQgbV9n bG9iYWxGbGFnCisgICAgICAgIChXVFI6OkxheW91dFRlc3RDb250cm9sbGVyOjpnbG9iYWxGbGFn KTogc2ltcGxlIGdldHRlcgorICAgICAgICAoV1RSOjpMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0 R2xvYmFsRmxhZyk6IHNpbXBsZSBzZXR0ZXIKKwogMjAxMS0wOS0xMyAgUnlvc3VrZSBOaXdhICA8 cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgQWxpY2UgYW5kIEFyeWVoIHRvIHRoZSBs aXN0IG9mIGNvbnRyaWJ1dG9ycy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvQmluZGluZ3MvTGF5b3V0VGVzdENvbnRyb2xsZXIuaWRsIGIvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9CaW5kaW5ncy9MYXlvdXRUZXN0Q29udHJv bGxlci5pZGwKaW5kZXggZjE0NjhkMDJjY2IxZWI3MDFmMjNiYWMzNzBhNDlkZmE5ZWFjYTdkNC4u NTIxYWI3YzBhNjAwY2NlNWZjZWM3MzAyZTJiN2I0OGFjMTczZjk3YiAxMDA2NDQKLS0tIGEvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9CaW5kaW5ncy9MYXlvdXRUZXN0Q29u dHJvbGxlci5pZGwKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9C aW5kaW5ncy9MYXlvdXRUZXN0Q29udHJvbGxlci5pZGwKQEAgLTY2LDYgKzY2LDkgQEAgbW9kdWxl IFdUUiB7CiAgICAgICAgIERPTVN0cmluZyBtYXJrZXJUZXh0Rm9yTGlzdEl0ZW0oaW4gb2JqZWN0 IGVsZW1lbnQpOwogICAgICAgICB1bnNpZ25lZCBsb25nIHdpbmRvd0NvdW50KCk7CiAKKyAgICAg ICAgLy8gU3BlY2lhbCBET00gdmFyaWFibGVzLgorICAgICAgICBhdHRyaWJ1dGUgYm9vbGVhbiBn bG9iYWxGbGFnOworCiAgICAgICAgIC8vIFJlcGFpbnQgdGVzdGluZy4KICAgICAgICAgdm9pZCB0 ZXN0UmVwYWludCgpOwogICAgICAgICB2b2lkIHJlcGFpbnRTd2VlcEhvcml6b250YWxseSgpOwpk aWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRU ZXN0Q29udHJvbGxlci5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxl L0xheW91dFRlc3RDb250cm9sbGVyLmNwcAppbmRleCAyNzkwZjJlYWM4ODc2MzY0MmIwYTk1MTkw MGU2OGM1ZThiYzY1MGU5Li4wM2MyN2Y2NTE0NjI3NTcwMzYwOGFiMjhiNzZjZThiOTRkZjE1MGQx IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xheW91 dFRlc3RDb250cm9sbGVyLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVk QnVuZGxlL0xheW91dFRlc3RDb250cm9sbGVyLmNwcApAQCAtMTA2LDYgKzEwNiw3IEBAIExheW91 dFRlc3RDb250cm9sbGVyOjpMYXlvdXRUZXN0Q29udHJvbGxlcigpCiAgICAgLCBtX3dpbGxTZW5k UmVxdWVzdFJldHVybnNOdWxsKGZhbHNlKQogICAgICwgbV9wb2xpY3lEZWxlZ2F0ZUVuYWJsZWQo ZmFsc2UpCiAgICAgLCBtX3BvbGljeURlbGVnYXRlUGVybWlzc2l2ZShmYWxzZSkKKyAgICAsIG1f Z2xvYmFsRmxhZyhmYWxzZSkKIHsKICAgICBwbGF0Zm9ybUluaXRpYWxpemUoKTsKIH0KZGlmZiAt LWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvTGF5b3V0VGVzdENv bnRyb2xsZXIuaCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvTGF5b3V0 VGVzdENvbnRyb2xsZXIuaAppbmRleCA5MWUzNDY2MmRlOTQ1ZGE3NGRkYzIwYTY4ZDg2ZWI5Njdm MmZiMGJkLi42YTlhMTFlN2I3OWU0ZjAyODczNjI4NTdhN2M5ZTE4NTBkOTBiZjRkIDEwMDY0NAot LS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xheW91dFRlc3RDb250 cm9sbGVyLmgKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlv dXRUZXN0Q29udHJvbGxlci5oCkBAIC0xNjksNiArMTY5LDkgQEAgcHVibGljOgogICAgIHZvaWQg c2V0VGV4dERpcmVjdGlvbihKU1N0cmluZ1JlZik7CiAKICAgICB2b2lkIHNldFNob3VsZFN0YXlP blBhZ2VBZnRlckhhbmRsaW5nQmVmb3JlVW5sb2FkKGJvb2wpOworICAgIAorICAgIGJvb2wgZ2xv YmFsRmxhZygpIGNvbnN0IHsgcmV0dXJuIG1fZ2xvYmFsRmxhZzsgfQorICAgIHZvaWQgc2V0R2xv YmFsRmxhZyhib29sIHZhbHVlKSB7IG1fZ2xvYmFsRmxhZyA9IHZhbHVlOyB9CiAKIHByaXZhdGU6 CiAgICAgc3RhdGljIGNvbnN0IGRvdWJsZSB3YWl0VG9EdW1wV2F0Y2hkb2dUaW1lckludGVydmFs OwpAQCAtMTk4LDYgKzIwMSw4IEBAIHByaXZhdGU6CiAKICAgICBib29sIG1fcG9saWN5RGVsZWdh dGVFbmFibGVkOwogICAgIGJvb2wgbV9wb2xpY3lEZWxlZ2F0ZVBlcm1pc3NpdmU7CisgICAgCisg ICAgYm9vbCBtX2dsb2JhbEZsYWc7CiAKICAgICBQbGF0Zm9ybVRpbWVyUmVmIG1fd2FpdFRvRHVt cFdhdGNoZG9nVGltZXI7CiB9Owo=