67969 2011-09-12 16:24:16 -0700 Implement a HashChangeEvent constructor for V8 2011-09-14 01:32:11 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 67824 0 haraken webkit-unassigned abarth ap dominicc sam webkit.review.bot oldest_to_newest 465929 0 haraken 2011-09-12 16:24:16 -0700 We have been working on implementing constructors of Events. HashChangeEvent has a constructor in JSC (https://bugs.webkit.org/show_bug.cgi?id=67924), but do not have it in V8. 465933 1 107106 haraken 2011-09-12 16:30:58 -0700 Created attachment 107106 Patch 466672 2 107106 japhet 2011-09-13 16:36:25 -0700 Comment on attachment 107106 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107106&action=review > Source/WebCore/dom/HashChangeEvent.idl:26 > - CustomConstructFunction > + CustomConstructFunction, > + V8CustomConstructor It looks like there's substantial overlap between these two attributes. Is there any chance we could merge them? 466696 3 107106 morrita 2011-09-13 17:00:58 -0700 Comment on attachment 107106 Patch Haraken should respond Chapin's comment. 466746 4 107106 webkit.review.bot 2011-09-13 18:04:34 -0700 Comment on attachment 107106 Patch Clearing flags on attachment: 107106 Committed r95063: <http://trac.webkit.org/changeset/95063> 466747 5 webkit.review.bot 2011-09-13 18:04:39 -0700 All reviewed patches have been landed. Closing bug. 466917 6 haraken 2011-09-14 01:32:11 -0700 (In reply to comment #2) > (From update of attachment 107106 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107106&action=review > > > Source/WebCore/dom/HashChangeEvent.idl:26 > > - CustomConstructFunction > > + CustomConstructFunction, > > + V8CustomConstructor > > It looks like there's substantial overlap between these two attributes. Is there any chance we could merge them? Sure! I will do it sometime soon. 107106 2011-09-12 16:30:58 -0700 2011-09-13 18:04:34 -0700 Patch bug-67969-20110913083056.patch text/plain 4591 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ5ODAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwYTQ0OTRhODNhYzc1YzE4OWYzNzQ5 MDRhYmJkMTk2ZjQ3MTFjYjY2Li4xMDQyODc4YzA3Mzk5YmQ5N2Q4ZTMxY2RlODMyZGYwYzBhNDQ3 MDQzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMTIgIEtlbnRhcm8gSGFyYSAgPGhh cmFrZW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBJbXBsZW1lbnQgYSBIYXNoQ2hhbmdlRXZlbnQg Y29uc3RydWN0b3IgZm9yIFY4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02Nzk2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEVuYWJsZWQgaGFzaC1jaGFuZ2UtZXZlbnQtY29uc3RydWN0b3IuaHRtbCwgc2lu Y2Ugbm93IFY4IGhhcyBhIEhhc2hDaGFuZ2VFdmVudCBjb25zdHJ1Y3Rvci4KKworICAgICAgICAq IHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMS0wOS0xMiAg QmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3ODk4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKaW5kZXggOTc0MjMyNjllZTVmOWJj YWY3ZGUyMTdmZTNlNDJkYzc0ZmFkZjdmZS4uNmFkZTliZmM2NjdmODgxZGE1NTg0NjVmYjE4M2I1 NzE5MTA1MjBlMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVz dF9leHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rl c3RfZXhwZWN0YXRpb25zLnR4dApAQCAtODMsOSArODMsNiBAQCBCVUdDUjEwMzk1IFNLSVAgOiBz dmcvd2ViYXJjaGl2ZSA9IFBBU1MgRkFJTAogQlVHQ1IxMDM5NSBTS0lQIDogc3ZnL2N1c3RvbS9p bWFnZS13aXRoLXByZWZpeC1pbi13ZWJhcmNoaXZlLnN2ZyA9IFBBU1MgRkFJTAogQlVHQ1IxMDM5 NSBTS0lQIDogaHR0cC90ZXN0cy93ZWJhcmNoaXZlID0gUEFTUyBGQUlMCiAKLS8vIFRoaXMgd2ls bCBzb29uIGJlIGZpeGVkIGFmdGVyIGltcGxlbWVudGluZyBhIEhhc2hDaGFuZ2VFdmVudCBjb25z dHJ1Y3RvciBmb3IgVjguCi1CVUdXSzY3OTI0IDogZmFzdC9ldmVudHMvY29uc3RydWN0b3JzL2hh c2gtY2hhbmdlLWV2ZW50LWNvbnN0cnVjdG9yLmh0bWwgPSBGQUlMCi0KIC8vIEFjY29yZGluZyB0 byB0aGUgQ2hyb21pdW0gYnVnLCB3ZSBuZWVkIHRvIHdyaXRlIHNvbWUgc29ydCBvZiB3b3JrYXJv dW5kIGZvcgogLy8gaG93IGNsaXBib2FyZHMgb24gV2luZG93cyB3b3JrLCBvciBzb21ldGhpbmc/ ICBUaGF0IGRvZXNuJ3QgZXhwbGFpbiB3aHkgdGhpcwogLy8gZmFpbHMgZm9yIG90aGVyIHBsYXRm b3Jtcy4uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQ0ZDcyMjhjYjRjMzI4MWI3MTZlMzM0Mzc2MmMzMGM1NmU0 YzMwZmYuLjhhZmEwZDY4ZDM5ODM4MmUyNmQ0NGNmZmRlZTg2MTJkYTQ3ZGFkY2UgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wOS0xMiAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBn b29nbGUuY29tPgorCisgICAgICAgIEltcGxlbWVudCBhIEhhc2hDaGFuZ2VFdmVudCBjb25zdHJ1 Y3RvciBmb3IgVjgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY3OTY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGVzdDogZmFzdC9ldmVudHMvY29uc3RydWN0b3JzL2hhc2gtY2hhbmdlLWV2ZW50LWNvbnN0 cnVjdG9yLmh0bWwKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEV2ZW50Q29uc3Ry dWN0b3JzLmNwcDogQWRkZWQgdGhlIEhhc2hDaGFuZ2VFdmVudCBjb25zdHJ1Y3Rvci4KKyAgICAg ICAgKiBkb20vSGFzaENoYW5nZUV2ZW50LmlkbDogQWRkZWQgYSAnVjhDdXN0b21Db25zdHJ1Y3Rv cicgYXR0cmlidXRlLgorCiAyMDExLTA5LTEyICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNv bT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc4 OTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEV2ZW50 Q29uc3RydWN0b3JzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEV2 ZW50Q29uc3RydWN0b3JzLmNwcAppbmRleCBlNGNiNTVkOGM4ZGY2Yzk3ZjAwOGQ5ZDBkZWZiOGFh MWJhMWM0ZWRlLi4zMjdhOTZjNTkzOTIyNGYzYTZhMmIxNjQwYWI2OWE4YWU4YjEwODAwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhFdmVudENvbnN0cnVj dG9ycy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RXZlbnRD b25zdHJ1Y3RvcnMuY3BwCkBAIC0zNCw2ICszNCw3IEBACiAjaW5jbHVkZSAiQ3VzdG9tRXZlbnQu aCIKICNpbmNsdWRlICJEb2N1bWVudC5oIgogI2luY2x1ZGUgIkRvY3VtZW50RnJhZ21lbnQuaCIK KyNpbmNsdWRlICJIYXNoQ2hhbmdlRXZlbnQuaCIKICNpbmNsdWRlICJOb2RlLmgiCiAjaW5jbHVk ZSAiUHJvZ3Jlc3NFdmVudC5oIgogI2luY2x1ZGUgIldlYktpdEFuaW1hdGlvbkV2ZW50LmgiCkBA IC00NCw2ICs0NSw3IEBACiAjaW5jbHVkZSAiVjhDdXN0b21FdmVudC5oIgogI2luY2x1ZGUgIlY4 RG9jdW1lbnQuaCIKICNpbmNsdWRlICJWOEV2ZW50LmgiCisjaW5jbHVkZSAiVjhIYXNoQ2hhbmdl RXZlbnQuaCIKICNpbmNsdWRlICJWOE5vZGUuaCIKICNpbmNsdWRlICJWOFByb2dyZXNzRXZlbnQu aCIKICNpbmNsdWRlICJWOFByb3h5LmgiCkBAIC0xMDUsNiArMTA3LDcgQEAgSU5TVEFOVElBVEVf SU5JVElBTElaSU5HX0NPTlNUUlVDVE9SX0ZPUl9FVkVOVChESUNUSU9OQVJZX1NUQVJULCBESUNU SU9OQVJZX0VORCwKIElOU1RBTlRJQVRFX0lOSVRJQUxJWklOR19DT05TVFJVQ1RPUl9GT1JfQ1VT VE9NX0VWRU5UKERJQ1RJT05BUllfU1RBUlQsIERJQ1RJT05BUllfRU5ELCBGSUxMX1BBUkVOVF9Q Uk9QRVJUSUVTLCBGSUxMX1BST1BFUlRZKQogSU5TVEFOVElBVEVfSU5JVElBTElaSU5HX0NPTlNU UlVDVE9SX0ZPUl9QUk9HUkVTU19FVkVOVChESUNUSU9OQVJZX1NUQVJULCBESUNUSU9OQVJZX0VO RCwgRklMTF9QQVJFTlRfUFJPUEVSVElFUywgRklMTF9QUk9QRVJUWSkKIElOU1RBTlRJQVRFX0lO SVRJQUxJWklOR19DT05TVFJVQ1RPUl9GT1JfV0VCS0lUX0FOSU1BVElPTl9FVkVOVChESUNUSU9O QVJZX1NUQVJULCBESUNUSU9OQVJZX0VORCwgRklMTF9QQVJFTlRfUFJPUEVSVElFUywgRklMTF9Q Uk9QRVJUWSkKK0lOU1RBTlRJQVRFX0lOSVRJQUxJWklOR19DT05TVFJVQ1RPUl9GT1JfSEFTSF9D SEFOR0VfRVZFTlQoRElDVElPTkFSWV9TVEFSVCwgRElDVElPTkFSWV9FTkQsIEZJTExfUEFSRU5U X1BST1BFUlRJRVMsIEZJTExfUFJPUEVSVFkpCiAKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0hhc2hDaGFuZ2VFdmVudC5pZGwgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vSGFzaENoYW5nZUV2ZW50LmlkbAppbmRleCA4YTE0ZWM4NTRhMDBlYjY3 NWQ4Njk4NDA0NjRiZWEwZjZmODg3N2RkLi4xMzA2OWVjMGZlZmRhZTg2NmRmZjNlODQ4YTI3NTZk MzkyMmEzNDA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vSGFzaENoYW5nZUV2ZW50 LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vSGFzaENoYW5nZUV2ZW50LmlkbApAQCAtMjIs NyArMjIsOCBAQCBtb2R1bGUgZXZlbnRzIHsKICAgICAvLyBJbnRyb2R1Y2VkIGluIGh0dHA6Ly93 d3cud2hhdHdnLm9yZy9zcGVjcy93ZWItYXBwcy9jdXJyZW50LXdvcmsvbXVsdGlwYWdlL2hpc3Rv cnkuaHRtbCNldmVudC1oYXNoY2hhbmdlCiAgICAgaW50ZXJmYWNlIFsKICAgICAgICAgQ2FuQmVD b25zdHJ1Y3RlZCwKLSAgICAgICAgQ3VzdG9tQ29uc3RydWN0RnVuY3Rpb24KKyAgICAgICAgQ3Vz dG9tQ29uc3RydWN0RnVuY3Rpb24sCisgICAgICAgIFY4Q3VzdG9tQ29uc3RydWN0b3IKICAgICBd IEhhc2hDaGFuZ2VFdmVudCA6IEV2ZW50IHsKICAgICAgICAgdm9pZCBpbml0SGFzaENoYW5nZUV2 ZW50KGluIFtPcHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gRE9NU3RyaW5nIHR5cGUsIAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVm YXVsdFZhbHVlXSBib29sZWFuIGNhbkJ1YmJsZSwgCg==