67936 2011-09-12 08:16:45 -0700 REGRESSION(r81225): ORWT should ignore reftests 2012-01-17 08:21:50 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 55936 1 ossy bank ossy oldest_to_newest 465611 0 ossy 2011-09-12 08:16:45 -0700 When I run ORWT, the following tests are missing from tests_run.txt: (All of them are ref test) editing/pasteboard/data-transfer-items-image-png.html fast/forms/checkbox-appearance-change-by-checked.html fast/forms/file-input-reset.html fast/forms/file/file-reset-in-change.html fast/forms/placeholder-in-invisible-elements.html fast/forms/range/input-appearance-range-rtl.html fast/forms/search-cancel-in-invisible-elements.html fast/harness/font-weight-bold.html fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html fast/harness/sample-mismatch-reftest-expected-mismatch.html fast/harness/sample-mismatch-reftest.html When I passed these tests to the commandline of ORWT, it reported that they are new tests without expected files. 537011 1 ossy 2012-01-17 03:51:22 -0800 If you don't pass any parameter to ORWT or if you pass directory, it ignores reftests, because it can't handle reftests. It's correct behaviour. But if you pass complete test names it reports that they are new tests without expected files. The correct solution can be that ORWT should ignore reftests always. 537043 2 122753 bank 2012-01-17 06:10:04 -0800 Created attachment 122753 proposed fix Based on Csaba Osztrogonac's first comment. 537045 3 122753 ossy 2012-01-17 06:16:26 -0800 Comment on attachment 122753 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=122753&action=review LGTM, but the changelog isn't so talkative, please fix it. > Tools/ChangeLog:4 > + [ORWT] Call isUsedInReftest() in findTestsToRun if you pass complete test name. > + https://bugs.webkit.org/show_bug.cgi?id=67936 REGRESSION(r81225): ORWT should ignore reftests https://bugs.webkit.org/show_bug.cgi?id=67936 > Tools/ChangeLog:10 > + (isUsedInReftest): > + (findTestsToRun): (isUsedInReftest): $filename should be the first parameter (findTestsToRun): run test if it isn't reftest 537110 4 ossy 2012-01-17 08:12:11 -0800 Fixed patch landed in http://trac.webkit.org/changeset/105162 122753 2012-01-17 06:10:04 -0800 2012-01-17 08:12:28 -0800 proposed fix 2012-01-17_orwt.patch text/plain 1628 bank ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlMmUy MWJiNC4uYzA3MWI2OCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAxLTE3ICBCYWxhenMgQW5rZXMgIDxBbmtl cy5CYWxhenNAc3R1ZC51LXN6ZWdlZC5odT4KKworICAgICAgICBbT1JXVF0gQ2FsbCBpc1VzZWRJ blJlZnRlc3QoKSBpbiBmaW5kVGVzdHNUb1J1biBpZiB5b3UgcGFzcyBjb21wbGV0ZSB0ZXN0IG5h bWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Nzkz NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2Ny aXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0czoKKyAgICAgICAgKGlzVXNlZEluUmVmdGVzdCk6Cisg ICAgICAgIChmaW5kVGVzdHNUb1J1bik6CisKIDIwMTItMDEtMDMgIFRvciBBcm5lIFZlc3Riw7gg IDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gSW50cm9kdWNlIHFt YWtlIHJlcGxhY2UgZnVuY3Rpb24gZm9yIHRoZSBhY3RpdmUgYnVpbGQgY29uZmlnCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9v bGQtcnVuLXdlYmtpdC10ZXN0cwppbmRleCA0ZDgxMjNkLi5hMmE1MjVhIDEwMDc1NQotLS0gYS9U b29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvb2xk LXJ1bi13ZWJraXQtdGVzdHMKQEAgLTI1ODAsOSArMjU4MCw5IEBAIHN1YiByZWFkQ2hlY2tzdW1G cm9tUG5nKCQpCiAKIG15IEB0ZXN0c0ZvdW5kOwogCi1zdWIgaXNVc2VkSW5SZWZ0ZXN0CitzdWIg aXNVc2VkSW5SZWZ0ZXN0KCQpCiB7Ci0gICAgbXkgJGZpbGVuYW1lID0gJF87CisgICAgbXkgJGZp bGVuYW1lID0gJF9bMF07CiAgICAgaWYgKCRmaWxlbmFtZSA9fiAvLSRleHBlY3RlZFRhZygtJG1p c21hdGNoVGFnKT9cLmh0bWwkLykgewogICAgICAgICByZXR1cm4gMTsKICAgICB9CkBAIC0yNjE4 LDcgKzI2MTgsNyBAQCBzdWIgZmluZFRlc3RzVG9SdW4KICAgICAgICAgbXkgJGZ1bGxQYXRoID0g Y2F0ZmlsZSgkdGVzdERpcmVjdG9yeSwgJHRlc3QpOwogICAgICAgICBpZiAoZmlsZV9uYW1lX2lz X2Fic29sdXRlKCR0ZXN0KSkgewogICAgICAgICAgICAgcHJpbnQgImNhbid0IHJ1biB0ZXN0ICR0 ZXN0IG91dHNpZGUgJHRlc3REaXJlY3RvcnlcbiI7Ci0gICAgICAgIH0gZWxzaWYgKC1mICRmdWxs UGF0aCkgeworICAgICAgICB9IGVsc2lmICgtZiAkZnVsbFBhdGggJiYgIWlzVXNlZEluUmVmdGVz dCgkZnVsbFBhdGgpKSB7CiAgICAgICAgICAgICBteSAoJGZpbGVuYW1lLCAkcGF0aG5hbWUsICRm aWxlRXh0ZW5zaW9uKSA9IGZpbGVwYXJzZSgkdGVzdCwgcXJ7XC5bXi5dKyR9KTsKICAgICAgICAg ICAgIGlmICghZXhpc3RzICRzdXBwb3J0ZWRGaWxlRXh0ZW5zaW9uc3tzdWJzdHIoJGZpbGVFeHRl bnNpb24sIDEpfSkgewogICAgICAgICAgICAgICAgIHByaW50ICJ0ZXN0ICR0ZXN0IGRvZXMgbm90 IGhhdmUgYSBzdXBwb3J0ZWQgZXh0ZW5zaW9uXG4iOwo=