67855 2011-09-09 10:15:55 -0700 Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt 2011-09-09 11:20:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64812 1 rniwa webkit-unassigned aroben dpranke eric tony oldest_to_newest 464867 0 rniwa 2011-09-09 10:15:55 -0700 Some ports use RunWebKitTests instead of NewRunWebKitTests to run tests, and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput. 464868 1 106885 rniwa 2011-09-09 10:17:17 -0700 Created attachment 106885 fixes the bug 464886 2 rniwa 2011-09-09 10:38:16 -0700 We really need this patch landed ASAP. Right now, this bug is making Mac bots red. 464900 3 106885 dpranke 2011-09-09 10:54:34 -0700 Comment on attachment 106885 fixes the bug Shouldn't we switch the ports that are using RunWebKitTests to NewRunWebKitTests instead of modifying both evaluateCommands ? 464915 4 rniwa 2011-09-09 11:07:38 -0700 (In reply to comment #3) > (From update of attachment 106885 [details]) > Shouldn't we switch the ports that are using RunWebKitTests to NewRunWebKitTests instead of modifying both evaluateCommands ? We can't because some of bots are still in the process of transitioning and we may need to move it back. 464924 5 106885 dpranke 2011-09-09 11:16:23 -0700 Comment on attachment 106885 fixes the bug Per conversation over IRC, some (most?) bots are invoking NRWT through the run-webkit-tests wrapper, and so they we need to update the parser in the wrapper command. R+. We really need to consolidate these things and finish the cutover though ... 464927 6 106885 rniwa 2011-09-09 11:20:50 -0700 Comment on attachment 106885 fixes the bug Clearing flags on attachment: 106885 Committed r94868: <http://trac.webkit.org/changeset/94868> 464928 7 rniwa 2011-09-09 11:20:54 -0700 All reviewed patches have been landed. Closing bug. 106885 2011-09-09 10:17:17 -0700 2011-09-09 11:20:50 -0700 fixes the bug fix67855 text/plain 2884 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk0ODIzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTcgQEAKKzIwMTEtMDktMDggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgQnVpbGRib3QgbWF5IHVzZSBSdW5XZWJLaXRUZXN0J3MgZXZhbHVhdGVDb21tYW5k IG9uIGJvdHMgdGhhdCBydW4gbnJ3dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Njc4NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgYnVnIHdhcyBjYXVzZWQgYnkgdGhlIGZhY3Qgc29tZSBwb3J0cyB1 c2UgUnVuV2ViS2l0VGVzdHMgaW5zdGVhZCBvZiBOZXdSdW5XZWJLaXRUZXN0cyB0byBydW4gdGVz dHMsCisgICAgICAgIGFuZCB1c2luZyBSdW5XZWJLaXRUZXN0cy5ldmFsdWF0ZUNvbW1hbmQgYWZ0 ZXIgY2FsbGluZyBfcGFyc2VOZXdSdW5XZWJLaXRUZXN0c091dHB1dC4KKworICAgICAgICBGaXhl ZCB0aGUgYnVnIGJ5IG1lcmdpbmcgZXZhbHVhdGVDb21tYW5kIG9mIFJ1bldlYktpdFRlc3RzIGFu ZCBOZXdSdW5XZWJLaXRUZXN0cy4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxk LndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmc6CisKIDIwMTEtMDktMDggIEJyaWFuIFdlaW5z dGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYktpdDI6IEFzc2VydGlv biB3aGVuIGNhbGxpbmcgZGlkUGVyZm9ybSpSZWRpcmVjdCBvbiBudWxsIHNvdXJjZS9kZXN0aW5h dGlvbiBVUkwgc3RyaW5nCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcJKHJldmlzaW9uIDk0ODA2 KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwkod29ya2luZyBjb3B5KQpAQCAtMzE1LDE4ICszMTUsMjQgQEAgY2xhc3MgUnVuV2Vi S2l0VGVzdHMoc2hlbGwuVGVzdCk6CiAgICAgICAgICAgICBzZWxmLl9wYXJzZU9sZFJ1bldlYktp dFRlc3RzT3V0cHV0KGxvZ1RleHQpCiAKICAgICBkZWYgZXZhbHVhdGVDb21tYW5kKHNlbGYsIGNt ZCk6CisgICAgICAgIHJlc3VsdCA9IFNVQ0NFU1MKKwogICAgICAgICBpZiBzZWxmLmluY29ycmVj dExheW91dExpbmVzOgogICAgICAgICAgICAgaWYgbGVuKHNlbGYuaW5jb3JyZWN0TGF5b3V0TGlu ZXMpID09IDE6CiAgICAgICAgICAgICAgICAgbGluZSA9IHNlbGYuaW5jb3JyZWN0TGF5b3V0TGlu ZXNbMF0KICAgICAgICAgICAgICAgICBpZiBsaW5lLmZpbmQoJ3dlcmUgbmV3JykgPj0gMCBvciBs aW5lLmZpbmQoJ3dhcyBuZXcnKSA+PSAwIG9yIGxpbmUuZmluZCgnIGxlYWsnKSA+PSAwOgogICAg ICAgICAgICAgICAgICAgICByZXR1cm4gV0FSTklOR1MKIAotICAgICAgICAgICAgcmV0dXJuIEZB SUxVUkUKKyAgICAgICAgICAgIGZvciBsaW5lIGluIHNlbGYuaW5jb3JyZWN0TGF5b3V0TGluZXM6 CisgICAgICAgICAgICAgICAgaWYgbGluZS5maW5kKCdmbGFrZXMnKSA+PSAwIG9yIGxpbmUuZmlu ZCgnbmV3IHBhc3NlcycpID49IDAgb3IgbGluZS5maW5kKCdtaXNzaW5nIHJlc3VsdHMnKSA+PSAw OgorICAgICAgICAgICAgICAgICAgICByZXN1bHQgPSBXQVJOSU5HUworICAgICAgICAgICAgICAg IGVsc2U6CisgICAgICAgICAgICAgICAgICAgIHJldHVybiBGQUlMVVJFCiAKICAgICAgICAgaWYg Y21kLnJjICE9IDA6CiAgICAgICAgICAgICByZXR1cm4gRkFJTFVSRQogCi0gICAgICAgIHJldHVy biBTVUNDRVNTCisgICAgICAgIHJldHVybiByZXN1bHQKIAogICAgIGRlZiBnZXRUZXh0KHNlbGYs IGNtZCwgcmVzdWx0cyk6CiAgICAgICAgIHJldHVybiBzZWxmLmdldFRleHQyKGNtZCwgcmVzdWx0 cykKQEAgLTM1NCwyMCArMzYwLDYgQEAgY2xhc3MgTmV3UnVuV2ViS2l0VGVzdHMoUnVuV2ViS2l0 VGVzdHMpOgogICAgICAgICBsb2dUZXh0ID0gY21kLmxvZ3NbJ3N0ZGlvJ10uZ2V0VGV4dCgpCiAg ICAgICAgIHNlbGYuX3BhcnNlTmV3UnVuV2ViS2l0VGVzdHNPdXRwdXQobG9nVGV4dCkKIAotICAg IGRlZiBldmFsdWF0ZUNvbW1hbmQoc2VsZiwgY21kKToKLSAgICAgICAgaWYgY21kLnJjICE9IDA6 Ci0gICAgICAgICAgICByZXR1cm4gRkFJTFVSRQotCi0gICAgICAgIHJlc3VsdCA9IFNVQ0NFU1MK LSAgICAgICAgaWYgc2VsZi5pbmNvcnJlY3RMYXlvdXRMaW5lczoKLSAgICAgICAgICAgIGZvciBs aW5lIGluIHNlbGYuaW5jb3JyZWN0TGF5b3V0TGluZXM6Ci0gICAgICAgICAgICAgICAgaWYgbGlu ZS5maW5kKCdmbGFrZXMnKSA+PSAwIG9yIGxpbmUuZmluZCgnbmV3IHBhc3NlcycpID49IDAgb3Ig bGluZS5maW5kKCdtaXNzaW5nIHJlc3VsdHMnKSA+PSAwOgotICAgICAgICAgICAgICAgICAgICBy ZXN1bHQgPSBXQVJOSU5HUwotICAgICAgICAgICAgICAgIGVsc2U6Ci0gICAgICAgICAgICAgICAg ICAgIHJldHVybiBGQUlMVVJFCi0KLSAgICAgICAgcmV0dXJuIHJlc3VsdAotCiBjbGFzcyBSdW5V bml0VGVzdHMoc2hlbGwuVGVzdCk6CiAgICAgbmFtZSA9ICJydW4tYXBpLXRlc3RzIgogICAgIGRl c2NyaXB0aW9uID0gWyJ1bml0IHRlc3RzIHJ1bm5pbmciXQ==