6782 2006-01-24 18:29:26 -0800 REGRESSION: replaceChild broken when node to replace is first (TinyMCE test app broken) 2006-01-24 22:06:11 -0800 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED P1 Normal --- 6644 1 justin.garcia darin darin eric oldest_to_newest 29785 0 justin.garcia 2006-01-24 18:29:26 -0800 Goto: http://tinymce.moxiecode.com/example.php?example=true Compare the test app in TOT and an r12282 or earlier nightly build. The app looks partially loaded. This is sent to stderr in a development build: (event handler): Undefined value 29793 1 justin.garcia 2006-01-24 20:03:24 -0800 Eric thought that his changes to 5874 might have caused this regression, since they played with event handling. I've rolled out those changes and those from 5964 (since they touched some of the changes made for 5874), but the problem still exists. 29796 2 darin 2006-01-24 20:46:41 -0800 The "undefined" thing here is the contentWindow of an <iframe> element. I see HTMLFrameElementImpl::contentPart returning 0. 29797 3 darin 2006-01-24 20:56:53 -0800 At the time contentWindow is called, the <iframe> element is not yet inserted into a document. 29798 4 darin 2006-01-24 21:04:45 -0800 Figured it out. Have a reduced test case and a fix. 29799 5 5938 darin 2006-01-24 21:12:06 -0800 Created attachment 5938 fix problem in replaceChild that was breaking TinyMCE 29803 6 5938 eric 2006-01-24 21:55:04 -0800 Comment on attachment 5938 fix problem in replaceChild that was breaking TinyMCE Looks good. r=me. 29805 7 5938 darin 2006-01-24 22:02:18 -0800 Comment on attachment 5938 fix problem in replaceChild that was breaking TinyMCE Clearing the flag on this one because there is a patch in bug 6784 that fixes both this bug and that one. 5938 2006-01-24 21:12:06 -0800 2006-01-24 22:02:18 -0800 fix problem in replaceChild that was breaking TinyMCE ReplaceChildPatch.txt text/plain 4099 darin SW5kZXg6IFdlYkNvcmUva2h0bWwveG1sL0NvbnRhaW5lck5vZGVJbXBsLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL2todG1sL3htbC9Db250YWluZXJOb2RlSW1wbC5jcHAJKHJldmlzaW9uIDEy MzQxKQorKysgV2ViQ29yZS9raHRtbC94bWwvQ29udGFpbmVyTm9kZUltcGwuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yNDYsNyArMjQ2LDcgQEAKICAgICBSZWZQdHI8Tm9kZUltcGw+IGNoaWxkID0g aXNGcmFnbWVudCA/IG5ld0NoaWxkLT5maXJzdENoaWxkKCkgOiBuZXdDaGlsZC5nZXQoKTsKICAg ICB3aGlsZSAoY2hpbGQpIHsKICAgICAgICAgLy8gSWYgdGhlIG5ldyBjaGlsZCBpcyBhbHJlYWR5 IGluIHRoZSByaWdodCBwbGFjZSwgd2UncmUgZG9uZS4KLSAgICAgICAgaWYgKHByZXYgPT0gY2hp bGQgfHwgcHJldiA9PSBjaGlsZC0+cHJldmlvdXNTaWJsaW5nKCkpCisgICAgICAgIGlmIChwcmV2 ICYmIChwcmV2ID09IGNoaWxkIHx8IHByZXYgPT0gY2hpbGQtPnByZXZpb3VzU2libGluZygpKSkK ICAgICAgICAgICAgIGJyZWFrOwogCiAgICAgICAgIC8vIEZvciBhIGZyYWdtZW50IHdlIGhhdmUg bW9yZSBjaGlsZHJlbiB0byBkby4KSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjM0MSkKKysrIFdlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsMTUgQEAKIDIwMDYtMDEtMjQgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSBZRVQu CisKKyAgICAgICAgLSB0ZXN0IGZvciBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hv d19idWcuY2dpP2lkPTY3ODIKKyAgICAgICAgICBSRUdSRVNTSU9OOiByZXBsYWNlQ2hpbGQgYnJv a2VuIHdoZW4gbm9kZSB0byByZXBsYWNlIGlzIGZpcnN0IChUaW55TUNFIHRlc3QgYXBwIGJyb2tl bikKKworICAgICAgICAqIGtodG1sL3htbC9Db250YWluZXJOb2RlSW1wbC5jcHA6IChXZWJDb3Jl OjpDb250YWluZXJOb2RlSW1wbDo6aW5zZXJ0QmVmb3JlKToKKyAgICAgICAgRml4IHRlc3QgdGhh dCB3b3VsZCBzY3JldyB1cCB3aGVuIGJvdGggInByZXYiIGFuZCAicmVmQ2hpbGQtPnByZXZpb3Vz U2libGluZygpIiB3ZXJlIDAuCisKKzIwMDYtMDEtMjQgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBw bGUuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4gU3VsbGl2YW4uCiAKICAgICAgICAg LSBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTY3NTAKSW5k ZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHJldmlzaW9uIDEyMzQwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMDEtMjQgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSBZRVQuCisKKyAgICAgICAg LSB0ZXN0IGZvciBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lk PTY3ODIKKyAgICAgICAgICBSRUdSRVNTSU9OOiByZXBsYWNlQ2hpbGQgYnJva2VuIHdoZW4gbm9k ZSB0byByZXBsYWNlIGlzIGZpcnN0IChUaW55TUNFIHRlc3QgYXBwIGJyb2tlbikKKworICAgICAg ICAqIGZhc3QvZG9tL3JlcGxhY2UtZmlyc3QtY2hpbGQuaHRtbDogQWRkZWQuCisgICAgICAgICog ZmFzdC9kb20vcmVwbGFjZS1maXJzdC1jaGlsZC1leHBlY3RlZC50eHQ6IEFkZGVkCisKIDIwMDYt MDEtMjMgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIC0gdGVzdCBm b3IgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD02Mzg1Cklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9yZXBsYWNlLWZpcnN0LWNoaWxkLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9yZXBsYWNlLWZpcnN0LWNoaWxk LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL3JlcGxh Y2UtZmlyc3QtY2hpbGQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQgQEAK K1RoaXMgdGVzdHMgZm9yIGEgYnVnIGluIHJlcGxhY2VDaGlsZCB3aGVyZSBpdCB3b3VsZCBmYWls IHRvIHJlcGxhY2UgYW4gZWxlbWVudCBpZiBpdCB3YXMgdGhlIGZpcnN0IGNoaWxkIG9mIGl0cyBj b250YWluZXIuIFNlZSBidWcgNjc4MiBmb3IgZGV0YWlscy4gSWYgdGhlIHRlc3QgaXMgc3VjY2Vz c2Z1bCB5b3Ugd2lsbCBzZWUgYW4gb2JqZWN0IGRlc2NyaXB0aW9uIGJlbG93LCBhbmQgaWYgaXQg ZmFpbHMgeW91IHdpbGwgc2VlICJudWxsIi4KKworW29iamVjdCBESVZdCisKClByb3BlcnR5IGNo YW5nZXMgb246IExheW91dFRlc3RzL2Zhc3QvZG9tL3JlcGxhY2UtZmlyc3QtY2hpbGQtZXhwZWN0 ZWQudHh0Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KTmFtZTogc3ZuOmVvbC1zdHlsZQogICArIG5hdGl2ZQoKSW5kZXg6 IExheW91dFRlc3RzL2Zhc3QvZG9tL3JlcGxhY2UtZmlyc3QtY2hpbGQuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9yZXBsYWNlLWZpcnN0LWNoaWxkLmh0bWwJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9yZXBsYWNlLWZpcnN0LWNoaWxkLmh0bWwJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTQgQEAKKzxzY3JpcHQ+CitmdW5jdGlvbiB0ZXN0KCkg eworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIGxheW91dFRlc3RDb250cm9s bGVyLmR1bXBBc1RleHQoKTsKKyAgICB2YXIgbm9kZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo ImRpdiIpOworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXBsYWNlIikucGFyZW50Tm9k ZS5yZXBsYWNlQ2hpbGQobm9kZSwgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlcGxhY2UiKSk7 CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpLmFwcGVuZENoaWxkKGRvY3Vt ZW50LmNyZWF0ZVRleHROb2RlKG5vZGUucGFyZW50Tm9kZSkpOworfQorPC9zY3JpcHQ+Cis8Ym9k eSBvbmxvYWQ9InRlc3QoKSI+Cis8cD5UaGlzIHRlc3RzIGZvciBhIGJ1ZyBpbiByZXBsYWNlQ2hp bGQgd2hlcmUgaXQgd291bGQgZmFpbCB0byByZXBsYWNlIGFuIGVsZW1lbnQgaWYgaXQgd2FzIHRo ZSBmaXJzdCBjaGlsZCBvZiBpdHMgY29udGFpbmVyLgorU2VlIDxhIGhyZWY9Imh0dHA6Ly9idWd6 aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc4MiI+YnVnIDY3ODI8L2E+IGZv ciBkZXRhaWxzLgorSWYgdGhlIHRlc3QgaXMgc3VjY2Vzc2Z1bCB5b3Ugd2lsbCBzZWUgYW4gb2Jq ZWN0IGRlc2NyaXB0aW9uIGJlbG93LCBhbmQgaWYgaXQgZmFpbHMgeW91IHdpbGwgc2VlICJudWxs Ii48L3A+Cis8ZGl2PjxkaXYgaWQ9InJlcGxhY2UiPjwvZGl2PjwvZGl2PgorPGRpdiBpZD0icmVz dWx0Ij48L2Rpdj48L2JvZHk+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0 L2RvbS9yZXBsYWNlLWZpcnN0LWNoaWxkLmh0bWwKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWltZS10 eXBlCiAgICsgdGV4dC9odG1sCk5hbWU6IHN2bjplb2wtc3R5bGUKICAgKyBuYXRpdmUKCg==