67690 2011-09-06 18:28:20 -0700 Remove virtual functions from JSCell 2011-10-27 10:17:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 67691 67727 67875 67902 67909 67911 68404 68651 68741 68839 68851 68937 69024 69156 69186 69311 69593 69659 69673 69677 69679 69807 69810 69851 69858 69872 69884 70162 70163 70257 70271 70281 70439 70638 70738 70740 70741 70958 69382 1 mhahnenberg mhahnenberg oldest_to_newest 463043 0 mhahnenberg 2011-09-06 18:28:20 -0700 In order to maintain more control over exactly how JS objects are laid out, we need to remove the C++ virtual functions from JS object implementations due to the freedom that C++ compilers are given with how they lay out objects with vtable pointers. We can also save a little bit of memory due to the lack of vtable pointer in each object. The methods in JSCell that either need to be made non-virtual or removed are the following: isGetterSetter isAPIValueWrapper isPropertyNameIterator getCallData getConstructData getUInt32 toPrimitive getPrimitive toBoolean toNumber toString toObject visitChildren put(ExecState*, const Identifier&, JSValue, PutPropertySlot&) put(ExecState*, unsigned, JSValue) deleteProperty(ExecState*, const Identifier&) deleteProperty(ExecState*, unsigned) toThisObject getJSNumber getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&) getOwnPropertySlot(ExecState*, unsigned, PropertySlot&) Destructors will be taken care of by Oliver :-) There will be a patch for each function, roughly. This will serve as the tracking bug for this task. 467484 1 mhahnenberg 2011-09-14 17:15:53 -0700 Sam helped me out a little bit and de-virtualized isGetterSetter, isAPIValueWrapper, and killed isPropertyNameIterator :-) 491676 2 mhahnenberg 2011-10-27 10:17:37 -0700 Except the virtual destructor, which will remain for a while longer until we get around to replacing virtual destructors with finalizers, there are no longer any virtual functions in JSCell. Closing this bug.