67459 2011-09-01 18:24:34 -0700 Generate an EventSource constructor of V8 using the IDL 'Constructor' extended attribute 2011-09-02 00:40:51 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 65839 0 haraken webkit-unassigned abarth ap dglazkov dominicc webkit.review.bot oldest_to_newest 460987 0 haraken 2011-09-01 18:24:34 -0700 Currently, the EventSource constructor is written manually as a custom constructor. We should replace this with automatically generated code by the IDL 'Constructor' extended attribute. 460991 1 106078 haraken 2011-09-01 18:32:33 -0700 Created attachment 106078 Patch 461079 2 106078 webkit.review.bot 2011-09-02 00:40:46 -0700 Comment on attachment 106078 Patch Clearing flags on attachment: 106078 Committed r94390: <http://trac.webkit.org/changeset/94390> 461080 3 webkit.review.bot 2011-09-02 00:40:51 -0700 All reviewed patches have been landed. Closing bug. 106078 2011-09-01 18:32:33 -0700 2011-09-02 00:40:46 -0700 Patch bug-67459-20110901183232.patch text/plain 6505 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTQzNzYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwYWZhYzUxZjMxZTFjNDlj Y2VjNWYwMzJiZDhlMzFiOTI0NTYwNjA3Li5lMzhmOGZmM2U5MjJlMzUyMjU4YjVhOWUxNjUxNDMz YjIyOTQ5MzM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTEtMDktMDEgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AZ29vZ2xlLmNvbT4KIAorICAgICAgICBHZW5lcmF0ZSBhbiBFdmVu dFNvdXJjZSBjb25zdHJ1Y3RvciBvZiBWOCB1c2luZyB0aGUgSURMICdDb25zdHJ1Y3RvcicgZXh0 ZW5kZWQgYXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02NzQ1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRlc3RzOiBmYXN0L2V2ZW50c291cmNlL2V2ZW50c291cmNlLWNvbnN0cnVjdG9yLmh0 bWwKKyAgICAgICAgICAgICAgIGZhc3QvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtYXR0cmlidXRl LWxpc3RlbmVycy5odG1sCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cGk6IFJlbW92ZWQgVjhFdmVu dFNvdXJjZUNvbnN0cnVjdG9yLmNwcC4KKyAgICAgICAgKiBXZWJDb3JlLnBybzogUmVtb3ZlZCBW OEV2ZW50U291cmNlQ29uc3RydWN0b3IuY3BwLgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3Rv bS9WOEV2ZW50U291cmNlQ29uc3RydWN0b3IuY3BwOiBSZW1vdmVkLgorICAgICAgICAqIHBhZ2Uv RXZlbnRTb3VyY2UuaWRsOiBBZGRlZCB0aGUgJ0NvbnN0cnVjdG9yJyBleHRlbmRlZCBhdHRyaWJ1 dGUuCisKKzIwMTEtMDktMDEgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AZ29vZ2xlLmNvbT4KKwog ICAgICAgICBHZW5lcmF0ZSBhIEZpbGVSZWFkZXIgY29uc3RydWN0b3Igb2YgVjggdXNpbmcgdGhl IElETCAnQ29uc3RydWN0b3InIGV4dGVuZGVkIGF0dHJpYnV0ZQogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc0MTIKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvV2ViQ29yZS5neXBpIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXBpCmluZGV4 IGI4MzYzZmUxYzZjYTA1ZTA2YTRjYTBiNWY2ODIzYmE3NjU5YTQ1M2YuLjI3OTU5NmQ1ZmI4MDM5 ODRlY2QzNzQwY2M0YmMyYTViZDM0MzhhYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dl YkNvcmUuZ3lwaQorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkKQEAgLTIxNDgsNyAr MjE0OCw2IEBACiAgICAgICAgICAgICAnYmluZGluZ3MvdjgvY3VzdG9tL1Y4RW50cnlDdXN0b20u Y3BwJywKICAgICAgICAgICAgICdiaW5kaW5ncy92OC9jdXN0b20vVjhFbnRyeVN5bmNDdXN0b20u Y3BwJywKICAgICAgICAgICAgICdiaW5kaW5ncy92OC9jdXN0b20vVjhFdmVudEN1c3RvbS5jcHAn LAotICAgICAgICAgICAgJ2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEV2ZW50U291cmNlQ29uc3RydWN0 b3IuY3BwJywKICAgICAgICAgICAgICdiaW5kaW5ncy92OC9jdXN0b20vVjhGaWxlUmVhZGVyQ3Vz dG9tLmNwcCcsCiAgICAgICAgICAgICAnYmluZGluZ3MvdjgvY3VzdG9tL1Y4RmxvYXQzMkFycmF5 Q3VzdG9tLmNwcCcsCiAgICAgICAgICAgICAnYmluZGluZ3MvdjgvY3VzdG9tL1Y4RmxvYXQ2NEFy cmF5Q3VzdG9tLmNwcCcsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnBybyBi L1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJvCmluZGV4IDhmNTMyY2M3NjI2ZmY4OWIwZWMwMWUy N2I3ZjA2YzIyYjUzODRmMTIuLmJkMjI1N2UxNzIyYzE4MzQ4YzJmMTM1MTVlZjVmZTI3MjNhOGY5 ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJvCisrKyBiL1NvdXJjZS9X ZWJDb3JlL1dlYkNvcmUucHJvCkBAIC0xNjUsNyArMTY1LDYgQEAgdjggewogICAgICAgICBiaW5k aW5ncy92OC9jdXN0b20vVjhEb2N1bWVudExvY2F0aW9uQ3VzdG9tLmNwcCBcCiAgICAgICAgIGJp bmRpbmdzL3Y4L2N1c3RvbS9WOEVsZW1lbnRDdXN0b20uY3BwIFwKICAgICAgICAgYmluZGluZ3Mv djgvY3VzdG9tL1Y4RXZlbnRDdXN0b20uY3BwIFwKLSAgICAgICAgYmluZGluZ3MvdjgvY3VzdG9t L1Y4RXZlbnRTb3VyY2VDb25zdHJ1Y3Rvci5jcHAgXAogICAgICAgICBiaW5kaW5ncy92OC9jdXN0 b20vVjhGaWxlUmVhZGVyQ3VzdG9tLmNwcCBcCiAgICAgICAgIGJpbmRpbmdzL3Y4L2N1c3RvbS9W OEhUTUxBbGxDb2xsZWN0aW9uQ3VzdG9tLmNwcAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9jdXN0b20vVjhFdmVudFNvdXJjZUNvbnN0cnVjdG9yLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEV2ZW50U291cmNlQ29uc3RydWN0b3IuY3Bw CmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCBhNDA5NTFjOWQ2YzY1NGExYjM0YzJmNWI4 YWY3NDMzZjEzNzkwN2JhLi4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEV2ZW50U291cmNlQ29u c3RydWN0b3IuY3BwCisrKyAvZGV2L251bGwKQEAgLTEsNzkgKzAsMCBAQAotLyoKLSAqIENvcHly aWdodCAoQykgMjAxMCBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgotICoKLSAqIFJl ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig d2l0aG91dAotICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhl IGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQotICogbWV0OgotICoKLSAqICAgICAqIFJlZGlzdHJp YnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0Ci0g KiBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2Ns YWltZXIuCi0gKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXBy b2R1Y2UgdGhlIGFib3ZlCi0gKiBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0 aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCi0gKiBpbiB0aGUgZG9jdW1lbnRhdGlv biBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCi0gKiBkaXN0cmlidXRp b24uCi0gKiAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEdvb2dsZSBJbmMuIG5vciB0aGUgbmFt ZXMgb2YgaXRzCi0gKiBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9t b3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQotICogdGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNp ZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KLSAqCi0gKiBUSElTIFNPRlRXQVJFIElTIFBS T1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCi0gKiAiQVMg SVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVU IE5PVAotICogTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFC SUxJVFkgQU5EIEZJVE5FU1MgRk9SCi0gKiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xB SU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVAotICogT1dORVIgT1IgQ09OVFJJ QlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsCi0g KiBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5H LCBCVVQgTk9UCi0gKiBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RT IE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwKLSAqIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lO RVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQotICogVEhFT1JZIE9G IExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9S VAotICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkg V0FZIE9VVCBPRiBUSEUgVVNFCi0gKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQg T0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgotICovCi0KLSNpbmNsdWRlICJjb25m aWcuaCIKLQotI2lmIEVOQUJMRShFVkVOVFNPVVJDRSkKLSNpbmNsdWRlICJWOEV2ZW50U291cmNl LmgiCi0KLSNpbmNsdWRlICJFdmVudFNvdXJjZS5oIgotI2luY2x1ZGUgIkZyYW1lLmgiCi0jaW5j bHVkZSAiVjhCaW5kaW5nLmgiCi0jaW5jbHVkZSAiVjhQcm94eS5oIgotI2luY2x1ZGUgIlY4VXRp bGl0aWVzLmgiCi0jaW5jbHVkZSAiV29ya2VyQ29udGV4dC5oIgotI2luY2x1ZGUgIldvcmtlckNv bnRleHRFeGVjdXRpb25Qcm94eS5oIgotCi1uYW1lc3BhY2UgV2ViQ29yZSB7Ci0KLXY4OjpIYW5k bGU8djg6OlZhbHVlPiBWOEV2ZW50U291cmNlOjpjb25zdHJ1Y3RvckNhbGxiYWNrKGNvbnN0IHY4 OjpBcmd1bWVudHMmIGFyZ3MpCi17Ci0gICAgSU5DX1NUQVRTKCJET00uRXZlbnRTb3VyY2UuQ29u c3RydWN0b3IiKTsKLQotICAgIGlmICghYXJncy5Jc0NvbnN0cnVjdENhbGwoKSkKLSAgICAgICAg cmV0dXJuIHRocm93RXJyb3IoIkRPTSBvYmplY3QgY29uc3RydWN0b3IgY2Fubm90IGJlIGNhbGxl ZCBhcyBhIGZ1bmN0aW9uLiIsIFY4UHJveHk6OlR5cGVFcnJvcik7Ci0KLSAgICAvLyBFeHBlY3Qg b25lIHBhcmFtZXRlci4KLSAgICAvLyBBbGxvY2F0ZSBhbiBFdmVudFNvdXJjZSBvYmplY3QgYXMg aXRzIGludGVybmFsIGZpZWxkLgotICAgIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQg PSBnZXRTY3JpcHRFeGVjdXRpb25Db250ZXh0KCk7Ci0gICAgaWYgKCFjb250ZXh0KQotICAgICAg ICByZXR1cm4gdGhyb3dFcnJvcigiRXZlbnRTb3VyY2UgY29uc3RydWN0b3IncyBhc3NvY2lhdGVk IGNvbnRleHQgaXMgbm90IGF2YWlsYWJsZSIsIFY4UHJveHk6OlJlZmVyZW5jZUVycm9yKTsKLSAg ICBpZiAoYXJncy5MZW5ndGgoKSAhPSAxKQotICAgICAgICByZXR1cm4gdGhyb3dFcnJvcigiTm90 IGVub3VnaCBhcmd1bWVudHMiLCBWOFByb3h5OjpUeXBlRXJyb3IpOwotCi0gICAgRXhjZXB0aW9u Q29kZSBlYyA9IDA7Ci0gICAgU3RyaW5nIHVybCA9IHRvV2ViQ29yZVN0cmluZyhhcmdzWzBdKTsK LQotICAgIFJlZlB0cjxFdmVudFNvdXJjZT4gZXZlbnRTb3VyY2UgPSBFdmVudFNvdXJjZTo6Y3Jl YXRlKHVybCwgY29udGV4dCwgZWMpOwotCi0gICAgaWYgKGVjKQotICAgICAgICByZXR1cm4gdGhy b3dFcnJvcihlYyk7Ci0KLSAgICBWOERPTVdyYXBwZXI6OnNldERPTVdyYXBwZXIoYXJncy5Ib2xk ZXIoKSwgJmluZm8sIGV2ZW50U291cmNlLmdldCgpKTsKLQotICAgIC8vIEFkZCBvYmplY3QgdG8g dGhlIHdyYXBwZXIgbWFwLgotICAgIGV2ZW50U291cmNlLT5yZWYoKTsKLSAgICBWOERPTVdyYXBw ZXI6OnNldEpTV3JhcHBlckZvckFjdGl2ZURPTU9iamVjdChldmVudFNvdXJjZS5nZXQoKSwgdjg6 OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD46Ok5ldyhhcmdzLkhvbGRlcigpKSk7Ci0gICAgcmV0dXJu IGFyZ3MuSG9sZGVyKCk7Ci19Ci0KLX0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKLQotI2VuZGlmIC8v IEVOQUJMRShFVkVOVFNPVVJDRSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZl bnRTb3VyY2UuaWRsIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudFNvdXJjZS5pZGwKaW5kZXgg NDgzMTVhOGNjMDkyY2M2YjczNTA1MGNiYzJkMjllNWU1NzdiMGI4Ni4uYzI0Y2IzNWVkZTE0NTg5 MTJhYTgwYzVmZDQ1MmU0Yjc3ZTI3ODFjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFn ZS9FdmVudFNvdXJjZS5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudFNvdXJjZS5p ZGwKQEAgLTM3LDcgKzM3LDEwIEBAIG1vZHVsZSB3aW5kb3cgewogICAgICAgICBDYW5CZUNvbnN0 cnVjdGVkLAogICAgICAgICBDdXN0b21Db25zdHJ1Y3RGdW5jdGlvbiwKICAgICAgICAgQ29uc3Ry dWN0b3JQYXJhbWV0ZXJzPTEsCi0gICAgICAgIFY4Q3VzdG9tQ29uc3RydWN0b3IsCisgICAgICAg IENvbnN0cnVjdG9yKGluIERPTVN0cmluZyBzY3JpcHRVcmwpLAorICAgICAgICBDb25zdHJ1Y3Rv cldpdGg9U2NyaXB0RXhlY3V0aW9uQ29udGV4dCwKKyAgICAgICAgQ29uc3RydWN0b3JSYWlzZXNF eGNlcHRpb24sCisgICAgICAgIFY4Q29uc3RydWN0b3JTZXRzQWN0aXZlRE9NV3JhcHBlciwKICAg ICAgICAgRXZlbnRUYXJnZXQsCiAgICAgICAgIE5vU3RhdGljVGFibGVzCiAgICAgXSBFdmVudFNv dXJjZSB7Cg==