67447 2011-09-01 15:20:30 -0700 Generate a Worker constructor of V8 using the IDL 'Constructor' extended attribute 2011-09-01 18:37:05 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 65839 0 haraken webkit-unassigned abarth ap dglazkov dominicc webkit.review.bot oldest_to_newest 460844 0 haraken 2011-09-01 15:20:30 -0700 Currently, the Worker constructor is written manually as a custom constructor. We should replace this with automatically generated code by the IDL 'Constructor' extended attribute. 460846 1 106047 haraken 2011-09-01 15:23:20 -0700 Created attachment 106047 Patch 460868 2 106047 dglazkov 2011-09-01 15:55:22 -0700 Comment on attachment 106047 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106047&action=review > Source/WebCore/workers/Worker.idl:37 > + ConstructorRaisesException, shouldn't this be Constructor(in DOMString scriptUrl) raises (DOMException)? Or is this still coming? 460879 3 106047 webkit.review.bot 2011-09-01 16:06:57 -0700 Comment on attachment 106047 Patch Rejecting attachment 106047 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: " exit_code: 1 Parsed 3 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp Hunk #1 FAILED at 47. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp.rej patching file Source/WebCore/workers/Worker.idl Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/9578572 460893 4 haraken 2011-09-01 16:20:14 -0700 (In reply to comment #2) > (From update of attachment 106047 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=106047&action=review > > > Source/WebCore/workers/Worker.idl:37 > > + ConstructorRaisesException, > > shouldn't this be Constructor(in DOMString scriptUrl) raises (DOMException)? Dimitri: Thank you very much for the review. The spec of the 'Constructor' extended attribute does not allow the "Constructor(...) raises (...)" format (http://www.w3.org/TR/WebIDL/#Constructor). For example, the spec says that the IDL of a Worker constructor should be "Constructor(DOMString scriptURL)" (http://dev.w3.org/html5/workers/#dedicated-workers-and-the-worker-interface). On the other hand, the spec of the Worker constructor says that it can throw SYNTAX_ERR (http://dev.w3.org/html5/workers/#dom-worker). Therefore, I think that the possible approaches for us are as follows: Appraoch1: Change the spec of constructors, so that it can allow the "Constructor(...) raises (...)" format. Approach2: We introduce a special extended attribute for WebKit (as we have done so far), 'ConstructorRaisesException'. For now, this patch takes Approach2. 460974 5 106073 haraken 2011-09-01 18:04:37 -0700 Created attachment 106073 Patch 460975 6 haraken 2011-09-01 18:07:16 -0700 Dimitri: I rebased the patch with the latest repository. Would you please try to commit it again? Thanks. 460996 7 106073 webkit.review.bot 2011-09-01 18:37:00 -0700 Comment on attachment 106073 Patch Clearing flags on attachment: 106073 Committed r94381: <http://trac.webkit.org/changeset/94381> 460997 8 webkit.review.bot 2011-09-01 18:37:05 -0700 All reviewed patches have been landed. Closing bug. 106047 2011-09-01 15:23:20 -0700 2011-09-01 18:04:33 -0700 Patch bug-67447-20110901152319.patch text/plain 3521 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTQyOTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiZmJmYzU0MzVkNTgwZDZh ZjA1NmY5NmE0MDU4OTgyMjJmMjJkMDJiLi5mNzJkYjY2MjU3MWVjNjNjZDU5MDMwYTE4Mjg4YWM0 MDBmNTE2MWVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDktMDEgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBHZW5lcmF0ZSBhIFdvcmtl ciBjb25zdHJ1Y3RvciBvZiBWOCB1c2luZyB0aGUgSURMICdDb25zdHJ1Y3RvcicgZXh0ZW5kZWQg YXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02NzQ0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRlc3Q6IGZhc3Qvd29ya2Vycy93b3JrZXItY29uc3RydWN0b3IuaHRtbAorICAgICAgICAgICAg ICBmYXN0L3dvcmtlcnMvd29ya2VyLWV2ZW50LWxpc3RlbmVyLmh0bWwKKworICAgICAgICAqIGJp bmRpbmdzL3Y4L2N1c3RvbS9WOFdvcmtlckN1c3RvbS5jcHA6IFJlbW92ZWQgY29uc3RydWN0b3JD YWxsYmFjaygpLgorICAgICAgICAqIHdvcmtlcnMvV29ya2VyLmlkbDogQWRkZWQgdGhlICdDb25z dHJ1Y3RvcicgZXh0ZW5kZWQgYXR0cmlidXRlLgorCiAyMDExLTA5LTAxICBWc2V2b2xvZCBWbGFz b3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERlY29k ZSBxdWVyeS9mb3JtIHBhcmFtZXRlcnMgbmFtZXMgYXMgd2VsbCBhcyB2YWx1ZXMuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhXb3JrZXJDdXN0b20uY3Bw IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4V29ya2VyQ3VzdG9tLmNwcApp bmRleCA5NTUwNGRiZWE2MDFlM2UxNTQ3ZDIxZWRiYThiMDg1ZGNiNDM2NmIwLi4zYTA0MDU3ZjU0 NGJjNmM4MGJjMDRmM2M3ZDNhNjEyN2ZiYjJjMDAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9jdXN0b20vVjhXb3JrZXJDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFdvcmtlckN1c3RvbS5jcHAKQEAgLTQ3LDQ2ICs0Nyw2 IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4V29y a2VyOjpjb25zdHJ1Y3RvckNhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCi17Ci0g ICAgSU5DX1NUQVRTKEwiRE9NLldvcmtlci5Db25zdHJ1Y3RvciIpOwotCi0gICAgaWYgKCFhcmdz LklzQ29uc3RydWN0Q2FsbCgpKQotICAgICAgICByZXR1cm4gdGhyb3dFcnJvcigiRE9NIG9iamVj dCBjb25zdHJ1Y3RvciBjYW5ub3QgYmUgY2FsbGVkIGFzIGEgZnVuY3Rpb24uIik7Ci0KLSAgICBp ZiAoIWFyZ3MuTGVuZ3RoKCkpCi0gICAgICAgIHJldHVybiB0aHJvd0Vycm9yKCJOb3QgZW5vdWdo IGFyZ3VtZW50cyIsIFY4UHJveHk6OlR5cGVFcnJvcik7Ci0KLSAgICB2ODo6VHJ5Q2F0Y2ggdHJ5 Q2F0Y2g7Ci0gICAgdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBzY3JpcHRVcmwgPSBhcmdzWzBdLT5U b1N0cmluZygpOwotICAgIGlmICh0cnlDYXRjaC5IYXNDYXVnaHQoKSkKLSAgICAgICAgcmV0dXJu IHRocm93RXJyb3IodHJ5Q2F0Y2guRXhjZXB0aW9uKCkpOwotCi0gICAgaWYgKHNjcmlwdFVybC5J c0VtcHR5KCkpCi0gICAgICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7Ci0KLSAgICAvLyBHZXQg dGhlIHNjcmlwdCBleGVjdXRpb24gY29udGV4dC4KLSAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0 KiBjb250ZXh0ID0gZ2V0U2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpOwotICAgIGlmICghY29udGV4 dCkKLSAgICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKLQotICAgIC8vIENyZWF0ZSB0aGUg d29ya2VyIG9iamVjdC4KLSAgICAvLyBOb3RlOiBpdCdzIE9LIHRvIGxldCB0aGlzIFJlZlB0ciBn byBvdXQgb2Ygc2NvcGUgYmVjYXVzZSB3ZSBhbHNvIGNhbGwgc2V0RE9NV3JhcHBlcigpLCB3aGlj aCBlZmZlY3RpdmVseSBob2xkcyBhIHJlZmVyZW5jZSB0byBvYmouCi0gICAgRXhjZXB0aW9uQ29k ZSBlYyA9IDA7Ci0gICAgUmVmUHRyPFdvcmtlcj4gb2JqID0gV29ya2VyOjpjcmVhdGUodG9XZWJD b3JlU3RyaW5nKHNjcmlwdFVybCksIGNvbnRleHQsIGVjKTsKLSAgICBpZiAoZWMpCi0gICAgICAg IHJldHVybiB0aHJvd0Vycm9yKGVjKTsKLQotICAgIC8vIFNldHVwIHRoZSBzdGFuZGFyZCB3cmFw cGVyIG9iamVjdCBpbnRlcm5hbCBmaWVsZHMuCi0gICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiB3 cmFwcGVyT2JqZWN0ID0gYXJncy5Ib2xkZXIoKTsKLSAgICBWOERPTVdyYXBwZXI6OnNldERPTVdy YXBwZXIod3JhcHBlck9iamVjdCwgJmluZm8sIG9iai5nZXQoKSk7Ci0KLSAgICBvYmotPnJlZigp OwotICAgIFY4RE9NV3JhcHBlcjo6c2V0SlNXcmFwcGVyRm9yQWN0aXZlRE9NT2JqZWN0KG9iai5n ZXQoKSwgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD46Ok5ldyh3cmFwcGVyT2JqZWN0KSk7Ci0K LSAgICByZXR1cm4gd3JhcHBlck9iamVjdDsKLX0KLQogdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4 V29ya2VyOjpwb3N0TWVzc2FnZUNhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCiB7 CiAgICAgSU5DX1NUQVRTKCJET00uV29ya2VyLnBvc3RNZXNzYWdlIik7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlci5pZGwgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJz L1dvcmtlci5pZGwKaW5kZXggNzYzNzU2OWE1NDg5NmJjZmY4ZWU0OWFjOWE4ZmE5MTliMzc0YzE4 Yy4uZjg3MWRmOTVkNzYyY2QyMTM2MGMwNTdiMzhlMGVkM2I5NDVhY2Q1YyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXIuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dv cmtlcnMvV29ya2VyLmlkbApAQCAtMzIsNyArMzIsMTAgQEAgbW9kdWxlIHRocmVhZHMgewogICAg ICAgICBDYW5CZUNvbnN0cnVjdGVkLAogICAgICAgICBDdXN0b21Db25zdHJ1Y3RGdW5jdGlvbiwK ICAgICAgICAgQ29uc3RydWN0b3JQYXJhbWV0ZXJzPTEsCi0gICAgICAgIFY4Q3VzdG9tQ29uc3Ry dWN0b3IsCisgICAgICAgIENvbnN0cnVjdG9yKGluIERPTVN0cmluZyBzY3JpcHRVcmwpLAorICAg ICAgICBDb25zdHJ1Y3RvcldpdGg9U2NyaXB0RXhlY3V0aW9uQ29udGV4dCwKKyAgICAgICAgQ29u c3RydWN0b3JSYWlzZXNFeGNlcHRpb24sCisgICAgICAgIFY4Q29uc3RydWN0b3JTZXRzQWN0aXZl RE9NV3JhcHBlciwKICAgICAgICAgR2VuZXJhdGVOYXRpdmVDb252ZXJ0ZXIsCiAgICAgICAgIEdl bmVyYXRlVG9KUwogICAgIF0gV29ya2VyIDogQWJzdHJhY3RXb3JrZXIgewo= 106073 2011-09-01 18:04:37 -0700 2011-09-01 18:37:00 -0700 Patch bug-67447-20110901180436.patch text/plain 3612 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTQzNzYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwYWZhYzUxZjMxZTFjNDlj Y2VjNWYwMzJiZDhlMzFiOTI0NTYwNjA3Li43MTZlYmFiYzEyNmZlYjhkMTQzZDcwMjBiNDBhYWIz ZTBkNTlhYmZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTEtMDktMDEgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AZ29vZ2xlLmNvbT4KIAorICAgICAgICBHZW5lcmF0ZSBhIFdvcmtl ciBjb25zdHJ1Y3RvciBvZiBWOCB1c2luZyB0aGUgSURMICdDb25zdHJ1Y3RvcicgZXh0ZW5kZWQg YXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02NzQ0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRlc3Q6IGZhc3Qvd29ya2Vycy93b3JrZXItY29uc3RydWN0b3IuaHRtbAorICAgICAgICAgICAg ICBmYXN0L3dvcmtlcnMvd29ya2VyLWV2ZW50LWxpc3RlbmVyLmh0bWwKKworICAgICAgICAqIGJp bmRpbmdzL3Y4L2N1c3RvbS9WOFdvcmtlckN1c3RvbS5jcHA6IFJlbW92ZWQgY29uc3RydWN0b3JD YWxsYmFjaygpLgorICAgICAgICAqIHdvcmtlcnMvV29ya2VyLmlkbDogQWRkZWQgdGhlICdDb25z dHJ1Y3RvcicgZXh0ZW5kZWQgYXR0cmlidXRlLgorCisyMDExLTA5LTAxICBLZW50YXJvIEhhcmEg IDxoYXJha2VuQGdvb2dsZS5jb20+CisKICAgICAgICAgR2VuZXJhdGUgYSBGaWxlUmVhZGVyIGNv bnN0cnVjdG9yIG9mIFY4IHVzaW5nIHRoZSBJREwgJ0NvbnN0cnVjdG9yJyBleHRlbmRlZCBhdHRy aWJ1dGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3 NDEyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFdv cmtlckN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhXb3Jr ZXJDdXN0b20uY3BwCmluZGV4IGY1ZjkwYWUxMjFkNzJmMTJjNWQ5NTg4MDJkMmQ3ZGE2NzYzZGQ0 MzguLjNhMDQwNTdmNTQ0YmM2YzgwYmMwNGYzYzdkM2E2MTI3ZmJiMmMwMDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFdvcmtlckN1c3RvbS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4V29ya2VyQ3VzdG9tLmNwcApA QCAtNDcsNDYgKzQ3LDYgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi12ODo6SGFuZGxlPHY4 OjpWYWx1ZT4gVjhXb3JrZXI6OmNvbnN0cnVjdG9yQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50 cyYgYXJncykKLXsKLSAgICBJTkNfU1RBVFMoTCJET00uV29ya2VyLkNvbnN0cnVjdG9yIik7Ci0K LSAgICBpZiAoIWFyZ3MuSXNDb25zdHJ1Y3RDYWxsKCkpCi0gICAgICAgIHJldHVybiB0aHJvd0Vy cm9yKCJET00gb2JqZWN0IGNvbnN0cnVjdG9yIGNhbm5vdCBiZSBjYWxsZWQgYXMgYSBmdW5jdGlv bi4iLCBWOFByb3h5OjpUeXBlRXJyb3IpOwotCi0gICAgaWYgKCFhcmdzLkxlbmd0aCgpKQotICAg ICAgICByZXR1cm4gdGhyb3dFcnJvcigiTm90IGVub3VnaCBhcmd1bWVudHMiLCBWOFByb3h5OjpU eXBlRXJyb3IpOwotCi0gICAgdjg6OlRyeUNhdGNoIHRyeUNhdGNoOwotICAgIHY4OjpIYW5kbGU8 djg6OlN0cmluZz4gc2NyaXB0VXJsID0gYXJnc1swXS0+VG9TdHJpbmcoKTsKLSAgICBpZiAodHJ5 Q2F0Y2guSGFzQ2F1Z2h0KCkpCi0gICAgICAgIHJldHVybiB0aHJvd0Vycm9yKHRyeUNhdGNoLkV4 Y2VwdGlvbigpKTsKLQotICAgIGlmIChzY3JpcHRVcmwuSXNFbXB0eSgpKQotICAgICAgICByZXR1 cm4gdjg6OlVuZGVmaW5lZCgpOwotCi0gICAgLy8gR2V0IHRoZSBzY3JpcHQgZXhlY3V0aW9uIGNv bnRleHQuCi0gICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCA9IGdldFNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQoKTsKLSAgICBpZiAoIWNvbnRleHQpCi0gICAgICAgIHJldHVybiB2ODo6 VW5kZWZpbmVkKCk7Ci0KLSAgICAvLyBDcmVhdGUgdGhlIHdvcmtlciBvYmplY3QuCi0gICAgLy8g Tm90ZTogaXQncyBPSyB0byBsZXQgdGhpcyBSZWZQdHIgZ28gb3V0IG9mIHNjb3BlIGJlY2F1c2Ug d2UgYWxzbyBjYWxsIHNldERPTVdyYXBwZXIoKSwgd2hpY2ggZWZmZWN0aXZlbHkgaG9sZHMgYSBy ZWZlcmVuY2UgdG8gb2JqLgotICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwotICAgIFJlZlB0cjxX b3JrZXI+IG9iaiA9IFdvcmtlcjo6Y3JlYXRlKHRvV2ViQ29yZVN0cmluZyhzY3JpcHRVcmwpLCBj b250ZXh0LCBlYyk7Ci0gICAgaWYgKGVjKQotICAgICAgICByZXR1cm4gdGhyb3dFcnJvcihlYyk7 Ci0KLSAgICAvLyBTZXR1cCB0aGUgc3RhbmRhcmQgd3JhcHBlciBvYmplY3QgaW50ZXJuYWwgZmll bGRzLgotICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gd3JhcHBlck9iamVjdCA9IGFyZ3MuSG9s ZGVyKCk7Ci0gICAgVjhET01XcmFwcGVyOjpzZXRET01XcmFwcGVyKHdyYXBwZXJPYmplY3QsICZp bmZvLCBvYmouZ2V0KCkpOwotCi0gICAgb2JqLT5yZWYoKTsKLSAgICBWOERPTVdyYXBwZXI6OnNl dEpTV3JhcHBlckZvckFjdGl2ZURPTU9iamVjdChvYmouZ2V0KCksIHY4OjpQZXJzaXN0ZW50PHY4 OjpPYmplY3Q+OjpOZXcod3JhcHBlck9iamVjdCkpOwotCi0gICAgcmV0dXJuIHdyYXBwZXJPYmpl Y3Q7Ci19Ci0KIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOFdvcmtlcjo6cG9zdE1lc3NhZ2VDYWxs YmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcmdzKQogewogICAgIElOQ19TVEFUUygiRE9NLldv cmtlci5wb3N0TWVzc2FnZSIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9X b3JrZXIuaWRsIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXIuaWRsCmluZGV4IDc2Mzc1 NjlhNTQ4OTZiY2ZmOGVlNDlhYzlhOGZhOTE5YjM3NGMxOGMuLmY4NzFkZjk1ZDc2MmNkMjEzNjBj MDU3YjM4ZTBlZDNiOTQ1YWNkNWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMv V29ya2VyLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlci5pZGwKQEAgLTMy LDcgKzMyLDEwIEBAIG1vZHVsZSB0aHJlYWRzIHsKICAgICAgICAgQ2FuQmVDb25zdHJ1Y3RlZCwK ICAgICAgICAgQ3VzdG9tQ29uc3RydWN0RnVuY3Rpb24sCiAgICAgICAgIENvbnN0cnVjdG9yUGFy YW1ldGVycz0xLAotICAgICAgICBWOEN1c3RvbUNvbnN0cnVjdG9yLAorICAgICAgICBDb25zdHJ1 Y3RvcihpbiBET01TdHJpbmcgc2NyaXB0VXJsKSwKKyAgICAgICAgQ29uc3RydWN0b3JXaXRoPVNj cmlwdEV4ZWN1dGlvbkNvbnRleHQsCisgICAgICAgIENvbnN0cnVjdG9yUmFpc2VzRXhjZXB0aW9u LAorICAgICAgICBWOENvbnN0cnVjdG9yU2V0c0FjdGl2ZURPTVdyYXBwZXIsCiAgICAgICAgIEdl bmVyYXRlTmF0aXZlQ29udmVydGVyLAogICAgICAgICBHZW5lcmF0ZVRvSlMKICAgICBdIFdvcmtl ciA6IEFic3RyYWN0V29ya2VyIHsK