67414 2011-09-01 09:42:50 -0700 Generate an XSLTProcessor constructor of V8 using the IDL 'Constructor' extended attribute 2011-09-01 15:15:33 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 65839 0 haraken webkit-unassigned abarth ap dominicc webkit.review.bot oldest_to_newest 460523 0 haraken 2011-09-01 09:42:50 -0700 Currently, the XSLTProcessor constructor is written manually as a custom constructor. We should replace this with automatically generated code by the IDL 'Constructor' extended attribute. 460759 1 106022 haraken 2011-09-01 13:49:20 -0700 Created attachment 106022 Patch 460772 2 106026 haraken 2011-09-01 14:11:37 -0700 Created attachment 106026 Patch 460790 3 106026 dglazkov 2011-09-01 14:30:13 -0700 Comment on attachment 106026 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106026&action=review > Source/WebCore/xml/XSLTProcessor.idl:38 > CustomConstructFunction, Is this still necessary? 460793 4 haraken 2011-09-01 14:34:50 -0700 > > Source/WebCore/xml/XSLTProcessor.idl:38 > > CustomConstructFunction, > > Is this still necessary? Yes, it is still used in JSC. We will remove it when we support the 'Constructor' extended attribute in JSC. 460841 5 106026 webkit.review.bot 2011-09-01 15:15:28 -0700 Comment on attachment 106026 Patch Clearing flags on attachment: 106026 Committed r94350: <http://trac.webkit.org/changeset/94350> 460842 6 webkit.review.bot 2011-09-01 15:15:33 -0700 All reviewed patches have been landed. Closing bug. 106022 2011-09-01 13:49:20 -0700 2011-09-01 14:11:31 -0700 Patch bug-67414-20110901134919.patch text/plain 2218 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTQyOTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiZmJmYzU0MzVkNTgwZDZh ZjA1NmY5NmE0MDU4OTgyMjJmMjJkMDJiLi5mYzY5YzRiNTExMTY2ZGM3ODA0YjI3YjQ1ODg0NGUy NDEwZDAwMTYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDktMDEgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBHZW5lcmF0ZSBhbiBYU0xU UHJvY2Vzc29yIGNvbnN0cnVjdG9yIG9mIFY4IHVzaW5nIHRoZSBJREwgJ0NvbnN0cnVjdG9yJyBl eG50ZWRlZCBhdHRyaWJ1dGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY3NDE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGVzdDogZmFzdC9kb20vV2luZG93L2N1c3RvbS1jb25zdHJ1Y3RvcnMuaHRtbAor ICAgICAgICAgICAgICBmYXN0L3hzbC9kZWZhdWx0LWh0bWwuaHRtbAorCisgICAgICAgICogYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4WFNMVFByb2Nlc3NvckN1c3RvbS5jcHA6IFJlbW92ZWQgY29uc3Ry dWN0b3JDYWxsYmFjaygpLgorICAgICAgICAqIHhtbC9YU0xUUHJvY2Vzc29yLmlkbDogQWRkZWQg dGhlICdDb25zdHJ1Y3RvcicgZXh0ZW5kZWQgYXR0cmlidXRlLgorCiAyMDExLTA5LTAxICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IERlY29kZSBxdWVyeS9mb3JtIHBhcmFtZXRlcnMgbmFtZXMgYXMgd2VsbCBhcyB2YWx1ZXMu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhYU0xUUHJv Y2Vzc29yQ3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFhT TFRQcm9jZXNzb3JDdXN0b20uY3BwCmluZGV4IGI2MjRmY2ZlNzA1MTljZmJiNjQ5N2U4Yjg5NzA1 MzI4MjljNzQzYmMuLjFhZDUyZDEzMjdkMjk5MmFhZDM4NjFjNTc0YjRlNWQ2Mjc1OTlkMjAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFhTTFRQcm9jZXNz b3JDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFhT TFRQcm9jZXNzb3JDdXN0b20uY3BwCkBAIC00NiwxMyArNDYsNiBAQAogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKLXY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOFhTTFRQcm9jZXNzb3I6OmNvbnN0cnVj dG9yQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncykKLXsKLSAgICBJTkNfU1RBVFMo IkRPTS5YU0xUUHJvY2Vzc29yLkNvbnN0cnVjdG9yIik7Ci0gICAgcmV0dXJuIFY4UHJveHk6OmNv bnN0cnVjdERPTU9iamVjdDxYU0xUUHJvY2Vzc29yPihhcmdzLCAmaW5mbyk7Ci19Ci0KLQogdjg6 OkhhbmRsZTx2ODo6VmFsdWU+IFY4WFNMVFByb2Nlc3Nvcjo6aW1wb3J0U3R5bGVzaGVldENhbGxi YWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCiB7CiAgICAgSU5DX1NUQVRTKCJET00uWFNM VFByb2Nlc3Nvci5pbXBvcnRTdHlsZXNoZWV0Iik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS94bWwvWFNMVFByb2Nlc3Nvci5pZGwgYi9Tb3VyY2UvV2ViQ29yZS94bWwvWFNMVFByb2Nlc3Nv ci5pZGwKaW5kZXggZGFjNGIyMTAwNzQ3NjNhZmQzNTkwMDI1MmUxYTk3MjMyNjcyMjU5MS4uOTUx MmIzMzc4ZmUwY2IxYzliMTgwOGNmYmQ3NzFhZjliM2RiNWJkYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUveG1sL1hTTFRQcm9jZXNzb3IuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9Y U0xUUHJvY2Vzc29yLmlkbApAQCAtMzYsNyArMzYsNyBAQCBtb2R1bGUgeG1sIHsKICAgICAgICAg Q29uZGl0aW9uYWw9WFNMVCwKICAgICAgICAgQ2FuQmVDb25zdHJ1Y3RlZCwKICAgICAgICAgQ3Vz dG9tQ29uc3RydWN0RnVuY3Rpb24sCi0gICAgICAgIFY4Q3VzdG9tQ29uc3RydWN0b3IKKyAgICAg ICAgQ29uc3RydWN0b3IKICAgICBdIFhTTFRQcm9jZXNzb3IgewogICAgICAgICAKICAgICAgICAg W0N1c3RvbV0gdm9pZCBpbXBvcnRTdHlsZXNoZWV0KGluIE5vZGUgc3R5bGVzaGVldCk7Cg== 106026 2011-09-01 14:11:37 -0700 2011-09-01 15:15:28 -0700 Patch bug-67414-20110901141136.patch text/plain 2218 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTQyOTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiZmJmYzU0MzVkNTgwZDZh ZjA1NmY5NmE0MDU4OTgyMjJmMjJkMDJiLi42MjgxZWU5NTBkOTY0MjI3ZjYxNDZjZWQwZDRhNTJm MGIxNDFjMzRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDktMDEgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBHZW5lcmF0ZSBhbiBYU0xU UHJvY2Vzc29yIGNvbnN0cnVjdG9yIG9mIFY4IHVzaW5nIHRoZSBJREwgJ0NvbnN0cnVjdG9yJyBl eHRlbmRlZCBhdHRyaWJ1dGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY3NDE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGVzdDogZmFzdC9kb20vV2luZG93L2N1c3RvbS1jb25zdHJ1Y3RvcnMuaHRtbAor ICAgICAgICAgICAgICBmYXN0L3hzbC9kZWZhdWx0LWh0bWwuaHRtbAorCisgICAgICAgICogYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4WFNMVFByb2Nlc3NvckN1c3RvbS5jcHA6IFJlbW92ZWQgY29uc3Ry dWN0b3JDYWxsYmFjaygpLgorICAgICAgICAqIHhtbC9YU0xUUHJvY2Vzc29yLmlkbDogQWRkZWQg dGhlICdDb25zdHJ1Y3RvcicgZXh0ZW5kZWQgYXR0cmlidXRlLgorCiAyMDExLTA5LTAxICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IERlY29kZSBxdWVyeS9mb3JtIHBhcmFtZXRlcnMgbmFtZXMgYXMgd2VsbCBhcyB2YWx1ZXMu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhYU0xUUHJv Y2Vzc29yQ3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFhT TFRQcm9jZXNzb3JDdXN0b20uY3BwCmluZGV4IGI2MjRmY2ZlNzA1MTljZmJiNjQ5N2U4Yjg5NzA1 MzI4MjljNzQzYmMuLjFhZDUyZDEzMjdkMjk5MmFhZDM4NjFjNTc0YjRlNWQ2Mjc1OTlkMjAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFhTTFRQcm9jZXNz b3JDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFhT TFRQcm9jZXNzb3JDdXN0b20uY3BwCkBAIC00NiwxMyArNDYsNiBAQAogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKLXY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOFhTTFRQcm9jZXNzb3I6OmNvbnN0cnVj dG9yQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncykKLXsKLSAgICBJTkNfU1RBVFMo IkRPTS5YU0xUUHJvY2Vzc29yLkNvbnN0cnVjdG9yIik7Ci0gICAgcmV0dXJuIFY4UHJveHk6OmNv bnN0cnVjdERPTU9iamVjdDxYU0xUUHJvY2Vzc29yPihhcmdzLCAmaW5mbyk7Ci19Ci0KLQogdjg6 OkhhbmRsZTx2ODo6VmFsdWU+IFY4WFNMVFByb2Nlc3Nvcjo6aW1wb3J0U3R5bGVzaGVldENhbGxi YWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCiB7CiAgICAgSU5DX1NUQVRTKCJET00uWFNM VFByb2Nlc3Nvci5pbXBvcnRTdHlsZXNoZWV0Iik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS94bWwvWFNMVFByb2Nlc3Nvci5pZGwgYi9Tb3VyY2UvV2ViQ29yZS94bWwvWFNMVFByb2Nlc3Nv ci5pZGwKaW5kZXggZGFjNGIyMTAwNzQ3NjNhZmQzNTkwMDI1MmUxYTk3MjMyNjcyMjU5MS4uOTUx MmIzMzc4ZmUwY2IxYzliMTgwOGNmYmQ3NzFhZjliM2RiNWJkYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUveG1sL1hTTFRQcm9jZXNzb3IuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9Y U0xUUHJvY2Vzc29yLmlkbApAQCAtMzYsNyArMzYsNyBAQCBtb2R1bGUgeG1sIHsKICAgICAgICAg Q29uZGl0aW9uYWw9WFNMVCwKICAgICAgICAgQ2FuQmVDb25zdHJ1Y3RlZCwKICAgICAgICAgQ3Vz dG9tQ29uc3RydWN0RnVuY3Rpb24sCi0gICAgICAgIFY4Q3VzdG9tQ29uc3RydWN0b3IKKyAgICAg ICAgQ29uc3RydWN0b3IKICAgICBdIFhTTFRQcm9jZXNzb3IgewogICAgICAgICAKICAgICAgICAg W0N1c3RvbV0gdm9pZCBpbXBvcnRTdHlsZXNoZWV0KGluIE5vZGUgc3R5bGVzaGVldCk7Cg==