67412 2011-09-01 09:34:06 -0700 Generate a FileReader constructor of V8 using the IDL 'Constructor' extended attribute 2011-09-01 17:48:39 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 65839 0 haraken webkit-unassigned abarth ap dglazkov dominicc webkit.review.bot oldest_to_newest 460518 0 haraken 2011-09-01 09:34:06 -0700 Currently, the FileReader constructor is written manually as a custom constructor. We should replace this with automatically generated code by the IDL 'Constructor' extended attribute. 460785 1 106032 haraken 2011-09-01 14:28:16 -0700 Created attachment 106032 Patch 460960 2 106032 webkit.review.bot 2011-09-01 17:48:34 -0700 Comment on attachment 106032 Patch Clearing flags on attachment: 106032 Committed r94375: <http://trac.webkit.org/changeset/94375> 460961 3 webkit.review.bot 2011-09-01 17:48:39 -0700 All reviewed patches have been landed. Closing bug. 106032 2011-09-01 14:28:16 -0700 2011-09-01 17:48:34 -0700 Patch bug-67412-20110901142815.patch text/plain 3015 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTQyOTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiZmJmYzU0MzVkNTgwZDZh ZjA1NmY5NmE0MDU4OTgyMjJmMjJkMDJiLi5hMGQyOTY4ODAzZGYwMWU4Y2I3ZjRhYTg3NTM1NDNj MzI1YmU0NmQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDktMDEgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBHZW5lcmF0ZSBhIEZpbGVS ZWFkZXIgY29uc3RydWN0b3Igb2YgVjggdXNpbmcgdGhlIElETCAnQ29uc3RydWN0b3InIGV4dGVu ZGVkIGF0dHJpYnV0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Njc0MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUZXN0OiBmYXN0L2ZpbGVzL2Jsb2Itc2xpY2UtdGVzdC5odG1sCisgICAgICAgICAgICAg IGZhc3QvZmlsZXMvZmlsZS1yZWFkZXItYWJvcnQuaHRtbAorCisgICAgICAgICogYmluZGluZ3Mv djgvY3VzdG9tL1Y4RmlsZVJlYWRlckN1c3RvbS5jcHA6IFJlbW92ZWQgY29uc3RydWN0b3JDYWxs YmFjaygpLgorICAgICAgICAqIGZpbGVhcGkvRmlsZVJlYWRlci5pZGw6IEFkZGVkIHRoZSAnQ29u c3RydWN0b3InIGV4dGVuZGVkIGF0dHJpYnV0ZS4KKwogMjAxMS0wOS0wMSAgVnNldm9sb2QgVmxh c292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBEZWNv ZGUgcXVlcnkvZm9ybSBwYXJhbWV0ZXJzIG5hbWVzIGFzIHdlbGwgYXMgdmFsdWVzLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RmlsZVJlYWRlckN1c3Rv bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhGaWxlUmVhZGVyQ3Vz dG9tLmNwcAppbmRleCBmYjBkNTNjMTc3ZGE2NzBjMGRmY2Q0ZjEwODRjMGNmNjZhYjQ0MTEzLi5i NWI1NzQ4MzYxNjFiMzY3NWU3ZTllZTE2ZGE5ZWIwMDA1Zjg5YzcxIDEwMDc1NQotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhGaWxlUmVhZGVyQ3VzdG9tLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhGaWxlUmVhZGVyQ3VzdG9tLmNw cApAQCAtNDAsMjcgKzQwLDYgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi12ODo6SGFuZGxl PHY4OjpWYWx1ZT4gVjhGaWxlUmVhZGVyOjpjb25zdHJ1Y3RvckNhbGxiYWNrKGNvbnN0IHY4OjpB cmd1bWVudHMmIGFyZ3MpCi17Ci0gICAgSU5DX1NUQVRTKCJET00uRmlsZVJlYWRlci5Db25zdHJ1 Y3RvciIpOwotCi0gICAgaWYgKCFhcmdzLklzQ29uc3RydWN0Q2FsbCgpKQotICAgICAgICByZXR1 cm4gdGhyb3dFcnJvcigiRE9NIG9iamVjdCBjb25zdHJ1Y3RvciBjYW5ub3QgYmUgY2FsbGVkIGFz IGEgZnVuY3Rpb24uIiwgVjhQcm94eTo6VHlwZUVycm9yKTsKLQotICAgIC8vIEV4cGVjdCBubyBw YXJhbWV0ZXJzLgotICAgIC8vIEFsbG9jYXRlIGEgRmlsZVJlYWRlciBvYmplY3QgYXMgaXRzIGlu dGVybmFsIGZpZWxkLgotICAgIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQgPSBnZXRT Y3JpcHRFeGVjdXRpb25Db250ZXh0KCk7Ci0gICAgaWYgKCFjb250ZXh0KQotICAgICAgICByZXR1 cm4gdGhyb3dFcnJvcigiRmlsZVJlYWRlciBjb25zdHJ1Y3RvcidzIGFzc29jaWF0ZWQgY29udGV4 dCBpcyBub3QgYXZhaWxhYmxlIiwgVjhQcm94eTo6UmVmZXJlbmNlRXJyb3IpOwotICAgIFJlZlB0 cjxGaWxlUmVhZGVyPiBmaWxlUmVhZGVyID0gRmlsZVJlYWRlcjo6Y3JlYXRlKGNvbnRleHQpOwot ICAgIFY4RE9NV3JhcHBlcjo6c2V0RE9NV3JhcHBlcihhcmdzLkhvbGRlcigpLCAmaW5mbywgZmls ZVJlYWRlci5nZXQoKSk7Ci0KLSAgICAvLyBBZGQgb2JqZWN0IHRvIHRoZSB3cmFwcGVyIG1hcC4K LSAgICBmaWxlUmVhZGVyLT5yZWYoKTsKLSAgICBWOERPTVdyYXBwZXI6OnNldEpTV3JhcHBlckZv ckFjdGl2ZURPTU9iamVjdChmaWxlUmVhZGVyLmdldCgpLCB2ODo6UGVyc2lzdGVudDx2ODo6T2Jq ZWN0Pjo6TmV3KGFyZ3MuSG9sZGVyKCkpKTsKLSAgICByZXR1cm4gYXJncy5Ib2xkZXIoKTsKLX0K LQogdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4RmlsZVJlYWRlcjo6cmVzdWx0QWNjZXNzb3JHZXR0 ZXIodjg6OkxvY2FsPHY4OjpTdHJpbmc+IG5hbWUsIGNvbnN0IHY4OjpBY2Nlc3NvckluZm8mIGlu Zm8pCiB7CiAgICAgSU5DX1NUQVRTKCJET00uRmlsZVJlYWRlci5yZXN1bHQuX2dldCIpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9GaWxlUmVhZGVyLmlkbCBiL1NvdXJjZS9X ZWJDb3JlL2ZpbGVhcGkvRmlsZVJlYWRlci5pZGwKaW5kZXggNjFkNWFmYjJkMDE1MDBhZjY2MDk0 MjZlMmRlZTUyMmNkMzg1MzZjNC4uYWE5OGIwOWU4MmJkMDAwZDY0ZTc4MjQ5YTVlNmIzMzk2MjZj NzdjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9GaWxlUmVhZGVyLmlkbAor KysgYi9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL0ZpbGVSZWFkZXIuaWRsCkBAIC0zNyw3ICszNyw5 IEBAIG1vZHVsZSBodG1sIHsKICAgICAgICAgQ2FsbFdpdGg9U2NyaXB0RXhlY3V0aW9uQ29udGV4 dCwKICAgICAgICAgRXZlbnRUYXJnZXQsCiAgICAgICAgIE5vU3RhdGljVGFibGVzLAotICAgICAg ICBWOEN1c3RvbUNvbnN0cnVjdG9yCisgICAgICAgIENvbnN0cnVjdG9yLAorICAgICAgICBDb25z dHJ1Y3RvcldpdGg9U2NyaXB0RXhlY3V0aW9uQ29udGV4dCwKKyAgICAgICAgVjhDb25zdHJ1Y3Rv clNldHNBY3RpdmVET01XcmFwcGVyCiAgICAgXSBGaWxlUmVhZGVyIHsKICAgICAgICAgLy8gcmVh ZHkgc3RhdGVzCiAgICAgICAgIGNvbnN0IHVuc2lnbmVkIHNob3J0IEVNUFRZID0gMDsK