67273 2011-08-31 01:44:21 -0700 Remove INSTANTIATE_ALL_EVENT_INITIALIZING_CONSTRUCTORS from EventConstructors.h 2011-09-09 09:37:31 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 67824 0 haraken webkit-unassigned ap dominicc mitz sam oldest_to_newest 459524 0 haraken 2011-08-31 01:44:21 -0700 Using INSTANTIATE_ALL_EVENT_INITIALIZING_CONSTRUCTORS in EventConstructors.h means that the set of constructors implemented in JSC and in V8 must be synchronized. In other words, if we add a constructor to JSC, then we need to add it to V8 at the same time, which makes it difficult to add constructors to JSC and to V8 separately. We should remove INSTANTIATE_ALL_EVENT_INITIALIZING_CONSTRUCTORS from EventConstructors.h and describe INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_* in JSEventConstructors.cpp and V8EventConstructors.cpp. 459528 1 105761 haraken 2011-08-31 01:51:22 -0700 Created attachment 105761 Patch 460045 2 ap 2011-08-31 16:27:25 -0700 > In other words, if we add a constructor to JSC, then we need to add it to V8 at the same time, which makes it difficult to add constructors to JSC and to V8 separately. Keeping various WebKit based browsers compatible is a good thing. Why would it be good to add constructors separately even without a feature define? 460109 3 haraken 2011-08-31 17:26:41 -0700 (In reply to comment #2) > > In other words, if we add a constructor to JSC, then we need to add it to V8 at the same time, which makes it difficult to add constructors to JSC and to V8 separately. > > Keeping various WebKit based browsers compatible is a good thing. Why would it be good to add constructors separately even without a feature define? Yeah, I do agree that we should synchronize constructors for JSC and V8. What I wanted to mean is that using that macro makes it impossible to add a constructor to JSC and to V8 _as_a_separate_patch_. In fact, recently Sam and I have been adding constructors for JSC and V8 in separate patches step by step. However, it may be now OK to decide that we must implement a constructor for JSC and V8 in one patch. 464570 4 sam 2011-09-08 18:48:30 -0700 I don't think this is a good idea. I add the ALL variant to keep the two implementations in line. 464837 5 haraken 2011-09-09 09:37:06 -0700 (In reply to comment #4) > I don't think this is a good idea. I add the ALL variant to keep the two implementations in line. OK. Let's keep ALL. However, I would like to commit patches for JSC and V8 separately in order to reduce the size of each patch. So, until all events are implemented, I will use ALL for JSC but will not use ALL for V8. 105761 2011-08-31 01:51:22 -0700 2011-09-09 09:37:31 -0700 Patch bug-67273-20110831015121.patch text/plain 2844 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTQxNTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlZTI4NDhjYjAzNWQ5OWEx ZjFiMjViNjk5NjFmMTUwMjE3MTJjMWJjLi4zOGRiZGI0ZmM1NWFmN2I0MTkwMGZlOGNjMzBlMjE5 ODI4MTFmZmQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDgtMzEgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZW1vdmUgSU5TVEFOVElB VEVfQUxMX0VWRU5UX0lOSVRJQUxJWklOR19DT05TVFJVQ1RPUlMgZnJvbSBFdmVudENvbnN0cnVj dG9ycy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 NzI3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgcGF0Y2ggcmVtb3ZlcyBJTlNUQU5USUFURV9BTExfRVZFTlRfSU5JVElBTElaSU5HX0NPTlNU UlVDVE9SUworICAgICAgICBmcm9tIEV2ZW50Q29uc3RydWN0b3JzLmgsIGFuZCBtb3ZlcyBJTlNU QU5USUFURV9JTklUSUFMSVpJTkdfQ09OU1RSVUNUT1JfRk9SXyoKKyAgICAgICAgbWFjcm9zIGlu IEV2ZW50Q29uc3J1Y3RvcnMuaCB0byBKU0V2ZW50Q29uc3RydWN0b3JzLmNwcC4KKworICAgICAg ICBObyBuZXcgdGVzdHMgYXMgbm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmlu ZGluZ3MvZ2VuZXJpYy9FdmVudENvbnN0cnVjdG9ycy5oOgorICAgICAgICAqIGJpbmRpbmdzL2pz L0pTRXZlbnRDb25zdHJ1Y3RvcnMuY3BwOgorCiAyMDExLTA4LTMwICBQaGlsaXBwZSBOb3JtYW5k ICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBnc3RyZWFtZXIvIGZpbGVz IGRpcmVjdGx5IHJlbGF0ZWQgdG8gdGhlIE1lZGlhUGxheWVyIG5lZWQgVklERU8gZ3VhcmRzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL0V2ZW50Q29uc3RydWN0 b3JzLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL0V2ZW50Q29uc3RydWN0b3Jz LmgKaW5kZXggODE4MTUxMWIyNzdhODIyMWFhMDE2MTE4Y2FjZmM3N2NhZmUwZGFhMy4uYzEzODA4 ODkzNDY4YWU2MGQ3MTMyM2FiMThkZWMwMjYxNjkxY2ZlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9FdmVudENvbnN0cnVjdG9ycy5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvRXZlbnRDb25zdHJ1Y3RvcnMuaApAQCAtNDIsMTEgKzQy LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBGSUxMX1BST1BFUlRZKGRldGFpbCkg XAogICAgIERJQ1RJT05BUllfRU5EKEN1c3RvbUV2ZW50KQogCi0KLSNkZWZpbmUgSU5TVEFOVElB VEVfQUxMX0VWRU5UX0lOSVRJQUxJWklOR19DT05TVFJVQ1RPUlMoRElDVElPTkFSWV9TVEFSVCwg RElDVElPTkFSWV9FTkQsIEZJTExfUEFSRU5UX1BST1BFUlRJRVMsIEZJTExfUFJPUEVSVFkpIFwK LSAgICBJTlNUQU5USUFURV9JTklUSUFMSVpJTkdfQ09OU1RSVUNUT1JfRk9SX0VWRU5UKERJQ1RJ T05BUllfU1RBUlQsIERJQ1RJT05BUllfRU5ELCBGSUxMX1BBUkVOVF9QUk9QRVJUSUVTLCBGSUxM X1BST1BFUlRZKSBcCi0gICAgSU5TVEFOVElBVEVfSU5JVElBTElaSU5HX0NPTlNUUlVDVE9SX0ZP Ul9DVVNUT01fRVZFTlQoRElDVElPTkFSWV9TVEFSVCwgRElDVElPTkFSWV9FTkQsIEZJTExfUEFS RU5UX1BST1BFUlRJRVMsIEZJTExfUFJPUEVSVFkpIFwKLQogfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQogCiAjZW5kaWYgLy8gRXZlbnRDb25zdHJ1Y3RvcnNfaApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvSlNFdmVudENvbnN0cnVjdG9ycy5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU0V2ZW50Q29uc3RydWN0b3JzLmNwcAppbmRleCBiMzNhNWNiNjFkZTM1 ODg3OTIwYTRlYTRmYTcwYzI1OGM1ZmY5NDE2Li41YTk0Y2M1MDU0NmYwOGI5MTg2NGU4ZTgwYTI0 MjI1NmY3MTJkNjU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0V2 ZW50Q29uc3RydWN0b3JzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0V2 ZW50Q29uc3RydWN0b3JzLmNwcApAQCAtOTEsNiArOTEsOCBAQCBzdGF0aWMgRW5jb2RlZEpTVmFs dWUgY29uc3RydWN0SlNFdmVudFdpdGhJbml0aWFsaXplcihFeGVjU3RhdGUqIGV4ZWMsIGJvb2wg KCpmaQogICAgIGlmICghZGljdGlvbmFyeS50cnlHZXRQcm9wZXJ0eSgjcHJvcGVydHlOYW1lLCBl dmVudEluaXQucHJvcGVydHlOYW1lKSkgXAogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLUlOU1RB TlRJQVRFX0FMTF9FVkVOVF9JTklUSUFMSVpJTkdfQ09OU1RSVUNUT1JTKERJQ1RJT05BUllfU1RB UlQsIERJQ1RJT05BUllfRU5ELCBGSUxMX1BBUkVOVF9QUk9QRVJUSUVTLCBGSUxMX1BST1BFUlRZ KQorCitJTlNUQU5USUFURV9JTklUSUFMSVpJTkdfQ09OU1RSVUNUT1JfRk9SX0VWRU5UKERJQ1RJ T05BUllfU1RBUlQsIERJQ1RJT05BUllfRU5ELCBGSUxMX1BBUkVOVF9QUk9QRVJUSUVTLCBGSUxM X1BST1BFUlRZKQorSU5TVEFOVElBVEVfSU5JVElBTElaSU5HX0NPTlNUUlVDVE9SX0ZPUl9DVVNU T01fRVZFTlQoRElDVElPTkFSWV9TVEFSVCwgRElDVElPTkFSWV9FTkQsIEZJTExfUEFSRU5UX1BS T1BFUlRJRVMsIEZJTExfUFJPUEVSVFkpCiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK