66763 2011-08-23 04:31:47 -0700 Remove last occurrences of PLATFORM(ANDROID) 2011-08-23 06:07:40 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66688 1 steveblock steveblock mnaganov peter satish steveblock tonyg oldest_to_newest 455311 0 steveblock 2011-08-23 04:31:47 -0700 See also Bug 66741 455317 1 104819 steveblock 2011-08-23 04:36:47 -0700 Created attachment 104819 Patch 455331 2 104819 tonyg 2011-08-23 05:22:06 -0700 Comment on attachment 104819 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104819&action=review > Source/WebCore/bindings/v8/V8GCController.cpp:-476 > - static const int highUsageDeltaMB = -1; Any background on this? Should it still be present as OS(ANDROID)? 455351 3 104819 steveblock 2011-08-23 05:51:16 -0700 Comment on attachment 104819 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104819&action=review >> Source/WebCore/bindings/v8/V8GCController.cpp:-476 >> - static const int highUsageDeltaMB = -1; > > Any background on this? Should it still be present as OS(ANDROID)? I guess we're not sure yet, as I don't know if or how we'll provide this functionality via the Chromium port. In any case, switching it to OS(ANDROID) now will mean that it won't compile, so I thought it best to remove it to allow us to get the Chromium port building for Android ASAP. Peter, do you have any thoughts? 455352 4 tonyg 2011-08-23 05:57:00 -0700 (In reply to comment #3) > (From update of attachment 104819 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104819&action=review > > >> Source/WebCore/bindings/v8/V8GCController.cpp:-476 > >> - static const int highUsageDeltaMB = -1; > > > > Any background on this? Should it still be present as OS(ANDROID)? > > I guess we're not sure yet, as I don't know if or how we'll provide this functionality via the Chromium port. > > In any case, switching it to OS(ANDROID) now will mean that it won't compile, so I thought it best to remove it to allow us to get the Chromium port building for Android ASAP. Peter, do you have any thoughts? Sounds good. 455356 5 peter 2011-08-23 06:01:19 -0700 I agree on removing them for now. Re-adding these three variables is trivial and could easily be done as part of supporting the methods in Chromium's PlatformBridge after we decide on how to implement the functionality. 455360 6 steveblock 2011-08-23 06:07:40 -0700 Committed r93597: <http://trac.webkit.org/changeset/93597> 104819 2011-08-23 04:36:47 -0700 2011-08-23 05:57:14 -0700 Patch bug-66763-20110823123645.patch text/plain 3348 steveblock U3VidmVyc2lvbiBSZXZpc2lvbjogOTM1OTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBi NTY0ZGI5ODI4MjAwNWFlM2Q0YTNhYjdhYTI1MjM2NzQyOTkxZjQuLjRiNWIzNDNkMDJmNTgyNzI4 ZGM5M2EzN2NlY2M0YTk5MDMyOGJmMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDExLTA4LTIzICBTdGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNv bT4KKworICAgICAgICBSZW1vdmUgbGFzdCBvY2N1cnJlbmNlcyBvZiBQTEFURk9STShBTkRST0lE KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY3NjMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Q bGF0Zm9ybS5oOgorCiAyMDExLTA4LTIzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmVtb3ZlIFdlYkNvcmUvZWRpdGluZy9hbmRyb2lkIGFuZCBvdGhlciBBbmRy b2lkLXNwZWNpZmljIGRpcmVjdG9yaWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgK aW5kZXggZjUwMTEzM2EzM2ExMzkzNGM4Zjk1MTFhODk5ZDMxMGM2OWVlMGZiMS4uZmI0Mjk0NjVm ZWQ4ZmY1MDM5NGM4NjczYThlNTNhOGJmNjI3ODg2MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYv UGxhdGZvcm0uaApAQCAtNjEyLDIwICs2MTIsNiBAQAogI2RlZmluZSBFTkFCTEVfV0VCX0FSQ0hJ VkUgMQogI2VuZGlmCiAKLSNpZiBQTEFURk9STShBTkRST0lEKQotI2RlZmluZSBXVEZfVVNFX1BU SFJFQURTIDEKLSNkZWZpbmUgVVNFX1NZU1RFTV9NQUxMT0MgMQotI2RlZmluZSBFTkFCTEVfSkFW QV9CUklER0UgMQotI2RlZmluZSBMT0dfRElTQUJMRUQgMQotLyogUHJldmVudHMgV2Via2l0IGZy b20gZHJhd2luZyB0aGUgY2FyZXQgaW4gdGV4dGZpZWxkcyBhbmQgdGV4dGFyZWFzCi0gICBUaGlz IHByZXZlbnRzIHVubmVjZXNzYXJ5IGludmFscy4gKi8KLSNkZWZpbmUgRU5BQkxFX1RFWFRfQ0FS RVQgMQotI2RlZmluZSBFTkFCTEVfSkFWQVNDUklQVF9ERUJVR0dFUiAwCi0jaWYgIWRlZmluZWQo RU5BQkxFX0pJVCkgJiYgIUVOQUJMRShBTkRST0lEX0pTQ19KSVQpCi0jZGVmaW5lIEVOQUJMRV9K SVQgMAotI2VuZGlmCi0jZW5kaWYKLQogI2lmIFBMQVRGT1JNKFdJTikgJiYgIU9TKFdJTkNFKQog I2RlZmluZSBXVEZfVVNFX0NGIDEKICNkZWZpbmUgV1RGX1VTRV9QVEhSRUFEUyAwCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK aW5kZXggZmMyYWUzNWU0NTU4MTE4YzQ0MDY1Njk5NjQyMmZiNTBjMjg3MjJkZi4uNGIwNGZmNjc0 NjU0N2QzNzM0N2Q0NjY3YWNhYjFiMGI4ODhlMTQ1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDExLTA4LTIzICBTdGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KKwor ICAgICAgICBSZW1vdmUgbGFzdCBvY2N1cnJlbmNlcyBvZiBQTEFURk9STShBTkRST0lEKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY3NjMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMs IHJlbW92aW5nIGRlYWQgY29kZSBvbmx5LgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhHQ0Nv bnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhHQ0NvbnRyb2xsZXI6OmNoZWNrTWVt b3J5VXNhZ2UpOgorCiAyMDExLTA4LTIzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmVtb3ZlIFdlYkNvcmUvZWRpdGluZy9hbmRyb2lkIGFuZCBvdGhlciBBbmRy b2lkLXNwZWNpZmljIGRpcmVjdG9yaWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OEdDQ29udHJvbGxlci5jcHAKaW5kZXggZGFlZThmZThhZjJmMWQ1NDc1OTkyOGRmZWU5YmU3NTNi NmNiMDIwZS4uYjUxYWVkMTk4MTVlMzVlYTFiMmQyMmRkMzc1MDRhNGM4MDVhOGEwMCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcApAQCAtNDY4LDEy ICs0NjgsNiBAQCB2b2lkIFY4R0NDb250cm9sbGVyOjpjaGVja01lbW9yeVVzYWdlKCkKICAgICBj b25zdCBpbnQgbG93VXNhZ2VNQiA9IDI1NjsgIC8vIElmIG1lbW9yeSB1c2FnZSBpcyBiZWxvdyB0 aGlzIHRocmVzaG9sZCwgZG8gbm90IGJvdGhlciBmb3JjaW5nIEdDLgogICAgIGNvbnN0IGludCBo aWdoVXNhZ2VNQiA9IDEwMjQ7ICAvLyBJZiBtZW1vcnkgdXNhZ2UgaXMgYWJvdmUgdGhpcyB0aHJl c2hvbGQsIGZvcmNlIEdDIG1vcmUgYWdncmVzaXZlbHkuCiAgICAgY29uc3QgaW50IGhpZ2hVc2Fn ZURlbHRhTUIgPSAxMjg7ICAvLyBEZWx0YSBvZiBtZW1vcnkgdXNhZ2UgZ3Jvd3RoICh2cy4gbGFz dCB3b3JraW5nU2V0RXN0aW1hdGVNQikgdG8gZm9yY2UgR0Mgd2hlbiBtZW1vcnkgdXNhZ2UgaXMg aGlnaC4KLSNlbGlmIFBMQVRGT1JNKEFORFJPSUQpCi0gICAgLy8gUXVlcnkgdGhlIFBsYXRmb3Jt QnJpZGdlIGZvciBtZW1vcnkgdGhyZXNob2xkcyBhcyB0aGVzZSB2YXJ5IGRldmljZSB0byBkZXZp Y2UuCi0gICAgc3RhdGljIGNvbnN0IGludCBsb3dVc2FnZU1CID0gUGxhdGZvcm1CcmlkZ2U6Omxv d01lbW9yeVVzYWdlTUIoKTsKLSAgICBzdGF0aWMgY29uc3QgaW50IGhpZ2hVc2FnZU1CID0gUGxh dGZvcm1CcmlkZ2U6OmhpZ2hNZW1vcnlVc2FnZU1CKCk7Ci0gICAgLy8gV2UgdXNlIGEgZGVsdGEg b2YgLTEgdG8gZW5zdXJlIHRoYXQgd2hlbiB3ZSBhcmUgaW4gYSBsb3cgbWVtb3J5IHNpdHVhdGlv biB3ZSBhbHdheXMgdHJpZ2dlciBhIEdDLgotICAgIHN0YXRpYyBjb25zdCBpbnQgaGlnaFVzYWdl RGVsdGFNQiA9IC0xOwogI2Vsc2UKICAgICByZXR1cm47CiAjZW5kaWYK