66759 2011-08-23 04:10:45 -0700 Remove Android-specific modifications to non-client-based Geolocation 2011-10-18 05:55:36 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 40373 66688 1 steveblock steveblock hausmann kenneth peter steveblock tonyg zalan oldest_to_newest 455302 0 steveblock 2011-08-23 04:10:45 -0700 Remove Android-specific modifications to non-client-based Geolocation 455324 1 steveblock 2011-08-23 04:57:11 -0700 Geolocation::suspend()/resume() and GeolocationService::suspend()/resume()were first added in http://trac.webkit.org/changeset/38018 Geolocation::suspend()/resume() were removed in http://trac.webkit.org/changeset/56188 but reinstated for Android in http://trac.webkit.org/changeset/58061. When GeolocationClient implementations for GTK (http://trac.webkit.org/changeset/38765) and EFL (http://trac.webkit.org/changeset/81556) were added, they added empty stubs for suspend() and resume() even though these methods are only called on Android. The Android port of WebKit is being removed in Bug 66688, so it should be safe to remove the methods on Geolocation and on the clients. 455325 2 104823 steveblock 2011-08-23 04:59:36 -0700 Created attachment 104823 Patch 455349 3 steveblock 2011-08-23 05:46:24 -0700 Committed r93596: <http://trac.webkit.org/changeset/93596> 485952 4 kenneth 2011-10-18 04:28:23 -0700 Well this code is used by Qt on our branch and it is used by iOS as well. 485958 5 steveblock 2011-10-18 04:36:23 -0700 > Well this code is used by Qt on our branch and it is used by iOS as well. Sorry, I wasn't aware of this. Wasn't it you that reviewed http://trac.webkit.org/changeset/56188 which removed them previously? Do these methods need to be present upstream? If so, we should add comments to make this clear so they're not deleted again in the future. 485982 6 kenneth 2011-10-18 05:48:42 -0700 We are going to upstream all of our suspend/resume code, so they will be needed yes. We will readd them as part of that. 485984 7 steveblock 2011-10-18 05:52:54 -0700 > We will readd them as part of that. OK Do you have plans to switch to the client-based Geolocation implementation? There's consensus that it's the right approach and that we should remove the non-client-based implementation. It would also remove the need for add()/resume() as all this logic can be handled by the client. See Bug 40373. 485985 8 kenneth 2011-10-18 05:55:36 -0700 (In reply to comment #7) > > We will readd them as part of that. > OK > > Do you have plans to switch to the client-based Geolocation implementation? There's consensus that it's the right approach and that we should remove the non-client-based implementation. It would also remove the need for add()/resume() as all this logic can be handled by the client. See Bug 40373. Yes, we will be using that, sure. 104823 2011-08-23 04:59:36 -0700 2011-08-23 05:23:59 -0700 Patch bug-66759-20110823125934.patch text/plain 5597 steveblock U3VidmVyc2lvbiBSZXZpc2lvbjogOTM1OTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmYzJhZTM1ZTQ1NTgxMThj NDQwNjU2OTk2NDIyZmI1MGMyODcyMmRmLi43ODgyOGExOTlhNWMwY2FkMDYwYzYyMDY2YjkyZTk4 MmMyZWNhNWNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDgtMjMgIFN0ZXZl IEJsb2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBBbmRyb2lk LXNwZWNpZmljIG1vZGlmaWNhdGlvbnMgdG8gbm9uLWNsaWVudC1iYXNlZCBHZW9sb2NhdGlvbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY3NTkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMsIHJlbW92aW5nIGRlYWQgY29kZSBvbmx5LgorCisgICAgICAgICogcGFnZS9HZW9sb2NhdGlv bi5jcHA6CisgICAgICAgICogcGFnZS9HZW9sb2NhdGlvbi5oOgorICAgICAgICAqIHBsYXRmb3Jt L0dlb2xvY2F0aW9uU2VydmljZS5oOgorICAgICAgICAqIHBsYXRmb3JtL2VmbC9HZW9sb2NhdGlv blNlcnZpY2VFZmwuY3BwOgorICAgICAgICAqIHBsYXRmb3JtL2VmbC9HZW9sb2NhdGlvblNlcnZp Y2VFZmwuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvR2VvbG9jYXRpb25TZXJ2aWNlR3RrLmNw cDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvR2VvbG9jYXRpb25TZXJ2aWNlR3RrLmg6CisKIDIw MTEtMDgtMjMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1v dmUgV2ViQ29yZS9lZGl0aW5nL2FuZHJvaWQgYW5kIG90aGVyIEFuZHJvaWQtc3BlY2lmaWMgZGly ZWN0b3JpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvR2VvbG9jYXRpb24uY3Bw IGIvU291cmNlL1dlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5jcHAKaW5kZXggMmM4MTNhNTRhZTky MmE0YWFlNmI0ZDU4ZTMzMDM2NDBiMGYwNmVjYS4uMTlmOWFjN2IwMGU4MDU1NTVhM2JhZjI4MmZi ODUyYThlYjc0NjExZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9HZW9sb2NhdGlv bi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5jcHAKQEAgLTQyNCwy MiArNDI0LDYgQEAgdm9pZCBHZW9sb2NhdGlvbjo6Y2xlYXJXYXRjaChpbnQgd2F0Y2hJZCkKICAg ICAgICAgc3RvcFVwZGF0aW5nKCk7CiB9CiAKLXZvaWQgR2VvbG9jYXRpb246OnN1c3BlbmQoKQot ewotI2lmICFFTkFCTEUoQ0xJRU5UX0JBU0VEX0dFT0xPQ0FUSU9OKQotICAgIGlmIChoYXNMaXN0 ZW5lcnMoKSkKLSAgICAgICAgbV9zZXJ2aWNlLT5zdXNwZW5kKCk7Ci0jZW5kaWYKLX0KLQotdm9p ZCBHZW9sb2NhdGlvbjo6cmVzdW1lKCkKLXsKLSNpZiAhRU5BQkxFKENMSUVOVF9CQVNFRF9HRU9M T0NBVElPTikKLSAgICBpZiAoaGFzTGlzdGVuZXJzKCkpCi0gICAgICAgIG1fc2VydmljZS0+cmVz dW1lKCk7Ci0jZW5kaWYKLX0KLQogdm9pZCBHZW9sb2NhdGlvbjo6c2V0SXNBbGxvd2VkKGJvb2wg YWxsb3dlZCkKIHsKICAgICAvLyBQcm90ZWN0IHRoZSBHZW9sb2NhdGlvbiBvYmplY3QgZnJvbSBn YXJiYWdlIGNvbGxlY3Rpb24gZHVyaW5nIGEgY2FsbGJhY2suCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0dlb2xvY2F0 aW9uLmgKaW5kZXggZjk2YzVhOTY3MGNlYzZkMTc2ZTg4N2JlZjM1NzI5Njc3YTQ0YTFmZi4uMDRi OTBkYmY0MTVjMDU1MjI4OGVlN2E0NjYyMmViYjJjYzc2NTNmNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvR2Vv bG9jYXRpb24uaApAQCAtNjQsMTAgKzY0LDYgQEAgcHVibGljOgogICAgIGludCB3YXRjaFBvc2l0 aW9uKFBhc3NSZWZQdHI8UG9zaXRpb25DYWxsYmFjaz4sIFBhc3NSZWZQdHI8UG9zaXRpb25FcnJv ckNhbGxiYWNrPiwgUGFzc1JlZlB0cjxQb3NpdGlvbk9wdGlvbnM+KTsKICAgICB2b2lkIGNsZWFy V2F0Y2goaW50IHdhdGNoSWQpOwogCi0gICAgLy8gVGhlc2UgbWV0aG9kcyBhcmUgdXNlZCBieSBB bmRyb2lkLgotICAgIHZvaWQgc3VzcGVuZCgpOwotICAgIHZvaWQgcmVzdW1lKCk7Ci0KICAgICB2 b2lkIHNldElzQWxsb3dlZChib29sKTsKICAgICBGcmFtZSogZnJhbWUoKSBjb25zdCB7IHJldHVy biBtX2ZyYW1lOyB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0dlb2xv Y2F0aW9uU2VydmljZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vR2VvbG9jYXRpb25TZXJ2 aWNlLmgKaW5kZXggOTI2NWEwNWQxZWViMWI5NWIxM2E1YzEwMWVkMTcxYzhlYjY3MjJhNi4uNWJh OWZkNzUzN2VlYTllYWNiMTgxYmJkZWVmMjdlNWQ3NWE1MDUwOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vR2VvbG9jYXRpb25TZXJ2aWNlLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vR2VvbG9jYXRpb25TZXJ2aWNlLmgKQEAgLTUyLDkgKzUyLDYgQEAgcHVibGlj OgogICAgIHZpcnR1YWwgYm9vbCBzdGFydFVwZGF0aW5nKFBvc2l0aW9uT3B0aW9ucyopIHsgcmV0 dXJuIGZhbHNlOyB9CiAgICAgdmlydHVhbCB2b2lkIHN0b3BVcGRhdGluZygpIHsgfQogCi0gICAg dmlydHVhbCB2b2lkIHN1c3BlbmQoKSB7IH0KLSAgICB2aXJ0dWFsIHZvaWQgcmVzdW1lKCkgeyB9 Ci0KICAgICB2aXJ0dWFsIEdlb3Bvc2l0aW9uKiBsYXN0UG9zaXRpb24oKSBjb25zdCB7IHJldHVy biAwOyB9CiAgICAgdmlydHVhbCBQb3NpdGlvbkVycm9yKiBsYXN0RXJyb3IoKSBjb25zdCB7IHJl dHVybiAwOyB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9HZW9s b2NhdGlvblNlcnZpY2VFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0dlb2xv Y2F0aW9uU2VydmljZUVmbC5jcHAKaW5kZXggOWE1NzZkNTk1NDA4YzU2MWM1ZGM4NjEzY2Q5M2I2 YzI0OGY3YzUyMi4uNzA4MTQ3NTc3YjZjOGUyNGVlNDhkMWY2Zjc0MjYwZDFmM2JmNjA3NyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0dlb2xvY2F0aW9uU2VydmljZUVm bC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0dlb2xvY2F0aW9uU2Vydmlj ZUVmbC5jcHAKQEAgLTU2LDE2ICs1Niw2IEBAIHZvaWQgR2VvbG9jYXRpb25TZXJ2aWNlRWZsOjpz dG9wVXBkYXRpbmcoKQogICAgIG5vdEltcGxlbWVudGVkKCk7CiB9CiAKLXZvaWQgR2VvbG9jYXRp b25TZXJ2aWNlRWZsOjpzdXNwZW5kKCkKLXsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotfQotCi12 b2lkIEdlb2xvY2F0aW9uU2VydmljZUVmbDo6cmVzdW1lKCkKLXsKLSAgICBub3RJbXBsZW1lbnRl ZCgpOwotfQotCiBHZW9wb3NpdGlvbiogR2VvbG9jYXRpb25TZXJ2aWNlRWZsOjpsYXN0UG9zaXRp b24oKSBjb25zdAogewogICAgIHJldHVybiBtX2xhc3RQb3NpdGlvbi5nZXQoKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9HZW9sb2NhdGlvblNlcnZpY2VFZmwuaCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9HZW9sb2NhdGlvblNlcnZpY2VFZmwuaAppbmRl eCBkMzBhZDM4N2E3NTQ1ZTc0ODEwY2ZiOTU1ZjM4NDZmNWE2ZGU3MDhlLi4wY2QzZThiZTdjNmIx ZGYxZDJjYzFmOWI3MTdiNDhmNDg3Yjk0ZGMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvR2VvbG9jYXRpb25TZXJ2aWNlRWZsLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZWZsL0dlb2xvY2F0aW9uU2VydmljZUVmbC5oCkBAIC0zNyw5ICszNyw2IEBAIHB1 YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgc3RhcnRVcGRhdGluZyhQb3NpdGlvbk9wdGlvbnMqKTsK ICAgICB2aXJ0dWFsIHZvaWQgc3RvcFVwZGF0aW5nKCk7CiAKLSAgICB2aXJ0dWFsIHZvaWQgc3Vz cGVuZCgpOwotICAgIHZpcnR1YWwgdm9pZCByZXN1bWUoKTsKLQogICAgIHZpcnR1YWwgR2VvcG9z aXRpb24qIGxhc3RQb3NpdGlvbigpIGNvbnN0OwogICAgIHZpcnR1YWwgUG9zaXRpb25FcnJvciog bGFzdEVycm9yKCkgY29uc3Q7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9HZW9sb2NhdGlvblNlcnZpY2VHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3RrL0dlb2xvY2F0aW9uU2VydmljZUd0ay5jcHAKaW5kZXggOGMzZDQ1NmZhZDQwMTQxMTRjMGJk YWRhNDllNzA1ZTkxMjViOTRlNi4uNDlhN2I0ZGYzODZjOTk1NjI1ZjdhODNkYzAxNjQwMzI0YTQy Y2QzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0dlb2xvY2F0aW9u U2VydmljZUd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0dlb2xvY2F0 aW9uU2VydmljZUd0ay5jcHAKQEAgLTEzNywxOCArMTM3LDYgQEAgdm9pZCBHZW9sb2NhdGlvblNl cnZpY2VHdGs6OnN0b3BVcGRhdGluZygpCiAgICAgbV9nZW9jbHVlQ2xpZW50ID0gMDsKIH0KIAot dm9pZCBHZW9sb2NhdGlvblNlcnZpY2VHdGs6OnN1c3BlbmQoKQotewotICAgIC8vIG5vdCBhdmFp bGFibGUgd2l0aCBnZW9jbHVlCi0gICAgbm90SW1wbGVtZW50ZWQoKTsKLX0KLQotdm9pZCBHZW9s b2NhdGlvblNlcnZpY2VHdGs6OnJlc3VtZSgpCi17Ci0gICAgLy8gbm90IGF2YWlsYWJsZSB3aXRo IGdlb2NsdWUKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotfQotCiBHZW9wb3NpdGlvbiogR2VvbG9j YXRpb25TZXJ2aWNlR3RrOjpsYXN0UG9zaXRpb24oKSBjb25zdAogewogICAgIHJldHVybiBtX2xh c3RQb3NpdGlvbi5nZXQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9HZW9sb2NhdGlvblNlcnZpY2VHdGsuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9H ZW9sb2NhdGlvblNlcnZpY2VHdGsuaAppbmRleCA4ZWNhOGFhYTVlYWYyOTljY2JiZmMyZjRhMDY2 MTlmYTgzYzQzMDYwLi5lZGEzMDkwN2UyYTUwOTFjYTdlMjk4ZWI3NjM2ZjJmYjFmNTJiYzdmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvR2VvbG9jYXRpb25TZXJ2aWNl R3RrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0dlb2xvY2F0aW9uU2Vydmlj ZUd0ay5oCkBAIC0zOCw5ICszOCw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdmly dHVhbCBib29sIHN0YXJ0VXBkYXRpbmcoUG9zaXRpb25PcHRpb25zKik7CiAgICAgICAgIHZpcnR1 YWwgdm9pZCBzdG9wVXBkYXRpbmcoKTsKIAotICAgICAgICB2aXJ0dWFsIHZvaWQgc3VzcGVuZCgp OwotICAgICAgICB2aXJ0dWFsIHZvaWQgcmVzdW1lKCk7Ci0KICAgICAgICAgR2VvcG9zaXRpb24q IGxhc3RQb3NpdGlvbigpIGNvbnN0OwogICAgICAgICBQb3NpdGlvbkVycm9yKiBsYXN0RXJyb3Io KSBjb25zdDsKIAo=