66551 2011-08-19 05:55:44 -0700 editing/selection/caret-at-bidi-boundary.html timing out on Windows since it was added 2011-08-22 12:13:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r93369%20(15625)/results.html LayoutTestFailure, PlatformOnly P2 Normal --- 1 aroben rniwa hyatt mrobinson rniwa webkit.review.bot oldest_to_newest 453769 0 aroben 2011-08-19 05:55:44 -0700 editing/selection/caret-at-bidi-boundary.html has been timing out on Windows since it was added in r93369 <http://trac.webkit.org/changeset/93369>. http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r93369%20(15625)/results.html 453884 1 rniwa 2011-08-19 09:50:39 -0700 Also see the bug 66514. 453888 2 rniwa 2011-08-19 09:52:58 -0700 Does the test still time out if you commented out all but the first dt and dd? 454268 3 rniwa 2011-08-19 18:40:41 -0700 So the problem is that Windows port's DRT actually sleeps for the amount of time leapForward is called upon :( See replaySavedEvents in win/EventSender.cpp. This is not now other ports implement leapForward. 454274 4 rniwa 2011-08-19 18:50:32 -0700 See http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/win/EventSender.cpp#L351 454275 5 rniwa 2011-08-19 18:51:14 -0700 Skipped the test in http://trac.webkit.org/changeset/93464. 454411 6 mrobinson 2011-08-21 09:57:27 -0700 (In reply to comment #3) > So the problem is that Windows port's DRT actually sleeps for the amount of time leapForward is called upon :( See replaySavedEvents in win/EventSender.cpp. This is not now other ports implement leapForward. I'm not sure this is accurate. GTK+, Qt and Windows all implement leapForward this way. 454744 7 104703 rniwa 2011-08-22 11:38:05 -0700 Created attachment 104703 fixes the test 454746 8 104704 rniwa 2011-08-22 11:38:47 -0700 Created attachment 104704 fixed the tab 454748 9 webkit.review.bot 2011-08-22 11:39:54 -0700 Attachment 104703 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/edit..." exit_code: 1 LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 454764 10 rniwa 2011-08-22 11:47:17 -0700 Note I have verified that the test passes on Windows after this change. 454788 11 rniwa 2011-08-22 12:13:03 -0700 Committed r93529: <http://trac.webkit.org/changeset/93529> 104703 2011-08-22 11:38:05 -0700 2011-08-22 11:38:47 -0700 fixes the test bidi-caret-test-fix text/plain 1418 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDkzNTIzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMjIgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgZWRpdGluZy9zZWxlY3Rpb24vY2FyZXQtYXQtYmlk aS1ib3VuZGFyeS5odG1sIHRpbWluZyBvdXQgb24gV2luZG93cyBzaW5jZSBpdCB3YXMgYWRkZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NTUxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwkJUmVwbGFjZWQgbGVhcEZv cndhcmQgYnkgZHVtbXkgY2xpY2tzIHRvIG1ha2UgaXQgd29yayBvbiBXaW5kb3dzIGFuZCBvdGhl ciBwb3J0cy4KKworICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL2NhcmV0LWF0LWJpZGktYm91 bmRhcnkuaHRtbDoKKwogMjAxMS0wOC0yMiAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFRlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02NDc0MS4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2NhcmV0 LWF0LWJpZGktYm91bmRhcnkuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5n L3NlbGVjdGlvbi9jYXJldC1hdC1iaWRpLWJvdW5kYXJ5Lmh0bWwJKHJldmlzaW9uIDkzNDI0KQor KysgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vY2FyZXQtYXQtYmlkaS1ib3VuZGFyeS5o dG1sCSh3b3JraW5nIGNvcHkpCkBAIC01NSw3ICs1NSwxMSBAQAogICAgIHZhciBwcmV2aW91c09m ZnNldCA9IC0xOwogICAgIHZhciBqID0gMDsKICAgICBmb3IgKHZhciB4ID0gNTsgeCA8PSB0YXJn ZXQub2Zmc2V0V2lkdGggLSA1OyB4KyspIHsKLSAgICAgICAgZXZlbnRTZW5kZXIubGVhcEZvcndh cmQoMTAwMCk7CisgICAgICAgIC8vIFJlc2V0IHRoZSBjbGljayBjb3VudAorICAgICAgICBldmVu dFNlbmRlci5tb3VzZU1vdmVUbygxLCAxKTsKKyAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3du KCk7CisgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKKwogICAgICAgICBldmVudFNlbmRl ci5tb3VzZU1vdmVUbyh0YXJnZXQub2Zmc2V0TGVmdCArIHgsIHkpOwogICAgICAgICBldmVudFNl bmRlci5tb3VzZURvd24oKTsKICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOwo= 104704 2011-08-22 11:38:47 -0700 2011-08-22 11:52:21 -0700 fixed the tab bidi-caret-test-fix text/plain 1424 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDkzNTIzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMjIgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgZWRpdGluZy9zZWxlY3Rpb24vY2FyZXQtYXQtYmlk aS1ib3VuZGFyeS5odG1sIHRpbWluZyBvdXQgb24gV2luZG93cyBzaW5jZSBpdCB3YXMgYWRkZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NTUxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwbGFjZWQg bGVhcEZvcndhcmQgYnkgZHVtbXkgY2xpY2tzIHRvIG1ha2UgaXQgd29yayBvbiBXaW5kb3dzIGFu ZCBvdGhlciBwb3J0cy4KKworICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL2NhcmV0LWF0LWJp ZGktYm91bmRhcnkuaHRtbDoKKwogMjAxMS0wOC0yMiAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFRlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02NDc0MS4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9u L2NhcmV0LWF0LWJpZGktYm91bmRhcnkuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9l ZGl0aW5nL3NlbGVjdGlvbi9jYXJldC1hdC1iaWRpLWJvdW5kYXJ5Lmh0bWwJKHJldmlzaW9uIDkz NDI0KQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vY2FyZXQtYXQtYmlkaS1ib3Vu ZGFyeS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC01NSw3ICs1NSwxMSBAQAogICAgIHZhciBwcmV2 aW91c09mZnNldCA9IC0xOwogICAgIHZhciBqID0gMDsKICAgICBmb3IgKHZhciB4ID0gNTsgeCA8 PSB0YXJnZXQub2Zmc2V0V2lkdGggLSA1OyB4KyspIHsKLSAgICAgICAgZXZlbnRTZW5kZXIubGVh cEZvcndhcmQoMTAwMCk7CisgICAgICAgIC8vIFJlc2V0IHRoZSBjbGljayBjb3VudAorICAgICAg ICBldmVudFNlbmRlci5tb3VzZU1vdmVUbygxLCAxKTsKKyAgICAgICAgZXZlbnRTZW5kZXIubW91 c2VEb3duKCk7CisgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKKwogICAgICAgICBldmVu dFNlbmRlci5tb3VzZU1vdmVUbyh0YXJnZXQub2Zmc2V0TGVmdCArIHgsIHkpOwogICAgICAgICBl dmVudFNlbmRlci5tb3VzZURvd24oKTsKICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOwo=