<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>66439</bug_id>
          
          <creation_ts>2011-08-17 17:46:47 -0700</creation_ts>
          <short_desc>[chromium] Remove LayerRendererChromium references from WebGLLayerChromium</short_desc>
          <delta_ts>2011-09-02 11:19:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>66430</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adrienne Walker">enne</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>enne</cc>
    
    <cc>husky</cc>
    
    <cc>jamesr</cc>
    
    <cc>kbr</cc>
    
    <cc>nduca</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>452768</commentid>
    <comment_count>0</comment_count>
    <who name="Adrienne Walker">enne</who>
    <bug_when>2011-08-17 17:46:47 -0700</bug_when>
    <thetext>WebGLLayerChromium will need to keep its own context for drawing, but will need to use a compositor context passed in as a function arg during updateCompositorResources.

Similarly to bug 66435, the interaction with adding and removing child contexts from the LayerRendererChromium will need to be deferred.

The part that I don&apos;t fully understand is how to handle WebGLLayerChromium::paintRenderingResultsToCanvas.  That seems problematic at best to get working with the compositor thread.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>452769</commentid>
    <comment_count>1</comment_count>
    <who name="James Robinson">jamesr</who>
    <bug_when>2011-08-17 17:48:51 -0700</bug_when>
    <thetext>Yeah it&apos;s extremely problematic.  It&apos;s basically a hack to get printing going for m14. We need to figure this out for real going forward.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>453151</commentid>
    <comment_count>2</comment_count>
    <who name="James Robinson">jamesr</who>
    <bug_when>2011-08-18 11:05:50 -0700</bug_when>
    <thetext>I personally vote that we punt on threaded compositor + WebGL + printing for now.  It&apos;ll be a pain to sort out now, but I think it&apos;ll become more clear once we figure out how we handle readback paths in the threaded compositor in general.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>453155</commentid>
    <comment_count>3</comment_count>
    <who name="Adrienne Walker">enne</who>
    <bug_when>2011-08-18 11:09:21 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; I personally vote that we punt on threaded compositor + WebGL + printing for now.  It&apos;ll be a pain to sort out now, but I think it&apos;ll become more clear once we figure out how we handle readback paths in the threaded compositor in general.

In the short term maybe we can #ifdef this functionality out when the threaded compositor is on and file another bug to fix it properly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>461357</commentid>
    <comment_count>4</comment_count>
    <who name="Adrienne Walker">enne</who>
    <bug_when>2011-09-02 11:19:16 -0700</bug_when>
    <thetext>This was fixed in bug 66430.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>