66294 2011-08-16 05:36:35 -0700 [WebSocket] Remove arguments from CloseEvent::create() 2011-08-18 01:03:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Trivial --- 66362 0 toyoshim webkit-unassigned abarth ap tkent webkit.review.bot yutak oldest_to_newest 451567 0 toyoshim 2011-08-16 05:36:35 -0700 I took over implementation of CloseEvent's code and reason. For the coming next change, I'd like to remove arguments from CloseEvent::create() because it was useless. 451568 1 104030 toyoshim 2011-08-16 05:42:21 -0700 Created attachment 104030 Patch 451572 2 104030 yutak 2011-08-16 05:56:49 -0700 Comment on attachment 104030 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104030&action=review [Note: I'm not a WebKit reviewer] Code change looks fine to me. > Source/WebCore/ChangeLog:7 > + You need to write the reason why you can safely omit wasClean argument from create(). You also need to justify not adding a new test. 452178 3 104159 toyoshim 2011-08-17 02:27:52 -0700 Created attachment 104159 Patch 452182 4 104159 yutak 2011-08-17 02:42:30 -0700 Comment on attachment 104159 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104159&action=review > Source/WebCore/ChangeLog:9 > + Remove arguments from CloseEvent::create(). CloseEvent objects are > + initialized by initCloseEvent() in all cases. Initialization in > + create() is redundant. We does not need additional tests because this > + change does not introduce any functional difference. > + https://bugs.webkit.org/show_bug.cgi?id=66294 > + > + Reviewed by NOBODY (OOPS!). Normally, ChangeLog entry is formatted like: <Bug title> <Bug URL> Reviewed by <Reviewer>. <Change description> See existing entries. 452184 5 104163 toyoshim 2011-08-17 02:50:45 -0700 Created attachment 104163 Patch 452185 6 toyoshim 2011-08-17 02:52:15 -0700 Sorry for bothering. Revised again. 452202 7 104163 yutak 2011-08-17 04:42:32 -0700 Comment on attachment 104163 Patch Looks fine. [Note: I'm not a WebKit reviewer] 452873 8 104163 tkent 2011-08-17 23:44:21 -0700 Comment on attachment 104163 Patch ok 452898 9 104163 webkit.review.bot 2011-08-18 01:02:55 -0700 Comment on attachment 104163 Patch Clearing flags on attachment: 104163 Committed r93288: <http://trac.webkit.org/changeset/93288> 452899 10 webkit.review.bot 2011-08-18 01:03:00 -0700 All reviewed patches have been landed. Closing bug. 104030 2011-08-16 05:42:21 -0700 2011-08-17 02:27:45 -0700 Patch bug-66294-20110816214220.patch text/plain 2539 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogOTMwODEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MGU4ZmM1MzEzOThiMmNk YjZjMDk4YmY5NjBhYTczNzlhODhiYmVhLi4yOWU5OGI2YmEyZmM1NzZhODgxNDk4MjYxMzdiMzU0 YzAxMzFhMmU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMTYgIFRha2Fz aGkgVG95b3NoaW1hICA8dG95b3NoaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBh cmd1bWVudHMgZnJvbSBDbG9zZUV2ZW50OjpjcmVhdGUoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2Mjk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3ZWJzb2NrZXRzL0Nsb3NlRXZlbnQuaDoKKyAg ICAgICAgKFdlYkNvcmU6OkNsb3NlRXZlbnQ6OmNyZWF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpD bG9zZUV2ZW50OjpDbG9zZUV2ZW50KToKKyAgICAgICAgKiB3ZWJzb2NrZXRzL1dlYlNvY2tldC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJTb2NrZXQ6OmRpZENsb3NlKToKKwogMjAxMS0wOC0x NSAgSmVmZnJleSBQZmF1ICA8anBmYXVAYXBwbGUuY29tPgogCiAgICAgICAgIE5ldyBYTUwgcGFy c2VyOiBhZGQgeG1sIG5hbWVzcGFjZSB0byB0aGUgZGVmYXVsdCBtYXAgb2YgbmFtZXNwYWNlcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9DbG9zZUV2ZW50LmggYi9Tb3Vy Y2UvV2ViQ29yZS93ZWJzb2NrZXRzL0Nsb3NlRXZlbnQuaAppbmRleCBmZWIzYjZlMGQ0NGY3Yjc5 NGFhM2Q1ZWNlNDhlZGJjNzY1NjZlYjg0Li5hMDc5MDAzM2Y0Y2M3MzAwYThkYjNjYTdlNmY3YjRk NTA2NjYzODQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL0Nsb3NlRXZl bnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL0Nsb3NlRXZlbnQuaApAQCAtNDAs OSArNDAsOSBAQCBjbGFzcyBDbG9zZUV2ZW50IDogcHVibGljIEV2ZW50IHsKIHB1YmxpYzoKICAg ICB2aXJ0dWFsIGJvb2wgaXNDbG9zZUV2ZW50KCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQogCi0g ICAgc3RhdGljIFBhc3NSZWZQdHI8Q2xvc2VFdmVudD4gY3JlYXRlKGJvb2wgd2FzQ2xlYW4pCisg ICAgc3RhdGljIFBhc3NSZWZQdHI8Q2xvc2VFdmVudD4gY3JlYXRlKCkKICAgICB7Ci0gICAgICAg IHJldHVybiBhZG9wdFJlZihuZXcgQ2xvc2VFdmVudCh3YXNDbGVhbikpOworICAgICAgICByZXR1 cm4gYWRvcHRSZWYobmV3IENsb3NlRXZlbnQoKSk7CiAgICAgfQogCiAgICAgdm9pZCBpbml0Q2xv c2VFdmVudChjb25zdCBBdG9taWNTdHJpbmcmIHR5cGUsIGJvb2wgY2FuQnViYmxlLCBib29sIGNh bmNlbGFibGUsIGJvb2wgd2FzQ2xlYW4pCkBAIC01OCw5ICs1OCw5IEBAIHB1YmxpYzoKICAgICBi b29sIHdhc0NsZWFuKCkgY29uc3QgeyByZXR1cm4gbV93YXNDbGVhbjsgfQogCiBwcml2YXRlOgot ICAgIENsb3NlRXZlbnQoYm9vbCB3YXNDbGVhbikKKyAgICBDbG9zZUV2ZW50KCkKICAgICAgICAg OiBFdmVudChldmVudE5hbWVzKCkuY2xvc2VFdmVudCwgZmFsc2UsIGZhbHNlKQotICAgICAgICAs IG1fd2FzQ2xlYW4od2FzQ2xlYW4pCisgICAgICAgICwgbV93YXNDbGVhbihmYWxzZSkKICAgICB7 IH0KIAogICAgIGJvb2wgbV93YXNDbGVhbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dl YnNvY2tldHMvV2ViU29ja2V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29j a2V0LmNwcAppbmRleCA1NmIyY2UzMzliOWJkYWExMDQzMWZjMDA1M2E1MDBiZTUwMjk4MTk4Li4x YjAxMzNlOTdkYjVkY2RjMjk4OWQ3MmFhNmY2MDZkOGVmNWQ5NTAzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv d2Vic29ja2V0cy9XZWJTb2NrZXQuY3BwCkBAIC00MjIsNyArNDIyLDcgQEAgdm9pZCBXZWJTb2Nr ZXQ6OmRpZENsb3NlKHVuc2lnbmVkIGxvbmcgdW5oYW5kbGVkQnVmZmVyZWRBbW91bnQsIENsb3Np bmdIYW5kc2hha2UKICAgICBtX3N0YXRlID0gQ0xPU0VEOwogICAgIG1fYnVmZmVyZWRBbW91bnRB ZnRlckNsb3NlICs9IHVuaGFuZGxlZEJ1ZmZlcmVkQW1vdW50OwogICAgIEFTU0VSVChzY3JpcHRF eGVjdXRpb25Db250ZXh0KCkpOwotICAgIFJlZlB0cjxDbG9zZUV2ZW50PiBldmVudCA9IENsb3Nl RXZlbnQ6OmNyZWF0ZShmYWxzZSk7CisgICAgUmVmUHRyPENsb3NlRXZlbnQ+IGV2ZW50ID0gQ2xv c2VFdmVudDo6Y3JlYXRlKCk7CiAgICAgZXZlbnQtPmluaXRDbG9zZUV2ZW50KGV2ZW50TmFtZXMo KS5jbG9zZUV2ZW50LCBmYWxzZSwgZmFsc2UsIHdhc0NsZWFuKTsKICAgICBkaXNwYXRjaEV2ZW50 KGV2ZW50KTsKICAgICBpZiAobV9jaGFubmVsKSB7Cg== 104159 2011-08-17 02:27:52 -0700 2011-08-17 02:50:38 -0700 Patch bug-66294-20110817182751.patch text/plain 2776 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogOTMwODEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MGU4ZmM1MzEzOThiMmNk YjZjMDk4YmY5NjBhYTczNzlhODhiYmVhLi5lNDQwZmE4ZTQ3ZWFlZjg0OTE1ZDBhOGU0MDVjZDIy ZWJhYjcxMjRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDgtMTYgIFRha2Fz aGkgVG95b3NoaW1hICA8dG95b3NoaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBh cmd1bWVudHMgZnJvbSBDbG9zZUV2ZW50OjpjcmVhdGUoKS4gQ2xvc2VFdmVudCBvYmplY3RzIGFy ZQorICAgICAgICBpbml0aWFsaXplZCBieSBpbml0Q2xvc2VFdmVudCgpIGluIGFsbCBjYXNlcy4g SW5pdGlhbGl6YXRpb24gaW4KKyAgICAgICAgY3JlYXRlKCkgaXMgcmVkdW5kYW50LiBXZSBkb2Vz IG5vdCBuZWVkIGFkZGl0aW9uYWwgdGVzdHMgYmVjYXVzZSB0aGlzCisgICAgICAgIGNoYW5nZSBk b2VzIG5vdCBpbnRyb2R1Y2UgYW55IGZ1bmN0aW9uYWwgZGlmZmVyZW5jZS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2Mjk0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3ZWJzb2NrZXRzL0Nsb3NlRXZl bnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkNsb3NlRXZlbnQ6OmNyZWF0ZSk6CisgICAgICAgIChX ZWJDb3JlOjpDbG9zZUV2ZW50OjpDbG9zZUV2ZW50KToKKyAgICAgICAgKiB3ZWJzb2NrZXRzL1dl YlNvY2tldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJTb2NrZXQ6OmRpZENsb3NlKToKKwog MjAxMS0wOC0xNSAgSmVmZnJleSBQZmF1ICA8anBmYXVAYXBwbGUuY29tPgogCiAgICAgICAgIE5l dyBYTUwgcGFyc2VyOiBhZGQgeG1sIG5hbWVzcGFjZSB0byB0aGUgZGVmYXVsdCBtYXAgb2YgbmFt ZXNwYWNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9DbG9zZUV2ZW50 LmggYi9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL0Nsb3NlRXZlbnQuaAppbmRleCBmZWIzYjZl MGQ0NGY3Yjc5NGFhM2Q1ZWNlNDhlZGJjNzY1NjZlYjg0Li5hMDc5MDAzM2Y0Y2M3MzAwYThkYjNj YTdlNmY3YjRkNTA2NjYzODQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRz L0Nsb3NlRXZlbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL0Nsb3NlRXZlbnQu aApAQCAtNDAsOSArNDAsOSBAQCBjbGFzcyBDbG9zZUV2ZW50IDogcHVibGljIEV2ZW50IHsKIHB1 YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgaXNDbG9zZUV2ZW50KCkgY29uc3QgeyByZXR1cm4gdHJ1 ZTsgfQogCi0gICAgc3RhdGljIFBhc3NSZWZQdHI8Q2xvc2VFdmVudD4gY3JlYXRlKGJvb2wgd2Fz Q2xlYW4pCisgICAgc3RhdGljIFBhc3NSZWZQdHI8Q2xvc2VFdmVudD4gY3JlYXRlKCkKICAgICB7 Ci0gICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgQ2xvc2VFdmVudCh3YXNDbGVhbikpOworICAg ICAgICByZXR1cm4gYWRvcHRSZWYobmV3IENsb3NlRXZlbnQoKSk7CiAgICAgfQogCiAgICAgdm9p ZCBpbml0Q2xvc2VFdmVudChjb25zdCBBdG9taWNTdHJpbmcmIHR5cGUsIGJvb2wgY2FuQnViYmxl LCBib29sIGNhbmNlbGFibGUsIGJvb2wgd2FzQ2xlYW4pCkBAIC01OCw5ICs1OCw5IEBAIHB1Ymxp YzoKICAgICBib29sIHdhc0NsZWFuKCkgY29uc3QgeyByZXR1cm4gbV93YXNDbGVhbjsgfQogCiBw cml2YXRlOgotICAgIENsb3NlRXZlbnQoYm9vbCB3YXNDbGVhbikKKyAgICBDbG9zZUV2ZW50KCkK ICAgICAgICAgOiBFdmVudChldmVudE5hbWVzKCkuY2xvc2VFdmVudCwgZmFsc2UsIGZhbHNlKQot ICAgICAgICAsIG1fd2FzQ2xlYW4od2FzQ2xlYW4pCisgICAgICAgICwgbV93YXNDbGVhbihmYWxz ZSkKICAgICB7IH0KIAogICAgIGJvb2wgbV93YXNDbGVhbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tl dHMvV2ViU29ja2V0LmNwcAppbmRleCA1NmIyY2UzMzliOWJkYWExMDQzMWZjMDA1M2E1MDBiZTUw Mjk4MTk4Li4xYjAxMzNlOTdkYjVkY2RjMjk4OWQ3MmFhNmY2MDZkOGVmNWQ5NTAzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXQuY3BwCkBAIC00MjIsNyArNDIyLDcgQEAgdm9p ZCBXZWJTb2NrZXQ6OmRpZENsb3NlKHVuc2lnbmVkIGxvbmcgdW5oYW5kbGVkQnVmZmVyZWRBbW91 bnQsIENsb3NpbmdIYW5kc2hha2UKICAgICBtX3N0YXRlID0gQ0xPU0VEOwogICAgIG1fYnVmZmVy ZWRBbW91bnRBZnRlckNsb3NlICs9IHVuaGFuZGxlZEJ1ZmZlcmVkQW1vdW50OwogICAgIEFTU0VS VChzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpOwotICAgIFJlZlB0cjxDbG9zZUV2ZW50PiBldmVu dCA9IENsb3NlRXZlbnQ6OmNyZWF0ZShmYWxzZSk7CisgICAgUmVmUHRyPENsb3NlRXZlbnQ+IGV2 ZW50ID0gQ2xvc2VFdmVudDo6Y3JlYXRlKCk7CiAgICAgZXZlbnQtPmluaXRDbG9zZUV2ZW50KGV2 ZW50TmFtZXMoKS5jbG9zZUV2ZW50LCBmYWxzZSwgZmFsc2UsIHdhc0NsZWFuKTsKICAgICBkaXNw YXRjaEV2ZW50KGV2ZW50KTsKICAgICBpZiAobV9jaGFubmVsKSB7Cg== 104163 2011-08-17 02:50:45 -0700 2011-08-18 01:02:55 -0700 Patch bug-66294-20110817185044.patch text/plain 2723 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogOTMwODEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MGU4ZmM1MzEzOThiMmNk YjZjMDk4YmY5NjBhYTczNzlhODhiYmVhLi5hODczYjE4OGQ2ZjE1YWRlNzAwNjE4YjY0MjczYTEz ZWQ2MDUwMDBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDgtMTYgIFRha2Fz aGkgVG95b3NoaW1hICA8dG95b3NoaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBh cmd1bWVudHMgZnJvbSBDbG9zZUV2ZW50OjpjcmVhdGUoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2Mjk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xvc2VFdmVudCBvYmplY3RzIGFyZSBpbml0aWFs aXplZCBieSBpbml0Q2xvc2VFdmVudCgpIGluIGFsbCBjYXNlcy4KKyAgICAgICAgSW5pdGlhbGl6 YXRpb24gaW4gY3JlYXRlKCkgaXMgcmVkdW5kYW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBm b3Igbm8gZnVuY3Rpb25hbCBkaWZmZXJlbmNlLgorCisgICAgICAgICogd2Vic29ja2V0cy9DbG9z ZUV2ZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpDbG9zZUV2ZW50OjpjcmVhdGUpOgorICAgICAg ICAoV2ViQ29yZTo6Q2xvc2VFdmVudDo6Q2xvc2VFdmVudCk6CisgICAgICAgICogd2Vic29ja2V0 cy9XZWJTb2NrZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViU29ja2V0OjpkaWRDbG9zZSk6 CisKIDIwMTEtMDgtMTUgIEplZmZyZXkgUGZhdSAgPGpwZmF1QGFwcGxlLmNvbT4KIAogICAgICAg ICBOZXcgWE1MIHBhcnNlcjogYWRkIHhtbCBuYW1lc3BhY2UgdG8gdGhlIGRlZmF1bHQgbWFwIG9m IG5hbWVzcGFjZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvQ2xvc2VF dmVudC5oIGIvU291cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9DbG9zZUV2ZW50LmgKaW5kZXggZmVi M2I2ZTBkNDRmN2I3OTRhYTNkNWVjZTQ4ZWRiYzc2NTY2ZWI4NC4uYTA3OTAwMzNmNGNjNzMwMGE4 ZGIzY2E3ZTZmN2I0ZDUwNjY2Mzg0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd2Vic29j a2V0cy9DbG9zZUV2ZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9DbG9zZUV2 ZW50LmgKQEAgLTQwLDkgKzQwLDkgQEAgY2xhc3MgQ2xvc2VFdmVudCA6IHB1YmxpYyBFdmVudCB7 CiBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIGlzQ2xvc2VFdmVudCgpIGNvbnN0IHsgcmV0dXJu IHRydWU7IH0KIAotICAgIHN0YXRpYyBQYXNzUmVmUHRyPENsb3NlRXZlbnQ+IGNyZWF0ZShib29s IHdhc0NsZWFuKQorICAgIHN0YXRpYyBQYXNzUmVmUHRyPENsb3NlRXZlbnQ+IGNyZWF0ZSgpCiAg ICAgewotICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IENsb3NlRXZlbnQod2FzQ2xlYW4pKTsK KyAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBDbG9zZUV2ZW50KCkpOwogICAgIH0KIAogICAg IHZvaWQgaW5pdENsb3NlRXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiB0eXBlLCBib29sIGNhbkJ1 YmJsZSwgYm9vbCBjYW5jZWxhYmxlLCBib29sIHdhc0NsZWFuKQpAQCAtNTgsOSArNTgsOSBAQCBw dWJsaWM6CiAgICAgYm9vbCB3YXNDbGVhbigpIGNvbnN0IHsgcmV0dXJuIG1fd2FzQ2xlYW47IH0K IAogcHJpdmF0ZToKLSAgICBDbG9zZUV2ZW50KGJvb2wgd2FzQ2xlYW4pCisgICAgQ2xvc2VFdmVu dCgpCiAgICAgICAgIDogRXZlbnQoZXZlbnROYW1lcygpLmNsb3NlRXZlbnQsIGZhbHNlLCBmYWxz ZSkKLSAgICAgICAgLCBtX3dhc0NsZWFuKHdhc0NsZWFuKQorICAgICAgICAsIG1fd2FzQ2xlYW4o ZmFsc2UpCiAgICAgeyB9CiAKICAgICBib29sIG1fd2FzQ2xlYW47CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS93ZWJz b2NrZXRzL1dlYlNvY2tldC5jcHAKaW5kZXggNTZiMmNlMzM5YjliZGFhMTA0MzFmYzAwNTNhNTAw YmU1MDI5ODE5OC4uMWIwMTMzZTk3ZGI1ZGNkYzI5ODlkNzJhYTZmNjA2ZDhlZjVkOTUwMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0LmNwcApAQCAtNDIyLDcgKzQyMiw3IEBA IHZvaWQgV2ViU29ja2V0OjpkaWRDbG9zZSh1bnNpZ25lZCBsb25nIHVuaGFuZGxlZEJ1ZmZlcmVk QW1vdW50LCBDbG9zaW5nSGFuZHNoYWtlCiAgICAgbV9zdGF0ZSA9IENMT1NFRDsKICAgICBtX2J1 ZmZlcmVkQW1vdW50QWZ0ZXJDbG9zZSArPSB1bmhhbmRsZWRCdWZmZXJlZEFtb3VudDsKICAgICBB U1NFUlQoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKTsKLSAgICBSZWZQdHI8Q2xvc2VFdmVudD4g ZXZlbnQgPSBDbG9zZUV2ZW50OjpjcmVhdGUoZmFsc2UpOworICAgIFJlZlB0cjxDbG9zZUV2ZW50 PiBldmVudCA9IENsb3NlRXZlbnQ6OmNyZWF0ZSgpOwogICAgIGV2ZW50LT5pbml0Q2xvc2VFdmVu dChldmVudE5hbWVzKCkuY2xvc2VFdmVudCwgZmFsc2UsIGZhbHNlLCB3YXNDbGVhbik7CiAgICAg ZGlzcGF0Y2hFdmVudChldmVudCk7CiAgICAgaWYgKG1fY2hhbm5lbCkgewo=