66276 2011-08-15 22:01:50 -0700 "new WebKitCSSMatrix()" should generate a default matrix when undefined, null or an empty string is passed 2011-10-12 01:34:01 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED DUPLICATE 67458 P2 Normal --- 0 haraken webkit-unassigned abarth ap cmarrin dominicc oldest_to_newest 451490 0 haraken 2011-08-15 22:01:50 -0700 A Web IDL Constructor extended attribute should be implemented in V8 (bug 65839). We are going to split the patch for bug 65839 into the following eleven steps in order to avoid regressions. This patch is for [3]. Spec: http://www.w3.org/TR/css3-3d-transforms/ (Look at the setMatrixValue section) [1] "new EventSource()" should throw SYNTAX_ERR when an invalid argument is passed. [2] "new SharedWorker()" should throw SYNTAX_ERR when an invalid argument is passed. [3] "new WebKitCSSMatrix()" should throw SYNTAX_ERR when an invalid argument is passed. [4] "new Worker()" should throw SYNTAX_ERR when an invalid argument is passed. [5] Implement the Web IDL Constructor extended attribute in IDLParser.pm and CodeGeneratorV8.pm. [6] Replace the EventSource constructor in V8 with the Web IDL Constructor extended attribute. [7] Replace the FileReader constructor in V8 with the Web IDL Constructor extended attribute. [8] Replace the SharedWorker constructor in V8 with the Web IDL Constructor extended attribute. [9] Replace the WebKitCSSMatrix constructor in V8 with the Web IDL Constructor extended attribute. [10] Replace the Worker constructor in V8 with the Web IDL Constructor extended attribute. [11] Replace the XSLTProcessor constructor in V8 with the Web IDL Constructor extended attribute. Dependencies: [6][7][8][9][10][11] depends on [1][2][3][4][5]. We can land [1][2][3][4][5] concurrently, and then can land [6][7][8][9][10][11] concurrently. 451551 1 104024 haraken 2011-08-16 04:34:34 -0700 Created attachment 104024 Patch 451755 2 ap 2011-08-16 11:14:25 -0700 Could you please explain why this change is correct in more detail? I suspect that it's not quite correct, for the same reason as in bug 66274. 452894 3 haraken 2011-08-18 00:56:06 -0700 (In reply to comment #2) > Could you please explain why this change is correct in more detail? I suspect that it's not quite correct, for the same reason as in bug 66274. I am sorry. I confirmed that this is not a bug and thus should not be fixed. 453070 4 104024 ap 2011-08-18 08:46:14 -0700 Comment on attachment 104024 Patch Marking r- per the above discussion. 482294 5 haraken 2011-10-12 01:34:01 -0700 *** This bug has been marked as a duplicate of bug 67458 *** 104024 2011-08-16 04:34:34 -0700 2011-08-18 08:46:14 -0700 Patch bug-66276-20110816203432.patch text/plain 6487 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTMwODgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2YmQzYWExMjgyNmJlZDI4ZjhiOGUx MTQwZmY1MzZlMGZmMzlkOTUyLi4wZWJmOTIwY2I2MGU2YTIwYzhjZGI0MTFiZTJiZTQ0NDI5OWU2 MmM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMTYgIEtlbnRhcm8gSGFyYSAgPGhh cmFrZW5AZ29vZ2xlLmNvbT4KKworICAgICAgICAibmV3IFdlYktpdENTU01hdHJpeCgpIiBzaG91 bGQgZ2VuZXJhdGUgYSBkZWZhdWx0IG1hdHJpeC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY2Mjc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgIm5ldyBXZWJLaXRDU1NNYXRyaXgodmFsdWUpIiBzaG91bGQg Z2VuZXJhdGUgYSBkZWZhdWx0IG1hdHJpeCwgd2hlbiB2YWx1ZSBpcyB1bmRlZmluZWQsCisgICAg ICAgIG51bGwsIG9yIGFuIGVtcHR5IHN0cmluZy4KKworICAgICAgICAqIHRyYW5zZm9ybXMvY3Nz LW1hdHJpeC1jb25zdHJ1Y3Rvci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHRyYW5z Zm9ybXMvY3NzLW1hdHJpeC1jb25zdHJ1Y3Rvci5odG1sOiBBZGRlZC4KKwogMjAxMS0wOC0xNiAg Wm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdIE9zc3lp emUgZWRpdGluZy9kZWxldGluZy9yZWdpb25hbC1pbmRpY2F0b3JzLmh0bWwgc2luY2UgaXQgZmFp bHMgYWZ0ZXIgcjkzMDY4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy90cmFuc2Zvcm1zL2Nzcy1t YXRyaXgtY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvdHJhbnNmb3Jtcy9j c3MtbWF0cml4LWNvbnN0cnVjdG9yLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iOWJkMTdiYzc3 NjhkNWQyOGZjNzc0NGFhY2E4OGUyMzQ2ZGMyZjViCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvdHJhbnNmb3Jtcy9jc3MtbWF0cml4LWNvbnN0cnVjdG9yLWV4cGVjdGVkLnR4dApAQCAt MCwwICsxLDEwIEBACitUaGlzIHRlc3RzIHRoZSBkZWZhdWx0IG1hdHJpeCBnZW5lcmF0ZWQgYnkg dGhlIFdlYktpdENTU01hdHJpeCBjb25zdHJ1Y3Rvci4gVGhpcyB0ZXN0IGNhbm5vdCBydW4gaW50 ZXJhY3RpdmVseS4KKworUEFTUzogQSBkZWZhdWx0IG1hdHJpeCBpcyBnZW5lcmF0ZWQ6IG1hdHJp eCgxLjAwMDAwMCwgMC4wMDAwMDAsIDAuMDAwMDAwLCAxLjAwMDAwMCwgMC4wMDAwMDAsIDAuMDAw MDAwKQorUEFTUzogQSBkZWZhdWx0IG1hdHJpeCBpcyBnZW5lcmF0ZWQ6IG1hdHJpeCgxLjAwMDAw MCwgMC4wMDAwMDAsIDAuMDAwMDAwLCAxLjAwMDAwMCwgMC4wMDAwMDAsIDAuMDAwMDAwKQorUEFT UzogQSBkZWZhdWx0IG1hdHJpeCBpcyBnZW5lcmF0ZWQ6IG1hdHJpeCgxLjAwMDAwMCwgMC4wMDAw MDAsIDAuMDAwMDAwLCAxLjAwMDAwMCwgMC4wMDAwMDAsIDAuMDAwMDAwKQorUEFTUzogQSBkZWZh dWx0IG1hdHJpeCBpcyBnZW5lcmF0ZWQ6IG1hdHJpeCgxLjAwMDAwMCwgMC4wMDAwMDAsIDAuMDAw MDAwLCAxLjAwMDAwMCwgMC4wMDAwMDAsIDAuMDAwMDAwKQorUEFTUyBzdWNjZXNzZnVsbHlQYXJz ZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Ry YW5zZm9ybXMvY3NzLW1hdHJpeC1jb25zdHJ1Y3Rvci5odG1sIGIvTGF5b3V0VGVzdHMvdHJhbnNm b3Jtcy9jc3MtbWF0cml4LWNvbnN0cnVjdG9yLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMjQ3MWZiYWJlZDU5 MzIyZjVmNDdmYTZlODBiZDg5YzU5ZGYxZTFiYQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL3RyYW5zZm9ybXMvY3NzLW1hdHJpeC1jb25zdHJ1Y3Rvci5odG1sCkBAIC0wLDAgKzEsMzcg QEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9mYXN0 L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4K KzxkaXYgaWQ9ImNvbnNvbGUiPgorPHA+CitUaGlzIHRlc3RzIHRoZSBkZWZhdWx0IG1hdHJpeCBn ZW5lcmF0ZWQgYnkgdGhlIFdlYktpdENTU01hdHJpeCBjb25zdHJ1Y3Rvci4KK1RoaXMgdGVzdCBj YW5ub3QgcnVuIGludGVyYWN0aXZlbHkuCis8L3A+Cis8L2Rpdj4KKzxzY3JpcHQ+CitpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgdHJ5IHsKKyAgICAgICAgdmFyIG1hdHJp eCA9IG5ldyBXZWJLaXRDU1NNYXRyaXgoKTsKKyAgICAgICAgZGVidWcoIlBBU1M6IEEgZGVmYXVs dCBtYXRyaXggaXMgZ2VuZXJhdGVkOiAiICsgbWF0cml4KTsKKyAgICB9IGNhdGNoIChlYykgewor ICAgICAgICBkZWJ1ZygiRkFJTDogQSBkZWZhdWx0IG1hdHJpeCBzaG91bGQgYmUgZ2VuZXJhdGVk IGJ1dCBhbiBleGNlcHRpb24gaXMgdGhyb3duOiAiICsgZWMpOworICAgIH0KKworICAgIHZhciB0 ZXN0cyA9IFtudWxsLCB1bmRlZmluZWQsICIiXTsKKyAgICB0ZXN0cy5mb3JFYWNoKGZ1bmN0aW9u ICh0ZXN0KSB7CisgICAgICAgIHRyeSB7CisgICAgICAgICAgICB2YXIgbWF0cml4ID0gbmV3IFdl YktpdENTU01hdHJpeCh0ZXN0KTsKKyAgICAgICAgICAgIGRlYnVnKCJQQVNTOiBBIGRlZmF1bHQg bWF0cml4IGlzIGdlbmVyYXRlZDogIiArIG1hdHJpeCk7CisgICAgICAgIH0gY2F0Y2ggKGVjKSB7 CisgICAgICAgICAgICBkZWJ1ZygiRkFJTDogQSBkZWZhdWx0IG1hdHJpeCBzaG91bGQgYmUgZ2Vu ZXJhdGVkIGJ1dCBhbiBleGNlcHRpb24gaXMgdGhyb3duOiAiICsgZWMpOworICAgICAgICB9Cisg ICAgfSk7Cit9CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+Cis8 c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Njcmlw dD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjM2VkMzk1Y2JiNTM0NjUzNzE2ZmE4 ZWM5NjdlMWU3YzUwYzk5OWZlLi41Zjc3MzU3MzQwMmQ1NDYyYTdjMzVmNTQ0NzZlNGI3MTU2OTFj OGJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDgtMTYgIEtlbnRhcm8gSGFy YSAgPGhhcmFrZW5AZ29vZ2xlLmNvbT4KKworICAgICAgICAibmV3IFdlYktpdENTU01hdHJpeCgp IiBzaG91bGQgZ2VuZXJhdGUgYSBkZWZhdWx0IG1hdHJpeC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2Mjc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgIm5ldyBXZWJLaXRDU1NNYXRyaXgodmFsdWUpIiBz aG91bGQgZ2VuZXJhdGUgYSBkZWZhdWx0IG1hdHJpeCwgd2hlbiB2YWx1ZSBpcyB1bmRlZmluZWQs CisgICAgICAgIG51bGwsIG9yIGFuIGVtcHR5IHN0cmluZy4KKworICAgICAgICBUZXN0OiB0cmFu c2Zvcm1zL2Nzcy1tYXRyaXgtY29uc3RydWN0b3IuaHRtbAorCisgICAgICAgICogYmluZGluZ3Mv anMvSlNXZWJLaXRDU1NNYXRyaXhDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNXZWJL aXRDU1NNYXRyaXhDb25zdHJ1Y3Rvcjo6Y29uc3RydWN0SlNXZWJLaXRDU1NNYXRyaXgpOiBXZWJL aXRDU1NNYXRyaXg6OmNyZWF0ZSgpIGNhbGxzIFdlYktpdENTU01hdHJpeDo6c2V0TWF0cml4VmFs dWUoKSwgd2hpY2ggZ2VuZXJhdGVzIGEgZGVmYXVsdCBtYXRyaXguCisgICAgICAgICogYmluZGlu Z3MvdjgvY3VzdG9tL1Y4V2ViS2l0Q1NTTWF0cml4Q29uc3RydWN0b3IuY3BwOgorICAgICAgICAo V2ViQ29yZTo6VjhXZWJLaXRDU1NNYXRyaXg6OmNvbnN0cnVjdG9yQ2FsbGJhY2spOiBXZWJLaXRD U1NNYXRyaXg6OmNyZWF0ZSgpIGNhbGxzIFdlYktpdENTU01hdHJpeDo6c2V0TWF0cml4VmFsdWUo KSwgd2hpY2ggZ2VuZXJhdGVzIGEgZGVmYXVsdCBtYXRyaXguCisKIDIwMTEtMDgtMTUgIE1PUklU QSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyNzA1 OTgpOiBbQ2hyb21pdW1dIFN0eWxlIGNoYW5nZXMgaW4gdGV4dElucHV0IGV2ZW50IGNhbiBwcmV2 ZW50IGZyb20gdXBkYXRpbmcgPHRleHRhcmVhPiB2YWx1ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTV2ViS2l0Q1NTTWF0cml4Q3VzdG9tLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTV2ViS2l0Q1NTTWF0cml4Q3VzdG9tLmNwcAppbmRleCAwY2Zk ZGEzODI2YWZiODk2MTQzOWQwMGI4NzlhNWQ0ZTg2Y2Y2Y2Q2Li5jZTg5MmZhNWZlNTQxZmQwMDU5 MDkzODE5MDNjMGU0NmJiNDZhZTcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU1dlYktpdENTU01hdHJpeEN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvSlNXZWJLaXRDU1NNYXRyaXhDdXN0b20uY3BwCkBAIC0zNSwxMiArMzUsMTYgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBKU1dlYktp dENTU01hdHJpeENvbnN0cnVjdG9yOjpjb25zdHJ1Y3RKU1dlYktpdENTU01hdHJpeChFeGVjU3Rh dGUqIGV4ZWMpCiB7CiAgICAgSlNXZWJLaXRDU1NNYXRyaXhDb25zdHJ1Y3RvcioganNDb25zdHJ1 Y3RvciA9IHN0YXRpY19jYXN0PEpTV2ViS2l0Q1NTTWF0cml4Q29uc3RydWN0b3IqPihleGVjLT5j YWxsZWUoKSk7Ci0gICAgU3RyaW5nIHM7Ci0gICAgaWYgKGV4ZWMtPmFyZ3VtZW50Q291bnQoKSA+ PSAxKQotICAgICAgICBzID0gdXN0cmluZ1RvU3RyaW5nKGV4ZWMtPmFyZ3VtZW50KDApLnRvU3Ry aW5nKGV4ZWMpKTsKLSAgICAKKworICAgIFVTdHJpbmcgY3NzVmFsdWU7CisgICAgaWYgKCFleGVj LT5hcmd1bWVudCgwKS5pc1VuZGVmaW5lZE9yTnVsbCgpKQorICAgICAgICBjc3NWYWx1ZSA9IGV4 ZWMtPmFyZ3VtZW50KDApLnRvU3RyaW5nKGV4ZWMpOworCisgICAgaWYgKGV4ZWMtPmhhZEV4Y2Vw dGlvbigpKQorICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKEpTVmFsdWUoKSk7CisKICAg ICBFeGNlcHRpb25Db2RlIGVjID0gMDsKLSAgICBSZWZQdHI8V2ViS2l0Q1NTTWF0cml4PiBtYXRy aXggPSBXZWJLaXRDU1NNYXRyaXg6OmNyZWF0ZShzLCBlYyk7CisgICAgUmVmUHRyPFdlYktpdENT U01hdHJpeD4gbWF0cml4ID0gV2ViS2l0Q1NTTWF0cml4OjpjcmVhdGUodXN0cmluZ1RvU3RyaW5n KGNzc1ZhbHVlKSwgZWMpOwogICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBlYyk7CiAgICAgcmV0 dXJuIEpTVmFsdWU6OmVuY29kZShDUkVBVEVfRE9NX1dSQVBQRVIoZXhlYywganNDb25zdHJ1Y3Rv ci0+Z2xvYmFsT2JqZWN0KCksIFdlYktpdENTU01hdHJpeCwgbWF0cml4LmdldCgpKSk7CiB9CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhXZWJLaXRDU1NN YXRyaXhDb25zdHJ1Y3Rvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20v VjhXZWJLaXRDU1NNYXRyaXhDb25zdHJ1Y3Rvci5jcHAKaW5kZXggYjk3ZDBlODg5ZWQyNWJjMGI2 MjQ3MmQ0YTEyYjMyNDJlMWIxMDJjYi4uNjU0NTE4NmQyOWQ2ZDNjMTdhNjJkMmMwYjIyNzI2MjAy MDU0NmVjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4 V2ViS2l0Q1NTTWF0cml4Q29uc3RydWN0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L2N1c3RvbS9WOFdlYktpdENTU01hdHJpeENvbnN0cnVjdG9yLmNwcApAQCAtNTQsNyAr NTQsNyBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhXZWJLaXRDU1NNYXRyaXg6OmNvbnN0cnVj dG9yQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cwogICAgIC8vIEZJWE1FOiBUaGUgbG9naWMg aGVyZSBpcyBhbG1vc3QgZXhhY3QgZHVwbGljYXRlIG9mIFY4Ojpjb25zdHJ1Y3RET01PYmplY3Qu CiAgICAgLy8gQ29uc2lkZXIgcmVmYWN0b3JpbmcgdG8gcmVkdWNlIGR1cGxpY2F0aW9uLgogICAg IFN0cmluZyBjc3NWYWx1ZTsKLSAgICBpZiAoYXJncy5MZW5ndGgoKSA+PSAxKQorICAgIGlmICgh aXNVbmRlZmluZWRPck51bGwoYXJnc1swXSkpCiAgICAgICAgIGNzc1ZhbHVlID0gdG9XZWJDb3Jl U3RyaW5nKGFyZ3NbMF0pOwogCiAgICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7Cg==