66275 2011-08-15 21:58:58 -0700 "new SharedWorker()" should throw SYNTAX_ERR when an invalid argument is passed 2011-08-23 11:29:23 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED DUPLICATE 66455 P2 Normal --- 0 haraken webkit-unassigned abarth ap dominicc oldest_to_newest 451489 0 haraken 2011-08-15 21:58:58 -0700 A Web IDL Constructor extended attribute should be implemented in V8 (bug 65839). We are going to split the patch for bug 65839 into the following eleven steps in order to avoid regressions. This patch is for [2]. Spec: http://dev.w3.org/html5/workers/#dom-sharedworker [1] "new EventSource()" should throw SYNTAX_ERR when an invalid argument is passed. [2] "new SharedWorker()" should throw SYNTAX_ERR when an invalid argument is passed. [3] "new WebKitCSSMatrix()" should throw SYNTAX_ERR when an invalid argument is passed. [4] "new Worker()" should throw SYNTAX_ERR when an invalid argument is passed. [5] Implement the Web IDL Constructor extended attribute in IDLParser.pm and CodeGeneratorV8.pm. [6] Replace the EventSource constructor in V8 with the Web IDL Constructor extended attribute. [7] Replace the FileReader constructor in V8 with the Web IDL Constructor extended attribute. [8] Replace the SharedWorker constructor in V8 with the Web IDL Constructor extended attribute. [9] Replace the WebKitCSSMatrix constructor in V8 with the Web IDL Constructor extended attribute. [10] Replace the Worker constructor in V8 with the Web IDL Constructor extended attribute. [11] Replace the XSLTProcessor constructor in V8 with the Web IDL Constructor extended attribute. Dependencies: [6][7][8][9][10][11] depends on [1][2][3][4][5]. We can land [1][2][3][4][5] concurrently, and then can land [6][7][8][9][10][11] concurrently. 451522 1 104013 haraken 2011-08-16 01:16:08 -0700 Created attachment 104013 Patch 451754 2 104013 abarth 2011-08-16 11:11:31 -0700 Comment on attachment 104013 Patch This patch does not appear correct, see: http://www.w3.org/TR/WebIDL/#es-DOMString In the null-or-undefined case, we hit step 3, which gives use "null" or "undefined", which is a valid relative URL. Therefore, we shouldn't throw a SYNTAX_ERROR in that case. 452893 3 haraken 2011-08-18 00:55:21 -0700 (In reply to comment #2) > (From update of attachment 104013 [details]) > This patch does not appear correct, see: > > http://www.w3.org/TR/WebIDL/#es-DOMString > > In the null-or-undefined case, we hit step 3, which gives use "null" or "undefined", which is a valid relative URL. Therefore, we shouldn't throw a SYNTAX_ERROR in that case. Thank you for the information. I confirmed that this is not a bug and thus should not be fixed. 455542 4 ap 2011-08-23 11:29:23 -0700 You could also repurpose this bug instead filing a new one. Duping to preserve context. *** This bug has been marked as a duplicate of bug 66455 *** 104013 2011-08-16 01:16:08 -0700 2011-08-16 11:11:31 -0700 Patch bug-66275-20110816171606.patch text/plain 10858 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTMwODEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxNzlhNjBkYjk2YzY1YzM2YjNkZGM3 NmQzNzEzYzAxZDVhOWUyOWI3Li4zYjA1ZWU4OTZkMWMxYzliZjE0YmU4N2RmNTE2OGQ5YTQ2NDA3 YjU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMTYgIEtlbnRhcm8gSGFyYSAgPGhh cmFrZW5AZ29vZ2xlLmNvbT4KKworICAgICAgICAibmV3IFNoYXJlZFdvcmtlcigpIiBzaG91bGQg dGhyb3cgU1lOVEFYX0VSUiB3aGVuIGFuIGludmFsaWQgYXJndW1lbnQgaXMgcGFzc2VkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjI3NQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICJuZXcgU2hhcmVkV29y a2VyKHVybCkiIHNob3VsZCB0aHJvdyBTWU5UQVhfRVJSLCB3aGVuIHVybCBpcyB1bmRlZmluZWQs IG51bGwsCisgICAgICAgIGFuIGVtcHR5IHN0cmluZywgb3IgYW4gaW52YWxpZCBVUkwuIFJlZmFj dG9yZWQgc2hhcmVkLXdvcmtlci1jb25zdHJ1Y3Rvci5odG1sLgorCisgICAgICAgICogZmFzdC93 b3JrZXJzL3NoYXJlZC13b3JrZXItY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0OgorICAgICAgICAq IGZhc3Qvd29ya2Vycy9zaGFyZWQtd29ya2VyLWNvbnN0cnVjdG9yLmh0bWw6CisKIDIwMTEtMDgt MTUgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjI2MwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3NoYXJlZC13b3JrZXItY29uc3RydWN0b3ItZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3NoYXJlZC13b3JrZXItY29uc3Ry dWN0b3ItZXhwZWN0ZWQudHh0CmluZGV4IDlmMGMwOTBjNzZmZjIzYWJiZGI3YjYwOGU5MmYxOTg5 MDE2ZTg1MWMuLmFhYjUwNDE2MjA4MGQ0ZGRjZjhmMDQ1ZGJmOWQ2YjdjYzU0NzMyNDkgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9zaGFyZWQtd29ya2VyLWNvbnN0cnVjdG9y LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvc2hhcmVkLXdvcmtl ci1jb25zdHJ1Y3Rvci1leHBlY3RlZC50eHQKQEAgLTEsOSArMSwxNCBAQAotVGVzdCBTaGFyZWRX b3JrZXIgY29uc3RydWN0b3IgZnVuY3Rpb25hbGl0eS4gU2hvdWxkIHByaW50IGEgc2VyaWVzIG9m IFBBU1MgbWVzc2FnZXMsIGZvbGxvd2VkIHdpdGggRE9ORS4KK1RoaXMgdGVzdHMgdGhlIGJlaGF2 aW9yIG9mIHRoZSBTaGFyZWRXb3JrZXIgY29uc3RydWN0b3IuIFRoaXMgdGVzdCBjYW5ub3QgcnVu IGludGVyYWN0aXZlbHkuCiAKLVBBU1M6IHRvU3RyaW5nIGV4Y2VwdGlvbiBwcm9wYWdhdGVkIGNv cnJlY3RseS4KLVBBU1M6IHRyeWluZyB0byBjcmVhdGUgd29ya2VycyByZWN1cnNpdmVseSByZXN1 bHRlZCBpbiBhbiBleGNlcHRpb24gKFJhbmdlRXJyb3I6IE1heGltdW0gY2FsbCBzdGFjayBzaXpl IGV4Y2VlZGVkLikKLVBBU1M6IGludm9raW5nIFNoYXJlZFdvcmtlciBjb25zdHJ1Y3RvciB3aXRo b3V0IGFyZ3VtZW50cyByZXN1bHRlZCBpbiBhbiBleGNlcHRpb24gKFN5bnRheEVycm9yOiBOb3Qg ZW5vdWdoIGFyZ3VtZW50cykKLVBBU1M6IGludm9raW5nIFNoYXJlZFdvcmtlciBjb25zdHJ1Y3Rv ciB3aXRob3V0IG5hbWUgZGlkIG5vdCByZXN1bHQgaW4gYW4gZXhjZXB0aW9uCi1QQVNTOiBTaGFy ZWRXb3JrZXIgY29uc3RydWN0b3Igc3VjY2VlZGVkOiBbb2JqZWN0IFNoYXJlZFdvcmtlcl0KLURP TkUKK1BBU1M6IEVycm9yOiBTWU5UQVhfRVJSOiBET00gRXhjZXB0aW9uIDEyCitQQVNTOiBFcnJv cjogU1lOVEFYX0VSUjogRE9NIEV4Y2VwdGlvbiAxMgorUEFTUzogRXJyb3I6IFNZTlRBWF9FUlI6 IERPTSBFeGNlcHRpb24gMTIKK1BBU1M6IEVycm9yOiBTWU5UQVhfRVJSOiBET00gRXhjZXB0aW9u IDEyCitQQVNTOiBUcnlpbmcgdG8gY3JlYXRlIHdvcmtlcnMgcmVjdXJzaXZlbHkgcmVzdWx0ZWQg aW4gYW4gZXhjZXB0aW9uIChSYW5nZUVycm9yOiBNYXhpbXVtIGNhbGwgc3RhY2sgc2l6ZSBleGNl ZWRlZC4pCitQQVNTOiB0b1N0cmluZyAnZXhjZXB0aW9uJyBwcm9wYWdhdGVkIGNvcnJlY3RseS4K K1BBU1M6IEludm9raW5nIFNoYXJlZFdvcmtlciBjb25zdHJ1Y3RvciB3aXRob3V0IG5hbWUgZGlk IG5vdCByZXN1bHQgaW4gYW4gZXhjZXB0aW9uCitQQVNTOiBJbnZva2luZyBTaGFyZWRXb3JrZXIg Y29uc3RydWN0b3Igd2l0aCBuYW1lIGRpZCBub3QgcmVzdWx0IGluIGFuIGV4Y2VwdGlvbgorUEFT UyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCiAKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9zaGFyZWQtd29ya2VyLWNvbnN0cnVjdG9yLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvc2hhcmVkLXdvcmtlci1jb25zdHJ1Y3Rvci5o dG1sCmluZGV4IDcxNjBjYmExOWVkZWQ5OWJhNmRhMjZmMmQyZTcxZThmZTVlNWNjMzAuLjU0ODg4 ODY0YzFkNmUxMGYzZDUyMjhhNjJlNTY1M2YzYmRjYzJkNGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2Zhc3Qvd29ya2Vycy9zaGFyZWQtd29ya2VyLWNvbnN0cnVjdG9yLmh0bWwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC93b3JrZXJzL3NoYXJlZC13b3JrZXItY29uc3RydWN0b3IuaHRtbApAQCAt MSw1OSArMSw2OSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBz cmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+CiA8 Ym9keT4KLTxwPlRlc3QgU2hhcmVkV29ya2VyIGNvbnN0cnVjdG9yIGZ1bmN0aW9uYWxpdHkuIFNo b3VsZCBwcmludCBhIHNlcmllcyBvZiBQQVNTIG1lc3NhZ2VzLCBmb2xsb3dlZCB3aXRoIERPTkUu PC9wPgotPGRpdiBpZD1yZXN1bHQ+PC9kaXY+Cis8ZGl2IGlkPSJjb25zb2xlIj4KKzxwPgorVGhp cyB0ZXN0cyB0aGUgYmVoYXZpb3Igb2YgdGhlIFNoYXJlZFdvcmtlciBjb25zdHJ1Y3Rvci4KK1Ro aXMgdGVzdCBjYW5ub3QgcnVuIGludGVyYWN0aXZlbHkuCis8L3A+Cis8L2Rpdj4KIDxzY3JpcHQ+ Ci1mdW5jdGlvbiBsb2cobWVzc2FnZSkKLXsKLSAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi cmVzdWx0IikuaW5uZXJIVE1MICs9IG1lc3NhZ2UgKyAiPGJyPiI7Ci19Ci0KIGlmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKLSAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNU ZXh0KCk7Ci0gICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwotfQorICAg IHRyeSB7CisgICAgICAgIG5ldyBTaGFyZWRXb3JrZXIoKTsKKyAgICAgICAgZGVidWcoIkZBSUw6 IFNZTlRBWF9FUlIgc2hvdWxkIGJlIHRocm93bi4iKTsKKyAgICB9IGNhdGNoIChlYykgeworICAg ICAgICBkZWJ1ZygiUEFTUzogIiArIGVjKTsKKyAgICB9CiAKLXRyeSB7Ci0gICAgbmV3IFNoYXJl ZFdvcmtlcih7dG9TdHJpbmc6ZnVuY3Rpb24oKXt0aHJvdyAiZXhjZXB0aW9uIn19LCAibmFtZSIp Ci0gICAgbG9nKCJGQUlMOiB0b1N0cmluZyBleGNlcHRpb24gbm90IHByb3BhZ2F0ZWQuIik7Ci19 IGNhdGNoIChleCkgewotICAgIGlmIChleCA9PSAiZXhjZXB0aW9uIikKLSAgICAgICAgbG9nKCJQ QVNTOiB0b1N0cmluZyBleGNlcHRpb24gcHJvcGFnYXRlZCBjb3JyZWN0bHkuIik7Ci0gICAgZWxz ZQotICAgICAgICBsb2coIkZBSUw6IHVuZXhwZWN0ZWQgZXhjZXB0aW9uICgiICsgZXggKyAiKSBy ZWNlaXZlZCBpbnN0ZWFkIG9mIG9uZSBwcm9wYWdhdGVkIGZyb20gdG9TdHJpbmcuIik7Ci19Cisg ICAgdmFyIHRlc3RzID0gW251bGwsIHVuZGVmaW5lZCwgIiJdOworICAgIHRlc3RzLmZvckVhY2go ZnVuY3Rpb24gKHRlc3QpIHsKKyAgICAgICAgdHJ5IHsKKyAgICAgICAgICAgIG5ldyBTaGFyZWRX b3JrZXIodGVzdCk7CisgICAgICAgICAgICBkZWJ1ZygiRkFJTDogU1lOVEFYX0VSUiBzaG91bGQg YmUgdGhyb3duLiIpOworICAgICAgICB9IGNhdGNoIChlYykgeworICAgICAgICAgICAgZGVidWco IlBBU1M6ICIgKyBlYyk7CisgICAgICAgIH0KKyAgICB9KTsKIAotdHJ5IHsKLSAgICB2YXIgZm9v ID0ge3RvU3RyaW5nOmZ1bmN0aW9uKCl7bmV3IFdvcmtlcihmb28pfX0KLSAgICBuZXcgU2hhcmVk V29ya2VyKGZvbywgbmFtZSk7Ci0gICAgbG9nKCJGQUlMOiBubyBleGNlcHRpb24gd2hlbiB0cnlp bmcgdG8gY3JlYXRlIHdvcmtlcnMgcmVjdXJzaXZlbHkiKTsKLX0gY2F0Y2ggKGV4KSB7Ci0gICAg bG9nKCJQQVNTOiB0cnlpbmcgdG8gY3JlYXRlIHdvcmtlcnMgcmVjdXJzaXZlbHkgcmVzdWx0ZWQg aW4gYW4gZXhjZXB0aW9uICgiICsgZXggKyAiKSIpOwotfQorICAgIHRyeSB7CisgICAgICAgIHZh ciBmb28gPSB7dG9TdHJpbmc6IGZ1bmN0aW9uKCkgeyBuZXcgV29ya2VyKGZvbykgfX07CisgICAg ICAgIG5ldyBTaGFyZWRXb3JrZXIoZm9vLCAibmFtZSIpOworICAgICAgICBkZWJ1ZygiRkFJTDog Tm8gZXhjZXB0aW9uIHdoZW4gdHJ5aW5nIHRvIGNyZWF0ZSB3b3JrZXJzIHJlY3Vyc2l2ZWx5Iik7 CisgICAgfSBjYXRjaCAoZWMpIHsKKyAgICAgICAgZGVidWcoIlBBU1M6IFRyeWluZyB0byBjcmVh dGUgd29ya2VycyByZWN1cnNpdmVseSByZXN1bHRlZCBpbiBhbiBleGNlcHRpb24gKCIgKyBlYyAr ICIpIik7CisgICAgfQogCi10cnkgewotICAgIG5ldyBTaGFyZWRXb3JrZXIoKTsKLSAgICBsb2co IkZBSUw6IGludm9raW5nIFNoYXJlZFdvcmtlciBjb25zdHJ1Y3RvciB3aXRob3V0IGFyZ3VtZW50 cyBkaWQgbm90IHJlc3VsdCBpbiBhbiBleGNlcHRpb24iKTsKLX0gY2F0Y2ggKGV4KSB7Ci0gICAg bG9nKCJQQVNTOiBpbnZva2luZyBTaGFyZWRXb3JrZXIgY29uc3RydWN0b3Igd2l0aG91dCBhcmd1 bWVudHMgcmVzdWx0ZWQgaW4gYW4gZXhjZXB0aW9uICgiICsgZXggKyAiKSIpOwotfQorICAgIHRy eSB7CisgICAgICAgIG5ldyBTaGFyZWRXb3JrZXIoe3RvU3RyaW5nOiBmdW5jdGlvbigpIHsgdGhy b3cgImV4Y2VwdGlvbiJ9IH0sICJuYW1lIik7CisgICAgICAgIGRlYnVnKCJGQUlMOiAnZXhjZXB0 aW9uJyBzaG91bGQgYmUgdGhyb3duLiIpOworICAgIH0gY2F0Y2ggKGVjKSB7CisgICAgICAgIGlm IChlYyA9PSAiZXhjZXB0aW9uIikKKyAgICAgICAgICAgIGRlYnVnKCJQQVNTOiB0b1N0cmluZyAn ZXhjZXB0aW9uJyBwcm9wYWdhdGVkIGNvcnJlY3RseS4iKTsKKyAgICAgICAgZWxzZQorICAgICAg ICAgICAgZGVidWcoIkZBSUw6IHVuZXhwZWN0ZWQgZXhjZXB0aW9uICgiICsgZWMgKyAiKSByZWNl aXZlZCBpbnN0ZWFkIG9mIG9uZSBwcm9wYWdhdGVkIGZyb20gdG9TdHJpbmcuIik7CisgICAgfQog Ci10cnkgewotICAgIHZhciB3b3JrZXIgPSBuZXcgU2hhcmVkV29ya2VyKCJyZXNvdXJjZXMvc2hh cmVkLXdvcmtlci1jb21tb24uanMiKTsKLSAgICBsb2coIlBBU1M6IGludm9raW5nIFNoYXJlZFdv cmtlciBjb25zdHJ1Y3RvciB3aXRob3V0IG5hbWUgZGlkIG5vdCByZXN1bHQgaW4gYW4gZXhjZXB0 aW9uIik7Ci19IGNhdGNoIChleCkgewotICAgIGxvZygiRkFJTDogQ29uc3RydWN0b3IgZmFpbGVk IHdoZW4gbm8gbmFtZSBpcyBwYXNzZWQ6ICgiICsgZXggKyAiKSIpOwotfQorICAgIHRyeSB7Cisg ICAgICAgIG5ldyBTaGFyZWRXb3JrZXIoInJlc291cmNlcy9zaGFyZWQtd29ya2VyLWNvbW1vbi5q cyIpOworICAgICAgICBkZWJ1ZygiUEFTUzogSW52b2tpbmcgU2hhcmVkV29ya2VyIGNvbnN0cnVj dG9yIHdpdGhvdXQgbmFtZSBkaWQgbm90IHJlc3VsdCBpbiBhbiBleGNlcHRpb24iKTsKKyAgICB9 IGNhdGNoIChlYykgeworICAgICAgICBkZWJ1ZygiRkFJTDogQ29uc3RydWN0b3IgZmFpbGVkIHdo ZW4gbm8gbmFtZSBpcyBwYXNzZWQgKCIgKyBlYyArICIpIik7CisgICAgfQogCi10cnkgewotICAg IHZhciB3b3JrZXIgPSBuZXcgU2hhcmVkV29ya2VyKCJyZXNvdXJjZXMvc2hhcmVkLXdvcmtlci1j b21tb24uanMiLCAibmFtZSIpOwotICAgIGxvZyAoIlBBU1M6IFNoYXJlZFdvcmtlciBjb25zdHJ1 Y3RvciBzdWNjZWVkZWQ6ICIgKyB3b3JrZXIpOwotfSBjYXRjaCAoZXgpIHsKLSAgICBsb2coIkZB SUw6IGludm9raW5nIFNoYXJlZFdvcmtlciBjb25zdHJ1Y3RvciByZXN1bHRlZCBpbiBhbiBleGNl cHRpb24gKCIgKyBleCArICIpIik7CisgICAgdHJ5IHsKKyAgICAgICAgbmV3IFNoYXJlZFdvcmtl cigicmVzb3VyY2VzL3NoYXJlZC13b3JrZXItY29tbW9uLmpzIiwgIm5hbWUiKTsKKyAgICAgICAg ZGVidWcoIlBBU1M6IEludm9raW5nIFNoYXJlZFdvcmtlciBjb25zdHJ1Y3RvciB3aXRoIG5hbWUg ZGlkIG5vdCByZXN1bHQgaW4gYW4gZXhjZXB0aW9uIik7CisgICAgfSBjYXRjaCAoZWMpIHsKKyAg ICAgICAgZGVidWcoIkZBSUw6IENvbnN0cnVjdG9yIGZhaWxlZCB3aGVuIG5hbWUgaXMgcGFzc2Vk ICgiICsgZWMgKyAiKSIpOworICAgIH0KIH0KIAotbG9nKCJET05FIik7Ci1pZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQotICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUo KTsKLQordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7CiA8L3NjcmlwdD4KKzxzY3JpcHQg c3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KIDwvYm9keT4K KzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MGU4ZmM1MzEzOThiMmNkYjZjMDk4YmY5NjBhYTczNzlh ODhiYmVhLi40NWNjYmU2OTFiMDIyNTAxZTFkNjhlNzU0NmEzYzNkYzg4YzYzY2YxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDgtMTYgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5A Z29vZ2xlLmNvbT4KKworICAgICAgICAibmV3IFNoYXJlZFdvcmtlcigpIiBzaG91bGQgdGhyb3cg U1lOVEFYX0VSUiB3aGVuIGFuIGludmFsaWQgYXJndW1lbnQgaXMgcGFzc2VkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjI3NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICJuZXcgU2hhcmVkV29ya2VyKHVy bCkiIHNob3VsZCB0aHJvdyBTWU5UQVhfRVJSLCB3aGVuIHVybCBpcyB1bmRlZmluZWQsIG51bGws CisgICAgICAgIGFuIGVtcHR5IHN0cmluZywgb3IgYW4gaW52YWxpZCBVUkwuCisKKyAgICAgICAg VGVzdDogZmFzdC93b3JrZXJzL3NoYXJlZC13b3JrZXItY29uc3RydWN0b3IuaHRtbAorCisgICAg ICAgICogYmluZGluZ3MvanMvSlNTaGFyZWRXb3JrZXJDdXN0b20uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SlNTaGFyZWRXb3JrZXJDb25zdHJ1Y3Rvcjo6Y29uc3RydWN0SlNTaGFyZWRXb3JrZXIp OiBTaGFyZWRXb3JrZXI6OmNyZWF0ZSgpIHRocm93cyBTWU5UQVhfRVJSLgorICAgICAgICAqIGJp bmRpbmdzL3Y4L2N1c3RvbS9WOFNoYXJlZFdvcmtlckN1c3RvbS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpWOFNoYXJlZFdvcmtlcjo6Y29uc3RydWN0b3JDYWxsYmFjayk6IFNoYXJlZFdvcmtlcjo6 Y3JlYXRlKCkgdGhyb3dzIFNZTlRBWF9FUlIuCisKIDIwMTEtMDgtMTUgIEplZmZyZXkgUGZhdSAg PGpwZmF1QGFwcGxlLmNvbT4KIAogICAgICAgICBOZXcgWE1MIHBhcnNlcjogYWRkIHhtbCBuYW1l c3BhY2UgdG8gdGhlIGRlZmF1bHQgbWFwIG9mIG5hbWVzcGFjZXMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTU2hhcmVkV29ya2VyQ3VzdG9tLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTU2hhcmVkV29ya2VyQ3VzdG9tLmNwcAppbmRleCBkMmJiZjZj ZWM0ZDdmNGUxOGQ0MWI4YjQ2MGRiMWJmNmEyMTQ5Mzg3Li42NTVjZTdlYWFjNTdmYTkxMzZmN2Q5 ZDJjMjI4MmQwYzAyMmFhYmM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU1NoYXJlZFdvcmtlckN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNTaGFyZWRXb3JrZXJDdXN0b20uY3BwCkBAIC01OCwxMiArNTgsMTIgQEAgRW5jb2RlZEpT VmFsdWUgSlNDX0hPU1RfQ0FMTCBKU1NoYXJlZFdvcmtlckNvbnN0cnVjdG9yOjpjb25zdHJ1Y3RK U1NoYXJlZFdvcmtlcigKIHsKICAgICBKU1NoYXJlZFdvcmtlckNvbnN0cnVjdG9yKiBqc0NvbnN0 cnVjdG9yID0gc3RhdGljX2Nhc3Q8SlNTaGFyZWRXb3JrZXJDb25zdHJ1Y3Rvcio+KGV4ZWMtPmNh bGxlZSgpKTsKIAotICAgIGlmIChleGVjLT5hcmd1bWVudENvdW50KCkgPCAxKQotICAgICAgICBy ZXR1cm4gdGhyb3dWTUVycm9yKGV4ZWMsIGNyZWF0ZVN5bnRheEVycm9yKGV4ZWMsICJOb3QgZW5v dWdoIGFyZ3VtZW50cyIpKTsKKyAgICBVU3RyaW5nIHNjcmlwdFVSTDsKKyAgICBpZiAoIWV4ZWMt PmFyZ3VtZW50KDApLmlzVW5kZWZpbmVkT3JOdWxsKCkpCisgICAgICAgIHNjcmlwdFVSTCA9IGV4 ZWMtPmFyZ3VtZW50KDApLnRvU3RyaW5nKGV4ZWMpOwogCi0gICAgVVN0cmluZyBzY3JpcHRVUkwg PSBleGVjLT5hcmd1bWVudCgwKS50b1N0cmluZyhleGVjKTsKICAgICBVU3RyaW5nIG5hbWU7Ci0g ICAgaWYgKGV4ZWMtPmFyZ3VtZW50Q291bnQoKSA+IDEpCisgICAgaWYgKCFleGVjLT5hcmd1bWVu dCgxKS5pc1VuZGVmaW5lZE9yTnVsbCgpKQogICAgICAgICBuYW1lID0gZXhlYy0+YXJndW1lbnQo MSkudG9TdHJpbmcoZXhlYyk7CiAKICAgICBpZiAoZXhlYy0+aGFkRXhjZXB0aW9uKCkpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhTaGFyZWRXb3JrZXJD dXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4U2hhcmVkV29y a2VyQ3VzdG9tLmNwcAppbmRleCAyZDcyYzM3YjUwNGYwYzg5YmZhN2Q4OWNjYTk5MWE0ZGVhNjA4 ZjlmLi43MDNkNjFiN2FhZDMzMmY3ZjkzZjkyNWM0NzM2MmI1OWE0MWEwMmU3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhTaGFyZWRXb3JrZXJDdXN0b20u Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFNoYXJlZFdvcmtl ckN1c3RvbS5jcHAKQEAgLTUxLDIwICs1MSwxMyBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhT aGFyZWRXb3JrZXI6OmNvbnN0cnVjdG9yQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYQog ICAgIGlmICghYXJncy5Jc0NvbnN0cnVjdENhbGwoKSkKICAgICAgICAgcmV0dXJuIHRocm93RXJy b3IoIkRPTSBvYmplY3QgY29uc3RydWN0b3IgY2Fubm90IGJlIGNhbGxlZCBhcyBhIGZ1bmN0aW9u LiIpOwogCi0gICAgaWYgKCFhcmdzLkxlbmd0aCgpKQotICAgICAgICByZXR1cm4gdGhyb3dFcnJv cigiTm90IGVub3VnaCBhcmd1bWVudHMiLCBWOFByb3h5OjpTeW50YXhFcnJvcik7CisgICAgU3Ry aW5nIHNjcmlwdFVybDsKKyAgICBpZiAoIWlzVW5kZWZpbmVkT3JOdWxsKGFyZ3NbMF0pKQorICAg ICAgICBzY3JpcHRVcmwgPSB0b1dlYkNvcmVTdHJpbmcoYXJnc1swXSk7CiAKLSAgICB2ODo6VHJ5 Q2F0Y2ggdHJ5Q2F0Y2g7Ci0gICAgdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBzY3JpcHRVcmwgPSBh cmdzWzBdLT5Ub1N0cmluZygpOwogICAgIFN0cmluZyBuYW1lOwotICAgIGlmIChhcmdzLkxlbmd0 aCgpID4gMSkKLSAgICAgICAgbmFtZSA9IHRvV2ViQ29yZVN0cmluZyhhcmdzWzFdLT5Ub1N0cmlu ZygpKTsKLQotICAgIGlmICh0cnlDYXRjaC5IYXNDYXVnaHQoKSkKLSAgICAgICAgcmV0dXJuIHRo cm93RXJyb3IodHJ5Q2F0Y2guRXhjZXB0aW9uKCkpOwotCi0gICAgaWYgKHNjcmlwdFVybC5Jc0Vt cHR5KCkpCi0gICAgICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CisgICAgaWYgKCFpc1VuZGVm aW5lZE9yTnVsbChhcmdzWzFdKSkKKyAgICAgICAgbmFtZSA9IHRvV2ViQ29yZVN0cmluZyhhcmdz WzFdKTsKIAogICAgIC8vIEdldCB0aGUgc2NyaXB0IGV4ZWN1dGlvbiBjb250ZXh0LgogICAgIFNj cmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQgPSBnZXRTY3JpcHRFeGVjdXRpb25Db250ZXh0 KCk7CkBAIC03NCw3ICs2Nyw3IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOFNoYXJlZFdvcmtl cjo6Y29uc3RydWN0b3JDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhCiAgICAgLy8gQ3Jl YXRlIHRoZSBTaGFyZWRXb3JrZXIgb2JqZWN0LgogICAgIC8vIE5vdGU6IGl0J3MgT0sgdG8gbGV0 IHRoaXMgUmVmUHRyIGdvIG91dCBvZiBzY29wZSBiZWNhdXNlIHdlIGFsc28gY2FsbCBTZXRET01X cmFwcGVyKCksIHdoaWNoIGVmZmVjdGl2ZWx5IGhvbGRzIGEgcmVmZXJlbmNlIHRvIG9iai4KICAg ICBFeGNlcHRpb25Db2RlIGVjID0gMDsKLSAgICBSZWZQdHI8U2hhcmVkV29ya2VyPiBvYmogPSBT aGFyZWRXb3JrZXI6OmNyZWF0ZSh0b1dlYkNvcmVTdHJpbmcoc2NyaXB0VXJsKSwgbmFtZSwgY29u dGV4dCwgZWMpOworICAgIFJlZlB0cjxTaGFyZWRXb3JrZXI+IG9iaiA9IFNoYXJlZFdvcmtlcjo6 Y3JlYXRlKHNjcmlwdFVybCwgbmFtZSwgY29udGV4dCwgZWMpOwogICAgIGlmIChlYykKICAgICAg ICAgcmV0dXJuIHRocm93RXJyb3IoZWMpOwogCg==