66274 2011-08-15 21:56:25 -0700 "new EventSource()" should throw SYNTAX_ERR when an invalid argument is passed 2011-08-23 11:28:59 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED DUPLICATE 66454 P2 Normal --- 0 haraken webkit-unassigned abarth ap dominicc oldest_to_newest 451488 0 haraken 2011-08-15 21:56:25 -0700 A Web IDL Constructor extended attribute should be implemented in V8 (bug 65839). We are going to split the patch for bug 65839 into the following eleven steps in order to avoid regressions. This patch is for [1]. Spec: http://dev.w3.org/html5/eventsource/#the-eventsource-interface [1] "new EventSource()" should throw SYNTAX_ERR when an invalid argument is passed. [2] "new SharedWorker()" should throw SYNTAX_ERR when an invalid argument is passed. [3] "new WebKitCSSMatrix()" should throw SYNTAX_ERR when an invalid argument is passed. [4] "new Worker()" should throw SYNTAX_ERR when an invalid argument is passed. [5] Implement the Web IDL Constructor extended attribute in IDLParser.pm and CodeGeneratorV8.pm. [6] Replace the EventSource constructor in V8 with the Web IDL Constructor extended attribute. [7] Replace the FileReader constructor in V8 with the Web IDL Constructor extended attribute. [8] Replace the SharedWorker constructor in V8 with the Web IDL Constructor extended attribute. [9] Replace the WebKitCSSMatrix constructor in V8 with the Web IDL Constructor extended attribute. [10] Replace the Worker constructor in V8 with the Web IDL Constructor extended attribute. [11] Replace the XSLTProcessor constructor in V8 with the Web IDL Constructor extended attribute. Dependencies: [6][7][8][9][10][11] depends on [1][2][3][4][5]. We can land [1][2][3][4][5] concurrently, and then can land [6][7][8][9][10][11] concurrently. 451515 1 104011 haraken 2011-08-15 23:57:33 -0700 Created attachment 104011 Patch 451753 2 104011 abarth 2011-08-16 11:11:19 -0700 Comment on attachment 104011 Patch This patch does not appear correct, see: http://www.w3.org/TR/WebIDL/#es-DOMString In the null-or-undefined case, we hit step 3, which gives use "null" or "undefined", which is a valid relative URL. Therefore, we shouldn't throw a SYNTAX_ERROR in that case. 452032 3 104011 dominicc 2011-08-16 17:45:16 -0700 Comment on attachment 104011 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104011&action=review > LayoutTests/fast/eventsource/eventsource-constructor-exceptions-expected.txt:1 > +This tests an exception thrown by the EventSource constructor. This test cannot run interactively. Nit: Why can’t this run interactively? 452892 4 haraken 2011-08-18 00:54:58 -0700 (In reply to comment #2) > (From update of attachment 104011 [details]) > This patch does not appear correct, see: > > http://www.w3.org/TR/WebIDL/#es-DOMString > > In the null-or-undefined case, we hit step 3, which gives use "null" or "undefined", which is a valid relative URL. Therefore, we shouldn't throw a SYNTAX_ERROR in that case. Thank you for the information. I confirmed that this is not a bug and thus should not be fixed. 455538 5 ap 2011-08-23 11:28:59 -0700 You could also repurpose this bug instead filing a new one. Duping to preserve context. *** This bug has been marked as a duplicate of bug 66454 *** 104011 2011-08-15 23:57:33 -0700 2011-08-16 17:45:16 -0700 Patch bug-66274-20110816155732.patch text/plain 8822 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTMwODEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxNzlhNjBkYjk2YzY1YzM2YjNkZGM3 NmQzNzEzYzAxZDVhOWUyOWI3Li44OTA3ZmYwODU4ODQ3NGU5NmM1NTM0Mzg5MDhiNTRjNDNkMTM2 ZmM0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMTUgIEtlbnRhcm8gSGFyYSAgPGhh cmFrZW5AZ29vZ2xlLmNvbT4KKworICAgICAgICAibmV3IEV2ZW50U291cmNlKCkiIHNob3VsZCB0 aHJvdyBTWU5UQVhfRVJSIHdoZW4gYW4gaW52YWxpZCBhcmd1bWVudCBpcyBwYXNzZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2Mjc0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgIm5ldyBFdmVudFNvdXJj ZSh1cmwpIiBzaG91bGQgdGhyb3cgU1lOVEFYX0VSUiwgd2hlbiB1cmwgaXMgdW5kZWZpbmVkLCBu dWxsLAorICAgICAgICBhbiBlbXB0eSBzdHJpbmcsIG9yIGFuIGludmFsaWQgVVJMLgorCisgICAg ICAgICogZmFzdC9ldmVudHNvdXJjZS9ldmVudHNvdXJjZS1jb25zdHJ1Y3Rvci1leGNlcHRpb25z LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9ldmVudHNvdXJjZS9ldmVudHNv dXJjZS1jb25zdHJ1Y3Rvci1leGNlcHRpb25zLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv ZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0OiBSZW1vdmVk LgorICAgICAgICAqIGZhc3QvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtY29uc3RydWN0b3IuaHRt bDogUmVtb3ZlZC4KKwogMjAxMS0wOC0xNSAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3Vn aEBhcHBsZS5jb20+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTY2MjYzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50c291cmNlL2V2 ZW50c291cmNlLWNvbnN0cnVjdG9yLWV4Y2VwdGlvbnMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvZmFzdC9ldmVudHNvdXJjZS9ldmVudHNvdXJjZS1jb25zdHJ1Y3Rvci1leGNlcHRpb25zLWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mMDZiNzIyMWNlNDQ0OGEyMDAwZGY4Mzc3MDVmMDQ2Nzgy YmQ5ZWU5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHNvdXJjZS9l dmVudHNvdXJjZS1jb25zdHJ1Y3Rvci1leGNlcHRpb25zLWV4cGVjdGVkLnR4dApAQCAtMCwwICsx LDExIEBACitUaGlzIHRlc3RzIGFuIGV4Y2VwdGlvbiB0aHJvd24gYnkgdGhlIEV2ZW50U291cmNl IGNvbnN0cnVjdG9yLiBUaGlzIHRlc3QgY2Fubm90IHJ1biBpbnRlcmFjdGl2ZWx5LgorCitQQVNT OiBFcnJvcjogU1lOVEFYX0VSUjogRE9NIEV4Y2VwdGlvbiAxMgorUEFTUzogRXJyb3I6IFNZTlRB WF9FUlI6IERPTSBFeGNlcHRpb24gMTIKK1BBU1M6IEVycm9yOiBTWU5UQVhfRVJSOiBET00gRXhj ZXB0aW9uIDEyCitQQVNTOiBFcnJvcjogU1lOVEFYX0VSUjogRE9NIEV4Y2VwdGlvbiAxMgorUEFT UzogRXJyb3I6IFNZTlRBWF9FUlI6IERPTSBFeGNlcHRpb24gMTIKK1BBU1Mgc3VjY2Vzc2Z1bGx5 UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9mYXN0L2V2ZW50c291cmNlL2V2ZW50c291cmNlLWNvbnN0cnVjdG9yLWV4Y2VwdGlvbnMuaHRt bCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtY29uc3RydWN0b3It ZXhjZXB0aW9ucy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjVlN2Q4MjQ3YWZmNGE2Y2JjMWYyMTk1NThiZjFm YWFkNWY5YjBmOTUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50c291 cmNlL2V2ZW50c291cmNlLWNvbnN0cnVjdG9yLWV4Y2VwdGlvbnMuaHRtbApAQCAtMCwwICsxLDM3 IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vanMv cmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPGRp diBpZD0iY29uc29sZSI+Cis8cD4KK1RoaXMgdGVzdHMgYW4gZXhjZXB0aW9uIHRocm93biBieSB0 aGUgRXZlbnRTb3VyY2UgY29uc3RydWN0b3IuCitUaGlzIHRlc3QgY2Fubm90IHJ1biBpbnRlcmFj dGl2ZWx5LgorPC9wPgorPC9kaXY+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlcikgeworICAgIHRyeSB7CisgICAgICAgIG5ldyBFdmVudFNvdXJjZSgpOworICAgICAg ICBkZWJ1ZygiRkFJTDogU1lOVEFYX0VSUiBzaG91bGQgYmUgdGhyb3duLiIpOworICAgIH0gY2F0 Y2ggKGVjKSB7CisgICAgICAgIGRlYnVnKCJQQVNTOiAiICsgZWMpOworICAgIH0KKworICAgIHZh ciB0ZXN0cyA9IFtudWxsLCB1bmRlZmluZWQsICIiLCAiaHR0cDovL3dlYnNlcnZlcjplaWdodHkv Il07CisgICAgdGVzdHMuZm9yRWFjaChmdW5jdGlvbiAodGVzdCkgeworICAgICAgICB0cnkgewor ICAgICAgICAgICAgbmV3IEV2ZW50U291cmNlKHRlc3QpOworICAgICAgICAgICAgZGVidWcoIkZB SUw6IFNZTlRBWF9FUlIgc2hvdWxkIGJlIHRocm93bi4iKTsKKyAgICAgICAgfSBjYXRjaCAoZWMp IHsKKyAgICAgICAgICAgIGRlYnVnKCJQQVNTOiAiICsgZWMpOworICAgICAgICB9CisgICAgfSk7 Cit9CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0 IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+ Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50c291cmNlL2V2ZW50 c291cmNlLWNvbnN0cnVjdG9yLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRz b3VyY2UvZXZlbnRzb3VyY2UtY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0CmRlbGV0ZWQgZmlsZSBt b2RlIDEwMDY0NAppbmRleCBjOGUyMjhjN2M0ZjYzYmM1ZjIwNGVlODAzODYxNjM1Y2E4YmUxYjhk Li4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xheW91dFRl c3RzL2Zhc3QvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0 CisrKyAvZGV2L251bGwKQEAgLTEsNyArMCwwIEBACi1UZXN0IEV2ZW50U291cmNlIGNvbnN0cnVj dG9yIGZ1bmN0aW9uYWxpdHkuIFNob3VsZCBwcmludCBhIHNlcmllcyBvZiBQQVNTIG1lc3NhZ2Vz IGZvbGxvd2VkIGJ5IERPTkUuCi0KLVBBU1M6IG1pc3NpbmcgYXJndW1lbnQgdG8gRXZlbnRTb3Vy Y2UgY29uc3RydWN0b3IgcmVzdWx0ZWQgaW4gYW4gZXhjZXB0aW9uIChTeW50YXhFcnJvcjogTm90 IGVub3VnaCBhcmd1bWVudHMpCi1QQVNTOiBwYXNzaW5nIGFuIGVtcHR5IHN0cmluZyB0byB0aGUg RXZlbnRTb3VyY2UgY29uc3RydWN0b3IgcmVzdWx0ZWQgaW4gYW4gZXhjZXB0aW9uIChFcnJvcjog U1lOVEFYX0VSUjogRE9NIEV4Y2VwdGlvbiAxMikKLVBBU1M6IHBhc3NpbmcgYW4gaW52YWxpZCBV UkwgdG8gdGhlIEV2ZW50U291cmNlIGNvbnN0cnVjdG9yIHJlc3VsdGVkIGluIGFuIGV4Y2VwdGlv biAoRXJyb3I6IFNZTlRBWF9FUlI6IERPTSBFeGNlcHRpb24gMTIpCi1ET05FCi0KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtY29uc3RydWN0b3Iu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtY29uc3RydWN0 b3IuaHRtbApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggOGJhZDdlZjQwNGZhMWE5MzZi MWUzMDcwMGZlMzM4OTg0MDk1ZDEwNS4uMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50c291cmNlL2V2ZW50c291cmNlLWNv bnN0cnVjdG9yLmh0bWwKKysrIC9kZXYvbnVsbApAQCAtMSw0NSArMCwwIEBACi08aHRtbD4KLTxi b2R5PgotPHA+VGVzdCBFdmVudFNvdXJjZSBjb25zdHJ1Y3RvciBmdW5jdGlvbmFsaXR5LiBTaG91 bGQgcHJpbnQgYSBzZXJpZXMgb2YgUEFTUyBtZXNzYWdlcyBmb2xsb3dlZCBieSBET05FLjwvcD4K LTxkaXYgaWQ9InJlc3VsdCI+PC9kaXY+Ci08c2NyaXB0PgotZnVuY3Rpb24gbG9nKG1zZykgewot ICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lckhUTUwgKz0gbXNnICsg Ijxicj4iOwotfQotCi1pZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7Ci0gICAgbGF5 b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwotICAgIGxheW91dFRlc3RDb250cm9sbGVy LndhaXRVbnRpbERvbmUoKTsKLX0KLQotdHJ5IHsKLSAgICBuZXcgRXZlbnRTb3VyY2UoKTsKLSAg ICBsb2coIkZBSUw6IG5vIGV4Y2VwdGlvbiB3aGVuIHRyeWluZyB0byBjb25zdHJ1Y3QgYW4gRXZl bnRTb3VyY2Ugd2l0aG91dCBhcmd1bWVudCIpOwotfQotY2F0Y2ggKGV4KSB7Ci0gICAgbG9nKCJQ QVNTOiBtaXNzaW5nIGFyZ3VtZW50IHRvIEV2ZW50U291cmNlIGNvbnN0cnVjdG9yIHJlc3VsdGVk IGluIGFuIGV4Y2VwdGlvbiAoIiArIGV4ICsgIikiKTsKLX0KLQotdHJ5IHsKLSAgICBuZXcgRXZl bnRTb3VyY2UoIiIpOwotICAgIGxvZygiRkFJTDogbm8gZXhjZXB0aW9uIHdoZW4gcGFzc2luZyBh biBlbXB0eSBzdHJpbmcgdG8gdGhlIEV2ZW50U291cmNlIGNvbnN0cnVjdG9yIik7Ci19Ci1jYXRj aCAoZXgpIHsKLSAgICBsb2coIlBBU1M6IHBhc3NpbmcgYW4gZW1wdHkgc3RyaW5nIHRvIHRoZSBF dmVudFNvdXJjZSBjb25zdHJ1Y3RvciByZXN1bHRlZCBpbiBhbiBleGNlcHRpb24gKCIgKyBleCAr ICIpIik7Ci19Ci0KLXRyeSB7Ci0gICAgbmV3IEV2ZW50U291cmNlKCJodHRwOi8vd2Vic2VydmVy OmVpZ2h0eS8iKTsKLSAgICBsb2coIkZBSUw6IG5vIGV4Y2VwdGlvbiB3aGVuIHBhc3NpbmcgYW4g aW52YWxpZCBVUkwgdG8gdGhlIEV2ZW50U291cmNlIGNvbnN0cnVjdG9yIik7Ci19Ci1jYXRjaCAo ZXgpIHsKLSAgICBsb2coIlBBU1M6IHBhc3NpbmcgYW4gaW52YWxpZCBVUkwgdG8gdGhlIEV2ZW50 U291cmNlIGNvbnN0cnVjdG9yIHJlc3VsdGVkIGluIGFuIGV4Y2VwdGlvbiAoIiArIGV4ICsgIiki KTsKLSAgICBsb2coIkRPTkUiKTsKLX0KLQotaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl cikKLSAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7Ci0KLTwvc2NyaXB0Pgot PC9ib2R5PgotPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDYwZThmYzUzMTM5OGIyY2RiNmMwOThiZjk2 MGFhNzM3OWE4OGJiZWEuLjQwYTJjYzUzMzEwNTFlZjg4ZWYwNDYxYjc0ZWY5Yjk5NmI5Mjg4YWEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMS0wOC0xNSAgS2VudGFybyBIYXJhICA8 aGFyYWtlbkBnb29nbGUuY29tPgorCisgICAgICAgICJuZXcgRXZlbnRTb3VyY2UoKSIgc2hvdWxk IHRocm93IFNZTlRBWF9FUlIgd2hlbiBhbiBpbnZhbGlkIGFyZ3VtZW50IGlzIHBhc3NlZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjYyNzQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAibmV3IEV2ZW50U291 cmNlKHVybCkiIHNob3VsZCB0aHJvdyBTWU5UQVhfRVJSLCB3aGVuIHVybCBpcyB1bmRlZmluZWQs IG51bGwsCisgICAgICAgIGFuIGVtcHR5IHN0cmluZywgb3IgYW4gaW52YWxpZCBVUkwuCisKKyAg ICAgICAgVGVzdDogZmFzdC9ldmVudHNvdXJjZS9ldmVudHNvdXJjZS1jb25zdHJ1Y3Rvci5odG1s CisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0V2ZW50U291cmNlQ3VzdG9tLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkpTRXZlbnRTb3VyY2VDb25zdHJ1Y3Rvcjo6Y29uc3RydWN0SlNFdmVudFNv dXJjZSk6IEV2ZW50U291cmNlOjpjcmVhdGUoKSB0aHJvd3MgU1lOVEFYX0VSUi4KKyAgICAgICAg KiBiaW5kaW5ncy92OC9jdXN0b20vVjhFdmVudFNvdXJjZUNvbnN0cnVjdG9yLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlY4RXZlbnRTb3VyY2U6OmNvbnN0cnVjdG9yQ2FsbGJhY2spOiBFdmVudFNv dXJjZTo6Y3JlYXRlKCkgdGhyb3dzIFNZTlRBWF9FUlIuCisKIDIwMTEtMDgtMTUgIEplZmZyZXkg UGZhdSAgPGpwZmF1QGFwcGxlLmNvbT4KIAogICAgICAgICBOZXcgWE1MIHBhcnNlcjogYWRkIHht bCBuYW1lc3BhY2UgdG8gdGhlIGRlZmF1bHQgbWFwIG9mIG5hbWVzcGFjZXMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRXZlbnRTb3VyY2VDdXN0b20uY3BwIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNFdmVudFNvdXJjZUN1c3RvbS5jcHAKaW5kZXggYWE5 OTFkZDI5ZTFkNDBkMTRkZmNlM2VmYjQ2YWI5NTRhNTY3ZTVjMi4uZTE0Y2U2Yjk2YmEyNzY2ZTJm YjkyNDVkZjc3OTc3NzQzY2Y5YzViOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNFdmVudFNvdXJjZUN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNFdmVudFNvdXJjZUN1c3RvbS5jcHAKQEAgLTQ2LDEyICs0NiwxMiBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgSlNFdmVudFNvdXJj ZUNvbnN0cnVjdG9yOjpjb25zdHJ1Y3RKU0V2ZW50U291cmNlKEV4ZWNTdGF0ZSogZXhlYykKIHsK LSAgICBpZiAoZXhlYy0+YXJndW1lbnRDb3VudCgpIDwgMSkKLSAgICAgICAgcmV0dXJuIHRocm93 Vk1FcnJvcihleGVjLCBjcmVhdGVTeW50YXhFcnJvcihleGVjLCAiTm90IGVub3VnaCBhcmd1bWVu dHMiKSk7Ci0KLSAgICBVU3RyaW5nIHVybCA9IGV4ZWMtPmFyZ3VtZW50KDApLnRvU3RyaW5nKGV4 ZWMpOwotICAgIGlmIChleGVjLT5oYWRFeGNlcHRpb24oKSkKLSAgICAgICAgcmV0dXJuIEpTVmFs dWU6OmVuY29kZShKU1ZhbHVlKCkpOworICAgIFVTdHJpbmcgdXJsOworICAgIGlmICghZXhlYy0+ YXJndW1lbnQoMCkuaXNVbmRlZmluZWRPck51bGwoKSkgeworICAgICAgICB1cmwgPSBleGVjLT5h cmd1bWVudCgwKS50b1N0cmluZyhleGVjKTsKKyAgICAgICAgaWYgKGV4ZWMtPmhhZEV4Y2VwdGlv bigpKQorICAgICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShKU1ZhbHVlKCkpOworICAg IH0KIAogICAgIEpTRXZlbnRTb3VyY2VDb25zdHJ1Y3RvcioganNDb25zdHJ1Y3RvciA9ICBzdGF0 aWNfY2FzdDxKU0V2ZW50U291cmNlQ29uc3RydWN0b3IqPihleGVjLT5jYWxsZWUoKSk7CiAgICAg U2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCA9IGpzQ29uc3RydWN0b3ItPnNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOEV2ZW50U291cmNlQ29uc3RydWN0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4RXZlbnRTb3VyY2VDb25zdHJ1Y3Rvci5jcHAKaW5kZXggMDFlOWM0 NDgxZWE5MzkzODM0NmRmOWM1YTI2YTMzZjQ2NzQ1ZWE4NC4uMTRiZTBjOTUxYjNjMzY1OTA4YzI1 MDZhNGZjZGM4MGRmYzkwNzRmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvY3VzdG9tL1Y4RXZlbnRTb3VyY2VDb25zdHJ1Y3Rvci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RXZlbnRTb3VyY2VDb25zdHJ1Y3Rvci5jcHAKQEAgLTU1 LDE0ICs1NSwxMyBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhFdmVudFNvdXJjZTo6Y29uc3Ry dWN0b3JDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcgogICAgIFNjcmlwdEV4ZWN1dGlv bkNvbnRleHQqIGNvbnRleHQgPSBnZXRTY3JpcHRFeGVjdXRpb25Db250ZXh0KCk7CiAgICAgaWYg KCFjb250ZXh0KQogICAgICAgICByZXR1cm4gdGhyb3dFcnJvcigiRXZlbnRTb3VyY2UgY29uc3Ry dWN0b3IncyBhc3NvY2lhdGVkIGNvbnRleHQgaXMgbm90IGF2YWlsYWJsZSIsIFY4UHJveHk6OlJl ZmVyZW5jZUVycm9yKTsKLSAgICBpZiAoYXJncy5MZW5ndGgoKSAhPSAxKQotICAgICAgICByZXR1 cm4gdGhyb3dFcnJvcigiTm90IGVub3VnaCBhcmd1bWVudHMiLCBWOFByb3h5OjpTeW50YXhFcnJv cik7CiAKLSAgICBFeGNlcHRpb25Db2RlIGVjID0gMDsKLSAgICBTdHJpbmcgdXJsID0gdG9XZWJD b3JlU3RyaW5nKGFyZ3NbMF0pOworICAgIFN0cmluZyB1cmw7CisgICAgaWYgKCFpc1VuZGVmaW5l ZE9yTnVsbChhcmdzWzBdKSkKKyAgICAgICAgdXJsID0gdG9XZWJDb3JlU3RyaW5nKGFyZ3NbMF0p OwogCisgICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7CiAgICAgUmVmUHRyPEV2ZW50U291cmNlPiBl dmVudFNvdXJjZSA9IEV2ZW50U291cmNlOjpjcmVhdGUodXJsLCBjb250ZXh0LCBlYyk7Ci0KICAg ICBpZiAoZWMpCiAgICAgICAgIHJldHVybiB0aHJvd0Vycm9yKGVjKTsKIAo=