65845 2011-08-08 00:55:02 -0700 WebSocket: Save the value of useHixie76Protocol flag in WebSocket object 2011-08-08 01:39:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 65247 1 yutak yutak abarth ap tkent oldest_to_newest 447893 0 yutak 2011-08-08 00:55:02 -0700 [Follow-up of bug 65250] I did not think WebSocket class needed to store the value of useHixie76Protocol flag when I was writing a patch for bug 65250, but it turned out that I was wrong; WebSocket class may need the value of this flag *after* WebSocketChannel is released, because some members may be accessed after the WebSocket connection gets closed. 447896 1 103217 yutak 2011-08-08 01:06:33 -0700 Created attachment 103217 Patch 447902 2 103217 tkent 2011-08-08 01:13:15 -0700 Comment on attachment 103217 Patch This patch looks just wasting memory. Why don't you add m_useHixie76Protocol when you need it? 447909 3 yutak 2011-08-08 01:38:38 -0700 (In reply to comment #2) > (From update of attachment 103217 [details]) > This patch looks just wasting memory. > Why don't you add m_useHixie76Protocol when you need it? Sure -- I'll merge this patch into another one which I was planning to post later. 103217 2011-08-08 01:06:33 -0700 2011-08-08 01:39:14 -0700 Patch bug-65845-20110808170631.patch text/plain 2689 yutak U3VidmVyc2lvbiBSZXZpc2lvbjogOTI0ODgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4M2UxMjk5OWQ5MDY3YzRj NDMzYmY1YzcwOTcyMzE1N2Q0MTE0NjJmLi5hNWNiZTcwOTQyODU4NzgzYTI3N2E3MDNjZDlhZDJj MTg1YjRiZGYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDgtMDggIFl1dGEg S2l0YW11cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViU29ja2V0OiBTYXZl IHRoZSB2YWx1ZSBvZiB1c2VIaXhpZTc2UHJvdG9jb2wgZmxhZyBpbiBXZWJTb2NrZXQgb2JqZWN0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTg0NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYlNvY2tl dCBjbGFzcyBtYXkgbmVlZCB0aGUgdmFsdWUgb2YgdXNlSGl4aWU3NlByb3RvY29sIGZsYWcgYWZ0 ZXIgdGhlIFdlYlNvY2tldENoYW5uZWwgaXMgcmVsZWFzZWQsCisgICAgICAgIHRodXMgaXQgc2hv dWxkIGJlIHByZXNlcnZlZCBpbiBXZWJTb2NrZXQgY2xhc3MuCisKKyAgICAgICAgTm8gY2hhbmdl IGluIGZ1bmN0aW9uYWxpdHksIHRodXMgbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogd2Vic29j a2V0cy9XZWJTb2NrZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViU29ja2V0OjpXZWJTb2Nr ZXQpOgorICAgICAgICAoV2ViQ29yZTo6V2ViU29ja2V0Ojpjb25uZWN0KToKKyAgICAgICAgKiB3 ZWJzb2NrZXRzL1dlYlNvY2tldC5oOgorICAgICAgICBJdCBzaG91bGQgYmUgb2theSB0byB1c2Ug Ym9vbCBoZXJlLCBiZWNhdXNlIGJvb2xlYW4gbGl0ZXJhbCBkb2VzIG5vdCBhcHBlYXIgYnkgaXRz ZWxmLgorCiAyMDExLTA4LTA1ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIEludHJvZHVjZSBhIG5ldyBSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldFR5cGUg Zm9yIFhIUnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0LmNwcAppbmRleCBhN2Ex MWUzNGU3MDU3NjZmYjQyNDgwODRiMGMwYmUwY2NjMWFmNmZmLi40MGU3NmFmYTc3Zjk3NGIxYzY5 MzYwNmJkZmUyZjVlYTBhZDFiNTJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJzb2Nr ZXRzL1dlYlNvY2tldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2Nr ZXQuY3BwCkBAIC05OSw2ICs5OSw3IEBAIFdlYlNvY2tldDo6V2ViU29ja2V0KFNjcmlwdEV4ZWN1 dGlvbkNvbnRleHQqIGNvbnRleHQpCiAgICAgOiBBY3RpdmVET01PYmplY3QoY29udGV4dCwgdGhp cykKICAgICAsIG1fc3RhdGUoQ09OTkVDVElORykKICAgICAsIG1fYnVmZmVyZWRBbW91bnRBZnRl ckNsb3NlKDApCisgICAgLCBtX3VzZUhpeGllNzZQcm90b2NvbCh0cnVlKQogewogfQogCkBAIC0x NTIsOCArMTUzLDggQEAgdm9pZCBXZWJTb2NrZXQ6OmNvbm5lY3QoY29uc3QgU3RyaW5nJiB1cmws IGNvbnN0IFN0cmluZyYgcHJvdG9jb2wsIEV4Y2VwdGlvbkNvZGUKICAgICB9CiAKICAgICBtX2No YW5uZWwgPSBUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbDo6Y3JlYXRlKHNjcmlwdEV4ZWN1dGlv bkNvbnRleHQoKSwgdGhpcyk7Ci0gICAgLy8gRklYTUU6IEdldCB0aGUgdmFsdWUgb2YgbV9jaGFu bmVsLT51c2VIaXhpZTc2UHJvdG9jb2woKSBhbmQgdmFsaWRhdGUgdGhlIHZhbHVlIG9mIHN1YnBy b3RvY29sCi0gICAgLy8gaWYgaHliaS0xMCBwcm90b2NvbCBpcyB1c2VkLgorICAgIG1fdXNlSGl4 aWU3NlByb3RvY29sID0gbV9jaGFubmVsLT51c2VIaXhpZTc2UHJvdG9jb2woKTsKKyAgICAvLyBG SVhNRTogQ2hlY2sgdGhlIHZhbHVlIG9mIG1fdXNlSGl4aWU3NlByb3RvY29sLCBhbmQgdmFsaWRh dGUgdGhlIHZhbHVlIG9mIHN1YnByb3RvY29sIGhlcmUuCiAgICAgbV9jaGFubmVsLT5jb25uZWN0 KG1fdXJsLCBtX3Byb3RvY29sKTsKICAgICBBY3RpdmVET01PYmplY3Q6OnNldFBlbmRpbmdBY3Rp dml0eSh0aGlzKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvV2Vi U29ja2V0LmggYi9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldC5oCmluZGV4IDE5 MWJjM2Y4ODk2ZDcwOTU1MWFjZDE5ZDI2YjczNDQwNWIyOTRiMWMuLjU1NWNkNTFiNTVmY2UwMDNl OThkOTY5NmU3M2ExMmUxM2YxNmRhZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dlYnNv Y2tldHMvV2ViU29ja2V0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2Nr ZXQuaApAQCAtMTEzLDYgKzExMyw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgU3Ry aW5nIG1fcHJvdG9jb2w7CiAgICAgICAgIEV2ZW50VGFyZ2V0RGF0YSBtX2V2ZW50VGFyZ2V0RGF0 YTsKICAgICAgICAgdW5zaWduZWQgbG9uZyBtX2J1ZmZlcmVkQW1vdW50QWZ0ZXJDbG9zZTsKKyAg ICAgICAgYm9vbCBtX3VzZUhpeGllNzZQcm90b2NvbDsKICAgICB9OwogCiB9IC8vIG5hbWVzcGFj ZSBXZWJDb3JlCg==